[PATCH] D19451: [clang-tidy] New checker for redundant expressions.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This checker finds redundant expression on both side of a binary operator. The current implementation provide a function to check whether expression are the equivalent. This

r267263 - [profile] Fix another use of the driver.

Author: silvas Date: Fri Apr 22 21:13:48 2016 New Revision: 267263 URL: http://llvm.org/viewvc/llvm-project?rev=267263=rev Log: [profile] Fix another use of the driver. Follow-on to r267262. Modified: cfe/trunk/test/Profile/cxx-indirect-call.cpp Modified:

r267262 - [profile] Use cc1 in these tests instead of the driver.

Author: silvas Date: Fri Apr 22 21:11:16 2016 New Revision: 267262 URL: http://llvm.org/viewvc/llvm-project?rev=267262=rev Log: [profile] Use cc1 in these tests instead of the driver. I ran into this when seeing what tests would break if we make a driver-level decision about whether FEPGO or

Re: [PATCH] D19393: Move Checkers.inc to clang/include/.../Checkers

chh updated this revision to Diff 54758. chh added a comment. Also move Checkers.td to clang/include/.../Checkers. http://reviews.llvm.org/D19393 Files: include/clang/CMakeLists.txt include/clang/StaticAnalyzer/Checkers/CMakeLists.txt include/clang/StaticAnalyzer/Checkers/Checkers.td

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

mprobst added a comment. Friendly ping. http://reviews.llvm.org/D19204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r267254 - [clang-tidy] Fix misc-macro-repeated-side-effects false positive with stringified arguments

Author: alexfh Date: Fri Apr 22 19:00:08 2016 New Revision: 267254 URL: http://llvm.org/viewvc/llvm-project?rev=267254=rev Log: [clang-tidy] Fix misc-macro-repeated-side-effects false positive with stringified arguments Added:

Re: [PATCH] D18768: Refactoring attribute subject diagnostics

rsmith added a comment. I think this is a reasonable direction. I'd like to see some kind of %list form added to our diagnostics system, but I don't mind whether that happens before or after this change. (I'd also prefer to use singular forms in the various subject names, but that seems to

Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

weimingz added a comment. Ping ? http://reviews.llvm.org/D17741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r267228 - [Clang-tidy] Fix Clang warning in misc/StringConstructorCheck.h.

Author: eugenezelenko Date: Fri Apr 22 16:33:33 2016 New Revision: 267228 URL: http://llvm.org/viewvc/llvm-project?rev=267228=rev Log: [Clang-tidy] Fix Clang warning in misc/StringConstructorCheck.h. Using LLVM_ENABLE_WARNINGS=ON is good idea. Modified:

r267224 - PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name

Author: xur Date: Fri Apr 22 16:19:05 2016 New Revision: 267224 URL: http://llvm.org/viewvc/llvm-project?rev=267224=rev Log: PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name Write out the PGOFuncName meta data if PGOFuncName is different from function's raw name.

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267224: PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name (authored by xur). Changed prior to commit: http://reviews.llvm.org/D18624?vs=54717=54725#toc Repository: rL

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

xur added a comment. tested with povray with full path names in the command line and it works fine. http://reviews.llvm.org/D18624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r267054 - Split interesting warnings off from -Wfloat-conversion

On Fri, Apr 22, 2016 at 10:50 AM, David Blaikie wrote: > > > On Thu, Apr 21, 2016 at 2:04 PM, Richard Trieu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rtrieu >> Date: Thu Apr 21 16:04:55 2016 >> New Revision: 267054 >> >> URL:

Re: r267054 - Split interesting warnings off from -Wfloat-conversion

Nico, With this warning, I was attempting to catch different cases of floating to bool conversion: bool x = 5.0; // Wrong type void test(bool, float); test(5.0, true); // Switched arguments. I did not see anything like your example come up. See as there are many edge cases in with

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D18624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r267186 - Fix a bug involving deferred decl emission and PCH

On Fri, Apr 22, 2016 at 12:59 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Apr 22, 2016 at 12:29 PM, Richard Smith > wrote: > >> On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >>

Re: [PATCH] D18768: Refactoring attribute subject diagnostics

aaron.ballman added a comment. Ping http://reviews.llvm.org/D18768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19244: Extend checking of va_start builtin

aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Ping. http://reviews.llvm.org/D19244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18624: [PGO] PGOFuncName meta data if PGOFuncName is different from function's raw name.

xur updated this revision to Diff 54717. xur added a comment. Handling the path-stripped prefix in PGOFuncName. This new patch depends on http://reviews.llvm.org/D19433 http://reviews.llvm.org/D18624 Files: CodeGenPGO.cpp Index: CodeGenPGO.cpp

[PATCH] D19432: [SystemZ] Support Swift calling convention

bryanpkc created this revision. bryanpkc added reviewers: rjmccall, kbarton. bryanpkc added a subscriber: cfe-commits. bryanpkc added a dependency: D19414: [SystemZ] Support Swift Calling Convention. Port rL265324 to SystemZ to allow using the 'swiftcall' attribute on that architecture. Depends

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

rjmccall added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:763 @@ -762,8 +762,3 @@ Includers.push_back(std::make_pair(FindFile, FindFile->getDir())); - File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false, -

Re: r267186 - Fix a bug involving deferred decl emission and PCH

On Fri, Apr 22, 2016 at 12:29 PM, Richard Smith wrote: > On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rnk >> Date: Fri Apr 22 13:46:33 2016 >> New Revision: 267186 >> >> URL:

Re: [PATCH] D18540: [Sema] Note when we've actually encountered a failure in ExprConstant, and take that into account when looking up objects.

george.burgess.iv added a comment. Ping :) http://reviews.llvm.org/D18540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r267186 - Fix a bug involving deferred decl emission and PCH

On Fri, Apr 22, 2016 at 11:46 AM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Fri Apr 22 13:46:33 2016 > New Revision: 267186 > > URL: http://llvm.org/viewvc/llvm-project?rev=267186=rev > Log: > Fix a bug involving deferred decl emission and PCH > >

Re: [PATCH] D18657: Propagate missing empty exception spec from function declared in system header

rsmith added a subscriber: rsmith. Comment at: lib/Sema/SemaExceptionSpec.cpp:260 @@ -261,1 +259,3 @@ + (First->getLocation().isInvalid() || + Context.getSourceManager().isInSystemHeader(First->getLocation( { New->setType(Context.getFunctionType(

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:763 @@ -762,8 +762,3 @@ Includers.push_back(std::make_pair(FindFile, FindFile->getDir())); - File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false, -

r267186 - Fix a bug involving deferred decl emission and PCH

Author: rnk Date: Fri Apr 22 13:46:33 2016 New Revision: 267186 URL: http://llvm.org/viewvc/llvm-project?rev=267186=rev Log: Fix a bug involving deferred decl emission and PCH For various reasons, involving dllexport and class linkage compuations, we have to wait until after the semicolon after

[PATCH] D19425: driver: Add a `--rsp-quoting` flag to choose which unquoting behavior to use in rsp files.

thakis created this revision. thakis added a reviewer: rnk. thakis added a subscriber: cfe-commits. Currently, clang-cl always uses Windows style for unquoting, and clang always uses POSIX style for unquoting. In general, response file quoting should match the shell the response file is used

Re: [PATCH] D18657: Propagate missing empty exception spec from function declared in system header

rjmccall added inline comments. Comment at: lib/Sema/SemaExceptionSpec.cpp:260 @@ -261,1 +259,3 @@ + (First->getLocation().isInvalid() || + Context.getSourceManager().isInSystemHeader(First->getLocation( { New->setType(Context.getFunctionType(

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

rjmccall added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:763 @@ -762,8 +762,3 @@ Includers.push_back(std::make_pair(FindFile, FindFile->getDir())); - File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false, -

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

bader added a comment. In http://reviews.llvm.org/D18369#409011, @yaxunl wrote: > In http://reviews.llvm.org/D18369#408773, @bader wrote: > > > BTW, there is a comment on GitHub that opencl.h might be a bad name for > > that header, since Khronos group provides the header with the same name, >

Re: r267054 - Split interesting warnings off from -Wfloat-conversion

On Thu, Apr 21, 2016 at 2:04 PM, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Thu Apr 21 16:04:55 2016 > New Revision: 267054 > > URL: http://llvm.org/viewvc/llvm-project?rev=267054=rev > Log: > Split interesting warnings off from -Wfloat-conversion

[libunwind] r267169 - unwind: unify some more macros

Author: compnerd Date: Fri Apr 22 12:11:05 2016 New Revision: 267169 URL: http://llvm.org/viewvc/llvm-project?rev=267169=rev Log: unwind: unify some more macros The macros were defined identically across both cases. Unify the definitions to have a single definition for

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: include/clang/AST/OpenMPClause.h:2789-2797 @@ +2788,11 @@ +// \brief Expression associated with the component. +Expr *AssociatedExpression; +// \brief Declaration associated with the

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao updated this revision to Diff 54672. sfantao marked 15 inline comments as done. sfantao added a comment. - Address review comments. Fix bug in the evaluation of the unique declarations. http://reviews.llvm.org/D19382 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Please fix formatting, btw. Repository: rL LLVM http://reviews.llvm.org/D19201 ___ cfe-commits mailing list

[PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists, theraven, jroelofs. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This patch builds on D19412. The motivation here is to allow toolchain vendors to build a version of `libcxx` with

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 54658. rmaprath added a comment. Added bit more context to the diff. http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__os_support include/mutex include/thread src/algorithm.cpp src/condition_variable.cpp

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

sbaranga added a comment. A gentle ping? Cheers, Silviu http://reviews.llvm.org/D18963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath created this revision. rmaprath added reviewers: EricWF, theraven, mclow.lists, jroelofs. rmaprath added subscribers: espositofulvio, cfe-commits. This is mostly D11781 with the final review comments addressed: - Merged all the headers into a single `__os_support` header - Moved all

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added a comment. In http://reviews.llvm.org/D18369#408773, @bader wrote: > BTW, there is a comment on GitHub that opencl.h might be a bad name for that > header, since Khronos group provides the header with the same name, but it > defines host API. So if some developer is using clang to

Re: [PATCH] D19406: [clang-tidy] fix link in Release Notes

hokein added a comment. In http://reviews.llvm.org/D19406#408893, @omtcyf0 wrote: > @hokein > > Great, thanks! > > I'd be very grateful if you could land it! Sure. Done. Repository: rL LLVM http://reviews.llvm.org/D19406 ___ cfe-commits

Re: [PATCH] D19062: Add functions in ctype.h to builtin function database (Fix)

twoh added a comment. Ping. @joerg, could you please take a look? http://reviews.llvm.org/D19062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r267155 - [clang-tidy] fix link in Release Notes

Author: hokein Date: Fri Apr 22 09:43:39 2016 New Revision: 267155 URL: http://llvm.org/viewvc/llvm-project?rev=267155=rev Log: [clang-tidy] fix link in Release Notes Summary: This is intended to fix https://llvm.org/bugs/show_bug.cgi?id=27426 Patch by Kirill Bobyrev! Reviewers: alexfh,

Re: [PATCH] D19406: [clang-tidy] fix link in Release Notes

This revision was automatically updated to reflect the committed changes. Closed by commit rL267155: [clang-tidy] fix link in Release Notes (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19406?vs=54620=54649#toc Repository: rL LLVM http://reviews.llvm.org/D19406

Re: r267054 - Split interesting warnings off from -Wfloat-conversion

Hi Richard, 1.) Are these new warnings in -Wconversion? If not, they probably should be, right? 2.) It looks like -Wfloat-bool-constant-conversion is on by default and warns on things like if (kHotspotRadius) if kHotspotRadius is a float. Do you have data that suggests that this is a common

Re: [PATCH] D19406: [clang-tidy] fix link in Release Notes

omtcyf0 added a comment. @hokein Great, thanks! I'd be very grateful if you could land it! http://reviews.llvm.org/D19406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r267135 - [clang][AVX512][Builtin] adding intrinsics for vf{n}madd{ss|sd} and vf{n}sub{ss|sd} instruction set

Author: mzuckerm Date: Fri Apr 22 05:56:24 2016 New Revision: 267135 URL: http://llvm.org/viewvc/llvm-project?rev=267135=rev Log: [clang][AVX512][Builtin] adding intrinsics for vf{n}madd{ss|sd} and vf{n}sub{ss|sd} instruction set Differential Revision: http://reviews.llvm.org/D19320 Modified:

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1544 @@ -1508,2 +1543,3 @@ deriveLocalStyle(AnnotatedLines); -computeAffectedLines(AnnotatedLines.begin(), AnnotatedLines.end()); +AffectedRangeMgr.computeAffectedLines(AnnotatedLines.begin(), +

Re: [PATCH] D19406: [clang-tidy] fix link in Release Notes

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D19406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r267129 - [Clang][AVX512][BUILTIN] Adding scalar intrinsics for rsqrt14 , rcp14, getexp and getmant instruction set

Author: mzuckerm Date: Fri Apr 22 05:06:10 2016 New Revision: 267129 URL: http://llvm.org/viewvc/llvm-project?rev=267129=rev Log: [Clang][AVX512][BUILTIN] Adding scalar intrinsics for rsqrt14 ,rcp14, getexp and getmant instruction set Differential Revision: http://reviews.llvm.org/D19326

[PATCH] D19406: [clang-tidy] Release Notes fix typo in check link

omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, LegalizeAdulthood, hokein. omtcyf0 added a subscriber: cfe-commits. This is intended to fix https://llvm.org/bugs/show_bug.cgi?id=27426 http://reviews.llvm.org/D19406 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

PING. On Thu, Apr 21, 2016 at 11:48 AM Eric Liu wrote: > ioeric updated this revision to Diff 54476. > ioeric added a comment. > > - Added comments for endsWithInternal(). > > > http://reviews.llvm.org/D18551 > > Files: > include/clang/Format/Format.h >

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

ioeric added a subscriber: ioeric. ioeric added a comment. PING. http://reviews.llvm.org/D18551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

bader added inline comments. Comment at: lib/Headers/opencl.h:2 @@ +1,3 @@ +// +// SPIR Tools +// This comment should be updated. http://reviews.llvm.org/D18369 ___ cfe-commits mailing list

r267125 - [OPENMP] Fix for PR27463: Privatizing struct fields with array type

Author: abataev Date: Fri Apr 22 04:05:03 2016 New Revision: 267125 URL: http://llvm.org/viewvc/llvm-project?rev=267125=rev Log: [OPENMP] Fix for PR27463: Privatizing struct fields with array type causes code generation failure. The codegen part of firstprivate clause for member decls used type

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. Weekly friendly ping, PTAL! http://reviews.llvm.org/D18035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r267118 - [index] Add SymbolSubKinds for ObjC IB annotations.

Author: akirtzidis Date: Fri Apr 22 02:21:16 2016 New Revision: 267118 URL: http://llvm.org/viewvc/llvm-project?rev=267118=rev Log: [index] Add SymbolSubKinds for ObjC IB annotations. Modified: cfe/trunk/include/clang/Index/IndexSymbol.h cfe/trunk/lib/Index/IndexSymbol.cpp

r267117 - [index] Add a SymbolSubKind for an ObjC unit test.

Author: akirtzidis Date: Fri Apr 22 02:21:10 2016 New Revision: 267117 URL: http://llvm.org/viewvc/llvm-project?rev=267117=rev Log: [index] Add a SymbolSubKind for an ObjC unit test. Added: cfe/trunk/test/Index/Core/index-subkinds.m Modified: cfe/trunk/include/clang/Index/IndexSymbol.h

r267116 - [index] Change SymbolCXXTemplateKind to a 'SymbolSubKinds' bitset.

Author: akirtzidis Date: Fri Apr 22 02:21:04 2016 New Revision: 267116 URL: http://llvm.org/viewvc/llvm-project?rev=267116=rev Log: [index] Change SymbolCXXTemplateKind to a 'SymbolSubKinds' bitset. This provides a more general and flexible way to annotate special symbols. Modified:

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:2789-2797 @@ +2788,11 @@ +// \brief Expression associated with the component. +Expr *AssociatedExpression; +// \brief Declaration associated with the declaration. If the component does +