Re: r213213 - DebugInfo: Forward HandleTagDeclRequiredDefinition through MultiplexConsumer to fix debug info emission in the presence of plugins.

Zombie review comment: ".test" isn't part of test/lit.cfg::config.suffixes, so the two .test files added in this change never run unless you explicitly run them (e.g. with `bin/llvm-lit ../llvm-rw/tools/clang/test/CodeGenCXX/*.test`). CodeGenCXX/debug-info-class-limited.test fails when I run it

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

thakis added a comment. Looks great, thanks! A few minor questions below. I verified that this has the same effect as my brute-force patch I tried locally. Do we have test coverage for `template class __declspec(dllexport) codecvt;` somewhere already? Comment at:

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

bkramer added inline comments. Comment at: include-fixer/IncludeFixer.h:51 @@ -50,6 +50,3 @@ - /// Headers to be added. - std::set - - /// Replacements are written here. - std::vector + /// The context that contains all information about queried symbol. +

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

bkramer added a comment. Can you add some lit tests for the various command line modes clang-include-fixer has now. We can't reasonably test the vim integration but we can tests the bits it's composed of. http://reviews.llvm.org/D20621 ___

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58448. hokein marked 6 inline comments as done. hokein added a comment. Update and address comments. http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h

Re: [PATCH] D20608: clang-cl: Treat dllimport explicit template instantiation definitions as declarations (PR27810, PR27811)

hans added a comment. In http://reviews.llvm.org/D20608#438760, @majnemer wrote: > Does this change our behavior for mingw? No, this only affects the MS ABI. MinGW doesn't seem to do this trick. For example, in this code, they will emit a definition for S::Inner::f: template struct S {

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

bcraig added a comment. LGTM. You probably need to get an approval from someone else though, as I haven't really established myself in the libunwind code base. As a side note... one of these days clang / llvm stack compaction may actually work reasonably well, and tricks like this won't be

Re: [PATCH] D20597: Speed up check by using a recursive visitor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270714: Speed up check by using a recursive visitor. (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D20597?vs=58438=58440#toc Repository: rL LLVM

[clang-tools-extra] r270714 - Speed up check by using a recursive visitor.

Author: sbenza Date: Wed May 25 11:19:23 2016 New Revision: 270714 URL: http://llvm.org/viewvc/llvm-project?rev=270714=rev Log: Speed up check by using a recursive visitor. Summary: Use a recursive visitor instead of forEachDescendant() matcher. The latter requires several layers of virtual

Re: [PATCH] D20597: Speed up check by using a recursive visitor.

sbenza updated this revision to Diff 58438. sbenza marked an inline comment as done. sbenza added a comment. Reformat code http://reviews.llvm.org/D20597 Files: clang-tidy/readability/FunctionSizeCheck.cpp clang-tidy/readability/FunctionSizeCheck.h Index:

[PATCH] D20630: [OpenCL] Allow -std=CL|CL1.1|CL1.2|CL2.0 in driver

yaxunl created this revision. yaxunl added a reviewer: Anastasia. yaxunl added subscribers: pxli168, bader, tstellarAMD, cfe-commits. Fix a regression which forbids using -std=CL|CL1.1|CL1.2|CL2.0 in driver. Changed -std=cl to -std=CL to match -cl-std=CL. http://reviews.llvm.org/D20630 Files:

Re: [PATCH] D20437: [MSVC] Support of __unaligned qualifier for function types

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Sema/SemaExprCXX.cpp:937 @@ -936,2 +936,3 @@ + CXXThisTypeQuals &= Qualifiers::FastMask; S.CXXThisTypeOverride Can you add

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! http://reviews.llvm.org/D18369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

Anastasia added a comment. @pxli168, do you still plan to update this? I think the implicit declarations would be quite useful to have. http://reviews.llvm.org/D17438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a module

Anastasia added inline comments. Comment at: include/clang/Basic/LangOptions.def:219 @@ -218,3 +218,3 @@ ENUM_LANGOPT(AddressSpaceMapMangling , AddrSpaceMapMangling, 2, ASMM_Target, "OpenCL address space map mangling mode") - +LANGOPT(NoDefaultHeader, 1, 0, "Do not include

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

bcraig added a comment. In http://reviews.llvm.org/D20334#438052, @ahatanak wrote: > My understanding is that typically std::ends is explicitly appended to > null-terminate the stream buffer. The test case in the example does that. > > http://en.cppreference.com/w/cpp/io/ostrstream/str Doh!

Re: [PATCH] D20617: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer

RKSimon added a comment. In http://reviews.llvm.org/D20617#439200, @craig.topper wrote: > Can you double check gcc's xmmintrin.h again. I'm pretty sure _mm_store1_ps > is calling _mm_storeu_ps. Yes you're right - for gcc _mm_store1_pd is aligned (and there is a comment saying it must be),

[PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20626 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: lib/Headers/avx512fintrin.h

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

bcraig added inline comments. Comment at: include/__threading_support:201 @@ +200,3 @@ +// Mutex +#define _LIBCPP_MUTEX_INITIALIZER nullptr +struct __libcpp_platform_mutex_t; rmaprath wrote: > rmaprath wrote: > > bcraig wrote: > > > rmaprath wrote: > > > > bcraig

r270708 - [X86][AVX2] Full set of AVX2 intrinsics tests

Author: rksimon Date: Wed May 25 10:10:49 2016 New Revision: 270708 URL: http://llvm.org/viewvc/llvm-project?rev=270708=rev Log: [X86][AVX2] Full set of AVX2 intrinsics tests llvm/test/CodeGen/X86/avx2-intrinsics-fast-isel.ll will be synced to this Modified:

Re: [PATCH] D20620: [Clang][AVX512][Builtin] Fix palignr intrinsics header

This revision was automatically updated to reflect the committed changes. Closed by commit rL270707: [Clang][AVX512][Builtin] Fix palignr intrinsics header (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20620?vs=58406=58425#toc Repository: rL LLVM

r270707 - [Clang][AVX512][Builtin] Fix palignr intrinsics header

Author: mzuckerm Date: Wed May 25 10:05:03 2016 New Revision: 270707 URL: http://llvm.org/viewvc/llvm-project?rev=270707=rev Log: [Clang][AVX512][Builtin] Fix palignr intrinsics header Differential Revision: http://reviews.llvm.org/D20620 Modified: cfe/trunk/lib/Headers/avx512bwintrin.h

Re: [PATCH] D20617: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer

Can you double check gcc's xmmintrin.h again. I'm pretty sure _mm_store1_ps is calling _mm_storeu_ps. On Wed, May 25, 2016 at 3:31 AM, Simon Pilgrim wrote: > RKSimon created this revision. > RKSimon added reviewers: craig.topper, spatel, andreadb. > RKSimon added a

Re: [PATCH] D20111: [OpenMP] Adjust map type bits according to latest spec and use zero size array sections for pointers.

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4874-4878 @@ -4881,1 +4873,7 @@ +OMP_MAP_IS_PTR = 0x10, +/// \brief This flags signals that an argument is the first one relating to +/// a map/private clause expression. For some cases a

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added inline comments. Comment at: include/__threading_support:201 @@ +200,3 @@ +// Mutex +#define _LIBCPP_MUTEX_INITIALIZER nullptr +struct __libcpp_platform_mutex_t; rmaprath wrote: > bcraig wrote: > > rmaprath wrote: > > > bcraig wrote: > > > >

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

ioeric added inline comments. Comment at: include-fixer/IncludeFixer.cpp:241 @@ -280,5 +240,3 @@ /// \return true if changes will be made, false otherwise. - bool Rewrite(clang::SourceManager , - clang::HeaderSearch , - std::set , -

RE: r267590 - [OpenCL] Add predefined macros.

Great! Thanks! Anastasia -Original Message- From: Liu, Yaxun (Sam) [mailto:yaxun@amd.com] Sent: 25 May 2016 15:46 To: Anastasia Stulova; cfe-commits@lists.llvm.org Cc: nd Subject: RE: r267590 - [OpenCL] Add predefined macros. I will take a look. Thanks. Sam -Original

Re: [PATCH] D20447: [OpenCL] Fixup extension list

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:11 @@ +10,3 @@ +#endif +#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable + jvesely wrote: > Anastasia wrote: > > jvesely wrote: > > > Anastasia wrote: > > > >

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath closed this revision. rmaprath added a comment. Accepted + closed. Patch committed as r270692. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: r267590 - [OpenCL] Add predefined macros.

I will take a look. Thanks. Sam -Original Message- From: Anastasia Stulova [mailto:anastasia.stul...@arm.com] Sent: Wednesday, May 25, 2016 10:29 AM To: Liu, Yaxun (Sam) ; cfe-commits@lists.llvm.org Cc: nd Subject: RE: r267590 - [OpenCL] Add predefined

r270704 - [AVX512] Don't rely on value names. They're different in release builds.

Author: d0k Date: Wed May 25 09:30:01 2016 New Revision: 270704 URL: http://llvm.org/viewvc/llvm-project?rev=270704=rev Log: [AVX512] Don't rely on value names. They're different in release builds. Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified:

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58420. hokein added a comment. Fix a nit. http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

RE: r267590 - [OpenCL] Add predefined macros.

This is because OpenCL sets C99 flag as being superset of it. If you check in clang/Frontend/LangStandards.def LANGSTANDARD(opencl, "cl", "OpenCL 1.0", LineComment | C99 | Digraphs | HexFloat) We should undo this change as it leaves no possibility to specify an OpenCL

Re: [PATCH] D20113: Fix mangled name of method with ns_consumed parameters.

thakis added a subscriber: thakis. thakis accepted this revision. thakis added a reviewer: thakis. thakis added a comment. This revision is now accepted and ready to land. We use phabricator not very dogmatically. If John says this looks good, then this looks good, even if phab didn't get the

[clang-tools-extra] r270703 - [include-fixer] /usr/include/xlocal.h to include/xlocal.h in hardcoded map.

Author: ioeric Date: Wed May 25 09:17:09 2016 New Revision: 270703 URL: http://llvm.org/viewvc/llvm-project?rev=270703=rev Log: [include-fixer] /usr/include/xlocal.h to include/xlocal.h in hardcoded map. Modified:

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein updated this revision to Diff 58415. hokein added a comment. Rebase http://reviews.llvm.org/D20621 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixer.h include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp

[clang-tools-extra] r270701 - Include local header with quotes instead of angle brackets.

Author: d0k Date: Wed May 25 09:14:52 2016 New Revision: 270701 URL: http://llvm.org/viewvc/llvm-project?rev=270701=rev Log: Include local header with quotes instead of angle brackets. This works by accident because we pass '-I.' Modified:

r270702 - Fix mangled name of method with ns_consumed parameters.

Author: nico Date: Wed May 25 09:15:08 2016 New Revision: 270702 URL: http://llvm.org/viewvc/llvm-project?rev=270702=rev Log: Fix mangled name of method with ns_consumed parameters. When a function/method use a parameter with "ns_consumed" attribute, ensure that the mangled name is the same

Re: [PATCH] D20581: [include-fixer] Simplify the code since we won't handle multiple includes at once.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270700: [include-fixer] Simplify the code since we won't handle multiple includes at… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20581?vs=58272=58412#toc Repository: rL

[clang-tools-extra] r270700 - [include-fixer] Simplify the code since we won't handle multiple includes at once.

Author: hokein Date: Wed May 25 09:06:12 2016 New Revision: 270700 URL: http://llvm.org/viewvc/llvm-project?rev=270700=rev Log: [include-fixer] Simplify the code since we won't handle multiple includes at once. Reviewers: bkramer Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D20523: [Clang][AVX512][BUILTIN] Add missing intrinsics for cast .

This revision was automatically updated to reflect the committed changes. Closed by commit rL270699: [Clang][AVX512][BUILTIN] Add missing intrinsics for cast (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20523?vs=58095=58411#toc Repository: rL LLVM

r270699 - [Clang][AVX512][BUILTIN] Add missing intrinsics for cast

Author: mzuckerm Date: Wed May 25 09:04:21 2016 New Revision: 270699 URL: http://llvm.org/viewvc/llvm-project?rev=270699=rev Log: [Clang][AVX512][BUILTIN] Add missing intrinsics for cast Differential Revision: http://reviews.llvm.org/D20523 Modified: cfe/trunk/lib/Headers/avx512fintrin.h

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

aturetsk added a comment. Ping. http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20619: [include-fixer] moved STLPostfixMap into findAllSymbols library and make it a static variable in function.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270696: [include-fixer] moved STLPostfixMap into findAllSymbols library and make it a… (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20619?vs=58408=58410#toc Repository: rL

Re: [PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein added a comment. Oh, sorry, I miss two separate commits here. This patch should not be ready for review. I need to rebase it after commit http://reviews.llvm.org/D20581. http://reviews.llvm.org/D20621 ___ cfe-commits mailing list

[clang-tools-extra] r270696 - [include-fixer] moved STLPostfixMap into findAllSymbols library and make it a static variable in function.

Author: ioeric Date: Wed May 25 08:53:33 2016 New Revision: 270696 URL: http://llvm.org/viewvc/llvm-project?rev=270696=rev Log: [include-fixer] moved STLPostfixMap into findAllSymbols library and make it a static variable in function. Summary: [include-fixer] moved STLPostfixMap into

[PATCH] D20621: [include-fixer] Create a mode in vim integration to show multiple potential headers.

hokein created this revision. hokein added a reviewer: bkramer. hokein added subscribers: ioeric, cfe-commits. Some changes in the patch: * Add two commandline flags in clang-include-fixer. * Introduce a IncludeFixerContext for the queried symbol. * Pull out CreateReplacementsForHeader.

Re: [PATCH] D20620: [Clang][AVX512][Builtin] Fix palignr intrinsics header

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20620: [Clang][AVX512][Builtin] Fix palignr intrinsics header

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. We don't need to multiply by eight the IMM. The instruction is doing that. http://reviews.llvm.org/D20620 Files: lib/Headers/avx512bwintrin.h Index:

Re: [PATCH] D20562: [Clang][AVX512][BUILTIN] Adding intrinsics for set1

AsafBadouh accepted this revision. AsafBadouh added a comment. This revision is now accepted and ready to land. LGTM with small fix Comment at: test/CodeGen/avx512f-builtins.c:341 @@ +340,3 @@ + // CHECK: insertelement <64 x i8> {{.*}}, i32 6 + // CHECK: insertelement <64 x

Re: [PATCH] D20523: [Clang][AVX512][BUILTIN] Add missing intrinsics for cast .

AsafBadouh accepted this revision. AsafBadouh added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20618: [Clang][avx512][builtin] Adding missing intrinsics for cvt

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D20618 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: lib/Headers/avx512fintrin.h

r270693 - Fix build problem in MSVC

Author: abataev Date: Wed May 25 07:51:24 2016 New Revision: 270693 URL: http://llvm.org/viewvc/llvm-project?rev=270693=rev Log: Fix build problem in MSVC Modified: cfe/trunk/lib/AST/OpenMPClause.cpp Modified: cfe/trunk/lib/AST/OpenMPClause.cpp URL:

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added a comment. Committed as r270692. But I forgot to mention this phab review in the commit message. Sigh. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] r270692 - Introduce a native-only unwinder build.

Author: asiri Date: Wed May 25 07:36:34 2016 New Revision: 270692 URL: http://llvm.org/viewvc/llvm-project?rev=270692=rev Log: Introduce a native-only unwinder build. Currently libunwind is built to support cross-unwinding [1] by default, which requires the buffers unw_context_t and unw_cursor_t

r270691 - Revert "[AArch64] Using new TargetParser in Clang"

Author: rengolin Date: Wed May 25 07:36:31 2016 New Revision: 270691 URL: http://llvm.org/viewvc/llvm-project?rev=270691=rev Log: Revert "[AArch64] Using new TargetParser in Clang" This reverts commit r270688 and r270689. The issue is not a random order, but a different order for some targets

r270690 - [OPENMP 4.5] Codegen for dacross loop synchronization constructs.

Author: abataev Date: Wed May 25 07:36:08 2016 New Revision: 270690 URL: http://llvm.org/viewvc/llvm-project?rev=270690=rev Log: [OPENMP 4.5] Codegen for dacross loop synchronization constructs. OpenMP 4.5 adds support for doacross loop synchronization. Patch implements codegen for this

r270689 - [AArch64] Try to fix test from r270688 with unordered output

Author: rengolin Date: Wed May 25 07:16:28 2016 New Revision: 270689 URL: http://llvm.org/viewvc/llvm-project?rev=270689=rev Log: [AArch64] Try to fix test from r270688 with unordered output Modified: cfe/trunk/test/Preprocessor/aarch64-target-features.c Modified:

Re: [PATCH] D20283: Add ras/noras flag to enable/disable RAS in clang

rogfer01 added a comment. I think this has become obsolete as of http://llvm.org/viewvc/llvm-project?view=revision=270688 http://reviews.llvm.org/D20283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20088: Using AArch64TargetParser in clang

rengolin closed this revision. rengolin added a comment. Committed in r270688. Repository: rL LLVM http://reviews.llvm.org/D20088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20089: Adding a TargetParser for AArch64

rengolin closed this revision. rengolin added a comment. Committed in r270687. Repository: rL LLVM http://reviews.llvm.org/D20089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r270688 - [AArch64] Using new TargetParser in Clang

Author: rengolin Date: Wed May 25 07:02:58 2016 New Revision: 270688 URL: http://llvm.org/viewvc/llvm-project?rev=270688=rev Log: [AArch64] Using new TargetParser in Clang Using AArch64TargetParser in clang to avoid repetitive string parsing. Use TargetParser to do ARCH/CPU/ArchExt parsing

Re: [PATCH] D20089: Adding a TargetParser for AArch64

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. In http://reviews.llvm.org/D20089#438937, @jmolloy wrote: > As far as I'm concerned, if you're happy I'm happy. You know this area more > than me. Ok, I'll go ahead and commit this, and

Re: [PATCH] D20088: Using AArch64TargetParser in clang

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Looks great, thanks Jojo! Repository: rL LLVM http://reviews.llvm.org/D20088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia marked 2 inline comments as done. Comment at: lib/Sema/SemaChecking.cpp:81 @@ +80,3 @@ +static bool checkBlockArgs(Sema , Expr *BlockArg) { + const BlockPointerType *BPT = cast(BlockArg->getType()); + ArrayRef Params = bader wrote: > There should be

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

Anastasia updated this revision to Diff 58403. Anastasia marked an inline comment as done. Anastasia added a comment. Updates from Alexey's comments: - Use canonical type while casting to block. - Added failing case to Sema tests. - Modified CodeGen tests due to captures ordering issue.

Re: [PATCH] D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported

This revision was automatically updated to reflect the committed changes. Closed by commit rL270686: [ms][dll] #26935 Defining a dllimport function should cause it to be exported (authored by dzobnin). Changed prior to commit: http://reviews.llvm.org/D18953?vs=58233=58401#toc Repository: rL

r270686 - [ms][dll] #26935 Defining a dllimport function should cause it to be exported

Author: dzobnin Date: Wed May 25 06:32:42 2016 New Revision: 270686 URL: http://llvm.org/viewvc/llvm-project?rev=270686=rev Log: [ms][dll] #26935 Defining a dllimport function should cause it to be exported If we have some function with dllimport attribute and then we have the function

Re: [PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

m_zuckerman added a comment. First thanks I don't see any problem with the patch. but if you can please add full svn diff from clang. svn diff --diff-cmd=diff -x -U99 > x.patch Repository: rL LLVM http://reviews.llvm.org/D20614 ___

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

deadalnix requested changes to this revision. This revision now requires changes to proceed. Comment at: include/llvm-c/Core.h:604 @@ -603,3 +603,3 @@ */ -LLVMBool LLVMPrintModuleToFile(LLVMModuleRef M, const char *Filename, +bool LLVMPrintModuleToFile(LLVMModuleRef M, const

Re: r270373 - [driver][mips] Support new versions of MIPS CodeScape toolchains

Hi, On Wed, May 25, 2016 at 1:32 PM, Simon Atanasyan wrote: > Hi, > > Thanks for the information. One more question. Does the following folder > exist? > >

Re: r270373 - [driver][mips] Support new versions of MIPS CodeScape toolchains

Hi, Thanks for the information. One more question. Does the following folder exist? /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/Driver/Inputs/mips_img_v2_tree/lib/gcc/mips-img-linux-gnu/4.9.2/../../../../mips-img-linux-gnu/include/c++/4.9.2 On Wed, May 25, 2016 at 9:55 AM, Ismail Donmez

[PATCH] D20617: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel, andreadb. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. According to the gcc headers, intel intrinsics docs and msdn codegen the _mm_store1_ps/_mm_store1_pd (and

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

EricWF added a comment. In http://reviews.llvm.org/D16948#438880, @rmaprath wrote: > Looks like I've completely missed this patch somehow. Will try to find some > time (or someone) to have a look at it from an embedded-systems / ARM point > of view asap. > > Great work!!! Thanks! Even just

Re: [PATCH] D19105: Changes in clang after running http://reviews.llvm.org/D18821

Prazek added inline comments. Comment at: include/llvm-c/Core.h:604 @@ -603,3 +603,3 @@ */ -LLVMBool LLVMPrintModuleToFile(LLVMModuleRef M, const char *Filename, +bool LLVMPrintModuleToFile(LLVMModuleRef M, const char *Filename, char

Re: [PATCH] D20089: Adding a TargetParser for AArch64

jmolloy added a comment. As far as I'm concerned, if you're happy I'm happy. You know this area more than me. Repository: rL LLVM http://reviews.llvm.org/D20089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20089: Adding a TargetParser for AArch64

rengolin added a comment. LGTM. James? Bradley? Tim? Repository: rL LLVM http://reviews.llvm.org/D20089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r270682 - [clang-tidy] Fix typo in test file name.

Author: d0k Date: Wed May 25 04:44:35 2016 New Revision: 270682 URL: http://llvm.org/viewvc/llvm-project?rev=270682=rev Log: [clang-tidy] Fix typo in test file name. polo Added: clang-tools-extra/trunk/test/clang-tidy/modernize-pass-by-value-macro-header.cpp - copied, changed from

r270679 - [X86][SSE] Updated _mm_store_ps1 test to match _mm_store1_ps

Author: rksimon Date: Wed May 25 04:20:08 2016 New Revision: 270679 URL: http://llvm.org/viewvc/llvm-project?rev=270679=rev Log: [X86][SSE] Updated _mm_store_ps1 test to match _mm_store1_ps Modified: cfe/trunk/test/CodeGen/sse-builtins.c Modified: cfe/trunk/test/CodeGen/sse-builtins.c URL:

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

bader added a subscriber: bader. bader added a comment. In http://reviews.llvm.org/D20602#438667, @rsmith wrote: > I'm not suggesting it be treated as invalid. This extension is part of at > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > Clang's implementation of the

[PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

kromanova created this revision. kromanova added a reviewer: m_zuckerman. kromanova added a subscriber: cfe-commits. kromanova set the repository for this revision to rL LLVM. Clean up: remove trailing spaces in x86 intrinsic headers. Repository: rL LLVM http://reviews.llvm.org/D20614 Files:

Re: r270373 - [driver][mips] Support new versions of MIPS CodeScape toolchains

On Tue, May 24, 2016 at 4:18 PM, Simon Atanasyan wrote: > /home/abuild/rpmbuild/BUILD/llvm/stage2/bin/clang -no-canonical-prefixes \ > /home/abuild/rpmbuild/BUILD/llvm/tools/clang/test/Driver/mips-img-v2.cpp \ > -### -o >

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a subscriber: rmaprath. rmaprath added a comment. Looks like I've completely missed this patch somehow. Will try to find some time (or someone) to have a look at it from an embedded-systems / ARM point of view asap. Great work!!! http://reviews.llvm.org/D16948

Re: [PATCH] D20574: [libcxxabi] Allow explicit pthread opt-in

rmaprath accepted this revision. rmaprath added a comment. This revision is now accepted and ready to land. LGTM. (I don't have powers to accept libcxx patches in general, but this patch is quite small and related to something I plugged in, so, I think it's OK in this instance)

Re: [PATCH] D20573: [libcxx] Allow explicit pthread opt-in

rmaprath accepted this revision. rmaprath added a comment. This revision is now accepted and ready to land. LGTM. (I don't have powers to accept libcxx patches in general, but this patch is quite small and related to something I plugged in, so, I think it's OK in this instance)

<    1   2