[PATCH] Fix stack overflow in MSVC unqualified type lookup logic

Hi Alexey, A customer encountered a stack overflow in the code from r229817. I've created a small repro for testing the issue and a fix. The fix should also better deal with lookup into partially specialized base templates. Test case included and tested against latest trunk. Let me know if it

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay! http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20766: [clang-tidy] Fix script adding new clang-tidy check

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The `getName()` call is useless. It's better to show a better example as tutorial. http://reviews.llvm.org/D20766 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py

r271080 - AMDGPU: Add fract builtin

Author: arsenm Date: Fri May 27 19:43:27 2016 New Revision: 271080 URL: http://llvm.org/viewvc/llvm-project?rev=271080=rev Log: AMDGPU: Add fract builtin Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp

r271077 - Clean up: remove trailing spaces in x86 intrinsic headers.

Author: kromanova Date: Fri May 27 19:18:59 2016 New Revision: 271077 URL: http://llvm.org/viewvc/llvm-project?rev=271077=rev Log: Clean up: remove trailing spaces in x86 intrinsic headers. Differential Revision: http://reviews.llvm.org/D20614 Modified:

Re: [PATCH] D20640: [AMDGPU] Set default dwarf version to 2

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D20640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r271074 - Add missing include to test_iterators.h

Author: ericwf Date: Fri May 27 18:43:29 2016 New Revision: 271074 URL: http://llvm.org/viewvc/llvm-project?rev=271074=rev Log: Add missing include to test_iterators.h Modified: libcxx/trunk/test/support/test_iterators.h Modified: libcxx/trunk/test/support/test_iterators.h URL:

[libcxx] r271073 - Fix PR27751. Add proper dependancies for install-libcxx-headers rule

Author: ericwf Date: Fri May 27 18:33:10 2016 New Revision: 271073 URL: http://llvm.org/viewvc/llvm-project?rev=271073=rev Log: Fix PR27751. Add proper dependancies for install-libcxx-headers rule Modified: libcxx/trunk/include/CMakeLists.txt Modified: libcxx/trunk/include/CMakeLists.txt

[libcxx] r271070 - Fix PR27875. Parse LIBCXX_CXX_ABI_LIBRARY_PATH as a path not a string

Author: ericwf Date: Fri May 27 18:05:37 2016 New Revision: 271070 URL: http://llvm.org/viewvc/llvm-project?rev=271070=rev Log: Fix PR27875. Parse LIBCXX_CXX_ABI_LIBRARY_PATH as a path not a string Modified: libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake Modified:

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

arsenm added inline comments. Comment at: test/Misc/r600.languageOptsOpenCL.cl:4 @@ +3,3 @@ +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown -target-cpu cypress +// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown -target-cpu

[libcxx] r271065 - Guard testing of tuple extensions to make tests portable

Author: ericwf Date: Fri May 27 17:41:45 2016 New Revision: 271065 URL: http://llvm.org/viewvc/llvm-project?rev=271065=rev Log: Guard testing of tuple extensions to make tests portable Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/UTypes.pass.cpp

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

jvesely updated the summary for this revision. jvesely added a subscriber: cfe-commits. jvesely updated this revision to Diff 58850. jvesely marked an inline comment as done. jvesely added a comment. report only exported extensions. int64 atomics, fp16, and 3d image writes are actually not

Re: [PATCH] D20388: AMDGPU: Fix supported CL features

jvesely marked an inline comment as done. jvesely added a comment. Repository: rL LLVM http://reviews.llvm.org/D20388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271063 - docs: Clarify that LTO visibility is based on source-level symbol visibility.

Author: pcc Date: Fri May 27 17:31:30 2016 New Revision: 271063 URL: http://llvm.org/viewvc/llvm-project?rev=271063=rev Log: docs: Clarify that LTO visibility is based on source-level symbol visibility. Modified: cfe/trunk/docs/LTOVisibility.rst Modified: cfe/trunk/docs/LTOVisibility.rst

Re: [PATCH] D20389: NVPTX: Add supported CL features

jvesely updated the summary for this revision. jvesely added a subscriber: cfe-commits. jvesely updated this revision to Diff 58849. jvesely added a comment. Report only clinfo exported extensions. Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp

[libcxx] r271060 - Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

Author: ericwf Date: Fri May 27 17:19:53 2016 New Revision: 271060 URL: http://llvm.org/viewvc/llvm-project?rev=271060=rev Log: Tolerate incorrect return type for 'isinf' and 'isnan' in tests. Summary: GLIBC recently removed the incorrect `int isinf(double)` and `int isnan(double)` overloads in

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting to get the test suite passing on newer linux distributions again. I tried modifying the tests to test the GLIBC version but IMO it was more

Re: Missing definition of a template virtual function

On Fri, May 27, 2016 at 1:03 PM, Srivastava, Sunil via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, > > > > I want to discuss the issue in PR27895, > >https://llvm.org/bugs/show_bug.cgi?id=27895 > > > > But I will give a slightly different example for this discussion. > > > >

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added a comment. Awesome, thanks. Comment at: include/clang/Basic/DiagnosticLexKinds.td:278 @@ +277,3 @@ +def pp_nonportable_path : Warning< + "non-portable path '%0' found in preprocessor directive">, + InGroup; rsmith wrote: > The fix-it hints

[PATCH] D20757: Add "REQUIRES-ANY" feature test

EricWF created this revision. EricWF added reviewers: ddunbar, rnk. EricWF added subscribers: cfe-commits, llvm-commits. EricWF set the repository for this revision to rL LLVM. This patch adds a "REQUIRES-ANY" feature test that is disjunctive. This marks a test as `UNSUPPORTED` if none of the

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM once the LLVM side is landed. Comment at: include/clang/Basic/DiagnosticLexKinds.td:278 @@ +277,3 @@ +def pp_nonportable_path : Warning<

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

> On May 27, 2016, at 2:55 PM, Rafael Espíndola > wrote: > > On 27 May 2016 at 17:32, Vedant Kumar wrote: >> vsk added a comment. >> >> Comments on this patch -- The increment and decrement snippets seem like >> they could be pulled into helper

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath added a comment. > I have a small concern about how difficult this would make things for us > though - our toolchain setup uses `-ffunction-sections` and `-fdata-sections` > along with linker's unused-section elimination to get rid of most of the > stuff not necessary for the final

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

On 27 May 2016 at 17:32, Vedant Kumar wrote: > vsk added a comment. > > Comments on this patch -- The increment and decrement snippets seem like they > could be pulled into helper methods. That should make it easier to update all > users of LLVMIRGeneration. I wasn't able to

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath added a comment. In http://reviews.llvm.org/D20677#442713, @EricWF wrote: > In http://reviews.llvm.org/D20677#442687, @rmaprath wrote: > > > In http://reviews.llvm.org/D20677#442559, @EricWF wrote: > > > > > I have an issue with this change since it allows a libc++abi built > > >

Re: [PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

vsk added a comment. Comments on this patch -- The increment and decrement snippets seem like they could be pulled into helper methods. That should make it easier to update all users of LLVMIRGeneration. I wasn't able to come up with a regression test, but I do think this patch needs one.

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF added a comment. In http://reviews.llvm.org/D20677#442687, @rmaprath wrote: > In http://reviews.llvm.org/D20677#442559, @EricWF wrote: > > > I have an issue with this change since it allows a libc++abi built without > > exceptions to be used in a program compiled with them. I assert that

Re: [PATCH] D20684: [X86][SSE] Replace VPMOVSX and (V)PMOVZX integer extension intrinsics with generic IR (clang)

RKSimon added a comment. In http://reviews.llvm.org/D20684#442514, @ab wrote: > I'd add the unsigned typedefs with their signed counterparts; no reason not > to. > With that, LGTM. Thanks, I'll do that as a follow up commit. Repository: rL LLVM http://reviews.llvm.org/D20684

Re: [PATCH] D20744: [OpenCL] Disable warning about core features by default

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D20744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

rmaprath added a comment. In http://reviews.llvm.org/D20677#442559, @EricWF wrote: > I have an issue with this change since it allows a libc++abi built without > exceptions to be used in a program compiled with them. I assert that this > should not be supported in any way. > > My personal

[PATCH] D20749: Introduce support for relative C++ ABI gated on LTO visibility.

pcc created this revision. pcc added reviewers: rsmith, rjmccall, rafael, mehdi_amini, aaron.ballman, majnemer, rnk. pcc added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. I'd like to propose this patch as an alternative to D17893 and D18199 that approaches the user

[PATCH] D20748: Handle recursion in LLVMIRGeneration Timer

davide created this revision. davide added reviewers: rafael, vsk. davide added a subscriber: cfe-commits. See http://reviews.llvm.org/D20735 for more context. Implementing this clang-side is not as terrible as I originally thought. Maybe needs a test case, but I wasn't able to reduce one easily

r271042 - [Driver] Fix driver support for color diagnostics

Author: bruno Date: Fri May 27 15:43:00 2016 New Revision: 271042 URL: http://llvm.org/viewvc/llvm-project?rev=271042=rev Log: [Driver] Fix driver support for color diagnostics Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitly

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl marked an inline comment as done. Comment at: include/clang/Basic/LangOptions.def:220 @@ -219,3 +219,3 @@ ENUM_LANGOPT(AddressSpaceMapMangling , AddrSpaceMapMangling, 2, ASMM_Target, "OpenCL address space map mangling mode") - +LANGOPT(IncludeDefaultHeader, 1, 0,

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl retitled this revision from "[OpenCL] Include opencl-c.h by default as a module" to "[OpenCL] Include opencl-c.h by default as a clang module". yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 58830. yaxunl added a comment. Revised as Anastasia suggested.

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

ahatanak added a comment. Thanks! Marshall, I've filed a PR for this bug: https://llvm.org/bugs/show_bug.cgi?id=27915 http://reviews.llvm.org/D20334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler updated this revision to Diff 58828. eric_niebler added a comment. Add fixit tests, fix path separator fixit issue on Windows. http://reviews.llvm.org/D19843 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticLexKinds.td

Missing definition of a template virtual function

Hi, I want to discuss the issue in PR27895, https://llvm.org/bugs/show_bug.cgi?id=27895 But I will give a slightly different example for this discussion. The issue can be demonstrated by this standalone code. Should this example link successfully?

Re: [PATCH] D20447: [OpenCL] Fixup extension list

jvesely marked 7 inline comments as done. Comment at: test/SemaOpenCL/extension-version.cl:12 @@ +11,3 @@ +#ifndef cl_clang_storage_class_specifiers +#error "Missing cl_clang_storage_class_specifiers define" +#endif arsenm wrote: > When the AMD compiler added

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

EricWF added a comment. I have an issue with this change since it allows a libc++abi built without exceptions to be used in a program compiled with them. I assert that this should not be supported in any way. My personal preference would be to remove as much of the exception API from the

Re: [PATCH] D20677: Make it possible to build a -fno-exceptions libc++abi variant.

mclow.lists added a comment. If you're really going to do this, you should probably empty out most of the routines in src/cxa_exception.cpp as well. http://reviews.llvm.org/D20677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58813. pirama added a comment. Switched to emitting errors when rgba is used in OpenCL < 2.2. Also, fixed the diagnostic's name mismatch at its point of issue. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h

r271022 - [Headers] Remove redundant typedef. NFC.

Author: ab Date: Fri May 27 12:57:23 2016 New Revision: 271022 URL: http://llvm.org/viewvc/llvm-project?rev=271022=rev Log: [Headers] Remove redundant typedef. NFC. Modified: cfe/trunk/lib/Headers/smmintrin.h Modified: cfe/trunk/lib/Headers/smmintrin.h URL:

Re: [PATCH] D20660: Remove `auto_ptr` in C++17.

ah, indeed :/ On Fri, May 27, 2016 at 10:55 AM, Eric Fiselier wrote: > > As for tests - XFAILing seems a bit general when there's really not > much value in running any of the tests anyway. REQUIRES, perhaps? > > Unfortunately REQUIRES is a conjunction so the obvious "// REQUIRES:

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

vsk updated this revision to Diff 58810. vsk marked 4 inline comments as done. vsk added a comment. Thanks for the feedback! - Addressed Sean's review comments. - Fixed the line count displayed in the summary view of `foo`. http://reviews.llvm.org/D20715 Files:

Re: [PATCH] D20447: [OpenCL] Fixup extension list

arsenm added a subscriber: arsenm. Comment at: test/SemaOpenCL/extension-version.cl:12 @@ +11,3 @@ +#ifndef cl_clang_storage_class_specifiers +#error "Missing cl_clang_storage_class_specifiers define" +#endif When the AMD compiler added these warnings a long time

Re: [PATCH] D20737: clang-format: [JS] FormatToken.startsSequence/endsSequence.

mprobst updated this revision to Diff 58809. mprobst added a comment. - fix description http://reviews.llvm.org/D20737 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.h lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.cpp Index:

[PATCH] D20737: clang-format: [JS] FormatToken.startsSequence/endsSequence.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Refactors AnnotatedLine.startsWith/endsWith by extracting the core functionality into FormatToken.startsSequence/endsSequence. This allows checking tokens

Re: [PATCH] D20447: [OpenCL] Fixup extension list

jvesely updated this revision to Diff 58806. jvesely added a comment. add detection of extensions in early CL versions to test. Repository: rL LLVM http://reviews.llvm.org/D20447 Files: include/clang/Basic/OpenCLExtensions.def test/SemaOpenCL/extension-version.cl Index:

Re: [PATCH] D20730: [libcxx] Prefer UNSUPPORTED over conditional compilation for tests

bcraig added subscribers: mclow.lists, bcraig. bcraig added a comment. LGTM. Add @mclow.lists as a reviewer. http://reviews.llvm.org/D20730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

bcraig added a comment. In http://reviews.llvm.org/D20320#442246, @rmaprath wrote: > Do you know if there are clang / llvm passes that attempts to achieve some > sort of stack compaction? I couldn't find much. I'm not sure if it belongs to its own pass, or if it is part of another pass, but

Re: [PATCH] D20428: Tracking exception specification source locations

hintonda added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428 @@ -3402,6 +3402,7 @@ // If we already had a dynamic specification, parse the noexcept for, // recovery, but emit a diagnostic and don't store the results. - SourceRange NoexceptRange; +

Re: [PATCH] D20632: clang-format: [JS] Support shebang lines on the very first line.

alexeagle added a comment. ping @djasper we need this fix in order to format angular 2 repo again http://reviews.llvm.org/D20632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20428: Tracking exception specification source locations

aaron.ballman updated this revision to Diff 58804. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Updating based on further review comments. http://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp

Re: [PATCH] D20428: Tracking exception specification source locations

aaron.ballman added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428 @@ -3402,6 +3402,7 @@ // If we already had a dynamic specification, parse the noexcept for, // recovery, but emit a diagnostic and don't store the results. - SourceRange NoexceptRange; +

Re: [PATCH] D20714: [Clang-tidy] Fix some Include What You Use warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 58803. Eugene.Zelenko added a comment. More diff content. Repository: rL LLVM http://reviews.llvm.org/D20714 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/ClangTidyDiagnosticConsumer.cpp

Re: [PATCH] D20617: [X86][SSE] _mm_store1_ps/_mm_store1_pd should require an aligned pointer

RKSimon added inline comments. Comment at: lib/Headers/emmintrin.h:598 @@ -594,3 +597,3 @@ static __inline__ void __DEFAULT_FN_ATTRS -_mm_store_pd(double *__dp, __m128d __a) +_mm_store_pd1(double *__dp, __m128d __a) { majnemer wrote: > You could use

Re: [PATCH] D20428: Tracking exception specification source locations

hintonda added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428 @@ -3402,6 +3402,7 @@ // If we already had a dynamic specification, parse the noexcept for, // recovery, but emit a diagnostic and don't store the results. - SourceRange NoexceptRange; +

[PATCH] D20734: [clang-format] insert new #includes into correct blocks when cleaning up Replacement with cleanupAroundReplacements().

ioeric created this revision. ioeric added reviewers: djasper, klimek. ioeric added subscribers: bkramer, cfe-commits. Herald added a subscriber: klimek. When a replacement's offset is set to UINT_MAX or -1U, it is treated as a header insertion replacement by cleanupAroundReplacements(). The new

r271010 - Add instcombine pass if sampleprofile pass is enabled.

Author: dehao Date: Fri May 27 11:14:35 2016 New Revision: 271010 URL: http://llvm.org/viewvc/llvm-project?rev=271010=rev Log: Add instcombine pass if sampleprofile pass is enabled. Summary: Sample profile pass need to have instcombine pass. A related change is http://reviews.llvm.org/D17742.

Re: [PATCH] D20428: Tracking exception specification source locations

hintonda added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3428 @@ -3402,6 +3402,7 @@ // If we already had a dynamic specification, parse the noexcept for, // recovery, but emit a diagnostic and don't store the results. - SourceRange NoexceptRange; +

r271005 - [msan] add a sentence about inline assembly

Author: kcc Date: Fri May 27 10:49:32 2016 New Revision: 271005 URL: http://llvm.org/viewvc/llvm-project?rev=271005=rev Log: [msan] add a sentence about inline assembly Modified: cfe/trunk/docs/MemorySanitizer.rst Modified: cfe/trunk/docs/MemorySanitizer.rst URL:

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

Anastasia added a comment. In http://reviews.llvm.org/D19780#442305, @rivanvx wrote: > @Anastasia I looked into introducing a separate getOpenCLVersion() function > (or perhaps three - major version, minor version and version string). This > would have to be used in lib/CodeGen/TargetInfo.cpp

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

Anastasia added a comment. Since it has been in review for quite a while, should we try to commit it ASAP? I think Richard can give us his feedback later as well. http://reviews.llvm.org/D18369 ___ cfe-commits mailing list

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

This revision was automatically updated to reflect the committed changes. Closed by commit rL271004: [libunwind] Improve unwinder stack usage - II (authored by asiri). Changed prior to commit: http://reviews.llvm.org/D20320?vs=57452=58794#toc Repository: rL LLVM

[libunwind] r271004 - [libunwind] Improve unwinder stack usage - II

Author: asiri Date: Fri May 27 10:41:45 2016 New Revision: 271004 URL: http://llvm.org/viewvc/llvm-project?rev=271004=rev Log: [libunwind] Improve unwinder stack usage - II unwind_phase1 and unwind_phase2 allocate their own copies of unw_cursor_t buffers on the stack. This can blow-up stack

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

rivanvx added a comment. @Anastasia I looked into introducing a separate getOpenCLVersion() function (or perhaps three - major version, minor version and version string). This would have to be used in lib/CodeGen/TargetInfo.cpp and lib/Parse/ParseDecl.cpp, and I am undecided on where should

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/vla.cl:1 @@ +1,2 @@ +// RUN: %clang_cc1 -emit-llvm -O0 -o - %s | FileCheck %s +// RUN: %clang_cc1 -emit-llvm -O0 -cl-std=CL2.0 -DCL20 -o - %s | FileCheck %s --check-prefix=CL20 pxli168 wrote: >

r271001 - [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

Author: sfantao Date: Fri May 27 10:21:27 2016 New Revision: 271001 URL: http://llvm.org/viewvc/llvm-project?rev=271001=rev Log: [OpenMP] Fix SEMA bug in the capture of global variables in template functions. Summary: Target regions require globals to be captured. This patch fixes a bug exposed

Re: [PATCH] D20729: [mips] Compact branch policy setting

sdardis added a comment. Thanks for the review. Repository: rL LLVM http://reviews.llvm.org/D20729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271000 - [mips] Compact branch policy setting.

Author: sdardis Date: Fri May 27 10:13:31 2016 New Revision: 271000 URL: http://llvm.org/viewvc/llvm-project?rev=271000=rev Log: [mips] Compact branch policy setting. This patch adds the commandline option -mcompact-branches={never,optimal,always), which controls how LLVM generates compact

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Probably worth doing the same thing for the non-EHABI non-SJLJ implementation, too (that can of course go in a separate commit). LGTM http://reviews.llvm.org/D20320

[PATCH] D20732: Don't use static variables in LambdaCapture

john.brawn created this revision. john.brawn added reviewers: faisalv, rsmith, jyknight. john.brawn added a subscriber: cfe-commits. john.brawn set the repository for this revision to rL LLVM. When static variables are used in inline functions in header files anything that uses that function

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

rmaprath added a comment. In http://reviews.llvm.org/D20320#439368, @bcraig wrote: > LGTM. You probably need to get an approval from someone else though, as I > haven't really established myself in the libunwind code base. > > As a side note... one of these days clang / llvm stack compaction

Re: [PATCH] D20447: [OpenCL] Fixup extension list

yaxunl added inline comments. Comment at: test/SemaOpenCL/extension-version.cl:11 @@ +10,3 @@ +#endif +#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable + Anastasia wrote: > jvesely wrote: > > Anastasia wrote: > > > jvesely wrote: > > > >

Re: [PATCH] D20428: Tracking exception specification source locations

aaron.ballman updated this revision to Diff 58784. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review comments. http://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp

Re: [PATCH] D20428: Tracking exception specification source locations

aaron.ballman added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3403-3427 @@ -3402,5 +3402,6 @@ // recovery, but emit a diagnostic and don't store the results. - SourceRange NoexceptRange; + SourceRange NoexceptRange(Tok.getLocation(), +

[PATCH] D20730: [libcxx] Prefer UNSUPPORTED over conditional compilation for tests

rmaprath created this revision. rmaprath added a reviewer: EricWF. rmaprath added a subscriber: cfe-commits. We seem to have quite a few tests where an entire test is conditionalized over some range of `_LIBCPP_STD_VER`. We should consider getting rid of these and using the UNSUPPORTED lit

Re: [PATCH] D18110: [OpenMP] Fix SEMA bug in the capture of global variables in template functions.

sfantao added a comment. In http://reviews.llvm.org/D18110#441959, @ABataev wrote: > Hi Daniel, > Will fix it ASAP Hi Alexey, Just to make sure: the bug I am talking about is fixed by this patch, that's why I didn't abandon this patch, instead I just rebased it. Sorry if my comment was

Re: [PATCH] D20679: [mips] Kill 'support' for untested EABI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270998: [mips] Kill 'support' for untested EABI. (authored by dsanders). Changed prior to commit: http://reviews.llvm.org/D20679?vs=58772=58782#toc Repository: rL LLVM

r270998 - [mips] Kill 'support' for untested EABI.

Author: dsanders Date: Fri May 27 09:30:23 2016 New Revision: 270998 URL: http://llvm.org/viewvc/llvm-project?rev=270998=rev Log: [mips] Kill 'support' for untested EABI. Summary: There are no llvm backend tests* for EABI and no EABI buildbots. There were only three clang tests, all of which

r270996 - Apply clang-tidy's misc-move-constructor-init throughout Clang.

Author: d0k Date: Fri May 27 09:27:13 2016 New Revision: 270996 URL: http://llvm.org/viewvc/llvm-project?rev=270996=rev Log: Apply clang-tidy's misc-move-constructor-init throughout Clang. No functionality change intended, maybe a tiny performance improvement. Modified:

Re: [PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

m_zuckerman added inline comments. Comment at: test/CodeGen/avx512f-builtins.c:1927 @@ +1926,3 @@ + // check-label: @test_mm512_div_pd + // check: @llvm.x86.avx512.mask.div.pd.512 + return _mm512_div_pd(__a,__b); craig.topper wrote: > delena wrote: > > I

Re: [PATCH] D20010: [clang-tidy] UnnecessaryCopyInitialization - Extend to trigger on non-const "this" object argument if it is not modified

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20666: Fix a wrong check in misc-unused-using-decls

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D20666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

alexfh added a comment. Thank you for the new check! Before starting with the review, I'd like to clarify one important thing. It's not immediately obvious that the pattern the check detects is actually a good indicator of a programming mistake. Did you try to run the check on a large enough

r270994 - Turn copies into references as suggested by clang-tidy's performance-unnecessary-copy-initialization.

Author: d0k Date: Fri May 27 08:36:58 2016 New Revision: 270994 URL: http://llvm.org/viewvc/llvm-project?rev=270994=rev Log: Turn copies into references as suggested by clang-tidy's performance-unnecessary-copy-initialization. Modified: cfe/trunk/lib/Analysis/CFG.cpp

Re: [PATCH] D20729: [mips] Compact branch policy setting

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM with some nits Comment at: lib/Driver/Tools.cpp:1446 @@ +1445,3 @@ +CmdArgs.push_back(Args.MakeArgString("-mips-compact-branches=" + Val)); + + } else

[PATCH] D20729: [mips] Compact branch policy setting

sdardis created this revision. sdardis added reviewers: dsanders, atanasyan. sdardis added a subscriber: cfe-commits. Herald added a reviewer: vkalintiris. Herald added a subscriber: sdardis. This patch adds the commandline option -mcompact-branches={never,optimal,always), which controls how

r270991 - [Frontend] StringRefize and fix bad indentation.

Author: d0k Date: Fri May 27 07:52:19 2016 New Revision: 270991 URL: http://llvm.org/viewvc/llvm-project?rev=270991=rev Log: [Frontend] StringRefize and fix bad indentation. NFC intended. Modified: cfe/trunk/lib/Frontend/HeaderIncludeGen.cpp Modified:

[clang-tools-extra] r270989 - [include-fixer] Add a missing .h.

Author: d0k Date: Fri May 27 07:49:58 2016 New Revision: 270989 URL: http://llvm.org/viewvc/llvm-project?rev=270989=rev Log: [include-fixer] Add a missing .h. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Modified:

Re: [PATCH] D20679: [mips] Kill 'support' for untested EABI.

atanasyan added a comment. In http://reviews.llvm.org/D20679#442121, @dsanders wrote: > Just to double-check: Do you still agree we should kill this now that the > number of tests covering EABI-specific behaviour is non-zero? > > I think we should on the basis that we still have no backend

Re: [PATCH] D20334: [libcxx] Fix a bug in strstreambuf::overflow

bcraig added a comment. LGTM. You may want to wait on Marshall's approval though. Thanks for being patient with me, and thanks for the patch! http://reviews.llvm.org/D20334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20679: [mips] Kill 'support' for untested EABI.

dsanders added a comment. Just to double-check: Do you still agree we should kill this now that the number of tests covering EABI-specific behaviour is non-zero? I think we should on the basis that we still have no backend tests and no buildbots. The only tests we have check that the driver

Re: [PATCH] D20679: [mips] Kill 'support' for untested EABI.

dsanders updated this revision to Diff 58772. dsanders added a comment. Herald added subscribers: sdardis, emaste. Removed the 'eabi' from Tools.cpp this revealed three driver tests for passing -mabi to the assembler but the ABI itself is still completely untested.

r270985 - Update for following LLVM commit.

Author: grimar Date: Fri May 27 07:15:25 2016 New Revision: 270985 URL: http://llvm.org/viewvc/llvm-project?rev=270985=rev Log: Update for following LLVM commit. It will be: Recommit 270977 - [llvm-mc] - Teach llvm-mc to generate zlib styled compression sections. Modified:

Re: [PATCH] D20678: [mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename to MipsTargetInfo. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL270984: [mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename… (authored by dsanders). Changed prior to commit: http://reviews.llvm.org/D20678?vs=58604=58770#toc Repository:

r270984 - [mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename to MipsTargetInfo. NFC

Author: dsanders Date: Fri May 27 06:51:02 2016 New Revision: 270984 URL: http://llvm.org/viewvc/llvm-project?rev=270984=rev Log: [mips] Fold MipsTargetInfoBase subclasses into MipsTargetInfoBase and rename to MipsTargetInfo. NFC Summary: This unifies mips/mipsel and mips64/mips64el into a

r270983 - Convert assert to static_assert. NFC.

Author: d0k Date: Fri May 27 06:48:53 2016 New Revision: 270983 URL: http://llvm.org/viewvc/llvm-project?rev=270983=rev Log: Convert assert to static_assert. NFC. Modified: cfe/trunk/include/clang/AST/Type.h Modified: cfe/trunk/include/clang/AST/Type.h URL:

Re: [PATCH] D20614: Remove trailing spaces in x86 intrinsic headers

m_zuckerman accepted this revision. m_zuckerman added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D20614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >