Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:6 @@ +5,3 @@ + +This check would look for cases when inserting new element into an STL +container, but the element is constructed temporarily or is constructed just --

[PATCH] D20966: [include-fixer] Add the missing header to the file where the unidentified symbol comes from.

hokein created this revision. hokein added reviewers: bkramer, ioeric. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D20966 Files: include-fixer/IncludeFixer.cpp include-fixer/IncludeFixerContext.h include-fixer/tool/ClangIncludeFixer.cpp include-fixer/tool/clang-include

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:28 @@ +27,3 @@ + + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), Shouldn't it start with an uppercase letter? =

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

sbarzowski added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:57 @@ +56,3 @@ + + auto functionNameSourceRange = CharSourceRange::getCharRange( + PushBackExpr->getExprLoc(), Call->getArg(0)->getExprLoc()); capital letter? ===

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59558. Prazek added a comment. - Fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h docs/Release

[PATCH] D20963: [mips] The P5600 does not support N32/N64 since it's a 32-bit CPU.

dsanders created this revision. dsanders added a reviewer: atanasyan. dsanders added a subscriber: cfe-commits. dsanders added a dependency: D20961: [mips] Replace almost all Arch checks in MipsTargetInfo with ABI checks. NFC.. Herald added a subscriber: sdardis. Depends on D20961 http://reviews

[PATCH] D20961: [mips] Replace almost all Arch checks in MipsTargetInfo with ABI checks. NFC.

dsanders created this revision. dsanders added a reviewer: atanasyan. dsanders added a subscriber: cfe-commits. setABI() is still tied to the Arch component of the Triple to preserve existing behaviour. http://reviews.llvm.org/D20961 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp =

Re: [PATCH] D20283: Add ras/noras flag to enable/disable RAS in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL271672: RAS extensions are part of ARMv8.2. (authored by SjoerdMeijer). Changed prior to commit: http://reviews.llvm.org/D20283?vs=57451&id=59551#toc Repository: rL LLVM http://reviews.llvm.org/D202

r271672 - RAS extensions are part of ARMv8.2.

Author: sjoerdmeijer Date: Fri Jun 3 09:08:20 2016 New Revision: 271672 URL: http://llvm.org/viewvc/llvm-project?rev=271672&view=rev Log: RAS extensions are part of ARMv8.2. This patch enables +ras +noras to AArch64 in clang. Patch by: Roger Ferrer Ibanez and Oliver Stannard Differential Revis

[clang-tools-extra] r271671 - [include-fixer] Be smarter about inserting symbols for a prefix.

Author: d0k Date: Fri Jun 3 09:07:38 2016 New Revision: 271671 URL: http://llvm.org/viewvc/llvm-project?rev=271671&view=rev Log: [include-fixer] Be smarter about inserting symbols for a prefix. If prefix search finds something where nothing can be nested under (e.g. a variable or macro) don't ad

Re: [PATCH] D20960: [include-fixer] Be smarter about inserting symbols for a prefix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271671: [include-fixer] Be smarter about inserting symbols for a prefix. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20960?vs=59545&id=59550#toc Repository: rL LLVM http://r

Re: [PATCH] D20960: [include-fixer] Be smarter about inserting symbols for a prefix.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. LG. http://reviews.llvm.org/D20960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D20959: [clang-format] make header guard identification stricter (with Lexer).

ioeric updated this revision to Diff 59549. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed reviewer's comments. http://reviews.llvm.org/D20959 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp ===

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor added a comment. Size changes to clang's binary (build with clang): Release: 63367728 Byte -> 6326141 Byte (0.2% less, -106kB) Debug: 1239669408 Byte -> 1264216256 Byte (2% increase, +24.5 MB) http://reviews.llvm.org/D20382 ___ cfe-commi

[PATCH] D20960: [include-fixer] Be smarter about inserting symbols for a prefix.

bkramer created this revision. bkramer added reviewers: hokein, ioeric. bkramer added a subscriber: cfe-commits. If prefix search finds something where nothing can be nested under (e.g. a variable or macro) don't add it to the result. This is for cases like: header.h: extern int a; file.cc: na

Re: [PATCH] D20959: [clang-format] make header guard identification stricter (with Lexer).

djasper added inline comments. Comment at: lib/Format/Format.cpp:1441 @@ +1440,3 @@ +void skipComments(Lexer &Lex, Token &Tok) { + while (!Lex.LexFromRawLexer(Tok)) +if (Tok.isNot(tok::comment)) I'd modify this to: while (Tok.is(comment)) if (Lex.LexFr

[PATCH] D20959: [clang-format] make header guard identification stricter (with Lexer).

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. make header guard identification stricter with Lexer. http://reviews.llvm.org/D20959 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. In http://reviews.llvm.org/D20933#447608, @zaks.anna wrote: > Does FoldingSet already have reserve? (I do not see it.) The reserve call would be new. I'm attempting to add it in this llvm review: http://reviews.llvm.org/D20930 > My understanding is that you propose to

Re: [PATCH] D20858: [clang-format] make header guard identification stricter in header insertion.

ioeric abandoned this revision. ioeric added a comment. Abandon this patch in favor of http://reviews.llvm.org/D20959 http://reviews.llvm.org/D20858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271664: [clang-format] skip empty lines and comments in the top of the code when… (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20898?vs=59511&id=59538#toc Repository: rL LL

r271664 - [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

Author: ioeric Date: Fri Jun 3 07:52:59 2016 New Revision: 271664 URL: http://llvm.org/viewvc/llvm-project?rev=271664&view=rev Log: [clang-format] skip empty lines and comments in the top of the code when inserting new headers. Summary: [clang-format] skip empty lines and comments in the top of

Re: [PATCH] D20732: Don't use static variables in LambdaCapture

john.brawn added a comment. Ping Repository: rL LLVM http://reviews.llvm.org/D20732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20857: [clang-tidy] Add modernize-explicit-operator-bool check.

murrayc updated this revision to Diff 59537. murrayc added a comment. Combined into one check. Also specifies C++11 for the test. http://reviews.llvm.org/D20857 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ExplicitOperatorBoolCheck.cpp clang-tidy/modernize/ExplicitOpera

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

hfinkel added a comment. In http://reviews.llvm.org/D18035#448002, @DmitryPolukhin wrote: > In http://reviews.llvm.org/D18035#447473, @hfinkel wrote: > > > FYI: There is now a specification, see: > > http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html > > > ... > But as far a

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

Just ask Chris for the access :) 03.06.2016 11:26 AM "Clement Courbet via cfe-commits" < cfe-commits@lists.llvm.org> napisał(a): > courbet added a comment. > > @sbenza @aaron.ballman I don't have write access. Can one of you submit > this on my behalf ? Thanks ! > > > http://reviews.llvm.org/D1932

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

DmitryPolukhin added a comment. In http://reviews.llvm.org/D18035#447473, @hfinkel wrote: > FYI: There is now a specification, see: > http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html For the records, this patch implements GCC 6 abi_tag semantic and to the best of my knowle

Re: [PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

Anastasia added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:3394 @@ +3393,3 @@ + if (NumElementsDst == 4) +Args.push_back(llvm::UndefValue::get(CGF.Int32Ty)); + llvm::Constant *Mask = llvm::ConstantVector::get(Args); should this be 3 unstead of

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. That could work :) I'm not sure my commit history is considered a "track record of submitting high quality patches" but I'll give it a try. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D20898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

sepavloff updated this revision to Diff 59532. sepavloff added a comment. Fixed test for friend functions. http://reviews.llvm.org/D16989 Files: include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/PR25848.cpp test/SemaCXX/friend2.cpp Index: test/SemaCXX/friend2.cpp ===

Re: [PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271660: [include-fixer] Don't add missing header if the unindentified symbol isn't… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20950?vs=59496&id=59529#toc Repository: rL

[clang-tools-extra] r271660 - [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

Author: hokein Date: Fri Jun 3 06:26:02 2016 New Revision: 271660 URL: http://llvm.org/viewvc/llvm-project?rev=271660&view=rev Log: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file. Summary: The further solution is to add the missing header to the fi

Re: [PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. LG. It's a bit sad but I guess the cases where that legitimately can happen due to template weirdness are far outweighed by the cases where we have a non-self contained header. The cases I'v

r271647 - [mips] Slightly simplify MipsTargetInfo::setDataLayout(). NFC.

Author: dsanders Date: Fri Jun 3 05:11:01 2016 New Revision: 271647 URL: http://llvm.org/viewvc/llvm-project?rev=271647&view=rev Log: [mips] Slightly simplify MipsTargetInfo::setDataLayout(). NFC. Summary: Reviewers: atanasyan Subscribers: atanasyan, cfe-commits Differential Revision: http://

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath updated this revision to Diff 59519. rmaprath added a comment. Added a comment about `__static_threading` and `__dynamic_threading` header includes. @EricWF: Ping (sorry). http://reviews.llvm.org/D20328 Files: CMakeLists.txt include/__config include/__config_site.in include/_

[clang-tools-extra] r271638 - [include-fixer] fixed a wrong header mapping.

Author: ioeric Date: Fri Jun 3 04:33:22 2016 New Revision: 271638 URL: http://llvm.org/viewvc/llvm-project?rev=271638&view=rev Log: [include-fixer] fixed a wrong header mapping. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Modified: clang-tools-

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271637: [include-fixer] added GNU symbols hardcoded header mapping. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20902?vs=59499&id=59513#toc Repository: rL LLVM http://rev

[clang-tools-extra] r271637 - [include-fixer] added GNU symbols hardcoded header mapping.

Author: ioeric Date: Fri Jun 3 04:25:03 2016 New Revision: 271637 URL: http://llvm.org/viewvc/llvm-project?rev=271637&view=rev Log: [include-fixer] added GNU symbols hardcoded header mapping. Summary: [include-fixer] added GNU symbols hardcoded header mapping. Reviewers: klimek, bkramer Subscr

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet added a comment. @sbenza @aaron.ballman I don't have write access. Can one of you submit this on my behalf ? Thanks ! http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg, thanks! http://reviews.llvm.org/D20902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59511. ioeric added a comment. - Nits fixed. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp === --- uni

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59510. ioeric marked an inline comment as done. ioeric added a comment. - Switch back to range-base looping for Lines. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp =

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59508. ioeric added a comment. - Use regular Lexer instead of FormatTokenLexer. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

Re: [PATCH] D20874: [libcxx] Two more threading dependencies

rmaprath updated this revision to Diff 59507. rmaprath added a comment. Added a comment about `~std::thread()` hook. @EricWF: Gentle ping. http://reviews.llvm.org/D20874 Files: include/__threading_support src/thread.cpp Index: src/thread.cpp ===

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet updated this revision to Diff 59502. courbet added a comment. Rebase on origin/master http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.c

Re: [PATCH] D20929: [libcxx] Fix join.pass.cpp segfault after r271475

rmaprath closed this revision. rmaprath added a comment. Thanks. Fixed in r271634. http://reviews.llvm.org/D20929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271636 - Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72

Author: sjoerdmeijer Date: Fri Jun 3 03:47:56 2016 New Revision: 271636 URL: http://llvm.org/viewvc/llvm-project?rev=271636&view=rev Log: Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72 Differential Revision: http://reviews.llvm.org/D20908 Modified: cfe/trunk

Re: [PATCH] D20908: Add a few missing Clang regression tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL271636: Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72 (authored by SjoerdMeijer). Changed prior to commit: http://reviews.llvm.org/D20908?vs=59371&id=59500#toc Reposit

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1484 @@ +1483,3 @@ + Environment::CreateVirtualEnvironment(Code, FileName, /*Ranges=*/{}); + FormatTokenLexer Lexer(Env->getSourceManager(), Env->getFileID(), Style, + encoding::detectEn

[libcxx] r271634 - [libcxx] Fix thread join.pass.cpp segfault after r271475

Author: asiri Date: Fri Jun 3 03:45:26 2016 New Revision: 271634 URL: http://llvm.org/viewvc/llvm-project?rev=271634&view=rev Log: [libcxx] Fix thread join.pass.cpp segfault after r271475 Some pthread implementations do not like being called pthead_join() with the pthread_t argument set to 0, an

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

ioeric updated this revision to Diff 59499. ioeric added a comment. - Removed non glibc header mapping. http://reviews.llvm.org/D20902 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp =

Re: [PATCH] D20898: [clang-format] skip empty lines and comments in the top of the code when inserting new headers.

ioeric updated this revision to Diff 59497. ioeric added a comment. - Use FormatTokenLexer to skip comments. http://reviews.llvm.org/D20898 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

[PATCH] D20950: [include-fixer] Don't add missing header if the unindentified symbol isn't from the main file.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. The further solution is to add the missing header to the file where the symbol comes from. http://reviews.llvm.org/D20950 Files: include-fixer/IncludeFixer.cpp unittests/include-fixer/Incl

Re: [PATCH] D20902: [include-fixer] added GNU symbols hardcoded header mapping.

bkramer added a comment. There are still headers in this list that aren't part of glibc, like curses. I'd rather have those not in the list right now and add stuff as-needed later. I hope that other packages usually found in /usr/include are saner so we don't need to add a header map for them.

Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271632: [clang-tidy] Ignore function context in misc-unused-using-decls. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20909?vs=59492&id=59494#toc Repository: rL LLVM http:

[clang-tools-extra] r271632 - [clang-tidy] Ignore function context in misc-unused-using-decls.

Author: hokein Date: Fri Jun 3 03:05:11 2016 New Revision: 271632 URL: http://llvm.org/viewvc/llvm-project?rev=271632&view=rev Log: [clang-tidy] Ignore function context in misc-unused-using-decls. Summary: Make the check's behavior more correct when handling using-decls in multiple scopes. Rev

Re: [PATCH] D20909: [clang-tidy] Ignore function context in misc-unused-using-decls.

hokein updated this revision to Diff 59492. hokein added a comment. Address code comments. http://reviews.llvm.org/D20909 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp clang-tidy/misc/UnusedUsingDeclsCheck.h test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unuse

<    1   2