Re: [PATCH] D21352: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

nlewycky closed this revision. nlewycky added a comment. Closed by r272755. http://reviews.llvm.org/D21352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272755 - Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

Author: nicholas Date: Wed Jun 15 00:18:39 2016 New Revision: 272755 URL: http://llvm.org/viewvc/llvm-project?rev=272755=rev Log: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D21030: [Sema] Fix rejects-valid where parameter pack was not expanded in type alias

faisalv added a comment. Thanks for working on this bug too! Comment at: lib/Sema/TreeTransform.h:4784 @@ +4783,3 @@ +NewType = getDerived().RebuildPackExpansionType( +NewType, SourceRange(), Loc, NumExpansions); +if (NewType.isNull())

Re: r272604 - [docs] Coverage: Document the profile merge pool specifier

Thanks! On Tue, Jun 14, 2016 at 10:30 AM, Vedant Kumar wrote: > I think David got rid of that limitation. > > The related warning in compiler-rt does not reflect this: > > PROF_WARN("%%m specifier can only be specified once at the end of > %s.\n", ...); > > Fixed the warning

Re: [PATCH] D14727: [Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations

bryanpkc added a comment. Ping? http://reviews.llvm.org/D14727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272747 - [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

Author: ericwf Date: Tue Jun 14 20:53:32 2016 New Revision: 272747 URL: http://llvm.org/viewvc/llvm-project?rev=272747=rev Log: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types. Summary: In test/support/test_allocator.h, fix construct() to avoid

Re: Buildbot numbers for the last week of 6/05/2016 - 6/11/2016

Some of these tables are getting quite mangled somewhere along the line (email client? mailing list handling? idk). Could you re-send with the tables also attached or something else that avoids that problem? -- Sean Silva On Tue, Jun 14, 2016 at 4:23 PM, Galina Kistanova via cfe-commits <

Re: [PATCH] D21346: [libcxx] [test] Improve portability of random_device tests.

EricWF closed this revision. EricWF added a comment. r272746. http://reviews.llvm.org/D21346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272746 - Improve portability of random_device tests. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 20:50:31 2016 New Revision: 272746 URL: http://llvm.org/viewvc/llvm-project?rev=272746=rev Log: Improve portability of random_device tests. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/numerics/rand/rand.device/ctor.pass.cpp

Re: [PATCH] D21348: [libcxx] [test] Improve portability of vector tests.

EricWF closed this revision. EricWF added a comment. r272745. http://reviews.llvm.org/D21348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272745 - Improve portability of vector tests. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 20:44:22 2016 New Revision: 272745 URL: http://llvm.org/viewvc/llvm-project?rev=272745=rev Log: Improve portability of vector tests. Patch from s...@microsoft.com Modified:

Re: [PATCH] D21347: [libcxx] [test] Improve portability of hash tests.

EricWF closed this revision. EricWF added a comment. r272744. http://reviews.llvm.org/D21347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r272744 - Improve portability of hash tests. Patch from s...@microsoft.com

Author: ericwf Date: Tue Jun 14 20:42:35 2016 New Revision: 272744 URL: http://llvm.org/viewvc/llvm-project?rev=272744=rev Log: Improve portability of hash tests. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/diagnostics/syserr/syserr.hash/error_code.pass.cpp

Re: [PATCH] D21349: [libcxx] [test] Fix a typo in commented-out code.

EricWF added a comment. Deferring this to @mclow.lists because he commented out those tests and hopefully its' time they get uncommented. http://reviews.llvm.org/D21349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxx] r272634 - Implement variadic lock_guard.

Update on the bot failures: I've spoken to the owner of the bots and they are planning to upgrade their Clang versions. This will get the bots green again. /Eric On Mon, Jun 13, 2016 at 11:49 PM, Eric Fiselier wrote: > This is causing some of the libc++ bots to go red. >

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

On Tue, Jun 14, 2016 at 6:09 PM Adrian Prantl wrote: > On Jun 13, 2016, at 9:37 AM, Steven Wu wrote: > > Thanks for the feedback! Replies inline. > > On Jun 12, 2016, at 11:44 PM, Eric Christopher wrote: > > Hi Steven, > > Great to see

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

> On Jun 13, 2016, at 9:37 AM, Steven Wu wrote: > > Thanks for the feedback! Replies inline. > >> On Jun 12, 2016, at 11:44 PM, Eric Christopher > > wrote: >> >> Hi Steven, >> >> Great to see the commentary and updates

Re: [PATCH] D21352: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

george.burgess.iv added a subscriber: george.burgess.iv. george.burgess.iv accepted this revision. george.burgess.iv added a reviewer: george.burgess.iv. george.burgess.iv added a comment. This revision is now accepted and ready to land. LGTM, thanks for the patch!

r272741 - Headers: tweak for MSVC[<1800]

Author: compnerd Date: Tue Jun 14 19:28:15 2016 New Revision: 272741 URL: http://llvm.org/viewvc/llvm-project?rev=272741=rev Log: Headers: tweak for MSVC[<1800] Earlier versions of MSVC did not include inttypes.h. Ensure that we dont try to include_next on those releases. Modified:

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

EricWF added a comment. Gosh darn it Howard. Your like 10 minutes ahead of me. Here is a constexpr gcd test. https://gist.github.com/EricWF/46ea4489f405ec9f83325a278fe99535 Comment at: include/experimental/numeric:50 @@ +49,3 @@ +struct __abs<_Tp, true> { +

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

howard.hinnant added a comment. Can't call `std::abs` as it isn't `constexpr`. You'll have to roll your own. http://reviews.llvm.org/D21343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

EricWF added inline comments. Comment at: include/experimental/numeric:44 @@ +43,3 @@ + +_LIBCPP_BEGIN_NAMESPACE_EXPERIMENTAL + This should be `_LIBCPP_BEGIN_NAMESPACE_LFTS`. Comment at: include/experimental/numeric:46 @@ +45,3 @@ + +template

r272735 - Fix sanitizer coverage support in the win32 driver.

Author: eugenis Date: Tue Jun 14 18:21:19 2016 New Revision: 272735 URL: http://llvm.org/viewvc/llvm-project?rev=272735=rev Log: Fix sanitizer coverage support in the win32 driver. --dependent-lib arguments for the sanitizer libraries must be emitted when coverage is enabled w/o any sanitizers.

Buildbot numbers for the last week of 6/05/2016 - 6/11/2016

Hello everyone, Below are some buildbot numbers for the last week of 6/05/2016 - 6/11/2016. Thanks Galina buildername | was_red ---+--- sanitizer-x86_64-linux-bootstrap

Re: [PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

howard.hinnant added a comment. I created a top-level `gcd` which did nothing but make everything unsigned and do the abs once, and then called a `__gcd` specialized for unsigned and only one kind of unsigned, and got measurably faster results (about 10%). template constexpr

Re: [llvm-dev] [RFC] Embedded bitcode and related upstream (Part II)

On Mon, Jun 13, 2016 at 9:37 AM Steven Wu wrote: > Thanks for the feedback! Replies inline. > > On Jun 12, 2016, at 11:44 PM, Eric Christopher wrote: > > Hi Steven, > > Great to see the commentary and updates here. I've got a few questions > about some of

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. shipit LGTM Comment at: clang-tidy/modernize/UseUsingCheck.cpp:71 @@ +70,3 @@ + const auto *MatchedDecl =

[libcxx] r272723 - Automatically detect export lists for OS X.

Author: ericwf Date: Tue Jun 14 16:55:14 2016 New Revision: 272723 URL: http://llvm.org/viewvc/llvm-project?rev=272723=rev Log: Automatically detect export lists for OS X. Summary: Libc++ reexports symbols from the system libc++abi using -reexport_symbols_list. This can cause a linker failure

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:629 @@ +628,3 @@ +/// \brief Matches expressions that match InnerMatcher after ExprWithCleanups +/// are stripped off. +AST_MATCHER_P(Expr, ignoringExprWithCleanups, internal::Matcher,

[libcxx] r272722 - Fix bad test that was previously getting ifdef-ed away

Author: ericwf Date: Tue Jun 14 16:50:30 2016 New Revision: 272722 URL: http://llvm.org/viewvc/llvm-project?rev=272722=rev Log: Fix bad test that was previously getting ifdef-ed away Modified:

r272720 - [OpenCL] Enable -fblocks by default for OpenCL 2.0 and above.

Author: yaxunl Date: Tue Jun 14 16:43:01 2016 New Revision: 272720 URL: http://llvm.org/viewvc/llvm-project?rev=272720=rev Log: [OpenCL] Enable -fblocks by default for OpenCL 2.0 and above. Reviewed as part of http://reviews.llvm.org/D20444 Added: cfe/trunk/test/Frontend/opencl-blocks.cl

Re: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

EricWF closed this revision. EricWF added a comment. Only 4 missing `#include "test_macros.h"`, and I'm sure all of them were my fault. Committed as r272716. Thanks again. I owe you a case of your preferred caffeine fix. http://reviews.llvm.org/D21098

r272717 - [sanitizer] Allow sanitize coverage w/o sanitizers.

Author: eugenis Date: Tue Jun 14 16:33:40 2016 New Revision: 272717 URL: http://llvm.org/viewvc/llvm-project?rev=272717=rev Log: [sanitizer] Allow sanitize coverage w/o sanitizers. The reason is that this (a) seems to work just fine and (b) useful when building stuff with sanitizer+coverage,

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis updated this revision to Diff 60759. eugenis added a comment. + docs Repository: rL LLVM http://reviews.llvm.org/D21317 Files: docs/SanitizerCoverage.rst lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-coverage.c Index: test/Driver/fsanitize-coverage.c

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 8 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21352: Add a "declared 'nonnull' here" note to warnings where an expression is checked against null.

nlewycky created this revision. nlewycky added a subscriber: cfe-commits. Point to the relevant 'nonnull' or 'returns_nonnull' attribute when complaining about 'a == 0' or 'f() == 0' expressions. http://reviews.llvm.org/D21352 Files: include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

STL_MSFT added a comment. I gotta wait for them, I don't have commit access. :-> (Nor do I need it at the moment) Haven't encountered problems with those locale tests yet, although I'm still processing 670-ish compiletime and runtime failures. http://reviews.llvm.org/D21345

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

bcraig added a comment. LGTM. I don't see anything controversial here. If you want to wait for @EricWF or @mclow.lists though, that's fine. http://reviews.llvm.org/D21345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21350: [libcxx] [test] Avoid C++17 terse static_assert.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. TOTALLY OPTIONAL, feel free to reject this, I won't mind. Newly-added libcxx tests for C++17 features have been using C++17 terse static_asserts occasionally. This is

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a comment. In http://reviews.llvm.org/D16948#457266, @EricWF wrote: > Add `LIBCXX_ENABLE_FILESYSTEM` CMake option to turn off only the filesystem > parts of `libc++experimental.a`. Thanks! http://reviews.llvm.org/D16948 ___

Re: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Thank you! I'll commit once my test-suite with -Wundef finishes. http://reviews.llvm.org/D21098 ___ cfe-commits mailing list

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Please also check if the documentation needs to be updated. Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list

[PATCH] D21349: [libcxx] [test] Fix a typo in commented-out code.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix a typo in commented-out code. http://reviews.llvm.org/D21349 Files: test/std/utilities/meta/meta.unary/meta.unary.prop/is_constructible.pass.cpp Index:

Re: [PATCH] D21345: [libcxx] [test] Avoid huge main() functions and huge arrays.

bcraig added a subscriber: bcraig. bcraig added a comment. > Even though they have artificial blocks in order to keep variables locally > scoped, this gives MSVC's /analyze a headache, because it views main() as > consuming an enormous amount of stack space (it doesn't reuse stack, at least >

[PATCH] D21348: [libcxx] [test] Improve portability of vector tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of vector tests. This test was assuming libcxx's 2x growth factor, which isn't guaranteed by the Standard and isn't provided by MSVC (we use 1.5x). As a

[PATCH] D21347: [libcxx] [test] Improve portability of hash tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of hash tests. These tests were expecting libcxx's identity-hash behavior, which isn't guaranteed by the Standard and isn't provided by MSVC (we currently

[PATCH] D21346: [libcxx] [test] Improve portability of random_device tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Improve portability of random_device tests. These tests were failing for MSVC, because we ignore the token (as permitted by the Standard). Marking the asserts as

Re: [PATCH] D20339: Update clang for D20260

pcc added a comment. Thanks, the patch I committed adds `-cl-opt-disable` to the tests. Repository: rL LLVM http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21320: Alternative to D1332

EricWF added a comment. If we choose to special case this I think we *need* to do it with a new specialization of `default_delete`, not using the primary template. The primary templates defines `default_delete::pointer` as `T*[N]`, which `T*` will not convert to. That means this

Re: [PATCH] D20339: Update clang for D20260

This revision was automatically updated to reflect the committed changes. Closed by commit rL272710: Update clang for D20348 (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D20339?vs=57527=60747#toc Repository: rL LLVM http://reviews.llvm.org/D20339 Files:

r272710 - Update clang for D20348

Author: pcc Date: Tue Jun 14 16:02:05 2016 New Revision: 272710 URL: http://llvm.org/viewvc/llvm-project?rev=272710=rev Log: Update clang for D20348 Differential Revision: http://reviews.llvm.org/D20339 Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp cfe/trunk/lib/CodeGen/CGExpr.cpp

[PATCH] D21343: Implement `lcm` and `gcd` from library fundamentals V2

mclow.lists created this revision. mclow.lists added reviewers: EricWF, howard.hinnant. mclow.lists added a subscriber: cfe-commits. These are probably going to end up in C++17 as well. This is a straight addition; no changes to existing code. http://reviews.llvm.org/D21343 Files:

Re: [PATCH] D20339: Update clang for D20260

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. Adding `-cl-opt-disable` to the tests seems fine as an alternative short-term approach; LGTM with that approach (either as part of this change or a separate

Re: [PATCH] D21337: [CUDA] Give templated device functions internal linkage, templated kernels external linkage.

jlebar added a comment. tra makes the good point that maybe this should be done in ASTContext, where we already have a special case for __global__. (I think I gravitated to doing it this way because the GVA* enums have zero documentation -- at least I have a vague idea of what the LLVM

Re: [PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

STL_MSFT updated this revision to Diff 60736. STL_MSFT added a comment. Inspect TEST_STD_VER and cast to void* as requested. I used a static_cast to avoid triggering any old-style cast warnings. (I also just noticed that I deleted an empty line, but was too lazy to regenerate the diff. Oops.)

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis added a comment. In http://reviews.llvm.org/D21317#457784, @kcc wrote: > Can you at least add a compiler-rt test where we ensure that this flag can > not be used such that it wil compile but fail to link? > > E.g. > > clang -fsanitize-coverage=edge x.c > > should compile *and* link

Re: [PATCH] D21320: Alternative to D1332

STL_MSFT resigned from this revision. STL_MSFT removed a reviewer: STL_MSFT. STL_MSFT added a comment. My only concern is that the tests in test/std shouldn't exercise this bug in the standard, as MSVC's implementation doesn't special-case it. If you'd like to special-case it in your product

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

thanks On Tue, Jun 14, 2016 at 1:31 PM Rui Ueyama wrote: > Hans seems to fix it in r272701. > > On Tue, Jun 14, 2016 at 1:26 PM, Vitaly Buka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Probably the bot was broken by this CL >>

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

Hans seems to fix it in r272701. On Tue, Jun 14, 2016 at 1:26 PM, Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Probably the bot was broken by this CL > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/9922 > > On Tue, Jun 14, 2016 at 1:03 PM Nico Weber

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

Probably the bot was broken by this CL http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/9922 On Tue, Jun 14, 2016 at 1:03 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This change was generated by running `svn mv -m "Rename Intrin.h to > intrin.h,

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama updated this revision to Diff 60735. pirama added a comment. - revise test http://reviews.llvm.org/D21334 Files: lib/Basic/Targets.cpp test/CodeGen/renderscript.c Index: test/CodeGen/renderscript.c === --- /dev/null

r272702 - s/Intrin.h/intrin.h/, trying to fix the build after r272701

Author: hans Date: Tue Jun 14 15:14:24 2016 New Revision: 272702 URL: http://llvm.org/viewvc/llvm-project?rev=272702=rev Log: s/Intrin.h/intrin.h/, trying to fix the build after r272701 Modified: cfe/trunk/lib/Headers/CMakeLists.txt cfe/trunk/lib/Headers/intrin.h

[PATCH] D21338: cc1_main: Do not print statistics in -disable_free mode.

MatzeB created this revision. MatzeB added reviewers: doug.gregor, bkramer. MatzeB added a subscriber: cfe-commits. MatzeB set the repository for this revision to rL LLVM. Herald added a subscriber: mcrosier. llvm statistics are currently printed when the destructor of a "static ManagedStatic

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

r272701, thanks! On Tue, Jun 14, 2016 at 9:34 PM, Hans Wennborg wrote: > SGTM, then :-) > > On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber wrote: > > I locally set up an SVN repo with a file called "File.txt" and then > renamed > > it with `svn mv` using a

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

This change was generated by running `svn mv -m "Rename Intrin.h to intrin.h, that's how all the documentation calls it." https://n...@llvm.org/svn/llvm-project/cfe/trunk/lib/Headers/Intrin.h https://n...@llvm.org/svn/llvm-project/cfe/trunk/lib/Headers/intrin.h` – I didn't manually do anything

r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

Author: nico Date: Tue Jun 14 14:54:40 2016 New Revision: 272701 URL: http://llvm.org/viewvc/llvm-project?rev=272701=rev Log: Rename Intrin.h to intrin.h, that's how all the documentation calls it. Added: cfe/trunk/lib/Headers/intrin.h (props changed) - copied unchanged from r272700,

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

yaxunl added a comment. In http://reviews.llvm.org/D20444#457588, @Anastasia wrote: > LGTM, I think it would be nice if the block related code goes in a separate > commit. > > Thanks! Will do. Thanks. http://reviews.llvm.org/D20444 ___

[PATCH] D21337: [CUDA] Give templated device functions internal linkage, templated kernels external linkage.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. This lets LLVM perform IPO over these functions. In particular, it allows LLVM to emit ld.global.nc for loads to __restrict pointers in kernels that are never written to.

Re: r272656 - Add loop pragma for Loop Distribution

r272699 should do it. > On Jun 14, 2016, at 9:32 PM, Adam Nemet via cfe-commits > wrote: > > On it, sorry about it. > >> On Jun 14, 2016, at 4:51 PM, Rafael Espíndola >> wrote: >> >> Looks like this broke the docs: >>

r272699 - Fix documentation bot after r272656

Author: anemet Date: Tue Jun 14 14:33:16 2016 New Revision: 272699 URL: http://llvm.org/viewvc/llvm-project?rev=272699=rev Log: Fix documentation bot after r272656 Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst URL:

Re: [PATCH] D20339: Update clang for D20260

pcc added a comment. Ping. http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

SGTM, then :-) On Tue, Jun 14, 2016 at 11:54 AM, Nico Weber wrote: > I locally set up an SVN repo with a file called "File.txt" and then renamed > it with `svn mv` using a new svn client (1.8). > > Then I tried updating several local checkouts of my local repo with svn >

Re: r272656 - Add loop pragma for Loop Distribution

On it, sorry about it. > On Jun 14, 2016, at 4:51 PM, Rafael Espíndola > wrote: > > Looks like this broke the docs: > http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/14690/steps/docs-clang-html/logs/stdio > > Cheers, > Rafael > > > On 14 June 2016 at

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama added a comment. This patch is based on the discussion in http://reviews.llvm.org/D20709. http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

pirama added a comment. http://reviews.llvm.org/D21333 and http://reviews.llvm.org/D21334 add the RenderScript triple and modify 'long' based off the triple. r272317, r272342, r272438 take care of the LangOpt and handling of '-x renderscript' and '.rs' extensions.

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60723. pirama added a comment. - Undo bad merge from different patch http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp test/CodeGen/ext-vector.c

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama added a comment. http://reviews.llvm.org/D21333 is the corresponding patch to LLVM http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama created this revision. pirama added reviewers: rsmith, echristo. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: mehdi_amini, danalbert, tberghammer, aemerson. The TargetInfo for 'renderscript32' and 'renderscript64' ArchTypes are subclasses of ARMleTargetInfo and

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60718. pirama added a comment. Herald added subscribers: danalbert, tberghammer. - Add TargetInfo for 32-bit and 64-bit RenderScript http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td

r272695 - [perf-training] Ignore 'Profile Note' warnings from the runtime

Author: vedantk Date: Tue Jun 14 14:06:48 2016 New Revision: 272695 URL: http://llvm.org/viewvc/llvm-project?rev=272695=rev Log: [perf-training] Ignore 'Profile Note' warnings from the runtime After r272599, -DLLVM_BUILD_INSTRUMENTED passes a default argument to -fprofile-instr-generate. This

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. FTR, I finally test it out for compile time and could not notice any difference besides noise. Thanks Eric! http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc added a comment. Can you at least add a compiler-rt test where we ensure that this flag can not be used such that it wil compile but fail to link? E.g. clang -fsanitize-coverage=edge x.c should compile *and* link (and run) Repository: rL LLVM http://reviews.llvm.org/D21317

Re: Virtual patch: `svn mv lib/Headers/Intrin.h lib/Headers/intrin.h`

I locally set up an SVN repo with a file called "File.txt" and then renamed it with `svn mv` using a new svn client (1.8). Then I tried updating several local checkouts of my local repo with svn 1.6.6 clients. All methods of updating I tried (`svn up`, `svn co current_checkout_url@2`) worked

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis added a comment. ubsan_standalone (that's what the needsUbsanRt change is for). Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20561: Warn when taking address of packed member

rsmith added a comment. This still looks like it will have has lots of false positives for cases like: struct __attribute__((packed)) A { char c; int n; } a; void *p = It also looks like it will now have false negatives for cases like: memcpy(x, y, *); I think whitelisting

Re: [PATCH] D20772: Automatically detect export lists for OS X.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Accepting to commit. http://reviews.llvm.org/D20772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

EricWF added a comment. In http://reviews.llvm.org/D21098#457726, @STL_MSFT wrote: > [Eric Fiselier] > > > Please change the `TEST_HAS_FEATURE(XXX)` into `TEST_STD_VER >= 11` for the > > following C++11 features: > > > > > > - `cxx_noexcept` > > > - `cxx_atomic` > > > -

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

On Mon, Jun 13, 2016 at 11:27 AM, Zachary Turner wrote: > I agree that it can be annoying to say "hey guys, i would normally do post > commit review on this, but i wanted to give the courtesy of a heads up", > and then potentially waiting an indeterminate amount of time. > >

RE: [PATCH] D21098: [libcxx] [test] Replace __cplusplus comparisons with TEST_STD_VER and __has_feature with TEST_HAS_FEATURE.

[Eric Fiselier] > Please change the `TEST_HAS_FEATURE(XXX)` into `TEST_STD_VER >= 11` for the > following C++11 features: > - `cxx_noexcept` > - `cxx_atomic` > - `cxx_access_control_sfinae` > Also if the entire test is wrapped in a `TEST_HAS_FEATURE(XXX)` please > translate that into a `//

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

timshen updated this revision to Diff 60704. timshen added a comment. Done. http://reviews.llvm.org/D21241 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Index:

[PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

EricWF created this revision. EricWF added reviewers: mclow.lists, dim, emaste, theraven. EricWF added a subscriber: cfe-commits. Herald added a subscriber: emaste. This patch does the following: * It renames `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR` to

Re: r272604 - [docs] Coverage: Document the profile merge pool specifier

I think David got rid of that limitation. The related warning in compiler-rt does not reflect this: PROF_WARN("%%m specifier can only be specified once at the end of %s.\n", ...); Fixed the warning in r272685. thanks, vedant > On Jun 13, 2016, at 8:13 PM, Sean Silva

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 60697. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/modernize/UseUsingCheck.h docs/ReleaseNotes.rst

Re: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

mkuper accepted this revision. mkuper added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D21173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libunwind] r272680 - [libunwind] Improve unwinder stack usage - III

Sorry it took this long, got pushed down on my TODO list :) Cheers, / Asiri On Tue, Jun 14, 2016 at 5:04 PM, Jonathan Roelofs via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On 6/14/16 9:51 AM, Asiri Rathnayake via cfe-commits wrote: > >> Author: asiri >> Date: Tue Jun 14 10:51:01

Re: [libunwind] r272680 - [libunwind] Improve unwinder stack usage - III

On 6/14/16 9:51 AM, Asiri Rathnayake via cfe-commits wrote: Author: asiri Date: Tue Jun 14 10:51:01 2016 New Revision: 272680 URL: http://llvm.org/viewvc/llvm-project?rev=272680=rev Log: [libunwind] Improve unwinder stack usage - III Implement the same optimization committed under r271004 on

[libunwind] r272680 - [libunwind] Improve unwinder stack usage - III

Author: asiri Date: Tue Jun 14 10:51:01 2016 New Revision: 272680 URL: http://llvm.org/viewvc/llvm-project?rev=272680=rev Log: [libunwind] Improve unwinder stack usage - III Implement the same optimization committed under r271004 on non-EHABI, non-SJLJ unwinder as well. Change-Id:

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia accepted this revision. Anastasia added a comment. LGTM, I think it would be nice if the block related code goes in a separate commit. Thanks! http://reviews.llvm.org/D20444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r272679 - Found a couple bugs in the test suite. No functionality change.

Author: marshall Date: Tue Jun 14 10:25:46 2016 New Revision: 272679 URL: http://llvm.org/viewvc/llvm-project?rev=272679=rev Log: Found a couple bugs in the test suite. No functionality change. Modified:

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc added a comment. What run-time is going to be linked when coverage is used w/o any of the sanitizers? Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >