Re: r272656 - Add loop pragma for Loop Distribution

Looks like this broke the docs: http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/14690/steps/docs-clang-html/logs/stdio Cheers, Rafael On 14 June 2016 at 08:04, Adam Nemet via cfe-commits wrote: > Author: anemet > Date: Tue Jun 14 07:04:26 2016 > New

[libcxx] r272671 - Partially Revert r272613. FreeBSD needs the non-trivial constructors in pair.

Author: ericwf Date: Tue Jun 14 09:34:19 2016 New Revision: 272671 URL: http://llvm.org/viewvc/llvm-project?rev=272671=rev Log: Partially Revert r272613. FreeBSD needs the non-trivial constructors in pair. Modified: libcxx/trunk/include/__config libcxx/trunk/include/utility Modified:

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

mboehme updated this revision to Diff 60686. http://reviews.llvm.org/D21223 Files: clang-tidy/misc/MoveConstantArgumentCheck.cpp docs/clang-tidy/checks/misc-move-const-arg.rst test/clang-tidy/misc-move-const-arg.cpp Index: test/clang-tidy/misc-move-const-arg.cpp

Re: [PATCH] D21323: [clang-format] do not add existing includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272669: [clang-format] do not add existing includes. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21323?vs=60680=60681#toc Repository: rL LLVM

r272669 - [clang-format] do not add existing includes.

Author: ioeric Date: Tue Jun 14 09:09:21 2016 New Revision: 272669 URL: http://llvm.org/viewvc/llvm-project?rev=272669=rev Log: [clang-format] do not add existing includes. Summary: do not add existing includes. Reviewers: djasper Subscribers: klimek, cfe-commits Differential Revision:

Re: [PATCH] D21323: [clang-format] do not add existing includes.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good :-) http://reviews.llvm.org/D21323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21323: [clang-format] do not add existing includes.

ioeric added inline comments. Comment at: unittests/Format/CleanupTest.cpp:701 @@ +700,3 @@ + std::string Code = "#include \"a.h\"\n#include \n"; + std::string Expected = "#include \"a.h\"\n#include \"vector\"\n" + "#include \n#include \n";

Re: [PATCH] D21323: [clang-format] do not add existing includes.

ioeric updated this revision to Diff 60680. ioeric marked 2 inline comments as done. ioeric added a comment. - addressed reviewer's comments. http://reviews.llvm.org/D21323 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index: unittests/Format/CleanupTest.cpp

r272668 - clang-format: [JS] Fix failing format with TypeScript casts.

Author: djasper Date: Tue Jun 14 08:54:38 2016 New Revision: 272668 URL: http://llvm.org/viewvc/llvm-project?rev=272668=rev Log: clang-format: [JS] Fix failing format with TypeScript casts. Before, this could be formatted at all (with BracketAlignmentStyle AlwaysBreak): foo = [ 1,

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76 @@ +74,4 @@ + +class NonMoveable { + public: + NonMoveable(); > Can you expand on this? > > The standard says: "If the definition of a class X does not explicitly >

r272667 - [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

Author: mzuckerm Date: Tue Jun 14 08:45:17 2016 New Revision: 272667 URL: http://llvm.org/viewvc/llvm-project?rev=272667=rev Log: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics Differential Revision: http://reviews.llvm.org/D21322 Modified:

Re: [PATCH] D21322: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL272667: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D21322?vs=60663=60678#toc Repository: rL LLVM

Re: [PATCH] D21323: [clang-format] do not add existing includes.

djasper added inline comments. Comment at: unittests/Format/CleanupTest.cpp:693 @@ +692,3 @@ + std::string Code = "#include \"a.h\"\n#include \n"; + std::string Expected = "#include \"a.h\"\n#include \n"; + tooling::Replacements Replaces = {createInsertion("#include "),

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. A build of Firefox does not show any false positive now. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21323: [clang-format] do not add existing includes.

ioeric updated this revision to Diff 60675. ioeric marked an inline comment as done. ioeric added a comment. - Addressed reviewer's comments: test case added. http://reviews.llvm.org/D21323 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index:

Re: [PATCH] D21323: [clang-format] do not add existing includes.

djasper added a comment. Lets get this in for now. We can always remove it if we think it is no longer useful. Comment at: unittests/Format/CleanupTest.cpp:692 @@ +691,3 @@ +TEST_F(CleanUpReplacementsTest, SkipExistingHeaders) { + std::string Code = "#include

Re: [PATCH] D21323: [clang-format] do not add existing includes.

ioeric added a comment. Agreed. So, do we still want to skip existing #includes here or simply rely on `sortIncludes` to de-duplicate? http://reviews.llvm.org/D21323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21323: [clang-format] do not add existing includes.

djasper added a comment. Well, it is easy to not see duplicated #includes when they aren't properly sorted. When clang-format then goes in and sorts them, they end up next to each other. And I think no user really wants that. http://reviews.llvm.org/D21323

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

mboehme added inline comments. Comment at: test/clang-tidy/misc-move-const-arg.cpp:75-76 @@ +74,4 @@ + +struct NonMoveable { + public: + NonMoveable(); aaron.ballman wrote: > This type isn't non-moveable. For that, you need to explicitly delete the > move

Re: [PATCH] D21323: [clang-format] do not add existing includes.

ioeric added a comment. It should be quite straight-forward to de-duplicate #includes in the same block in `sortIncludes`. I'm happy to add this into `sortIncludes`, but I'm not sure if this is a behavior users would expect from clang-format since it deletes code? And maybe duplicated headers

Re: [PATCH] D21223: [clang-tidy] misc-move-const-arg: Detect if result of std::move() is being passed as a const ref argument

mboehme updated this revision to Diff 60671. http://reviews.llvm.org/D21223 Files: clang-tidy/misc/MoveConstantArgumentCheck.cpp docs/clang-tidy/checks/misc-move-const-arg.rst test/clang-tidy/misc-move-const-arg.cpp Index: test/clang-tidy/misc-move-const-arg.cpp

Re: [PATCH] D21323: [clang-format] do not add existing includes.

djasper added a comment. I am happy to get this in for now, but I actually think the right solution might be to let clang-format de-duplicate #includes in general. What do you think? http://reviews.llvm.org/D21323 ___ cfe-commits mailing list

Re: [gentoo-musl] Re: Add support for musl-libc on Linux

On 13 June 2016 at 21:07, Lei Zhang wrote: > 2016-06-14 5:00 GMT+08:00 Rafael Espíndola : >> Do you need someone to commit it for you? > > Yes, please :) Committed. Cheers, Rafael ___ cfe-commits

r272662 - Start adding support for Musl.

Author: rafael Date: Tue Jun 14 07:47:24 2016 New Revision: 272662 URL: http://llvm.org/viewvc/llvm-project?rev=272662=rev Log: Start adding support for Musl. The two patches together enable clang to support targets like "x86_64-pc-linux-musl" and build binaries against musl-libc instead of

[PATCH] D21323: [clang-format] do not add existing includes.

ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. do not add existing includes. http://reviews.llvm.org/D21323 Files: lib/Format/Format.cpp unittests/Format/CleanupTest.cpp Index:

r272658 - [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

Author: mzuckerm Date: Tue Jun 14 07:38:58 2016 New Revision: 272658 URL: http://llvm.org/viewvc/llvm-project?rev=272658=rev Log: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps Differential Revision: http://reviews.llvm.org/D20626 Modified:

Re: [PATCH] D20626: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps

This revision was automatically updated to reflect the committed changes. Closed by commit rL272658: [Clang][AVX512][intrinsics] Adding missing intrinsics div_pd and div_ps (authored by mzuckerm). Changed prior to commit: http://reviews.llvm.org/D20626?vs=59663=60668#toc Repository: rL LLVM

Re: [PATCH] D21295: Add a negative TBAA test

rogfer01 updated this revision to Diff 60667. rogfer01 added a comment. Much simpler version thanks to @jmolloy comment. http://reviews.llvm.org/D21295 Files: test/CodeGen/tbaa.cpp Index: test/CodeGen/tbaa.cpp === ---

[clang-tools-extra] r272657 - [include-fixer] remove redundant code.

Author: ioeric Date: Tue Jun 14 07:14:36 2016 New Revision: 272657 URL: http://llvm.org/viewvc/llvm-project?rev=272657=rev Log: [include-fixer] remove redundant code. Modified: clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer.cpp Modified:

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rL272656: Add loop pragma for Loop Distribution (authored by anemet). Changed prior to commit: http://reviews.llvm.org/D19403?vs=55445=60665#toc Repository: rL LLVM http://reviews.llvm.org/D19403

r272656 - Add loop pragma for Loop Distribution

Author: anemet Date: Tue Jun 14 07:04:26 2016 New Revision: 272656 URL: http://llvm.org/viewvc/llvm-project?rev=272656=rev Log: Add loop pragma for Loop Distribution Summary: This is similar to other loop pragmas like 'vectorize'. Currently it only has state values: distribute(enable) and

Re: [PATCH] D21322: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 removed rL LLVM as the repository for this revision. rogfer01 updated this revision to Diff 60664. rogfer01 added a comment. This new patch adds a whitelist for memcpy, memmove, memset and memcmp. I'm not entirely happy with the strategy that I'm using, where Parser communicates to

r272654 - clang-format: [JS] Support annotated classes.

Author: djasper Date: Tue Jun 14 06:28:02 2016 New Revision: 272654 URL: http://llvm.org/viewvc/llvm-project?rev=272654=rev Log: clang-format: [JS] Support annotated classes. Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp cfe/trunk/unittests/Format/FormatTestJS.cpp Modified:

[PATCH] D21322: [Clang][avx512][Intrinsics] adding prefetch gather intrinsics

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. _mm512_prefetch_i64gather_ps _mm512_prefetch_i32gather_pd _mm512_prefetch_i64gather_pd _mm512_prefetch_i32gather_ps http://reviews.llvm.org/D21322 Files:

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 reopened this revision. rogfer01 added a comment. This revision is now accepted and ready to land. I've reverted the commit. During implementation of the white list I felt the changes were too much for a follow up commit, so I prefer some feedback first. Repository: rL LLVM

r272653 - Reverting "Warn when taking address of a packed member"

Author: rogfer01 Date: Tue Jun 14 06:20:07 2016 New Revision: 272653 URL: http://llvm.org/viewvc/llvm-project?rev=272653=rev Log: Reverting "Warn when taking address of a packed member" This new diagnostic is causing some false positives that have to be addressed. This reverts commit 272552

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 60662. Prazek marked an inline comment as done. Prazek added a comment. Runned on LLVM and bug fixed one thing http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

mnbvmar added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:69 @@ +68,3 @@ +AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher, + haveOneActiveArgument) { + return anyOf(parameterCountIs(1), Probably

r272645 - [mips] Defer validity check for CPU/ABI pairs and improve error message for invalid cases.

Author: dsanders Date: Tue Jun 14 03:58:50 2016 New Revision: 272645 URL: http://llvm.org/viewvc/llvm-project?rev=272645=rev Log: [mips] Defer validity check for CPU/ABI pairs and improve error message for invalid cases. Summary: The validity of ABI/CPU pairs is no longer checked on the fly but

Re: [libcxx] r272632 - Ignore depricated warnings from and

The depreciation warnings are emitted from and using "#warning". The actual types are not marked deprecated using attributes. That's why the tests suppress "-W#warning". I'm trying to get our test suite passing with -Wsystem-headers -Werror so this is a necessary evil. Hope that clears things

Re: [musl] Re: [gentoo-musl] Re: Add support for musl-libc on Linux

* Rafael Esp?ndola [2016-06-13 17:00:17 -0400]: > Do you need someone to commit it for you? > On Jun 13, 2016 9:50 AM, "Lei Zhang via cfe-commits" < > > http://git.alpinelinux.org/cgit/aports/plain/main/clang/clang-0004-Add-musl-targets-and-dynamic-linker.patch > > > >

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

jojo updated this revision to Diff 60658. jojo added a comment. Herald added a subscriber: mehdi_amini. Update according to inline comments. Repository: rL LLVM http://reviews.llvm.org/D21277 Files: lib/Basic/Targets.cpp lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp

Re: [libcxx] r272632 - Ignore depricated warnings from and

On Tue, Jun 14, 2016 at 03:26:11AM -, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Mon Jun 13 22:26:11 2016 > New Revision: 272632 > > URL: http://llvm.org/viewvc/llvm-project?rev=272632=rev > Log: > Ignore depricated warnings from and Commit message and change don't

Re: [PATCH] D21277: Resubmit r270688: Using new TargetParser in Clang.

jojo added inline comments. Comment at: lib/Basic/Targets.cpp:5709 @@ -5715,1 +5708,3 @@ + +return false; } echristo wrote: > compnerd wrote: > > Please collapse this: > > > > return Name == "generic" || llvm::AArch64::parseCPUArch(Name) != > >

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

erik65536 added a comment. I don't see any other issues. Thanks for fixing this. http://reviews.llvm.org/D20903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D20561: Warn when taking address of packed member

Hi Aaron, Euvgeni, I'll try to whitelist these functions. Kind regards, Roger -Original Message- From: Aaron Ballman [mailto:aaron.ball...@gmail.com] Sent: 14 June 2016 00:30 To: Evgenii Stepanov Cc: reviews+d20561+public+af1fea8a731d8...@reviews.llvm.org; Roger Ferrer Ibanez; Richard

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF added a comment. I checked in tests for the reported bug in r272642. They aren't the most portable so hopefully the pass on all supported platforms. http://reviews.llvm.org/D20903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r272642 - Update errcat.objects tests so they test the bug fixed in r272640.

Author: ericwf Date: Tue Jun 14 01:37:36 2016 New Revision: 272642 URL: http://llvm.org/viewvc/llvm-project?rev=272642=rev Log: Update errcat.objects tests so they test the bug fixed in r272640. Modified:

Re: [PATCH] D16948: [libcxx] Filesystem TS -- Complete

rmaprath added a comment. > > Fine by me. > > > > > > I didn't have much time to go through the patch, is there a way to disable > > this module from building? It won't compile for our targets until we put in > > some sort of a porting layer (which I need to start thinking of). Would be

[libcxx] r272641 - Fix syntax error in r272640.

Author: ericwf Date: Tue Jun 14 01:08:10 2016 New Revision: 272641 URL: http://llvm.org/viewvc/llvm-project?rev=272641=rev Log: Fix syntax error in r272640. Modified: libcxx/trunk/src/system_error.cpp Modified: libcxx/trunk/src/system_error.cpp URL:

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

EricWF added a comment. In http://reviews.llvm.org/D20903#457252, @erik65536 wrote: > > The POSIX version of strerror_r() returns 0 on success, and any other value > > indicates an error (Reference > > ). > > > I should

[libcxx] r272640 - Fix error checking for strerror_r implementations that return the error code.

Author: ericwf Date: Tue Jun 14 01:03:20 2016 New Revision: 272640 URL: http://llvm.org/viewvc/llvm-project?rev=272640=rev Log: Fix error checking for strerror_r implementations that return the error code. Modified: libcxx/trunk/src/system_error.cpp Modified:

Re: [PATCH] D20903: Make system_error::message() thread safe. Fixes PR25598.

erik65536 added a comment. > The POSIX version of strerror_r() returns 0 on success, and any other value > indicates an error (Reference > ). I should have been more explicit when I wrote this recommendation. Checking if

Re: [PATCH] D21094: [libcxx] [test] In test/support/test_allocator.h, fix construct() to avoid moving immovable types.

EricWF added inline comments. Comment at: test/support/test_allocator.h:83 @@ -82,2 +82,3 @@ {return UINT_MAX / sizeof(T);} +#ifdef _LIBCPP_HAS_NO_RVALUE_REFERENCES void construct(pointer p, const T& val) `#if TEST_STD_VER < 11`

<    1   2