r274968 - [X86] Use __builtin_ia32_vec_ext_v4hi and __builtin_ia32_vec_set_v4hi to implement pextrw/pinsertw MMX intrinsics instead of trying to use native IR.

Author: ctopper Date: Sat Jul 9 00:30:41 2016 New Revision: 274968 URL: http://llvm.org/viewvc/llvm-project?rev=274968=rev Log: [X86] Use __builtin_ia32_vec_ext_v4hi and __builtin_ia32_vec_set_v4hi to implement pextrw/pinsertw MMX intrinsics instead of trying to use native IR. Without this we

Re: [PATCH] D21954: [PM] Add some internal options for testing out the new PM.

silvas added a subscriber: cfe-commits. silvas added a comment. Actually add cfe-commits. Oops. Thanks to Chandler for pointing out I had added llvm-commits instead. http://reviews.llvm.org/D21954 ___ cfe-commits mailing list

Re: [PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

sfantao added inline comments. Comment at: lib/Driver/Driver.cpp:3108-3115 @@ +3107,10 @@ + +// Now that we have all the results generated, select the one that should be +// return for the current depending action. +std::pair ActionTC = { +A, +

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

jakev updated the summary for this revision. jakev updated this revision to Diff 63367. jakev marked 3 inline comments as done. jakev added a comment. Reduce instrumentation flags to `fpgo-train` and change profile output file flag to `fpgo-train-output`. Repository: rL LLVM

[PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno created this revision. bruno added reviewers: manmanren, doug.gregor. bruno added a subscriber: cfe-commits. Calls to TransformExpr for NSDictionary elements (keys and values) in TransformObjCDictionaryLiteral might fail to obtain TypoCorrections. This is OK, but the early exits with

Re: [PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 63365. sfantao marked an inline comment as done. sfantao added a comment. - Bind an action to an offloading prefix even if no bound architecture is used. http://reviews.llvm.org/D21847 Files: lib/Driver/Driver.cpp lib/Driver/Tools.cpp

Re: [PATCH] D13909: clang-offload-bundler - offload files bundling/unbundling tool

sfantao updated this revision to Diff 63362. sfantao added a comment. - Add tests for when the host does not come first. - Fix format of comments and add variable to trace the position of the host input. http://reviews.llvm.org/D13909 Files: test/CMakeLists.txt

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao updated this revision to Diff 63361. sfantao added a comment. - Allow host object to come in any order when generating the binary. Add testing for that. - Add save temps and command print option. - Add bundled object for testing. http://reviews.llvm.org/D21851 Files:

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao marked 4 inline comments as done. sfantao added a comment. That was probably not the reason why you were getting the failure, but the bundler was not prepared to bundle files if the host was not the first input. I fixed that. I also replaced the test that was running the linker by

Re: [PATCH] D21814: clang-rename: support multiple renames with one invocation

vmiklos added a comment. As far as I see `tooling::CommonOptionsParser` (in its current form) does not handle cl::SubCommand instances. Should I fix that or would it be OK to switch to using `cl::ParseCommandLineOptions` directly in clang-rename? http://reviews.llvm.org/D21814

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Fri, Jul 8, 2016 at 10:22 AM, Xinliang David Li wrote: > > > On Sun, Jul 3, 2016 at 1:50 PM, Sean Silva wrote: > >> >> >> On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li >> wrote: >> >>> Sanitizers are different IMO. Different

[PATCH] D22176: [OpenMP] add more tests for 'distribute simd' pragma

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, hfinkel, arpith-jacob. kkwli0 added a subscriber: cfe-commits. This patch is to add two additional tests for testing 'distribute simd' pragma with disallowed clauses and loops. http://reviews.llvm.org/D22176

r274930 - Teach -ast-print to print constexpr variables.

Author: vvassilev Date: Fri Jul 8 16:09:08 2016 New Revision: 274930 URL: http://llvm.org/viewvc/llvm-project?rev=274930=rev Log: Teach -ast-print to print constexpr variables. Patch reviewed by Richard Smith (D22168). Modified: cfe/trunk/lib/AST/DeclPrinter.cpp

[PATCH] D22171: [ObjC Availability] Implement parser support for Objective-C's @available

erik.pilkington created this revision. erik.pilkington added reviewers: manmanren, dexonsmith. erik.pilkington added a subscriber: cfe-commits. This patch is the first of the feature I proposed on Monday here: http://lists.llvm.org/pipermail/cfe-dev/2016-July/049851.html This patch adds a new

[PATCH] D22170: [OpenCL] Fixes opencl.cl testcase issues and cl-strict-aliasing only allowed with cl-std=CL

ashi1 created this revision. ashi1 added reviewers: Anastasia, bkramer. ashi1 added subscribers: nhaustov, rsmith, bader, pxli168, cfe-commits, yaxunl. ashi1 set the repository for this revision to rL LLVM. Fixes failures in test/Driver/opencl.cl. Also fixes strict-aliasing option to only be

[PATCH] D22169: [OpenMP] add more tests for 'distribute parallel for simd' pragma

kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel. kkwli0 added a subscriber: cfe-commits. This patch is to add two additional tests for testing 'distribute parallel for simd' pragma with disallowed clauses and loops.

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL274923: [OpenCL] Add missing -cl-no-signed-zeros option into driver (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D22067?vs=63143=63308#toc Repository: rL LLVM

r274923 - [OpenCL] Add missing -cl-no-signed-zeros option into driver

Author: yaxunl Date: Fri Jul 8 15:28:29 2016 New Revision: 274923 URL: http://llvm.org/viewvc/llvm-project?rev=274923=rev Log: [OpenCL] Add missing -cl-no-signed-zeros option into driver Add OCL option -cl-no-signed-zeros to driver options. Also added to opencl.cl testcases. Patch by Aaron En

Re: [PATCH] D21515: Update clang for D21514. NFC

ahatanak added a comment. Assuming http://reviews.llvm.org/D21514 will get accepted, this looks find to me. http://reviews.llvm.org/D21515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

On Fri, Jul 8, 2016 at 3:57 PM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Thu, Jul 7, 2016 at 4:10 PM, Reid Kleckner wrote: > >> On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie wrote: >> >>> Yeah - is this necessary for

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

On Thu, Jul 7, 2016 at 4:10 PM, Reid Kleckner wrote: > On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie wrote: > >> Yeah - is this necessary for CodeView? (does something break, or do you >> just get simple names where you'd prefer full mangled or qualified

Re: [PATCH] D22154: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21453: Add support for attribute "overallocated"

ahatanak marked 7 inline comments as done. Comment at: include/clang/AST/Decl.h:3249 @@ -3248,1 +3248,3 @@ + /// This is true if this struct ends with an array marked 'flexible_array'. + bool HasFlexibleArrayAttr : 1; Probably it can be looked up although it

Re: [PATCH] D21453: Add support for attribute "overallocated"

ahatanak updated this revision to Diff 63299. ahatanak added a comment. Address review comments. http://reviews.llvm.org/D21453 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D20352: Add XRay flags to Clang

aaron.ballman added a comment. I applied your patch locally and got a few compile errors with MSVC 2015: 'bool llvm::opt::ArgList::hasArg(llvm::opt::OptSpecifier,llvm::opt::OptSpecifier,llvm::opt::OptSpecifier) const': cannot convert argument 3 from 'bool' to 'llvm::opt::OptSpecifier'

Re: [PATCH] D21567: [OpenCL] Generate struct type for sampler_t and function call for the initializer

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 63286. yaxunl added a comment. Drop the sampler initializer structure as Anastasia suggested. Now `__translate_sampler_initializer` accepts an integer parameter. http://reviews.llvm.org/D21567 Files:

[PATCH] D22165: [libcxx] [test] Make bucket_count() greater-equal assertions portable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Make bucket_count() greater-equal assertions portable. The Standard provides a guarantee here, but these assertions were going beyond that guarantee. These containers have 8

[PATCH] D22159: [libcxx] [test] Mark bucket_size() assertions as nonportable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Mark bucket_size() assertions as nonportable. Even if you control the hash, the Standard doesn't guarantee what the bucket population sizes will be. All of these assertions

[PATCH] D22157: [libcxx] [test] Mark bucket() assertions as nonportable.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Mark bucket() assertions as nonportable. The Standard doesn't guarantee what bucket an element will land in, even if you control the hash. All such assertions are inherently

[PATCH] D22155: [libcxx] [test] Fix portability issues in tests.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Fix portability issues in tests. Three tests were asserting equal() after shuffling a sequence, which assumes the exact behavior of libc++'s implementation. To be portable,

[PATCH] D22154: [clang-tidy] Pass absolute path to OptionsProvider::getOptions/getRawOptions.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. Although there is no guarantee of getOptions/getRawOptions receiving an absolute path, we try to make it if possible. So FileOptionProvider subclasses don't have to convert the path to an

Re: r274628 - Include debug info for nested structs and classes

On Thu, Jul 7, 2016 at 4:22 PM, Adrian McCarthy wrote: > This patch was reverted because it breaks a test on the buildbots (that > I've been unable to reproduce locally), so that's why you didn't seen > anything. I'll try again to land the patch once I can fix and verify

Re: [PATCH] D22091: [clang-rename] exit code-related bugfix and code cleanup

vmiklos added a comment. In http://reviews.llvm.org/D22091#476756, @vmiklos wrote: > Can you please postpone the cleanup till http://reviews.llvm.org/D21814 is > reviewed? The two patches conflict with each other, I fear. Thanks. :-) Ignore this, that one won't land as-is after all.

Re: [PATCH] D22146: clang-format: [JS] Sort imports case insensitive.

mprobst updated this revision to Diff 63271. mprobst added a comment. - clang-format: [JS] support trailing commas in imports. http://reviews.llvm.org/D22146 Files: lib/Format/SortJavaScriptImports.cpp unittests/Format/SortImportsTestJS.cpp Index: unittests/Format/SortImportsTestJS.cpp

[PATCH] D22147: clang-format: [JS] support trailing commas in imports.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D22147 Files: lib/Format/SortJavaScriptImports.cpp unittests/Format/SortImportsTestJS.cpp Index:

[PATCH] D22146: clang-format: [JS] Sort imports case insensitive.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. ASCII case sorting does not help finding imported symbols quickly, and it is common to have e.g. class Foo and function fooFactory exported/imported from

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

teemperor updated this revision to Diff 63266. teemperor added a comment. - StmtSequence is now treating all Stmt objects as const. http://reviews.llvm.org/D20795 Files: include/clang/AST/CloneDetection.h include/clang/StaticAnalyzer/Checkers/Checkers.td lib/AST/CMakeLists.txt

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 63267. EricWF added a comment. Fix merge conflicts in __config. http://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

teemperor updated this revision to Diff 63262. teemperor marked 7 inline comments as done. http://reviews.llvm.org/D20795 Files: include/clang/AST/CloneDetection.h include/clang/StaticAnalyzer/Checkers/Checkers.td lib/AST/CMakeLists.txt lib/AST/CloneDetection.cpp

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D22067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Sun, Jul 3, 2016 at 1:50 PM, Sean Silva wrote: > > > On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li > wrote: > >> Sanitizers are different IMO. Different santizers are rather independent, >> and there is no such thing as -fsantize to mean

r274885 - CFGTests: Update libdeps.

Author: chapuni Date: Fri Jul 8 12:06:27 2016 New Revision: 274885 URL: http://llvm.org/viewvc/llvm-project?rev=274885=rev Log: CFGTests: Update libdeps. Modified: cfe/trunk/unittests/Analysis/CMakeLists.txt Modified: cfe/trunk/unittests/Analysis/CMakeLists.txt URL:

[libcxx] r274882 - Fix typo in #ifdef; leave tests commented out b/c gcc 4.8 harks on them.

Author: marshall Date: Fri Jul 8 11:59:54 2016 New Revision: 274882 URL: http://llvm.org/viewvc/llvm-project?rev=274882=rev Log: Fix typo in #ifdef; leave tests commented out b/c gcc 4.8 harks on them. Modified:

[libcxx] r274880 - Implement LWG685 (which is from C++11!). Fixes PR#28421. Note: this (subtly) changes the return type of operator-(Iter1, Iter2) where Iter1 is a reverse iterator or a move_iterator,

Author: marshall Date: Fri Jul 8 11:54:47 2016 New Revision: 274880 URL: http://llvm.org/viewvc/llvm-project?rev=274880=rev Log: Implement LWG685 (which is from C++11!). Fixes PR#28421. Note: this (subtly) changes the return type of operator-(Iter1, Iter2) where Iter1 is a reverse iterator or

r274879 - clang/unittests/Analysis/CFGTest.cpp: Appease msc targets with -fno-delayed-template-parsing.

Author: chapuni Date: Fri Jul 8 11:52:36 2016 New Revision: 274879 URL: http://llvm.org/viewvc/llvm-project?rev=274879=rev Log: clang/unittests/Analysis/CFGTest.cpp: Appease msc targets with -fno-delayed-template-parsing. Modified: cfe/trunk/unittests/Analysis/CFGTest.cpp Modified:

Re: [PATCH] D21971: Explicitly export symbols from the sample analyzer plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL274871: Explicitly export symbols from the sample analyzer plugin (authored by john.brawn). Changed prior to commit: http://reviews.llvm.org/D21971?vs=62674=63248#toc Repository: rL LLVM

r274871 - Explicitly export symbols from the sample analyzer plugin

Author: john.brawn Date: Fri Jul 8 11:20:57 2016 New Revision: 274871 URL: http://llvm.org/viewvc/llvm-project?rev=274871=rev Log: Explicitly export symbols from the sample analyzer plugin This is done so that it will work when built using MSVC if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON.

r274859 - Don't crash when printing auto variables.

Author: vvassilev Date: Fri Jul 8 11:04:22 2016 New Revision: 274859 URL: http://llvm.org/viewvc/llvm-project?rev=274859=rev Log: Don't crash when printing auto variables. Patch by Axel Naumann! Modified: cfe/trunk/lib/AST/DeclPrinter.cpp cfe/trunk/test/SemaCXX/ast-print.cpp Modified:

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

sfantao added a comment. In http://reviews.llvm.org/D21851#477905, @Hahnfeld wrote: > Another overall question: Back in February you said that it would be possible > to have a "default" object that can be taken without knowledge of the bundler > (see

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

This revision was automatically updated to reflect the committed changes. Closed by commit rL274858: [OpenCL] Fix access qualifiers handling for typedefs (authored by bader). Changed prior to commit: http://reviews.llvm.org/D20948?vs=63222=63235#toc Repository: rL LLVM

r274858 - [OpenCL] Fix access qualifiers handling for typedefs

Author: bader Date: Fri Jul 8 10:34:59 2016 New Revision: 274858 URL: http://llvm.org/viewvc/llvm-project?rev=274858=rev Log: [OpenCL] Fix access qualifiers handling for typedefs OpenCL s6.6: "Access qualifier must be used with image object arguments of kernels and of user-defined functions

[libcxx] r274857 - [libc++] Check hash before calling __hash_table key_eq function

Author: kmensah Date: Fri Jul 8 10:34:28 2016 New Revision: 274857 URL: http://llvm.org/viewvc/llvm-project?rev=274857=rev Log: [libc++] Check hash before calling __hash_table key_eq function Summary: The current implementations of __hash_table::find used by std::unordered_set/unordered_map

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator updated this revision to Diff 63232. tavianator marked 6 inline comments as done. tavianator added a comment. - Bring back HAVE___CXA_THREAD_ATEXIT_IMPL, and avoid the weak symbol/fallback implementation in that case - Fix a leak in an error path - Add a CreatesThreadLocalInDestructor

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic updated this revision to Diff 63222. asavonic added a comment. Change diagnostic wording http://reviews.llvm.org/D20948 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h lib/Sema/SemaType.cpp

Re: [PATCH] D22127: [include-fixer] Don't add qualifiers to symbols which have global scope operator.

hokein updated this revision to Diff 63221. hokein added a comment. Rebase to master. http://reviews.llvm.org/D22127 Files: include-fixer/IncludeFixerContext.cpp include-fixer/IncludeFixerContext.h unittests/include-fixer/IncludeFixerTest.cpp Index:

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic marked an inline comment as done. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2509-2510 @@ -2508,4 +2508,4 @@ "functions, methods, and parameters|classes|enums|variables|methods|" - "fields and global variables|structs|variables and typedefs|thread-local

Re: [PATCH] D22127: [include-fixer] Don't add qualifiers to symbols which have global scope operator.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274848: [include-fixer] Don't add qualifiers to symbols which have global scope… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D22127?vs=63221=63223#toc Repository: rL LLVM

[clang-tools-extra] r274848 - [include-fixer] Don't add qualifiers to symbols which have global scope operator.

Author: hokein Date: Fri Jul 8 09:28:43 2016 New Revision: 274848 URL: http://llvm.org/viewvc/llvm-project?rev=274848=rev Log: [include-fixer] Don't add qualifiers to symbols which have global scope operator. Reviewers: bkramer Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D20948: [OpenCL] Fix access qualifiers handling for typedefs

asavonic marked 2 inline comments as done. asavonic added a comment. http://reviews.llvm.org/D20948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath added a comment. @mclow.lists, @ericwf: Gentle ping. http://reviews.llvm.org/D21968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. Ping? Looking forward any further comments before committing. Thank you very much. http://reviews.llvm.org/D20561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware added a comment. I added tests for move assignment operators, but I could not find out any other simple test case than memory leak. However memory leaks are currently only detected by Unix.malloc for malloc. So I tried to replace strdup with malloc, strlen and strcpy, but

Re: [PATCH] D22067: [OpenCL] Add missing -cl-no-signed-zeros option into driver

yaxunl added a comment. LGTM. Thanks. http://reviews.llvm.org/D22067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22127: [include-fixer] Don't add qualifiers to symbols which have global scope operator.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This looks like the right thing to do to me. http://reviews.llvm.org/D22127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21851: [Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the host binary format.

Hahnfeld added a comment. Another overall question: Back in February you said that it would be possible to have a "default" object that can be taken without knowledge of the bundler (see http://lists.llvm.org/pipermail/cfe-dev/2016-February/047555.html). In my tests with the patch, this has

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:452 @@ -444,5 +451,3 @@ // inlining when reanalyzing an already inlined function. - if (Visited.count(D)) { -assert(isa(D) && - "We are only reanalyzing

[clang-tools-extra] r274845 - [include-fixer] Pull out Context implementation code to a cpp file.

Author: hokein Date: Fri Jul 8 08:11:38 2016 New Revision: 274845 URL: http://llvm.org/viewvc/llvm-project?rev=274845=rev Log: [include-fixer] Pull out Context implementation code to a cpp file. Added: clang-tools-extra/trunk/include-fixer/IncludeFixerContext.cpp Modified:

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware updated this revision to Diff 63207. baloghadamsoftware added a comment. Debug line removed. http://reviews.llvm.org/D19311 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h

[PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

sisnkemp created this revision. sisnkemp added a reviewer: rafael. sisnkemp added a subscriber: cfe-commits. When building a static PIE binary, linking against /usr/lib/crt0.o results in segfaults when trying to run the binary. Static PIE programs must link against /usr/lib/rcrt0.o instead to

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added a comment. http://reviews.llvm.org/D19311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21971: Explicitly export symbols from the sample analyzer plugin

Ilod added a comment. LGTM. Do you known if there is any good reason Analyzer plugins aren't using the Registry system (thus forcing plugin writers to manually export the functions)? Repository: rL LLVM http://reviews.llvm.org/D21971 ___

Re: [PATCH] D19311: [analyzer] Self Assignment Checker

baloghadamsoftware updated this revision to Diff 63204. baloghadamsoftware added a comment. Issues fixed. http://reviews.llvm.org/D19311 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

Ilod added a comment. LGTM Plugins tests are still disabled by lit.cfg I think, as it only checks for enable_shared, which is disabled. I suppose we could wait for both this and the SampleAnalyzerPlugin to be patched before enabling plugins tests if we have LLVM_EXPORT_SYMBOLS_FOR_PLUGINS, as

[libunwind] r274840 - [PATCH] [libunwind][ehabi] Use early returns where possible.

Author: asiri Date: Fri Jul 8 07:13:31 2016 New Revision: 274840 URL: http://llvm.org/viewvc/llvm-project?rev=274840=rev Log: [PATCH] [libunwind][ehabi] Use early returns where possible. Just a minor code cleanup. NFC. Modified: libunwind/trunk/src/Registers.hpp Modified:

Re: [PATCH] D22100: [clang-rename] fix typo in Python script for Vim integration

This revision was automatically updated to reflect the committed changes. Closed by commit rL274839: [clang-rename] fix typo in Python script for Vim integration (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D22100?vs=63101=63203#toc Repository: rL LLVM

Re: [PATCH] D22129: [clang-rename] add documentation

omtcyf0 updated this revision to Diff 63202. omtcyf0 marked an inline comment as done. http://reviews.llvm.org/D22129 Files: docs/clang-rename.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/index.rst

Re: [PATCH] D22129: [clang-rename] add documentation

klimek added inline comments. Comment at: docs/clang-rename.rst:13 @@ +12,3 @@ + +:program:`clang-rename` is a clang-based C++ "linter" tool. Its purpose is to +perform efficient renaming actions in large-scale projects such as renaming s/"linter"//

Re: [PATCH] D22100: [clang-rename] fix typo in Python script for Vim integration

omtcyf0 added a comment. @hokein thanks! Can you please land it? I don't have commit access. http://reviews.llvm.org/D22100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22100: [clang-rename] fix typo in Python script for Vim integration

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D22100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22129: [clang-rename] add documentation

omtcyf0 created this revision. omtcyf0 added reviewers: alexfh, ioeric, bkramer, klimek, hokein. omtcyf0 added a subscriber: cfe-commits. clang-rename needs at least to have a minimum documentation to provide a small introduction for new users http://reviews.llvm.org/D22129 Files:

Re: [PATCH] D22128: Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion

sberg added a comment. (I'm not sure where and how to add a test for this?) http://reviews.llvm.org/D22128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22128: Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion

sberg created this revision. sberg added a reviewer: rsmith. sberg added a subscriber: cfe-commits. Herald added a subscriber: aemerson. With > struct S1 {}; > struct S2 { operator S1(); }; > S1 f(S2 s) { return static_cast(s); } the static_cast expr is > CXXStaticCastExpr 0x... 'struct S1'

Re: [PATCH] D21799: [ASTMatchers] Add missing forEachArgumentWithParam() to code sample

This revision was automatically updated to reflect the committed changes. Closed by commit rL274835: [ASTMatchers] Add missing forEachArgumentWithParam() to code sample (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D21799?vs=62103=63196#toc Repository: rL LLVM

Re: [PATCH] D21895: CFGBuilder: Fix crash when visiting a range-based for over a dependent type

This revision was automatically updated to reflect the committed changes. Closed by commit rL274834: CFGBuilder: Fix crash when visiting a range-based for over a dependent type (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D21895?vs=62374=63194#toc Repository: rL

r274835 - [ASTMatchers] Add missing forEachArgumentWithParam() to code sample

Author: alexfh Date: Fri Jul 8 05:51:00 2016 New Revision: 274835 URL: http://llvm.org/viewvc/llvm-project?rev=274835=rev Log: [ASTMatchers] Add missing forEachArgumentWithParam() to code sample Reviewers: klimek Subscribers: cfe-commits, klimek Patch by Martin Boehme! Differential Revision:

r274834 - CFGBuilder: Fix crash when visiting a range-based for over a dependent type

Author: alexfh Date: Fri Jul 8 05:50:51 2016 New Revision: 274834 URL: http://llvm.org/viewvc/llvm-project?rev=274834=rev Log: CFGBuilder: Fix crash when visiting a range-based for over a dependent type Summary: CFG generation is expected to fail in this case, but it should not crash. Also

[PATCH] D22127: [include-fixer] Don't add qualifiers to symbols which have global scope operator.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D22127 Files: include-fixer/IncludeFixerContext.h unittests/include-fixer/IncludeFixerTest.cpp Index: unittests/include-fixer/IncludeFixerTest.cpp

[clang-tools-extra] r274832 - [include-fixer] Add missing namespace qualifiers after inserting a missing header.

Author: hokein Date: Fri Jul 8 04:10:29 2016 New Revision: 274832 URL: http://llvm.org/viewvc/llvm-project?rev=274832=rev Log: [include-fixer] Add missing namespace qualifiers after inserting a missing header. Summary: This is an initial version of fixing namespace issues by adding missing

Re: [PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.

This revision was automatically updated to reflect the committed changes. Closed by commit rL274832: [include-fixer] Add missing namespace qualifiers after inserting a missing… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21603?vs=63043=63189#toc Repository: rL

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

pgousseau added a comment. Ping! http://reviews.llvm.org/D20867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] Flag to limit depth of evaluated source locations during macro expansion

Ping 28.06.2016, 02:41, "Андрей Серебро via cfe-commits" :Hello everyone.This patch introduces flag --max-macro-exploc-depth=, which allows to set maximum depth of expansion, on which expansion locations will be evaluated. So, if expansion goes deeper than that, no

r274830 - Recommit r274348 and r274349. The Windows failures should be fixed.

Author: vvassilev Date: Fri Jul 8 03:33:56 2016 New Revision: 274830 URL: http://llvm.org/viewvc/llvm-project?rev=274830=rev Log: Recommit r274348 and r274349. The Windows failures should be fixed. Original commit message: "Add postorder traversal support to the RecursiveASTVisitor. This