hokein added inline comments.
Comment at: include-fixer/tool/ClangIncludeFixer.cpp:365
@@ +364,3 @@
+ for (const auto : Context.getQuerySymbolInfos()) {
+Replacements->insert({FilePath, Info.Range.getOffset(),
+ Info.Range.getLength(),
hokein updated this revision to Diff 64848.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D22567
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
omtcyfz updated this revision to Diff 64844.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
omtcyfz updated this revision to Diff 64841.
omtcyfz added a comment.
add one more XFAIL test
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
omtcyfz updated this revision to Diff 64839.
omtcyfz added a comment.
fix previously unsupported test
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
omtcyfz updated this revision to Diff 64838.
omtcyfz added a comment.
few fixes
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRFinder.h
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
omtcyfz added a comment.
ping
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
The patch looks fine to me (though I'm not sure if there are no new tests; if
they are interface changes should be applied).
If everyone seems to be in favor of such changes, I'm OK with it, but in
general I think it makes things more complicated and I'm not sure if
klimek added a comment.
Kirill, you happy with this approach?
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kimgr added a subscriber: kimgr.
kimgr added a comment.
Inline question on ctor+nullptr
Comment at: include/string_view:216
@@ +215,3 @@
+ basic_string_view(const _CharT* __s)
+ : __data(__s), __size(_Traits::length(__s)) {}
+
I'm working
Author: yrnkrn
Date: Thu Jul 21 02:44:41 2016
New Revision: 276252
URL: http://llvm.org/viewvc/llvm-project?rev=276252=rev
Log:
Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu
language extensions.
These are used by libstdc++ for is_integral<__int128>.
Addresses
vmiklos added a comment.
Is there anything I can help with to get this reviewed, please? As far as I see
it still applies cleanly on top of current trunk.
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ctopper
Date: Thu Jul 21 02:38:39 2016
New Revision: 276249
URL: http://llvm.org/viewvc/llvm-project?rev=276249=rev
Log:
[X86] Add missing __x86_64__ qualifiers on a bunch of intrinsics that assume
64-bit GPRs are available.
Usages of these intrinsics in a 32-bit build results in
Author: ctopper
Date: Thu Jul 21 02:38:43 2016
New Revision: 276250
URL: http://llvm.org/viewvc/llvm-project?rev=276250=rev
Log:
[Sema,X86] Add explicit check to ensure that builtins that require x86-64
target throw an error if used on 32-bit target.
If these builtins are allowed to go through
xazax.hun added inline comments.
Comment at: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1738
@@ +1737,3 @@
+
+ const auto Msg = "Assuming " + Met->getParamDecl(0)->getName() +
+ ((Param == This) ? " == " : " != ") + "*this";
Author: davide
Date: Thu Jul 21 01:28:48 2016
New Revision: 276242
URL: http://llvm.org/viewvc/llvm-project?rev=276242=rev
Log:
[CodeGen] Handle recursion in LLVMIRGeneration Timer.
This can happen when emitting a local decl, which triggers
loading a decl imported from an AST file, which we then
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276242: [CodeGen] Handle recursion in LLVMIRGeneration
Timer. (authored by davide).
Changed prior to commit:
https://reviews.llvm.org/D20748?vs=58833=64826#toc
Repository:
rL LLVM
baloghadamsoftware added a comment.
Thx, I checked the output, but I do not understand why a simple string
concatenation fails in your test environment. It works on our build server
(Linux) with the latest master trunk.
Repository:
rL LLVM
https://reviews.llvm.org/D19311
Author: marshall
Date: Thu Jul 21 01:24:04 2016
New Revision: 276241
URL: http://llvm.org/viewvc/llvm-project?rev=276241=rev
Log:
Fix some string_view tests that were failing when exceptions were disabled.
Also comment out a _LIBCPP_ASSERT that gcc4.9 was complaining about. Will
revisit that
101 - 119 of 119 matches
Mail list logo
