Re: [PATCH] D21314: Make pair and tuple respect is_copy_assignable and is_move_assignable

EricWF abandoned this revision. EricWF added a comment. Similar reversion committed as r276548. https://reviews.llvm.org/D21314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r276548 - Make pair/tuples assignment operators SFINAE properly.

Author: ericwf Date: Sun Jul 24 00:51:11 2016 New Revision: 276548 URL: http://llvm.org/viewvc/llvm-project?rev=276548=rev Log: Make pair/tuples assignment operators SFINAE properly. Added: libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/assign_pair.pass.cpp Modified:

[libcxx] r276547 - Fix memory leak in test.

Author: ericwf Date: Sat Jul 23 23:41:44 2016 New Revision: 276547 URL: http://llvm.org/viewvc/llvm-project?rev=276547=rev Log: Fix memory leak in test. Modified: libcxx/trunk/test/std/utilities/memory/specialized.algorithms/specialized.destroy/destroy_at.pass.cpp Modified:

[libcxx] r276545 - Implement LWG2328. Rvalue stream extraction should perfect forward.

Author: ericwf Date: Sat Jul 23 23:07:22 2016 New Revision: 276545 URL: http://llvm.org/viewvc/llvm-project?rev=276545=rev Log: Implement LWG2328. Rvalue stream extraction should perfect forward. Modified: libcxx/trunk/include/istream

[libcxx] r276544 - Implement P0040r3: Extending memory management tools

Author: ericwf Date: Sat Jul 23 22:51:39 2016 New Revision: 276544 URL: http://llvm.org/viewvc/llvm-project?rev=276544=rev Log: Implement P0040r3: Extending memory management tools Added: libcxx/trunk/test/std/utilities/memory/specialized.algorithms/specialized.destroy/

[libcxx] r276537 - Implement the in_place tags from p0032r3.

Author: ericwf Date: Sat Jul 23 17:19:19 2016 New Revision: 276537 URL: http://llvm.org/viewvc/llvm-project?rev=276537=rev Log: Implement the in_place tags from p0032r3. That paper also has changes to any/optional but those will be implemented later. Added:

Re: [PATCH] D20811: [analyzer] Model some library functions

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:191 @@ +190,3 @@ +// impossible to verify this precisely, but at least +// this check avoids potential crashes. +bool matchesCall(const CallExpr *CE) const;

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. > Yeah, just since we're all here anyway... By the way, -analyzer-config > prune-paths=false is also very handy. I think you should add these to the checker writer manual in the

[libcxx] r276533 - Fix undefined behavior in __hash_table

Author: ericwf Date: Sat Jul 23 15:36:55 2016 New Revision: 276533 URL: http://llvm.org/viewvc/llvm-project?rev=276533=rev Log: Fix undefined behavior in __hash_table Summary: This patch attempts to fix the undefined behavior in __hash_table by changing the node pointer types used throughout.

Re: [PATCH] D20787: Fix undefined behavior in __hash_table

EricWF updated this revision to Diff 65253. EricWF added a comment. - Merge with upstream. - Cleanup logic in iterator - Remove UBSAN blacklist. It's no longer needed. We have no more UB. https://reviews.llvm.org/D20787 Files: include/__config include/__debug include/__hash_table

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

On Sat, Jul 23, 2016 at 4:16 PM, Aaron Ballman wrote: > On Sat, Jul 23, 2016 at 1:38 PM, Piotr Padlewski > wrote: >> Prazek added a subscriber: Prazek. >> Prazek added a comment. >> >> Thanks for the contribution. Is it your first check? >> >>

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

On Sat, Jul 23, 2016 at 1:38 PM, Piotr Padlewski wrote: > Prazek added a subscriber: Prazek. > Prazek added a comment. > > Thanks for the contribution. Is it your first check? > > Some main issues: > > 1. I think it would be much better to move this check to modernize

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:70 @@ +69,3 @@ + + Replaces calls to memcpy with std::copy. + Please highlight memcpy and std::copy with `` as it done in documentation. Repository: rL LLVM

Re: [PATCH] D20811: [analyzer] Model some library functions

NoQ updated this revision to Diff 65248. NoQ marked 11 inline comments as done. NoQ added a comment. Renamed the checker as **xazax.hun** suggested, added a lot more comments, done with inline comments :) https://reviews.llvm.org/D20811 Files:

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

JDevlieghere added a comment. In https://reviews.llvm.org/D22725#493947, @Prazek wrote: > Thanks for the contribution. Is it your first check? Yes, it is! :-) > Some main issues: > > 1. I think it would be much better to move this check to modernize module. I > think the name

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

JDevlieghere updated this revision to Diff 65246. JDevlieghere added a comment. - Added new check to release notes - Renamed to modernize-use-copy - Addressed comments from Prazek Repository: rL LLVM https://reviews.llvm.org/D22725 Files: clang-tidy/modernize/CMakeLists.txt

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

Prazek removed rL LLVM as the repository for this revision. Prazek updated this revision to Diff 65243. Prazek added a comment. Ok works right now. I don't know why but I could not reproduce the error in test file, but I manged to fix it. https://reviews.llvm.org/D22208 Files:

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

Prazek added a comment. In https://reviews.llvm.org/D22725#493942, @JDevlieghere wrote: > In https://reviews.llvm.org/D22725#493940, @aaron.ballman wrote: > > > > Using std::copy opens up the possibility of type-aware optimizations > > > which are not possible with memcpy. > > > > > > To my

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

aaron.ballman added a comment. In https://reviews.llvm.org/D22725#493942, @JDevlieghere wrote: > In https://reviews.llvm.org/D22725#493940, @aaron.ballman wrote: > > > > Using std::copy opens up the possibility of type-aware optimizations > > > which are not possible with memcpy. > > > > > > To

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

Prazek added a subscriber: Prazek. Prazek added a comment. Thanks for the contribution. Is it your first check? Some main issues: 1. I think it would be much better to move this check to modernize module. I think the name 'modernize-use-copy' would follow the convention, or just

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

aaron.ballman added a comment. > Using std::copy opens up the possibility of type-aware optimizations which > are not possible with memcpy. To my knowledge, those type-aware optimizations are for transforming copies involving trivially-copyable types into calls to memcpy(). What other

Re: [PATCH] D22712: Remove FileEntry copy-constructor

compnerd accepted this revision. compnerd added a reviewer: compnerd. compnerd added a comment. This revision is now accepted and ready to land. Do you have commit access? https://reviews.llvm.org/D22712 ___ cfe-commits mailing list

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste updated this revision to Diff 65239. Alexander_Droste added a comment. - fix two MPIdatatype tags https://reviews.llvm.org/D22729 Files: clang-tidy/mpi/BufferDerefCheck.cpp clang-tidy/mpi/BufferDerefCheck.h clang-tidy/mpi/CMakeLists.txt clang-tidy/mpi/MPITidyModule.cpp

Re: [PATCH] D22419: [CFG] Fix crash in thread sanitizer.

dcoughlin added a comment. This is https://llvm.org/bugs/show_bug.cgi?id=28666 https://reviews.llvm.org/D22419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22717: Improve documentation of the type safety attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for improving the documentation! https://reviews.llvm.org/D22717 ___ cfe-commits mailing list

Re: [PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). May be modernize will be better place then misc? https://reviews.llvm.org/D22725 ___

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste updated this revision to Diff 65238. Alexander_Droste added a comment. - make `=` count accurate for `mpi-buffer-deref.rst` https://reviews.llvm.org/D22729 Files: clang-tidy/mpi/BufferDerefCheck.cpp clang-tidy/mpi/BufferDerefCheck.h clang-tidy/mpi/CMakeLists.txt

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander_Droste added a comment. > Do you have commit access? No, I don't have commit access. https://reviews.llvm.org/D21962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste created this revision. Alexander_Droste added a reviewer: alexfh. Alexander_Droste added a subscriber: cfe-commits. This check verifies if a buffer passed to an MPI (Message Passing Interface) function is sufficiently dereferenced. Buffers should be passed as a single pointer or

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

alexfh added a comment. My last comment might come across as somewhat harsh. I didn't mean it to be harsh and just wanted to say that imo, llvm code is not ready to mechanically applying IWYU. Repository: rL LLVM https://reviews.llvm.org/D22656

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

alexfh added a comment. Do you have commit access? https://reviews.llvm.org/D21962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22334: Fix for Bug 28172 : clang crashes on invalid code (with too few arguments to __builtin_signbit) without any proper diagnostics.

mayurpandey added a comment. The crash on : int x = __builtin_signbit("1"); is not a side effect of this patch. It was failing prior to the patch as well. I can work on a new patch for this crash. https://reviews.llvm.org/D22334 ___ cfe-commits

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

NoQ added a comment. > We could add file names but only in cases the file name does not match the > main file. Whoops, right, i guess i'd just fall back to the default source location printing routine for this case (or for macros). F2198462: 3.png > This

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

NoQ updated this revision to Diff 65223. https://reviews.llvm.org/D22622 Files: lib/StaticAnalyzer/Core/ExprEngine.cpp Index: lib/StaticAnalyzer/Core/ExprEngine.cpp === --- lib/StaticAnalyzer/Core/ExprEngine.cpp +++

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander_Droste updated this revision to Diff 65222. Alexander_Droste marked an inline comment as done. Alexander_Droste added a comment. - use parentheses instead of braces https://reviews.llvm.org/D21962 Files: clang-tidy/CMakeLists.txt clang-tidy/mpi/CMakeLists.txt

[PATCH] D22725: [clang-tidy] Add check 'misc-replace-memcpy'

JDevlieghere created this revision. JDevlieghere added a reviewer: alexfh. JDevlieghere added a subscriber: cfe-commits. JDevlieghere added a project: clang-tools-extra. This check emits a warning when memcpy is used and suggest replacing it with a call to std::copy. Using std::copy opens up

Re: [PATCH] D22656: [Clang-apply-replacements] Remove custom version printing; fix some Include What You Use warnings

alexfh added a comment. In https://reviews.llvm.org/D22656#493036, @Eugene.Zelenko wrote: > Don't include DiagnosticIDs.h. This header is just an example. I don't want anyone (including myself) manually figure out which of the headers inserted by IWYU actually need to be inserted. I'm also

Re: [PATCH] D22208: [clang-tidy] Fixes to modernize-use-emplace

alexfh added a comment. In https://reviews.llvm.org/D22208#492385, @Prazek wrote: > There is one bug left: > > In the ClangIncludeFixer.cpp:169 there is push back that looks like this > > Symbols.push_back(find_all_symbols::SymbolInfo( > > Split.first.trim(), >

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with one comment. Comment at: clang-tidy/mpi/TypeMismatchCheck.cpp:237 @@ +236,3 @@ +void TypeMismatchCheck::check(const MatchFinder::MatchResult ) { + static