Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

echristo added a comment. You haven't removed the custom handling? -eric Repository: rL LLVM https://reviews.llvm.org/D22766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

Prazek added inline comments. Comment at: clang-tidy/misc/GlobalNamespaceCheck.cpp:46 @@ +45,3 @@ +// extern "C" globals need to be in the global namespace. +if (VDecl->isExternC()) + return; I think it would be better to check it in matcher. I see

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

Prazek added a subscriber: Prazek. Prazek added a comment. LG(TM) https://reviews.llvm.org/D23135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

Prazek added a comment. In https://reviews.llvm.org/D22725#505020, @JDevlieghere wrote: > Addresses comments from Aaron Ballman > > @aaron.ballman Thanks for the thorough review! Can you check whether the > tests I added address your concerns? Could you also elaborate on the case > with the

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

Eugene.Zelenko added a comment. Please see PR28836. In some cases check should recommend to use insert(). Repository: rL LLVM https://reviews.llvm.org/D20196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

ahatanak added a comment. In each of these cases, "foo::a" is a non-dependent type, so it seems that clang shouldn't use DependentScopeDeclRefExpr or CXXDependentScopeMemberExpr in the AST when the template definitions are parsed. https://reviews.llvm.org/D23096

[PATCH] D23147: [ADT] Migrate DepthFirstIterator to use NodeRef

timshen created this revision. timshen added reviewers: dblaikie, chandlerc. timshen added a subscriber: cfe-commits. The corresponding LLVM change is D23146. https://reviews.llvm.org/D23147 Files: include/clang/AST/StmtGraphTraits.h include/clang/Analysis/Analyses/Dominators.h

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

This revision was automatically updated to reflect the committed changes. Closed by commit rL277677: [clang-tidy] Inefficient string operation (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D20196?vs=66492=66730#toc Repository: rL LLVM

[clang-tools-extra] r277677 - [clang-tidy] Inefficient string operation

Author: alexfh Date: Wed Aug 3 18:06:03 2016 New Revision: 277677 URL: http://llvm.org/viewvc/llvm-project?rev=277677=rev Log: [clang-tidy] Inefficient string operation Patch by Bittner Barni! Differential revision: https://reviews.llvm.org/D20196 Added:

Re: [PATCH] D19909: [Attr] Add support for the `ms_hook_prologue` attribute.

cdavis5x marked an inline comment as done. Comment at: include/clang/Basic/AttrDocs.td:560 @@ +559,3 @@ + +This attribute cannot be used in conjunction with the ``naked``, +``always_inline``, or ``__forceinline`` attributes. Done.

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

This revision was automatically updated to reflect the committed changes. omtcyfz marked an inline comment as done. Closed by commit rL277663: [clang-rename] improve USRFindingAction (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23058?vs=66670=66728#toc Repository:

Re: [PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

alexfh added a comment. In https://reviews.llvm.org/D23130#505242, @bkramer wrote: > DefinitionsInHeaders is tackling a different problem. IMO > DefinitionsInHeaders is something that should be on by default everywhere, > while this check for definitions in the global namespace is more of a

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r277658 - [Concepts] remove default argument for RequiresClause; NFC

Author: hubert.reinterpretcast Date: Wed Aug 3 17:07:50 2016 New Revision: 277658 URL: http://llvm.org/viewvc/llvm-project?rev=277658=rev Log: [Concepts] remove default argument for RequiresClause; NFC Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified:

Re: [PATCH] D23041: Un-XFAIL GCC atomics.align

jfb added a comment. I wrote a quick test, and I think this is technically OK for x86 because alignment "Just Works", but I think it's borked on GCC+ARM (I don't have a system to test that here): https://github.com/jfbastien/atomic_nullptr/blob/master/atomic_nullptr.cc

Re: [PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added a comment. DefinitionsInHeaders is tackling a different problem. IMO DefinitionsInHeaders is something that should be on by default everywhere, while this check for definitions in the global namespace is more of a coding style issue. GlobalNamesInHeaders is a bit of a misnomer,

Re: [PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

On Wed, Aug 3, 2016 at 5:17 PM, Alexander Kornienko wrote: > alexfh added a comment. > > Do we want to merge this check with google/GlobalNamesInHeadersCheck.cpp that > targets a similar set of issues? We also have misc/DefinitionsInHeadersCheck.cpp which is likely similar.

Re: [PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

alexfh added a comment. Do we want to merge this check with google/GlobalNamesInHeadersCheck.cpp that targets a similar set of issues? Repository: rL LLVM https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer updated this revision to Diff 66716. bkramer added a comment. Add relnote. https://reviews.llvm.org/D23130 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/GlobalNamespaceCheck.cpp clang-tidy/misc/GlobalNamespaceCheck.h clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh created this revision. alexfh added a reviewer: hokein. alexfh added a subscriber: cfe-commits. The misc-argument-comment check now ignores leading and trailing underscores and case. The new `StrictMode` local/global option can be used to switch back to strict checking. Add

Re: [libcxx] r273034 - Add Filesystem TS -- Complete

Hi Eric, After we upgraded our green dragon bots to El Captain (10.11), the test below started to fail on some of our machines: -- test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp TEST_CASE(hard_link_count_for_directory) { uintmax_t DirExpect =

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added inline comments. Comment at: test/CodeGenCXX/alloc-size.cpp:66 @@ +65,3 @@ + // CHECK: ret i32 122 + return __builtin_object_size(my_malloc(), 0) + + __builtin_object_size(my_calloc(5), 0) + ahatanak wrote: > george.burgess.iv

Re: [PATCH] D22927: [OpenCL] Fix size of image type

This revision was automatically updated to reflect the committed changes. Closed by commit rL277647: [OpenCL] Fix size of image type (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D22927?vs=65964=66705#toc Repository: rL LLVM https://reviews.llvm.org/D22927 Files:

r277647 - [OpenCL] Fix size of image type

Author: yaxunl Date: Wed Aug 3 15:38:06 2016 New Revision: 277647 URL: http://llvm.org/viewvc/llvm-project?rev=277647=rev Log: [OpenCL] Fix size of image type The size of image type is reported incorrectly as size of a pointer to address space 0, which causes error when casting image type to

Re: [PATCH] D23041: Un-XFAIL GCC atomics.align

jfb added a comment. @EricWF ran this on configuration `cxx_under_test=g++-4.9`. It generates the following error: libcxx/test/libcxx/atomics/atomics.align/align.pass.sh.cpp:32: atomic_test::atomic_test() [with T = std::nullptr_t]: Assertion `alignof(this->__a_) >= sizeof(this->__a_) &&

Re: [PATCH] D23130: Add a check for definitions in the global namespace.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). https://reviews.llvm.org/D23130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14274: Add alloc_size attribute to clang

ahatanak added inline comments. Comment at: test/CodeGenCXX/alloc-size.cpp:66 @@ +65,3 @@ + // CHECK: ret i32 122 + return __builtin_object_size(my_malloc(), 0) + + __builtin_object_size(my_calloc(5), 0) + george.burgess.iv wrote: > ahatanak wrote: > >

[PATCH] D23130: Add a check for definitions in the global namespace.

bkramer created this revision. bkramer added a reviewer: alexfh. bkramer added a subscriber: cfe-commits. This is prone to ODR violations and generally frowned upon in many codebases (e.g. LLVM). The checker flags definitions, variables and classes in the global namespace. Common false positives

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

JDevlieghere updated this revision to Diff 66688. JDevlieghere marked 21 inline comments as done. JDevlieghere added a comment. Addresses comments from Aaron Ballman @aaron.ballman Thanks for the thorough review! Can you check whether the tests I added address your concerns? Could you also

Re: [PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

ahatanak added a comment. OK, I'll add the test. When I apply this patch and compile your test, I see DependentScopeDeclRefExpr gets converted to DeclRefExpr when the function is instantiated. This doesn't happen without this patch, but somehow clang still manages to emit the same code.

[clang-tools-extra] r277623 - [docs] fix typo in clang-rename docs

Author: omtcyfz Date: Wed Aug 3 13:15:07 2016 New Revision: 277623 URL: http://llvm.org/viewvc/llvm-project?rev=277623=rev Log: [docs] fix typo in clang-rename docs clang-rename is a refactoring tool, not "linter" tool. Fix typo in docs. Modified:

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

benlangmuir added a comment. How about -fmodules-use-prebuilt-**module-cache** for the flag name? Saying "prebuilt-modules" is confusing to me, since -fmodule-file can also be used to load a prebuilt module, but doesn't use a cache. Comment at: lib/Driver/Tools.cpp:5416 @@

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added inline comments. Comment at: lib/Driver/Tools.cpp:5416 @@ -5408,1 +5415,3 @@ + if (Args.getLastArg(options::OPT_fmodules_use_prebuilt_modules)) { +// When using prebuilt modules, we disable module hash. benlangmuir wrote: > ``` > if

Re: [PATCH] D23096: [Sema] Pass CombineWithOuterScope = true to constructor of LocalInstantiationScope

sepavloff added inline comments. Comment at: test/SemaTemplate/default-expr-arguments-3.cpp:20 @@ +19,2 @@ + } +} Please add the following test to the patch: ``` template void f1() { enum class foo { a, b }; struct S { int g1(foo n = foo::a); }; }

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added a comment. > I'm wondering what the status of this patch is since someone has asked us to > add support for this attribute in clang. Are you still waiting for review? Waiting for an LGTM from Richard, though this patch currently doesn't pass all tests. One of the

[PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren created this revision. manmanren added a reviewer: benlangmuir. manmanren added a subscriber: cfe-commits. We add -fmodules-use-prebuilt-modules to support using prebuilt modules. In this mode, there is no need to load any module map and the programmer can simply use "@import" syntax

Re: [PATCH] D21453: Add support for attribute "overallocated"

ahatanak added a comment. ping https://reviews.llvm.org/D21453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14274: Add alloc_size attribute to clang

ahatanak added a subscriber: ahatanak. ahatanak added a comment. I'm wondering what the status of this patch is since someone has asked us to add support for this attribute in clang. Are you still waiting for review? Comment at: test/CodeGenCXX/alloc-size.cpp:66 @@ +65,3 @@ +

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

NoQ added a comment. Hmm. I suggest: 1. Change this test's constructor so that it was no longer almost-trivial. Because it isn't significant for this test if the constructor is almost-trivial or not. The test would pass. 2. Add a FIXME-test for this checker, in which a completely undefined

Re: [PATCH] D23060: [analyzer] Show enabled checker list

xazax.hun added a comment. In https://reviews.llvm.org/D23060#504832, @NoQ wrote: > Like! > > Do you think that if we rename the ~~bike shed~~ option to > `-analyzer-list-enabled-checkers` it'd be more natural and easy to remember? > (i barely remember how to spell `-analyzer-checker-help`,

Re: [PATCH] D23105: [clang/test] Fix a flaky unittest on windows

rnk added a comment. Thanks! lgtm Repository: rL LLVM https://reviews.llvm.org/D23105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

omtcyfz marked 2 inline comments as done. Comment at: test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:3 @@ +2,3 @@ +// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s + alexfh wrote:

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

omtcyfz updated this revision to Diff 66670. omtcyfz added a comment. Merged multiple identical tests into a single test with multiple `clang-rename` invocations. https://reviews.llvm.org/D23058 Files: clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp

Re: [PATCH] D23060: [analyzer] Show enabled checker list

NoQ added a comment. Like! Do you think that if we rename the ~~bike shed~~ option to `-analyzer-list-enabled-checkers` it'd be more natural and easy to remember? (i barely remember how to spell `-analyzer-checker-help`, it'd be much easier if it was called `-analyzer-list-checkers`).

r277603 - Fix bug in conflict check for Replacements::add().

Author: klimek Date: Wed Aug 3 10:12:00 2016 New Revision: 277603 URL: http://llvm.org/viewvc/llvm-project?rev=277603=rev Log: Fix bug in conflict check for Replacements::add(). We would not detect conflicts when inserting insertions at the same offset as previously contained replacements.

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. My comments were clarified in a Skype chat. https://reviews.llvm.org/D22982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

baloghadamsoftware added a comment. I agree with you. Do I have to modify the checker (in a separate patch), or someone else can do it? I do not know how difficult it is to unpack the store of a LazyCompoundVal (it probably has to be done recursively). https://reviews.llvm.org/D22374

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

NoQ accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Analysis/CloneDetection.cpp:99 @@ +98,3 @@ + /// Every item in this list is unique. + std::vector Variables; + NoQ wrote: > I've a feeling this is essentially a `map`,

Re: [PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

klimek added inline comments. Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:169 @@ +168,3 @@ + // starts after R is (I+1). + if (I != Replaces.end() && *I == R) +++I; ioeric wrote: > I think we should ignore replacement text when checking equality

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

yaxunl added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:43 @@ +42,3 @@ + + return llvm::StructType::create(EleTypes, "ndrange_t"); +} yaxunl wrote: > struct name should be "struct.ndrange_t" to allow library code to access it. Sorry, should be

Re: [PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

ioeric added inline comments. Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:169 @@ +168,3 @@ + // starts after R is (I+1). + if (I != Replaces.end() && *I == R) +++I; I think we should ignore replacement text when checking equality between `*I`

Re: [PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL277597: Fix quadratic runtime when adding items to tooling::Replacements. (authored by klimek). Changed prior to commit: https://reviews.llvm.org/D23119?vs=1=3#toc Repository: rL LLVM

Re: [PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

NoQ added a comment. Nice catch! Now, this needs a test. How about this one: // enable the debug.ExprInspection checker? void clang_analyzer_eval(int); void test_asume_after_access(unsigned long x) { char buf[100]; buf[x] = 1; clang_analyzer_eval(x <= 99); //

r277597 - Fix quadratic runtime when adding items to tooling::Replacements.

Author: klimek Date: Wed Aug 3 09:12:17 2016 New Revision: 277597 URL: http://llvm.org/viewvc/llvm-project?rev=277597=rev Log: Fix quadratic runtime when adding items to tooling::Replacements. Previously, we would search through all replacements when inserting a new one to check for overlaps.

Re: [PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

akuegel added a subscriber: akuegel. akuegel added a comment. lg Comment at: lib/Tooling/Core/Replacement.cpp:163 @@ +162,3 @@ + // Find the first entry that starts after the end of R. + // We cannot use upper_bound for that, as there might an element equal to + // AtEnd in

Re: [PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

klimek updated this revision to Diff 1. klimek added a comment. Fix bugs around marker replacements that neither insert nor delete anything. https://reviews.llvm.org/D23119 Files: lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index:

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

aaron.ballman requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:25 @@ +24,3 @@ + +static QualType getStrippedType(QualType T) { + while (const auto *PtrType = T->getAs()) I'd

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

kparzysz added a comment. Ping? Repository: rL LLVM https://reviews.llvm.org/D22766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23120: [OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D23120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23120: [OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.

bader created this revision. bader added reviewers: Anastasia, yaxunl. bader added a subscriber: cfe-commits. In order to re-define OpenCL built-in functions 'to_{private,local,global}' in OpenCL run-time library LLVM names must be different from the clang built-in function names.

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

alexfh added inline comments. Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2 @@ -1,3 +1,3 @@ // RUN: cat %s > %t.cpp -// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i -- +// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i -- //

Re: [PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

klimek updated this revision to Diff 66651. klimek added a comment. Remove re-implementation of overlaps check. https://reviews.llvm.org/D23119 Files: lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index: unittests/Tooling/RefactoringTest.cpp

[PATCH] D23119: Fix quadratic runtime when adding items to tooling::Replacements.

klimek created this revision. klimek added reviewers: djasper, bkramer, ioeric. klimek added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D23119 Files: lib/Tooling/Core/Replacement.cpp unittests/Tooling/RefactoringTest.cpp Index:

Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

hiraditya added a comment. In https://reviews.llvm.org/D22834#504425, @EricWF wrote: > LGTM. > > However I would like to see a small benchmark that demonstrates the > performance change. Please try and write the benchmark using Google Benchmark. > Some helpful links: > >

Re: [PATCH] D22782: Added 'inline' attribute to __init to inline the basic_string's constructor

hiraditya added a comment. In https://reviews.llvm.org/D22782#504416, @EricWF wrote: > The change itself LGTM, although we probably want to inline the forward/input > iterator __init's as well. > > However I would like to see a small benchmark that demonstrates the > performance change. Please

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

omtcyfz updated this revision to Diff 66642. omtcyfz added a comment. Removed `dump()` call used for debugging purposes. Removed unneeded header inclusion in `USRFindingAction.cpp`. https://reviews.llvm.org/D23058 Files: clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp

Re: [PATCH] D23071: [OpenCL] Remove extra native_ functions from opencl-c.h

Anastasia added a comment. LGTM! Repository: rL LLVM https://reviews.llvm.org/D23071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23112: [analyzer] Correctly add assumptions based on array bounds.

xazax.hun created this revision. xazax.hun added reviewers: zaks.anna, dcoughlin, NoQ. xazax.hun added a subscriber: cfe-commits. Right now due to a missing brace error the assumptions that an index is inbound in case we are under constrained is not added. https://reviews.llvm.org/D23112

Re: [PATCH] D23058: [clang-rename] add support for template instantiations

omtcyfz updated this revision to Diff 66634. https://reviews.llvm.org/D23058 Files: clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp test/clang-rename/ComplexFunctionOverride.cpp test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp

Re: [PATCH] D23014: [analyzer] Model base to derived casts more precisely.

xazax.hun updated this revision to Diff 66632. xazax.hun marked 4 inline comments as done. xazax.hun added a comment. - Improvements according to review comments. https://reviews.llvm.org/D23014 Files: include/clang/StaticAnalyzer/Core/PathSensitive/Store.h

Re: [PATCH] D23058: [clang-rename] add support for template instantiations

omtcyfz added inline comments. Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2 @@ -1,3 +1,3 @@ // RUN: cat %s > %t.cpp -// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i -- +// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i -- //

Re: [PATCH] D23058: [clang-rename] add support for template instantiations

omtcyfz added inline comments. Comment at: test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:2 @@ +1,3 @@ +// RUN: cat %s > %t.cpp +// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

bader added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:12 @@ -11,3 +11,3 @@ unsigned flags = 0; - // CHECK: %ndrange = alloca %opencl.ndrange_t* + // CHECK: %ndrange = alloca %ndrange_t ndrange_t ndrange; Could you also

[clang-tools-extra] r277578 - [extra-tools] Fix extra tools build bot warnings due to incorrect doc

Author: etienneb Date: Wed Aug 3 01:59:46 2016 New Revision: 277578 URL: http://llvm.org/viewvc/llvm-project?rev=277578=rev Log: [extra-tools] Fix extra tools build bot warnings due to incorrect doc

[clang-tools-extra] r277577 - [clang-tidy] address concerns with rL277340

Author: omtcyfz Date: Wed Aug 3 01:54:24 2016 New Revision: 277577 URL: http://llvm.org/viewvc/llvm-project?rev=277577=rev Log: [clang-tidy] address concerns with rL277340 alexfh raised a concern with https://reviews.llvm.org/rL277340 After retabbing indentation of .. code-block:: was

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

Alexander_Droste added a comment. Thanks for re-committing this patch! Repository: rL LLVM https://reviews.llvm.org/D21962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23105: [clang/test] Fix a flaky unittest on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL277576: [clang/test] Fix a flaky unittest on windows (authored by etienneb). Changed prior to commit: https://reviews.llvm.org/D23105?vs=66615=66616#toc Repository: rL LLVM

r277576 - [clang/test] Fix a flaky unittest on windows

Author: etienneb Date: Wed Aug 3 01:10:15 2016 New Revision: 277576 URL: http://llvm.org/viewvc/llvm-project?rev=277576=rev Log: [clang/test] Fix a flaky unittest on windows Summary: The append operator on a shell command for quick command-line is causing trouble on windows. [NFC] The easiest

[PATCH] D23105: [clang/test] Fix a flaky unittest on windows

etienneb created this revision. etienneb added a reviewer: rnk. etienneb added subscribers: chrisha, cfe-commits. The append operator on a shell command for quick command-line is causing trouble on windows. [NFC] The easiest way to fix them is to avoid using them. This patch is an attempt to fix