Author: arsenm
Date: Fri Aug 19 23:17:17 2016
New Revision: 279359
URL: http://llvm.org/viewvc/llvm-project?rev=279359=rev
Log:
amdgpu: Fix default case value for get_local_size
Modified:
libclc/trunk/amdgcn/lib/workitem/get_local_size.ll
libclc/trunk/r600/lib/workitem/get_local_size.ll
Prazek added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:35
@@ +34,3 @@
+ auto CanCallCtor = unless(has(ignoringImpCasts(cxxConstructExpr(
+ hasDeclaration(decl(anyOf(isPrivate(), isProtected(;
+
alexfh wrote:
> Prazek
Author: mren
Date: Fri Aug 19 22:00:54 2016
New Revision: 279358
URL: http://llvm.org/viewvc/llvm-project?rev=279358=rev
Log:
Revert r279351 and r279357 due to bot failures
Modified:
cfe/trunk/include/clang/AST/Type.h
cfe/trunk/lib/AST/Type.cpp
Modified:
Author: mren
Date: Fri Aug 19 21:28:15 2016
New Revision: 279357
URL: http://llvm.org/viewvc/llvm-project?rev=279357=rev
Log:
Fix windows bot
Modified:
cfe/trunk/include/clang/AST/Type.h
Modified: cfe/trunk/include/clang/AST/Type.h
URL:
On Fri, Aug 19, 2016 at 4:33 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 19, 2016 at 03:30:42PM -0700, Richard Smith wrote:
> > It typically does; the default stack ulimit is likely tuned for "normal"
> > applications that are not expected (by an ISO
nlewycky updated this revision to Diff 68755.
nlewycky added a comment.
Forgot clang changes!
https://reviews.llvm.org/D23734
Files:
lib/Transforms/Instrumentation/GCOVProfiling.cpp
test/Transforms/GCOVProfiling/three-element-mdnode.ll
tools/clang/include/clang/Driver/CC1Options.td
I feel like this thread has two very unrelated concerns and it might be
useful to separate them.
1) Should an application be changing the stack limit, or should the system
be able to enforce this?
Fortunately, there are two limits. One an application is allowed to change,
one it isn't. It seems
Windows build is broken
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/27686/steps/run%20tests/logs/stdio
On Fri, Aug 19, 2016 at 5:12 PM Manman Ren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mren
> Date: Fri Aug 19 19:04:21 2016
> New Revision: 279351
>
> URL:
Oops, thanks! :)
On Fri, Aug 19, 2016 at 4:15 PM, Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vedantk
> Date: Fri Aug 19 18:15:35 2016
> New Revision: 279348
>
> URL: http://llvm.org/viewvc/llvm-project?rev=279348=rev
> Log:
> [Driver] Remove unused #include of
manmanren added a comment.
Thanks for reviewing!
Manman
Comment at: include/clang/AST/RecursiveASTVisitor.h:1037
@@ -1036,1 +1036,3 @@
+DEF_TRAVERSE_TYPE(ObjCTypeParamType, {})
+
doug.gregor wrote:
> I'm sorta shocked that we don't visit the protocol
manmanren added a comment.
I will update this patch once the 2nd patch is done.
Thanks for reviewing,
Manman
Comment at: lib/AST/Type.cpp:1095
@@ +1094,3 @@
+return ctx.getQualifiedType(argType, splitType.Quals);
+ // Apply protocol lists if exists. Should
Author: mren
Date: Fri Aug 19 19:04:21 2016
New Revision: 279351
URL: http://llvm.org/viewvc/llvm-project?rev=279351=rev
Log:
[NFC] Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.
This is in preparation of adding a new type class ObjCTypeParamType that
can take protocol
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279351: [NFC] Add a class ObjCProtocolQualifiers to wrap
APIs for ObjC protocol list. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23078?vs=66526=68750#toc
Repository:
rL
Author: arsenm
Date: Fri Aug 19 19:01:21 2016
New Revision: 279350
URL: http://llvm.org/viewvc/llvm-project?rev=279350=rev
Log:
amdgcn: Fix get_local_size IR return type
Added:
libclc/trunk/amdgcn/lib/workitem/get_local_size.ll
libclc/trunk/r600/lib/workitem/get_local_size.ll
-
smeenai added a comment.
In https://reviews.llvm.org/D23719#521250, @rsmith wrote:
> Is there a -nodefaultlib analogue of -nostdinc++ to turn off just the C++
> standard library portion of the link?
There's `-nostdlib`, but if I'm parsing the GCC documentation
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: mzolotukhin, MatzeB.
This should finish the GraphTraits migration.
https://reviews.llvm.org/D23730
Files:
vsk updated this revision to Diff 68747.
vsk added a comment.
- Specify a target per Tim's comments. This now passes 'check-clang' on Ubuntu
Xenial.
https://reviews.llvm.org/D23643
Files:
lib/Driver/Tools.cpp
test/Driver/arm-cortex-cpus.c
Index: test/Driver/arm-cortex-cpus.c
alexshap added a reviewer: Eugene.Zelenko.
alexshap removed rL LLVM as the repository for this revision.
alexshap updated this revision to Diff 68746.
alexshap added a comment.
1. clang-tidy -checks=google-explicit-constructor
tools/clang/lib/AST/CommentSema.cpp - no other issues found
2.
doug.gregor requested changes to this revision.
doug.gregor added a comment.
This revision now requires changes to proceed.
I think most of the complexity here will fold away when ObjCTypeParamType
becomes sugar for the underlying ObjCObjectPointerType.
Comment at:
On Fri, Aug 19, 2016 at 03:30:42PM -0700, Richard Smith wrote:
> It typically does; the default stack ulimit is likely tuned for "normal"
> applications that are not expected (by an ISO standard) to cope with
> recursing a thousand levels deep. If the system administrator really wants
> to control
Author: vedantk
Date: Fri Aug 19 18:15:35 2016
New Revision: 279348
URL: http://llvm.org/viewvc/llvm-project?rev=279348=rev
Log:
[Driver] Remove unused #include of llvm/Support/config.h
This is a follow-up to r279112 (which removed the need for the header)
and in the same spirit as r279035
Eugene.Zelenko added a comment.
I meant to format only constructor, not entire file.
Repository:
rL LLVM
https://reviews.llvm.org/D23653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexshap added a comment.
i can do that, although there will be a lot of changes (mostly because of
clang-format). Another concern is that the style of the other files located
inside the same folder also might be not clang-format compliant. Do you want me
to do that ? (i mean to run clang-tidy
Author: arsenm
Date: Fri Aug 19 17:49:39 2016
New Revision: 279343
URL: http://llvm.org/viewvc/llvm-project?rev=279343=rev
Log:
amdgcn: Correct return types to be size_t
Modified:
libclc/trunk/amdgcn/lib/workitem/get_global_offset.cl
libclc/trunk/amdgcn/lib/workitem/get_group_id.cl
doug.gregor requested changes to this revision.
doug.gregor added a comment.
This revision now requires changes to proceed.
A couple of comments above, but this is looking very good.
Comment at: include/clang/AST/RecursiveASTVisitor.h:1037
@@ -1036,1 +1036,3 @@
rsmith added a comment.
In https://reviews.llvm.org/D23719#521233, @smeenai wrote:
> I'm thinking the best way to accomplish this is to globally add
> `-nodefaultlib` to `CMAKE_REQUIRED_FLAGS`, and then globally set
> `CMAKE_REQUIRED_LIBRARIES` to the required set of libraries, similar to what
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
This refactor LGTM.
https://reviews.llvm.org/D23078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
On Fri, Aug 19, 2016 at 1:43 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 19, 2016 at 01:16:59PM -0700, Richard Smith wrote:
> > On Fri, Aug 19, 2016 at 1:10 PM, Joerg Sonnenberger via cfe-commits <
> > cfe-commits@lists.llvm.org> wrote:
> >
> > > On
smeenai planned changes to this revision.
smeenai added a comment.
@rsmith: I think your points are valid, and I should have been more explicit
with the motivation :)
The issue is with linking, not with compiling. When we call
`check_cxx_source_compiles`, the compiler driver passes all the
alexshap removed rL LLVM as the repository for this revision.
alexshap updated this revision to Diff 68738.
alexshap added a comment.
1. Handle C++ ctors.
2. Add tests.
3. I have a diff for proper moving the attached comments
based on http://llvm.org/devmtg/2012-11/Gribenko_CommentParsing.pdf .
Eugene.Zelenko created this revision.
Eugene.Zelenko added a reviewer: alexfh.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Herald added a subscriber: nemanjai.
Repository:
rL LLVM
https://reviews.llvm.org/D23728
Files:
Author: dcoughlin
Date: Fri Aug 19 17:04:45 2016
New Revision: 279330
URL: http://llvm.org/viewvc/llvm-project?rev=279330=rev
Log:
[www] Add nullability questions to analyzer FAQ.
Modified:
cfe/trunk/www/analyzer/faq.html
Modified: cfe/trunk/www/analyzer/faq.html
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279329: [CallGraph] Use decltype instead of
pointer_to_unary_function. NFC. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D23726?vs=68733=68736#toc
Repository:
rL LLVM
Author: timshen
Date: Fri Aug 19 16:52:42 2016
New Revision: 279329
URL: http://llvm.org/viewvc/llvm-project?rev=279329=rev
Log:
[CallGraph] Use decltype instead of pointer_to_unary_function. NFC.
Reviewers: dblaikie
Subscribers: cfe-commits
Differential Revision:
timshen created this revision.
timshen added a reviewer: dblaikie.
timshen added a subscriber: cfe-commits.
https://reviews.llvm.org/D23726
Files:
include/clang/Analysis/CallGraph.h
Index: include/clang/Analysis/CallGraph.h
===
timshen closed this revision.
timshen added a comment.
Landed as r279326.
https://reviews.llvm.org/D23705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: timshen
Date: Fri Aug 19 16:20:13 2016
New Revision: 279326
URL: http://llvm.org/viewvc/llvm-project?rev=279326=rev
Log:
[GraphTraits] Make nodes_iterator dereference to NodeType*/NodeRef
Currently nodes_iterator may dereference to a NodeType* or a NodeType&. Make
them all dereference
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
I think will be good idea to run Clang-format over constructor code and
Clang-tidy google-explicit-constructor over entire file.
Repository:
rL LLVM
https://reviews.llvm.org/D23653
alexshap added a comment.
ping
https://reviews.llvm.org/D23653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Aug 19, 2016 at 01:16:59PM -0700, Richard Smith wrote:
> On Fri, Aug 19, 2016 at 1:10 PM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > On Fri, Aug 19, 2016 at 01:03:51PM -0700, Richard Smith wrote:
> > > On Fri, Aug 19, 2016 at 12:58 PM, Joerg
t.p.northover added inline comments.
Comment at: test/Driver/arm-cortex-cpus.c:306
@@ -305,2 +305,3 @@
// RUN: %clang -target arm -mcpu=bogus -### -c %s 2>&1 | FileCheck
-check-prefix=CHECK-BOGUS-CPU %s
+// RUN: %clang -arch arm64 -mcpu=bogus -### -c %s 2>&1 | FileCheck
rsmith added a comment.
I have to admit to not understanding the motivation for this change. It claims
that this is removing a reliance on having an existing C++ standard library,
but it doesn't appear to affect that: this test explicitly passes `-nostdinc++`
to avoid using a system standard
On Fri, Aug 19, 2016 at 1:10 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 19, 2016 at 01:03:51PM -0700, Richard Smith wrote:
> > On Fri, Aug 19, 2016 at 12:58 PM, Joerg Sonnenberger via cfe-commits <
> > cfe-commits@lists.llvm.org> wrote:
> >
> > > On
On Fri, Aug 19, 2016 at 01:03:51PM -0700, Richard Smith wrote:
> On Fri, Aug 19, 2016 at 12:58 PM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > On Thu, Aug 18, 2016 at 11:33:49AM -0700, Richard Smith wrote:
> > > On Wed, Aug 17, 2016 at 6:35 AM, Joerg
On Fri, Aug 19, 2016 at 12:58 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Aug 18, 2016 at 11:33:49AM -0700, Richard Smith wrote:
> > On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberger via cfe-commits <
> > cfe-commits@lists.llvm.org> wrote:
> >
> > > On
On Thu, Aug 18, 2016 at 11:33:49AM -0700, Richard Smith wrote:
> On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits
> > wrote:
> > > Author: rsmith
> > > Date: Tue
v.g.vassilev updated this revision to Diff 68723.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Sink some of the diagnostics in the DiagnoseUninstantiableTemplate.
https://reviews.llvm.org/D23492
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaTemplate.cpp
vmiklos added a comment.
It is expected that either SymbolOffsets or OldNames is empty, and the size of
the non-empty container is the same as the size of the NewNames container. So
no, the code does not rely on the offsets and the old names having the same
length.
bcraig added a comment.
In https://reviews.llvm.org/D23719#520969, @rsmith wrote:
> In https://reviews.llvm.org/D23719#520954, @bcraig wrote:
>
> > In https://reviews.llvm.org/D23719#520952, @rsmith wrote:
> >
> > > Are we really guaranteed that the C and C++ compiler behave the same way
> > >
timshen added inline comments.
Comment at: include/clang/Analysis/CallGraph.h:219
@@ -217,5 +218,3 @@
}
- static clang::CallGraphNode (PairTy P) {
-return *(P.second);
- }
+ static clang::CallGraphNode *CGdereference(PairTy P) { return P.second; }
rsmith added a comment.
In https://reviews.llvm.org/D23719#520954, @bcraig wrote:
> In https://reviews.llvm.org/D23719#520952, @rsmith wrote:
>
> > Are we really guaranteed that the C and C++ compiler behave the same way
> > here? I don't see why that would necessarily be the case.
>
>
> For
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/USRFindingAction.cpp:145
@@ +144,3 @@
+ explicit NamedDeclFindingConsumer(
+ ArrayRef SymbolOffsets,
+ ArrayRef OldNames,
What about the
bcraig added a comment.
In https://reviews.llvm.org/D23719#520953, @smeenai wrote:
> @bcraig: `__STDC_NO_ATOMICS__` wouldn't be defined for pre-C11 compilers
> either, right?
>
> From what I understand of the original code sample, one of the purposes was
> to check for 64-bit atomic support on
bcraig added a comment.
In https://reviews.llvm.org/D23719#520952, @rsmith wrote:
> Are we really guaranteed that the C and C++ compiler behave the same way
> here? I don't see why that would necessarily be the case.
For libc++, std::atomic is implemented in terms of _Atomic. So as long as
smeenai added a comment.
@bcraig: `__STDC_NO_ATOMICS__` wouldn't be defined for pre-C11 compilers
either, right?
From what I understand of the original code sample, one of the purposes was to
check for 64-bit atomic support on 32-bit systems (hence the use of `uintmax_t`
and the check for
rsmith added a subscriber: rsmith.
rsmith added a comment.
Are we really guaranteed that the C and C++ compiler behave the same way here?
I don't see why that would necessarily be the case.
https://reviews.llvm.org/D23719
___
cfe-commits mailing
amccarth created this revision.
amccarth added a subscriber: cfe-commits.
Clang tracks only start columns, not start-end ranges. CodeView allows for
that, but the VS debugger doesn't handle anything less than a complete range
well--it either highlights the wrong part of a statement or
bcraig added a subscriber: bcraig.
bcraig added a comment.
I like the rationale here, but can we avoid pulling in headers at all?
You could test _ _STDC_NO_ATOMICS_ _. You could also have some code like
this...
_Atomic int x;
int main() {
x += 1;
return x;
}
smeenai created this revision.
smeenai added reviewers: beanz, compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
The purpose of the check is to see if atomics are present and if they
require an explicit -latomic to link. We can achieve this equally well
by testing for C11
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Consider renaming and/or generalizing the handlers.
Also, in a follow-up or preliminary commit, could you remove all the DerefFun
stuff. Move the definition of CGdereference (if they
Anastasia added a comment.
What would be the use case to override the supported extensions for the end
user?
The change to set the right extensions based on the target compiled for was to
avoid mis-compilations. But adding a user flag to control that could lead to
the old problem to reoccur.
Anastasia added a comment.
Just to summarize, it seems there are the following options to proceed, each
has some benefits and disadvantages:
1. We can check the canonical type. This gives us possibility to accept the
type name aliases, but reduces flexibility to implement this type in a custom
erichkeane added a comment.
In https://reviews.llvm.org/D23692#520097, @erichkeane wrote:
> In https://reviews.llvm.org/D23692#520081, @rsmith wrote:
>
> > This is not a conforming extension. We are explicitly not allowed to make
> > standard library functions `constexpr` if the standard
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279250: clang-format: [JS] handle object literals with
casts. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D23714?vs=68686=68688#toc
Repository:
rL LLVM
Author: mprobst
Date: Fri Aug 19 09:35:01 2016
New Revision: 279250
URL: http://llvm.org/viewvc/llvm-project?rev=279250=rev
Log:
clang-format: [JS] handle object literals with casts.
Summary: E.g. `{a: 1} as b`.
Reviewers: djasper
Subscribers: cfe-commits, klimek
Differential Revision:
mprobst marked 9 inline comments as done.
mprobst added a comment.
https://reviews.llvm.org/D22431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst updated this revision to Diff 68687.
mprobst added a comment.
- Use a stack to parse nested template strings.
- move docs
- Fold GreaterStashed, LessStashed into TOKEN_STASHED lexer state.
https://reviews.llvm.org/D22431
Files:
lib/Format/FormatTokenLexer.cpp
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
E.g. `{a: 1} as b`.
https://reviews.llvm.org/D23714
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index:
teemperor updated this revision to Diff 68684.
teemperor added a comment.
- Fixed typo.
https://reviews.llvm.org/D23316
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
test/Analysis/copypaste/macro-complexity.cpp
test/Analysis/copypaste/macros.cpp
Index:
teemperor updated this revision to Diff 68683.
teemperor marked an inline comment as done.
https://reviews.llvm.org/D23555
Files:
lib/Analysis/CloneDetection.cpp
test/Analysis/copypaste/call.cpp
Index: test/Analysis/copypaste/call.cpp
teemperor marked 3 inline comments as done.
Comment at: lib/Analysis/CloneDetection.cpp:164
@@ +163,3 @@
+for (unsigned i = 0; i < Args->size(); ++i) {
+ Args->get(i).print(Context.getLangOpts(), OS);
+}
NoQ wrote:
> We don't discriminate
teemperor retitled this revision from "[analyzer] Added a pass architecture to
the CloneDetector" to "[analyzer] Added a reusable constraint system to the
CloneDetector".
teemperor updated the summary for this revision.
teemperor updated this revision to Diff 68680.
teemperor added a comment.
-
Author: asbokhan
Date: Fri Aug 19 08:36:31 2016
New Revision: 279240
URL: http://llvm.org/viewvc/llvm-project?rev=279240=rev
Log:
Fixed a typo (compilation_commands.json --> compile_commands.json).
Modified:
cfe/trunk/docs/HowToSetupToolingForLLVM.rst
Modified:
Hi,
What I meant by upgrade was simply making it build in VS 2015. However, you
bring up a valid point about making sure the extension will continue to
work in VS 2012. I will look into that. Like those references that go from
10 to 14 that point out; I wonder if instead I should be able to bring
Author: vpykhtin
Date: Fri Aug 19 07:54:31 2016
New Revision: 279235
URL: http://llvm.org/viewvc/llvm-project?rev=279235=rev
Log:
[AMDGPU] add s_incperflevel/s_decperflevel builtins
Differential revision: https://reviews.llvm.org/D23668
Modified:
asavonic updated this revision to Diff 68677.
asavonic added a comment.
- Remove unused test case
https://reviews.llvm.org/D23712
Files:
include/clang/Basic/OpenCLOptions.h
include/clang/Basic/TargetInfo.h
include/clang/Basic/TargetOptions.h
include/clang/Driver/Options.td
djasper added a comment.
I think instead of doing some complex computation with LineLevel and
NestingLevel, it might be better to just leave them as the pair and compare
them as a pair. The LineLevel should probably always trump the NestingLevel.
So, I'd try to just defined ScopeLevel as a
bmharper removed rL LLVM as the repository for this revision.
bmharper updated this revision to Diff 68675.
bmharper added a comment.
Fixed the two issues pointed out by djasper in his most recent comments:
1. Only calculate ScopeLevel when necessary.
2. Instead of calculating ScopeLevel by
asavonic created this revision.
asavonic added a reviewer: Anastasia.
asavonic added a subscriber: cfe-commits.
This patch adds a command line option '-cl-ext' to control a set of
supported OpenCL extensions. Option accepts a comma-separated list
of extensions prefixed with '+' or '-'.
It can be
rmaprath added a comment.
@compnerd: I plan to look at https://reviews.llvm.org/D18482 soon (going to
need it when this lands). Got moved to a new machine, still setting up the
environment :)
@mclow.lists: Ping?
https://reviews.llvm.org/D21968
rmaprath added inline comments.
Comment at: CMakeLists.txt:139
@@ -138,1 +138,3 @@
option(LIBCXX_HAS_PTHREAD_API "Ignore auto-detection and force use of pthread
API" OFF)
+option(LIBCXX_HAS_EXTERNAL_THREAD_API
+ "Build libc++ with an externalized threading API.
omtcyfz marked an inline comment as done.
Comment at: clang-rename/USRFindingAction.cpp:190
@@ -175,6 +189,3 @@
+ USRList.push_back(Finder.Find());
}
}
Yep. Makes sense. Thanks!
Comment at: clang-rename/USRFindingAction.cpp:201-202
omtcyfz updated this revision to Diff 68668.
https://reviews.llvm.org/D23651
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
Index: clang-rename/tool/ClangRename.cpp
omtcyfz updated this revision to Diff 68667.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D23651
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
Index: clang-rename/tool/ClangRename.cpp
alexshap added inline comments.
Comment at: clang-rename/USRFindingAction.cpp:190
@@ -175,1 +189,3 @@
+ std::vector NextUSRBunch = Finder.Find();
+ USRList.push_back(NextUSRBunch);
}
USRList.push_back(std::move(NextUSRBunch))
or (IMO even
alexshap added inline comments.
Comment at: clang-rename/USRFindingAction.cpp:205
@@ -196,2 +204,3 @@
+ USRList));
return std::move(Consumer);
}
not particularly important, probably it can be simply
return
Anastasia added a comment.
@hans, I have committed one minor addition to OpenCL notes (r279224), which is
important enough to include
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.rst (revision 279176)
+++
omtcyfz updated this revision to Diff 68665.
omtcyfz added a comment.
Address one more comment.
https://reviews.llvm.org/D23651
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
Index: clang-rename/tool/ClangRename.cpp
omtcyfz marked 2 inline comments as done.
Comment at: clang-rename/USRFindingAction.cpp:69
@@ -69,3 +68,3 @@
}
-USRs->insert(USRs->end(), USRSet.begin(), USRSet.end());
+return std::vector(USRSet.begin(), USRSet.end());
}
Ah, sure. Sorry, didn't
Author: omtcyfz
Date: Fri Aug 19 04:36:14 2016
New Revision: 279226
URL: http://llvm.org/viewvc/llvm-project?rev=279226=rev
Log:
minor header guards and help messages cleanup
Modified:
clang-tools-extra/trunk/clang-rename/RenamingAction.h
omtcyfz marked an inline comment as done.
Comment at: clang-rename/USRFindingAction.cpp:69
@@ -69,2 +68,3 @@
}
-USRs->insert(USRs->end(), USRSet.begin(), USRSet.end());
+USRs.insert(USRs.end(), USRSet.begin(), USRSet.end());
+return USRs;
alexfh
omtcyfz updated this revision to Diff 68656.
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Partly address comments.
https://reviews.llvm.org/D23651
Files:
clang-rename/USRFindingAction.cpp
clang-rename/USRFindingAction.h
clang-rename/tool/ClangRename.cpp
Index:
92 matches
Mail list logo
