Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

2016-08-21 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 68824. Prazek added a comment. - fixes https://reviews.llvm.org/D23343 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp docs/ReleaseNotes.rst test/clang-tidy/modernize-make-shared.cpp test/clang-tidy/modernize-make-unique.cpp Index:

Re: r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-21 Thread Vitaly Buka via cfe-commits
flake On Sat, Aug 20, 2016 at 11:30 AM Benjamin Kramer wrote: > It cycled back to green. flake? > > On Sat, Aug 20, 2016 at 7:27 PM, Vitaly Buka > wrote: > > msan is not happy about this change > > >

Re: [PATCH] D23761: clang-format: [JS] supports casts to types starting with punctuation ("{[(").

2016-08-21 Thread Yunzhong Gao via cfe-commits
ygao added a subscriber: ygao. Comment at: lib/Format/FormatTokenLexer.cpp:245 @@ -241,1 +244,3 @@ ++Offset; // Skip the escaped character. +if (Offset + 1 < Lex->getBuffer().end() && *Offset == '$' && +*(Offset + 1) == '{') { What happens if

[PATCH] D23761: clang-format: [JS] supports casts to types starting with punctuation ("{[(").

2016-08-21 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added subscribers: cfe-commits, klimek. https://reviews.llvm.org/D23761 Files: lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index:

Re: [PATCH] D19979: [analyzer] ScopeContext - initial implementation

2016-08-21 Thread Devin Coughlin via cfe-commits
dcoughlin added a comment. This has been requested by PR29069 https://llvm.org/bugs/show_bug.cgi?id=29069 https://reviews.llvm.org/D19979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23651: [clang-rename] improve performance for rename-all

2016-08-21 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked an inline comment as done. omtcyfz added a comment. In https://reviews.llvm.org/D23651#521031, @vmiklos wrote: > It is expected that either SymbolOffsets or OldNames is empty, and the size > of the non-empty container is the same as the size of the NewNames container. > So no,

Re: [PATCH] D15227: [analyzer] Valist checkers.

2016-08-21 Thread Artem Dergachev via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D15227#519239, @xazax.hun wrote: > I suspect that slightly different AST is generated for those architectures > that cause the different behavior. I will further investigate those problems. Seems so, because on my machine when i append `-triple

[PATCH] D23758: cmake: Support stand-alone Sphinx & doxygen doc build

2016-08-21 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added a reviewer: chapuni. mgorny added a subscriber: cfe-commits. Copy the necessary options and configuration checks from LLVM to clang, to support stand-alone documentation builds. https://reviews.llvm.org/D23758 Files: CMakeLists.txt Index:

Re: [PATCH] D23753: [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix

2016-08-21 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279392: [X86][AVX512F] minor fix of the parameter names (authored by abadouh). Changed prior to commit: https://reviews.llvm.org/D23753?vs=68801=68805#toc Repository: rL LLVM

r279392 - [X86][AVX512F] minor fix of the parameter names

2016-08-21 Thread Asaf Badouh via cfe-commits
Author: abadouh Date: Sun Aug 21 02:56:47 2016 New Revision: 279392 URL: http://llvm.org/viewvc/llvm-project?rev=279392=rev Log: [X86][AVX512F] minor fix of the parameter names add "__" prefix Bug 28842 https://llvm.org/bugs/show_bug.cgi?id=29040 Differential Revision:

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

2016-08-21 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added a reviewer: rafael. mgorny added a subscriber: cfe-commits. Add CLANG_GOLD_LIBDIR_SUFFIX that defaults to ${LLVM_LIBDIR_SUFFIX} and can be overriden if LLVMgold.so is installed elsewhere. The use case are multilib systems where binutils is 64-bit and

[PATCH] D23753: [AVX512] Arguments to _mm512_[mask_]abs_ps|d must have "__" prefix

2016-08-21 Thread Asaf Badouh via cfe-commits
AsafBadouh created this revision. AsafBadouh added a reviewer: igorb. AsafBadouh added a subscriber: cfe-commits. AsafBadouh set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D23753 Files: ../tunkClang/tools/clang/lib/Headers/avx512fintrin.h

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

2016-08-21 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: chandlerc, chapuni, samsonov. mgorny added a subscriber: cfe-commits. Make it possible to override the value of CLANG_LIBDIR_SUFFIX, and use it uniformly to control install location of runtimes (i.e. lib/clang), therefore supporting sharing