Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

2016-08-27 Thread Andrew Wells via cfe-commits
andrewmw94 added a comment. One more thing, obviously it should mimic malloc/free's behavior in complaining about delete/new being used. Should it also complain about free/malloc being used? I can't imagine that would be something people would usually intend to do, but I don't think it's rea

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-08-27 Thread Hal Finkel via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D18639#515000, @hfinkel wrote: > Updated to use scheme suggested by Marshall. Ping. https://reviews.llvm.org/D18639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D23961: Avoid embedded preprocessor directives in __tree

2016-08-27 Thread Vitaly Buka via cfe-commits
vitalybuka added a subscriber: vitalybuka. vitalybuka added a comment. PPC bots are broken by this patch http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/3547 http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/2353 Repository: rL LLVM https://reviews.llvm.org/D2

Re: [PATCH] D23963: [analyzer] pr28449 - Move literal rvalue construction away from RegionStore.

2016-08-27 Thread Artem Dergachev via cfe-commits
NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:669 @@ +668,3 @@ + // For structures, check if the respective field is a reference. + // FIXME: What if fields mismatch? + const RecordDecl *RD = RT->getDecl(); Whoops, w

[PATCH] D23963: [analyzer] pr28449 - Move literal rvalue construction away from RegionStore.

2016-08-27 Thread Artem Dergachev via cfe-commits
NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin. NoQ added a subscriber: cfe-commits. When binding string literal regions to `char` arrays, `RegionStore`'s `bindArray()` method converts the string literals to their lazy compound values before binding. B

Re: [PATCH] D23961: Avoid embedded preprocessor directives in __tree

2016-08-27 Thread Dimitry Andric via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279926: Avoid embedded preprocessor directives in __tree (authored by dim). Changed prior to commit: https://reviews.llvm.org/D23961?vs=69492&id=69496#toc Repository: rL LLVM https://reviews.llvm.or

[libcxx] r279926 - Avoid embedded preprocessor directives in __tree

2016-08-27 Thread Dimitry Andric via cfe-commits
Author: dim Date: Sat Aug 27 14:32:03 2016 New Revision: 279926 URL: http://llvm.org/viewvc/llvm-project?rev=279926&view=rev Log: Avoid embedded preprocessor directives in __tree Similar to rL242623, move C++ version checks outside of _NOEXCEPT_() macro invocation argument lists, to avoid "embedd

Re: [PATCH] D23871: [Modules] Add 'freestanding' to the 'requires-declaration' feature-list.

2016-08-27 Thread Elad Cohen via cfe-commits
eladcohen added inline comments. Comment at: lib/Headers/module.modulemap:66 @@ -65,2 +65,3 @@ explicit module mm_malloc { + requires !freestanding header "mm_malloc.h" rsmith wrote: > Are there more parts of the intrinsics modules to which this s

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

2016-08-27 Thread Andrey Khalyavin via cfe-commits
halyavin added a comment. ping. https://reviews.llvm.org/D23831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23961: Avoid embedded preprocessor directives in __tree

2016-08-27 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks https://reviews.llvm.org/D23961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

2016-08-27 Thread Jason Juang via cfe-commits
jasjuang added a comment. Just in case someone is interested. I figured out a hack with VCMD that actually does the job. using EnvDTE; using EnvDTE80; public class E : VisualCommanderExt.IExtension { public void SetSite(EnvDTE80.DTE2 DTE_, Microsoft.VisualStudio.Shell.Package pac

[PATCH] D23961: Avoid embedded preprocessor directives in __tree

2016-08-27 Thread Dimitry Andric via cfe-commits
dim created this revision. dim added reviewers: mclow.lists, EricWF. dim added subscribers: emaste, cfe-commits. When I compile as part of clang, with -pedantic enabled, I get the following warnings: In file included from /usr/include/c++/v1/map:442: /usr/include/c++/v1/__tree:874:2: war

[PATCH] D23960: Avoid narrowing warnings in __bitset constructor

2016-08-27 Thread Dimitry Andric via cfe-commits
dim created this revision. dim added reviewers: mclow.lists, EricWF. dim added subscribers: emaste, cfe-commits. When I compile is compiled with warnings enabled, I get the following error (which is interesting in itself, it should only be a warning): /usr/include/c++/v1/bitset:265:16: error

[PATCH] D23959: cmake: Support building unittests against installed LLVM gtest

2016-08-27 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: chapuni, delcypher, vsk, Bigcheese. mgorny added a subscriber: cfe-commits. Support using gtest library & headers installed by LLVM to make it possible to build unittests without LLVM sources. Depends on LLVM patch https://reviews.llvm.org/D2

[PATCH] D23957: Replace the Radeon GCN GPU family names by more descriptive ones

2016-08-27 Thread Niels Ole Salscheider via cfe-commits
olesalscheider created this revision. olesalscheider added reviewers: cfe-commits, arsenm, tstellarAMD. https://reviews.llvm.org/D23957 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp === --- lib/Basic/Targets.cpp +++ li

Re: [PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

2016-08-27 Thread Niels Ole Salscheider via cfe-commits
olesalscheider updated this revision to Diff 69485. https://reviews.llvm.org/D23746 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp === --- lib/Basic/Targets.cpp +++ lib/Basic/Targets.cpp @@ -2110,21 +2110,23 @@ sta

Re: [PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

2016-08-27 Thread Niels Ole Salscheider via cfe-commits
olesalscheider added inline comments. Comment at: lib/Basic/Targets.cpp:1959 @@ -1959,1 +1958,3 @@ +GK_VOLCANIC_ISLANDS, +GK_ARCTIC_ISLANDS } GPU; arsenm wrote: > tstellarAMD wrote: > > We're trying to move to more descriptive GPU family names, so this

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

2016-08-27 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D23926#527080, @EricWF wrote: > We already provide many C++11 extensions in C++03 mode, why should this be an > exception? This is kind of what I wanted to find out. Do we document what those extensions are? We have quite a strict C libra