Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

mehdi_amini added a comment. @dblaikie mentioned before that it is not clear that this is something we want to do at all (initialize all local variables). Would it be something we should have policy on in the first place before integrating such a patch? (Reminds me of constructor that don't

Re: [libcxx] r279955 - Fix pair::operator=(TupleLike&&).

@Hans While working on the std::tuple bug I found this bug in std::pair. Since we are already doing another RC I would like to merge this fix. @Marshall Sound OK to you? /Eric On Sun, Aug 28, 2016 at 7:43 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf >

Re: [libcxx] r279953 - Fix pair::operator=(TupleLike&&).

Ignore this thread. This patch was re-committed as r279955. On Sun, Aug 28, 2016 at 7:19 PM, Eric Fiselier wrote: > @Hans While working on the std::tuple bug I found this bug in std::pair. > Since we are already doing another RC I would like to merge this fix. > > @Marshall Sound

[libcxx] r279955 - Fix pair::operator=(TupleLike&&).

Author: ericwf Date: Sun Aug 28 20:43:41 2016 New Revision: 279955 URL: http://llvm.org/viewvc/llvm-project?rev=279955=rev Log: Fix pair::operator=(TupleLike&&). This assignment operator was previously broken since the SFINAE always resulted in substitution failure. This caused assignments to

[libcxx] r279954 - Revert r279953 - Fix pair::operator=(TupleLike&&)

Author: ericwf Date: Sun Aug 28 20:39:54 2016 New Revision: 279954 URL: http://llvm.org/viewvc/llvm-project?rev=279954=rev Log: Revert r279953 - Fix pair::operator=(TupleLike&&) The test emits warnings causing the test-suite to fail. Since I want this patch merged into 3.9 I'll recommit it with

Re: [libcxx] r279953 - Fix pair::operator=(TupleLike&&).

@Hans While working on the std::tuple bug I found this bug in std::pair. Since we are already doing another RC I would like to merge this fix. @Marshall Sound OK to you? On Sun, Aug 28, 2016 at 7:09 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date:

[libcxx] r279953 - Fix pair::operator=(TupleLike&&).

Author: ericwf Date: Sun Aug 28 20:09:47 2016 New Revision: 279953 URL: http://llvm.org/viewvc/llvm-project?rev=279953=rev Log: Fix pair::operator=(TupleLike&&). This assignment operator was previously broken since the SFINAE always resulted in substitution failure. This caused assignments to

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

dberris accepted this revision. dberris added a comment. Concur 100% with @rengolin here -- please land after the LLVM changes land. :) https://reviews.llvm.org/D23932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r279948 - Implement C++17 std::sample.

Author: ericwf Date: Sun Aug 28 17:14:37 2016 New Revision: 279948 URL: http://llvm.org/viewvc/llvm-project?rev=279948=rev Log: Implement C++17 std::sample. This patch implements the std::sample function added to C++17 from LFTS. It also removes the std::experimental::sample implementation which

[libcxx] r279947 - Mark LWG 2716 as complete - shuffle and sample disallows lvalue URNGs.

Author: ericwf Date: Sun Aug 28 16:55:00 2016 New Revision: 279947 URL: http://llvm.org/viewvc/llvm-project?rev=279947=rev Log: Mark LWG 2716 as complete - shuffle and sample disallows lvalue URNGs. Libc++'s implementation of shuffle and sample already support lvalue and rvalue RNG's. This

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

compnerd closed this revision. compnerd added a comment. SVN r279946 https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279946 - AST: improve layout of SimpleTypoCorrector

Author: compnerd Date: Sun Aug 28 16:33:30 2016 New Revision: 279946 URL: http://llvm.org/viewvc/llvm-project?rev=279946=rev Log: AST: improve layout of SimpleTypoCorrector Add the "explicit" specifier to the single-argument constructor of SimpleTypoCorrector. Reorder the fields to remove

[libcxx] r279945 - Implement LWG 2711. Constrain path members.

Author: ericwf Date: Sun Aug 28 16:26:01 2016 New Revision: 279945 URL: http://llvm.org/viewvc/llvm-project?rev=279945=rev Log: Implement LWG 2711. Constrain path members. Modified: libcxx/trunk/include/experimental/filesystem

[clang-tools-extra] r279944 - Fix some typos in the doc

Author: sylvestre Date: Sun Aug 28 15:33:42 2016 New Revision: 279944 URL: http://llvm.org/viewvc/llvm-project?rev=279944=rev Log: Fix some typos in the doc Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst

r279942 - Fix a typo in the doc: overriden -> overridden

Author: sylvestre Date: Sun Aug 28 15:22:34 2016 New Revision: 279942 URL: http://llvm.org/viewvc/llvm-project?rev=279942=rev Log: Fix a typo in the doc: overriden -> overridden Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/docs/analyzer/IPA.txt Modified:

[libunwind] r279941 - EHABI: fail on WMMX vops without WMMX support

Author: compnerd Date: Sun Aug 28 15:10:33 2016 New Revision: 279941 URL: http://llvm.org/viewvc/llvm-project?rev=279941=rev Log: EHABI: fail on WMMX vops without WMMX support When the unwinder is built without WMMX support, if we encounter a WMMX register virtual operation, early rather than

Re: [PATCH] D17983: Eliminate many benign instances of "potentially uninitialized local variable" warnings

iamsergio added a subscriber: iamsergio. iamsergio added a comment. @ariccio, are you blocked on this or waiting for reviewers ? This seems to be blocking the patch that fixes plugins on MSVC, thanks https://reviews.llvm.org/D17983 ___ cfe-commits

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

dim added a subscriber: dim. dim added a comment. This works for me. I had two test cases from the FreeBSD source tree which resulted in warnings, e.g.: cddl/contrib/opensolaris/lib/libnvpair/libnvpair.c:388:15: error: passing an object that undergoes default argument promotion to

[libcxx] r279940 - [Docs] Update libc++ target names after r279675.

Author: ericwf Date: Sun Aug 28 13:33:08 2016 New Revision: 279940 URL: http://llvm.org/viewvc/llvm-project?rev=279940=rev Log: [Docs] Update libc++ target names after r279675. Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/docs/BuildingLibcxx.rst Modified:

[libcxxabi] r279938 - [CMake] Be more consistent about naming targets and components in libc++abi

Author: ericwf Date: Sun Aug 28 13:28:51 2016 New Revision: 279938 URL: http://llvm.org/viewvc/llvm-project?rev=279938=rev Log: [CMake] Be more consistent about naming targets and components in libc++abi This patch (and commit summary) mirror r279675 by Chris B which was applied to libc++ but

Re: [PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

compnerd closed this revision. compnerd added a comment. SVN r279935 https://reviews.llvm.org/D23878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r279935 - test: fix test under ASAN and MSAN

Author: compnerd Date: Sun Aug 28 13:16:00 2016 New Revision: 279935 URL: http://llvm.org/viewvc/llvm-project?rev=279935=rev Log: test: fix test under ASAN and MSAN When we're running tests under ASAN or MSAN, they're compiled with -O1, which enables tail call elimination. This causes

[PATCH] D23973: clang-format: [JS] handle default bindings in imports.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Default imports appear outside of named bindings in curly braces: import A from 'a'; import A, {symbol} from 'a'; https://reviews.llvm.org/D23973

Re: [PATCH] D23914: [OpenCL] Make is_valid_event overloadable.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:16732 @@ -16731,3 +16731,3 @@ clk_event_t create_user_event(void); can we also make this one __ovld? Thanks. https://reviews.llvm.org/D23914 ___

Re: [PATCH] D23915: [OpenCL] Remove access qualifiers on images in arg info metadata.

yaxunl added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:439 @@ -438,1 +438,3 @@ +static void removeImageAccessQualifier(std::string& tyName) { + std::string roQual("__read_only"); variable names should be capitalized

Re: [PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

jsmouret added a comment. A slightly improved version of @jasjuang code. Restores current selection, and really saves if modified. using EnvDTE; using EnvDTE80; public class E : VisualCommanderExt.IExtension { public void SetSite(EnvDTE80.DTE2 DTE_,

[PATCH] D23972: clang-format: [JS] Sort all JavaScript imports if any changed.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. User feedback is that they expect *all* imports to be sorted if any import was affected by a change, not just imports up to the first non-affected line, as

Re: [PATCH] D23653: Minor cleanup of SimpleTypoCorrector

gribozavr accepted this revision. gribozavr added a comment. LGTM, thanks! https://reviews.llvm.org/D23653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

gribozavr added a comment. Here's the new builder: http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs Fails with `ninja: error: unknown target 'docs-clang-tools-html'`. Repository: rL LLVM https://reviews.llvm.org/D23787 ___ cfe-commits

Re: [PATCH] D23961: Avoid embedded preprocessor directives in __tree

dim added a comment. In https://reviews.llvm.org/D23961#527284, @vitalybuka wrote: > PPC bots are broken by this patch > http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/3547 > http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/2353 I saw some mails about it,