[PATCH] D24075: [include-fixer] Add a `query-symbol` option to query symbol without parsing the source file.

2016-08-31 Thread Haojian Wu via cfe-commits
hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h include-fixer/tool/ClangIncludeFixer.cpp test/include-fixer/query_symbol.cpp Index: test/include-fixer/

Re: r280065 - Fix for commit 280064 that break the build.

2016-08-31 Thread Renato Golin via cfe-commits
On 31 August 2016 at 11:30, Sjoerd Meijer wrote: > Regression test test/CodeGen/noexceptionsfpmath.c makes sure > -fno-trapping-math ends up as a function attribute, and I relied on that. > Flag -fno-trapping-math is used a lot in test/Driver/fast-math.c, but you are > right that there is no te

r280220 - Attempt to pacify buildbots after r280217

2016-08-31 Thread James Molloy via cfe-commits
Author: jamesm Date: Wed Aug 31 06:01:41 2016 New Revision: 280220 URL: http://llvm.org/viewvc/llvm-project?rev=280220&view=rev Log: Attempt to pacify buildbots after r280217 These clang tests check diagnostics from the backend by giving it an unvectorizable loop. This loop is now vectorized :/

RE: r280065 - Fix for commit 280064 that break the build.

2016-08-31 Thread Sjoerd Meijer via cfe-commits
Hi, I uploaded the incorrect patch, it shouldn't have included the -fexceptions-fp-math because we decided to use trapping-math and therefore I removed these test lines in the quick fix. Regression test test/CodeGen/noexceptionsfpmath.c makes sure -fno-trapping-math ends up as a function attri

Re: r280065 - Fix for commit 280064 that break the build.

2016-08-31 Thread Renato Golin via cfe-commits
On 30 August 2016 at 09:56, Sjoerd Meijer via cfe-commits wrote: > Author: sjoerdmeijer > Date: Tue Aug 30 03:56:00 2016 > New Revision: 280065 > > URL: http://llvm.org/viewvc/llvm-project?rev=280065&view=rev > Log: > Fix for commit 280064 that break the build. Any more info on this? Is this bein

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

2016-08-31 Thread Renato Golin via cfe-commits
Thanks! On 31 August 2016 at 01:02, Richard Smith wrote: > Hopefully r280178 should fix this. > > On Tue, Aug 30, 2016 at 4:00 PM, Renato Golin > wrote: >> >> On 30 August 2016 at 22:44, Renato Golin wrote: >> > This breakage was hidden by Duncan's build breakage: >> > >> > http://lab.llvm.org:

Re: [PATCH] D23279: clang-reorder-fields

2016-08-31 Thread Daniel Jasper via cfe-commits
djasper added a comment. Looks good :). Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

2016-08-31 Thread Alexander Shaposhnikov via cfe-commits
alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

2016-08-31 Thread Alexander Shaposhnikov via cfe-commits
alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

2016-08-31 Thread Alexander Shaposhnikov via cfe-commits
alexshap updated this revision to Diff 69814. alexshap added a comment. 1. Fix comments (hope so). 2. if (const auto *SyntacticForm = InitListEx->getSyntacticForm()) InitListEx = SyntacticForm; Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-field

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

2016-08-31 Thread Haojian Wu via cfe-commits
hokein added a comment. wow, thanks for many detailed comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not contain "." prefix). "h,hh,hpp,hxx" by default. For + extension-less header files, using an empty string or l

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

2016-08-31 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 69812. hokein marked 26 inline comments as done. hokein added a comment. Address aaron's comments. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-build-nam

Re: [PATCH] D23279: clang-reorder-fields

2016-08-31 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:181 @@ +180,3 @@ + assert(InitListEx && "Init list expression is null"); + // we care only about brace initializations + // which have valid source locations Write full sent

Re: [PATCH] D23279: clang-reorder-fields

2016-08-31 Thread Alexander Shaposhnikov via cfe-commits
alexshap updated this revision to Diff 69807. alexshap added a comment. 1. Fix handling of initListExprs. http://clang.llvm.org/doxygen/Expr_8h_source.html#l03701 2. Fix handling of unchanged files 3. Add tests (AggregatePartialInitialization and ClassDifferentFieldsAccesses) Repository: rL

[PATCH] D24069: Document option '-rtlib' in clang's man page and help info

2016-08-31 Thread Lei Zhang via cfe-commits
zlei created this revision. zlei added reviewers: cfe-commits, Hahnfeld. This patch adds an entry for "-rtlib" in the output of `man clang` and `clang -help`. https://reviews.llvm.org/D24069 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td Index: include/clang/Driver/Opti

Re: [PATCH] D23279: clang-reorder-fields

2016-08-31 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. good call, i have found a bug in handling of initListExprs. Will update this diff and add tests. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

r280199 - [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

2016-08-31 Thread Igor Kudrin via cfe-commits
Author: ikudrin Date: Wed Aug 31 02:04:16 2016 New Revision: 280199 URL: http://llvm.org/viewvc/llvm-project?rev=280199&view=rev Log: [Coverage] Suppress creating a code region if the same area is covered by an expansion region. In most cases these code regions are just redundant, but sometimes

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

2016-08-31 Thread Igor Kudrin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280199: [Coverage] Suppress creating a code region if the same area is covered by an… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D23987?vs=69709&id=69799#toc Repository:

<    1   2