Re: r280597 - [AVX-512] Remove masked integer mullo builtins and replace with native IR.

Renato, I remember you saying you worked around the bot problem by making the build dir a symlink. Maybe stuff gets confused by that setup? Symlink build dirs tend to cause trouble. On Sep 5, 2016 8:11 PM, "Craig Topper via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > This error makes

Re: r280597 - [AVX-512] Remove masked integer mullo builtins and replace with native IR.

This error makes even less sense. Nothing about __builtin_ia32_selectd_512 requires a constant integer. /home/linaro/buildbot/clang-cmake-thumbv7-a15/stage1/bin/../lib/clang/4.0.0/include/avx512fintrin.h:223:19: error: argument to '__builtin_ia32_selectd_512' must be a constant integer return

Re: r280597 - [AVX-512] Remove masked integer mullo builtins and replace with native IR.

On 6 September 2016 at 00:27, Craig Topper wrote: > This failure doesn't make sense. It's acting like the test was updated for > r280596, but not the intrinsic header or the clang binary. That's the only > way I can think that the output IR could contain >

Re: [PATCH] D23503: [clang-cl] Check that we are in clang cl mode before enabling support for the CL environment variable.

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r280597 - [AVX-512] Remove masked integer mullo builtins and replace with native IR.

This failure doesn't make sense. It's acting like the test was updated for r280596, but not the intrinsic header or the clang binary. That's the only way I can think that the output IR could contain @llvm.x86.avx512.mask.padd.b.256.

Re: r280597 - [AVX-512] Remove masked integer mullo builtins and replace with native IR.

On 3 September 2016 at 20:19, Craig Topper via cfe-commits wrote: > Author: ctopper > Date: Sat Sep 3 14:19:49 2016 > New Revision: 280597 > > URL: http://llvm.org/viewvc/llvm-project?rev=280597=rev > Log: > [AVX-512] Remove masked integer mullo builtins and replace

Re: [PATCH] D21506: [analyzer] Block in critical section

zdtorok removed rL LLVM as the repository for this revision. zdtorok updated this revision to Diff 70345. zdtorok marked an inline comment as done. zdtorok added a comment. Fixed based on the provided comments and feedbacks. - added new inter-procedural tests - minor styling fix (trailing

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

EricWF added a comment. In https://reviews.llvm.org/D23926#531226, @rmaprath wrote: > Simplified the patch a little bit more. > > Now, library vendors should be able to define > `_LIBCPP_STRICT_C99_COMPATIBILITY` and `libc++` will not use/test C99 math > functions in `C++03/98` modes.

r280672 - Add support for targeting armv6-unknown-cloudabi-eabihf.

Author: ed Date: Mon Sep 5 13:38:34 2016 New Revision: 280672 URL: http://llvm.org/viewvc/llvm-project?rev=280672=rev Log: Add support for targeting armv6-unknown-cloudabi-eabihf. I'm in the progress of adding ARMv6 support to CloudABI. On the compiler side, everything seems to work properly

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. Have you done any investigation regarding the compilation speed as this change adds expensive container lookups for all OpenCL declarations and function calls. It would be

Re: [PATCH] D22130: Link static PIE programs against rcrt0.o on OpenBSD

sisnkemp added a comment. Ping? https://reviews.llvm.org/D22130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

vmiklos added a comment. Sure, I have no problems merging rename-all and rename-at, I added it as it looked like a good idea at that time. https://reviews.llvm.org/D24224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23915: [OpenCL] Remove access qualifiers on images in arg info metadata.

Anastasia accepted this revision. Anastasia added a comment. LGTM! https://reviews.llvm.org/D23915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

Anastasia added a comment. Could we add a CodeGen test as well to check that the constants generated are in the right precision format? https://reviews.llvm.org/D24235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23992: [OpenCL] Augment pipe built-ins with pipe packet size and alignment.

Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:97 @@ +96,3 @@ + return llvm::ConstantInt::get(Int32Ty, +TypeSizeInBits / 8, // Size in bytes. +false); Perhaps it's

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet updated this revision to Diff 70324. szepet marked 4 inline comments as done. szepet added a comment. cast to dyn-cast change in order to fix a bug, changes based on comments https://reviews.llvm.org/D22507 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/EnumMisuseCheck.cpp

Re: [PATCH] D21505: [Clang][AVX512][Intrinsics]Adding intrinsics for mov{ss|sd} instruction set

delena added inline comments. Comment at: lib/Headers/avx512fintrin.h:9337 @@ +9336,3 @@ +{ + return (__m128) _mm_move_ss( __A, __builtin_ia32_selectps_128 ((__mmask8) __U, + (__v4sf) __B, selectps

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

I'll fix this. Vladimir --- From: *Akira Hatanaka* Date: Fri, Sep 2, 2016 at 3:00 AM Subject: Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values To:

r280659 - clang/test/Modules/compiler_builtins_x86.c: Fix r280658.

Author: chapuni Date: Mon Sep 5 08:14:54 2016 New Revision: 280659 URL: http://llvm.org/viewvc/llvm-project?rev=280659=rev Log: clang/test/Modules/compiler_builtins_x86.c: Fix r280658. Modified: cfe/trunk/test/Modules/compiler_builtins_x86.c Modified:

Re: [PATCH] D23831: [libcxx] Fix gcc 4.9 -Wcast-qual warning.

halyavin added a comment. False alarm. I figured out that only -Wattributes warnings ignore gcc system_header pragma. So this -Wcast-qual and other warnings doesn't block us. https://reviews.llvm.org/D23831 ___ cfe-commits mailing list

Re: r280613 - [Modules] Add 'freestanding' to the 'requires-declaration' feature-list.

Hi Elad, This commit broke all buildbots that don't default to targetting x86. I've committed a fix with r280658, but could you please double check it's correct. Cheers, James On Sun, 4 Sep 2016 at 07:09 Elad Cohen via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: eladcohen >

r280658 - Attempt to fix buildbots not targetting x86

Author: jamesm Date: Mon Sep 5 07:28:49 2016 New Revision: 280658 URL: http://llvm.org/viewvc/llvm-project?rev=280658=rev Log: Attempt to fix buildbots not targetting x86 r280613 introduced failures for all builds that don't target x86 by default. Add an explicit target to avoid a missing

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

omtcyfz added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:480 @@ +479,3 @@ +Replaces = Replaces.merge(NewReplacements); +format::FormatStyle Style = format::getStyle("file", FilePath, "google"); +// Clean up old namespaces if there is nothing in

Re: [PATCH] D21505: [Clang][AVX512][Intrinsics]Adding intrinsics for mov{ss|sd} instruction set

m_zuckerman updated this revision to Diff 70318. https://reviews.llvm.org/D21505 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builtins.c

Re: [PATCH] D21505: [Clang][AVX512][Intrinsics]Adding intrinsics for mov{ss|sd} instruction set

m_zuckerman marked an inline comment as done. m_zuckerman added a comment. https://reviews.llvm.org/D21505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r280653 - [clang-rename] Add comment after namespace closing

Author: omtcyfz Date: Mon Sep 5 04:42:02 2016 New Revision: 280653 URL: http://llvm.org/viewvc/llvm-project?rev=280653=rev Log: [clang-rename] Add comment after namespace closing Modified: clang-tools-extra/trunk/clang-rename/RenamingAction.h Modified:

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

omtcyfz added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:480 @@ +479,3 @@ +Replaces = Replaces.merge(NewReplacements); +format::FormatStyle Style = format::getStyle("file", FilePath, "google"); +// Clean up old namespaces if there is nothing in

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

ioeric added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:22 @@ +21,3 @@ + (void)NS.ltrim(':'); + return NS.str(); +} Yes, it is added to please `LLVM_ATTRIBUTE_UNUSED_RESULT` of `llvm::StringRef::ltrim`. Comment at:

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

ioeric updated this revision to Diff 70308. ioeric marked 4 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D24183 Files: CMakeLists.txt change-namespace/CMakeLists.txt change-namespace/ChangeNamespace.cpp