Re: [PATCH] D24690: Replace __ANDROID__ with __BIONIC__.

2016-09-18 Thread Dan Albert via cfe-commits
danalbert added inline comments. Comment at: include/__config:90 @@ +89,3 @@ +#if defined(__linux__) +#include +#if !defined(__GLIBC_PREREQ) EricWF wrote: > Does MUSL libc have a `features.h`? This include was previously guarded by > if

Re: [PATCH] D24690: Replace __ANDROID__ with __BIONIC__.

2016-09-18 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after addressing the MUSL libc comment. Comment at: include/__config:90 @@ +89,3 @@ +#if defined(__linux__) +#include +#if !defined(__GLIBC_PREREQ)

r281881 - [docs] Touch up the code coverage doc

2016-09-18 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Sun Sep 18 20:42:38 2016 New Revision: 281881 URL: http://llvm.org/viewvc/llvm-project?rev=281881=rev Log: [docs] Touch up the code coverage doc Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL:

r281880 - [analyzer] SATestBuild.py: Treat '#' as comment in projectMap.csv

2016-09-18 Thread Devin Coughlin via cfe-commits
Author: dcoughlin Date: Sun Sep 18 20:36:40 2016 New Revision: 281880 URL: http://llvm.org/viewvc/llvm-project?rev=281880=rev Log: [analyzer] SATestBuild.py: Treat '#' as comment in projectMap.csv Treat lines in projectMap.csv that start with '#' as comments. This enables a workflow where

Re: [PATCH] D24709: [analyzer] SATestBuild.py: Treat '#' as comment in projectMap.csv

2016-09-18 Thread Devin Coughlin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281880: [analyzer] SATestBuild.py: Treat '#' as comment in projectMap.csv (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D24709?vs=71757=71766#toc Repository: rL LLVM

r281879 - [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-18 Thread Dean Michael Berris via cfe-commits
Author: dberris Date: Sun Sep 18 19:59:19 2016 New Revision: 281879 URL: http://llvm.org/viewvc/llvm-project?rev=281879=rev Log: [XRay] ARM 32-bit no-Thumb support in Clang Just a test for now, adapted from x86_64 tests of XRay. This is one of 3 commits to different repositories of XRay ARM

Re: [PATCH] D23932: [XRay] ARM 32-bit no-Thumb support in Clang

2016-09-18 Thread Dean Michael Berris via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281879: [XRay] ARM 32-bit no-Thumb support in Clang (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D23932?vs=71635=71765#toc Repository: rL LLVM

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

2016-09-18 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:668 @@ -664,3 +667,3 @@ llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf); CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream); // Output name of the

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

2016-09-18 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:668 @@ -664,3 +667,3 @@ llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf); CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream); // Output name of the function.

[PATCH] D24709: [analyzer] SATestBuild.py: Treat '#' as comment in projectMap.csv

2016-09-18 Thread Devin Coughlin via cfe-commits
dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, NoQ. dcoughlin added a subscriber: cfe-commits. Treat lines in projectMap.csv that start with '#' as comments. This enables a workflow where projects can be temporarily disabled with a comment describing when they should be

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

2016-09-18 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:668 @@ -664,3 +667,3 @@ llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf); CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream); // Output name of the function.

Re: [PATCH] D24477: clang-format: [JS] Do not wrap taze: IWYU comments

2016-09-18 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281857: clang-format: [JS] Do not wrap taze annotation comments. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D24477?vs=71189=71756#toc Repository: rL LLVM

r281857 - clang-format: [JS] Do not wrap taze annotation comments.

2016-09-18 Thread Martin Probst via cfe-commits
Author: mprobst Date: Sun Sep 18 12:33:51 2016 New Revision: 281857 URL: http://llvm.org/viewvc/llvm-project?rev=281857=rev Log: clang-format: [JS] Do not wrap taze annotation comments. Summary: `// taze: ... from ...` comments are used help tools where a specific global symbol comes from.

Re: [PATCH] D24574: clang-format: [JS] ASI insertion after boolean literals.

2016-09-18 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281856: clang-format: [JS] ASI insertion after boolean literals. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D24574?vs=71385=71755#toc Repository: rL LLVM

[PATCH] D24708: clang-format: [JS] Fix line breaks before comments when sorting imports.

2016-09-18 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Previously, clang-format would always insert an additional line break after the import block if the main body started with a comment, due to loosing track

r281854 - CodeGen: mark ObjC cstring literals as constant

2016-09-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Sep 18 11:12:04 2016 New Revision: 281854 URL: http://llvm.org/viewvc/llvm-project?rev=281854=rev Log: CodeGen: mark ObjC cstring literals as constant These strings are constants, mark them as such. This doesn't matter too much in practice on MachO since the constants

r281855 - CodeGen: mark ObjC cstring literals as unnamed_addr

2016-09-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Sep 18 11:12:14 2016 New Revision: 281855 URL: http://llvm.org/viewvc/llvm-project?rev=281855=rev Log: CodeGen: mark ObjC cstring literals as unnamed_addr These are all emitted into a section with a cstring_literal attribute. The attribute permits the linker to

Re: [PATCH] D21506: [analyzer] Block in critical section

2016-09-18 Thread Zoltán Dániel Török via cfe-commits
zdtorok added a comment. As it's my first contribution I think I have no commit access. So far I could not test it on larger codebase. I've tried to do so on clang but my computer was too slow for that. I will try it again. What you mean by alpha-phase? What should be the next steps now?

[PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

2016-09-18 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: rsmith. DmitryPolukhin added subscribers: cfe-commits, andreybokhanko. Recursive mangling should use all existing substitutions and newly created substitutions should be copied outer mangler. This patch should fix PR30401

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

2016-09-18 Thread Daphne Pfister via cfe-commits
daphnediane created this revision. daphnediane added a reviewer: djasper. daphnediane added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fix for the formatting options combination of BreakBeforeBinaryOperators: All, AlignAfterOpenBracket: AlwaysBreak not handling long templates