Author: ericwf
Date: Mon Oct 10 01:31:00 2016
New Revision: 283721
URL: http://llvm.org/viewvc/llvm-project?rev=283721&view=rev
Log:
Cleanup CMake status output
Modified:
libcxx/trunk/benchmarks/CMakeLists.txt
libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake
Modified: libcxx/trunk/be
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
The decltype(declval) dance in the iterator traits is necessary because
DenseMap iterators aren't over std::pairs, but rather are over a
pair-like type defined in DenseMap. It used to work beca
EricWF added a comment.
In https://reviews.llvm.org/D24991#565715, @mclow.lists wrote:
> How does this play with existing binaries? Applications that expect these
> functions to exist in the dylib?
This patch is majorly ABI breaking, although we could probably find a
formulation that wasn't.
Author: mzuckerm
Date: Mon Oct 10 00:45:54 2016
New Revision: 283716
URL: http://llvm.org/viewvc/llvm-project?rev=283716&view=rev
Log:
[x86][inline-asm][clang] accept 'v' constraint
Commit in the name of: Coby Tayree
1.'v' constraint for (x86) non-avx arch imitates the already implemented 'x'
Author: ericwf
Date: Mon Oct 10 00:34:18 2016
New Revision: 283715
URL: http://llvm.org/viewvc/llvm-project?rev=283715&view=rev
Log:
Provide a constexpr addressof with GCC 7.
__builtin_addressof was added to the GCC trunk in the past week. This patch
teaches libc++ about it so it can correctly pr
Author: ericwf
Date: Mon Oct 10 00:19:59 2016
New Revision: 283714
URL: http://llvm.org/viewvc/llvm-project?rev=283714&view=rev
Log:
Workaround missing C++14 constexpr semantics in filesystem
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experim
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25426
Files:
clang/include/clang/Analysis/AnalysisContext.h
clang/lib/Analysis/AnalysisDeclContext.cpp
Index: clang/lib/Analysis/AnalysisDeclContext.cpp
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D25425
Files:
clang/lib/ASTMatchers/Dynamic/Marshallers.h
clang/lib/ASTMatchers/Dynamic/Registry.cpp
Index: clang/lib/ASTMatcher
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25423
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
Index: clang/lib/AST/VTableBuilder.cpp
=
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25422
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
clang/lib/CodeGen/MicrosoftCXXABI.cpp
Index: clang/lib/CodeGen/MicrosoftCXX
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25424
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
Index: clang/lib/AST/VTableBuilder.cpp
=
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25421
Files:
clang/include/clang/AST/VTableBuilder.h
clang/lib/AST/VTableBuilder.cpp
Index: clang/lib/AST/VTableBuilder.cpp
=
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
It doesn't need to be refcounted anymore, either.
https://reviews.llvm.org/D25420
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/MangleNumberingContext.h
clang/incl
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D25419
Files:
llvm/lib/IR/Constants.cpp
llvm/lib/IR/LLVMContextImpl.cpp
llvm/lib/IR/LLVMContextImpl.h
Index: llvm/lib/IR/LLVMContextImpl.h
==
EricWF created this revision.
EricWF added reviewers: mclow.lists, danalbert, jroelofs, compnerd.
EricWF added a subscriber: cfe-commits.
In 32 bit builds on a 64 bit system `std::malloc` does not return correctly
aligned memory. This leads to undefined behavior.
This patch switches to using `p
Author: ericwf
Date: Sun Oct 9 23:22:58 2016
New Revision: 283712
URL: http://llvm.org/viewvc/llvm-project?rev=283712&view=rev
Log:
Remove use of int128_t inside the filesystem implementation
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experi
mclow.lists added a comment.
How does this play with existing binaries? Applications that expect these
functions to exist in the dylib?
Repository:
rL LLVM
https://reviews.llvm.org/D24991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ericwf
Date: Sun Oct 9 16:43:30 2016
New Revision: 283701
URL: http://llvm.org/viewvc/llvm-project?rev=283701&view=rev
Log:
Remove debug output from gen_linker_script.py
Modified:
libcxx/trunk/utils/gen_link_script/gen_link_script.py
Modified: libcxx/trunk/utils/gen_link_script/gen_
Hi Renato, Hal,
I've hopefully fixed this in r283700. I'll be watching the bots to ensure
everything works.
Sorry about the breakage.
/Eric
On Sun, Oct 9, 2016 at 6:05 AM, Renato Golin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 9 October 2016 at 03:59, Hal Finkel via cfe-commits
Author: ericwf
Date: Sun Oct 9 16:34:03 2016
New Revision: 283700
URL: http://llvm.org/viewvc/llvm-project?rev=283700&view=rev
Log:
Fix linker script generation for in-tree builds
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/cmake/Modules/HandleLibcxxFlags.cmake
libcxx/trunk/li
The attached patch makes the LValue created in EmitValueForIvarAtOffset
have the same Qualifiers in the LValue as the QualType in the LValue.
Noticed when auditing for reasons the QualType would different from the
Qualifiers in an LValue. No functionality change.
Please review!
Nick
lvalue-qual
Author: ericwf
Date: Sun Oct 9 15:44:48 2016
New Revision: 283699
URL: http://llvm.org/viewvc/llvm-project?rev=283699&view=rev
Log:
[libc++abi] Fix bug which cased the static libunwind to always be chosen
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/src/CMakeLists.
elsteveogrande added a comment.
ping :) Wanted to get sign off on this (simplified) diff if possible.
Thanks! Sorry to nag. (This would be one part of the solution for really long
build times for us.)
https://reviews.llvm.org/D25153
___
cfe-com
jlebar created this revision.
jlebar added a reviewer: timshen.
jlebar added a subscriber: cfe-commits.
jlebar added a dependency: D25404: [ADT] Let MapVector handle non-copyable
values..
This is possible now that MapVector supports move-only values.
Depends on https://reviews.llvm.org/D25404.
jlebar added a comment.
Although these pass the CUDA test-suite tests (which I haven't yet committed
because they're broken without this change), I could use some help running the
libcxx tests.
I cannot find any documentation explaining how to run the libcxx tests with
just-built clang. Presu
https://reviews.llvm.org/D25403 for adding constexpr to the new libc++
functions.
On Sat, Oct 8, 2016 at 8:56 PM, Justin Lebar wrote:
>> > The fix is not as simple as simply changing our implementation of
>> e.g.
>> std::isnan to call __builtin_isnanf, because we also would want to
>> fix
>> ::is
jlebar created this revision.
jlebar added a reviewer: hfinkel.
jlebar added a subscriber: cfe-commits.
This makes these functions available on host and device, which is
necessary to compile for the device.
https://reviews.llvm.org/D25403
Files:
libcxx/include/cmath
Index: libcxx/include/c
coby removed rL LLVM as the repository for this revision.
coby updated this revision to Diff 74060.
https://reviews.llvm.org/D25004
Files:
lib/Basic/Targets.cpp
test/CodeGen/x86-inline-asm-v-constraint.c
Index: lib/Basic/Targets.cpp
==
zizhar updated this revision to Diff 74068.
zizhar added a comment.
I hope this last update finishes it,
Thanks for the review :)
https://reviews.llvm.org/D15075
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/TargetInfo.h
lib/Basic/TargetInfo.cpp
lib/Basic/Targets
Prazek added a comment.
BTW I think changing the commit name by removing bug ID would be good, because
it would be more clear that this is a feature commit, not a bug fix.
You can move t he bug id, or the link to bug to the summary section.
https://reviews.llvm.org/D25316
__
Prazek added inline comments.
Comment at: test/clang-tidy/modernize-use-auto-cast-remove-stars.cpp:25
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use auto when initializing with
a cast to avoid duplicating the type name
+ // CHECK-FIXES: auto ll = static_cast(l);
+ unsigne
Prazek added a comment.
In https://reviews.llvm.org/D25316#565574, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25316#565567, @Prazek wrote:
>
> > functionDecl(hasName(LEXICAL_CAST_NAME),
>
>
> I was trying to avoid specifying the name of the function so that it works
> for any t
malcolm.parsons added a comment.
In https://reviews.llvm.org/D25316#565567, @Prazek wrote:
> functionDecl(hasName(LEXICAL_CAST_NAME),
I was trying to avoid specifying the name of the function so that it works for
any templated function/member function that returns its first template type
Prazek added a comment.
In https://reviews.llvm.org/D25363#565472, @malcolm.parsons wrote:
> I've tested this with clang-query using `match typeLoc()` and a lot of
> permutations of int, short, long, unsigned and const.
I am pretty sure it works, but someone could change the implementation and
Prazek added a comment.
In https://reviews.llvm.org/D25363#565445, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25363#565371, @Prazek wrote:
>
> > Thanks for the patch! I think some unit test should be added.
>
>
> Are there any existing unit tests for TypeLoc that I can add to?
>
> > D
Prazek added a comment.
In https://reviews.llvm.org/D25316#565463, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25316#565378, @Prazek wrote:
>
> > Awesome to see this patch. After this one will make it to upstream, it will
> > be much easier for me to do same with template functions.
>
joerg added a comment.
I don't agree with the motivation for this change, BTW. Whether -lunwind is
needed or not is an implementation detail of the way the ABI implementation is
linked. That's why libc++ is now a linker script, to hide this kinds of
implementation details.
https://reviews.llv
joerg added a comment.
No, they are not desirable, in fact, they pretty much break clang. That's why I
wanted to see the test diff...
https://reviews.llvm.org/D25402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
On 9 October 2016 at 03:59, Hal Finkel via cfe-commits
wrote:
>> and now it doesn't because you no longer use SCRIPT_ABI_LIBNAME as
>> the argument to gen_link_script.py. Let me see if I can fix this...
>
> r283684
Hi Hal,
Thanks for looking into this, but, we're not there yet. :)
http://lab.ll
mgorny resigned from this revision.
mgorny removed a reviewer: mgorny.
mgorny added a comment.
I have no further comments. However, I'm quite a fresh contributor, so I'm not
really in a position to accept it.
https://reviews.llvm.org/D24933
___
cfe
mgorny added a reviewer: joerg.
mgorny updated this revision to Diff 74064.
mgorny added a comment.
I've updated the NetBSD tests (@joerg, please confirm if it's desired), and
added a Linux test for the case. AFAICS most of the other targets override the
method, some of them adding -lunwind alre
mgorny updated this revision to Diff 74063.
mgorny added a comment.
I'm sorry, I mixed branches up. Here's the correct patch with both updates.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang.rst
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
test/Driver/montavista
mgorny added a reviewer: ggreif.
mgorny updated this revision to Diff 74062.
mgorny added a comment.
Including a fix for montavista toolchain checks that miss passing -rtlib= and
therefore could fail depending on DEFAULT_* value.
https://reviews.llvm.org/D25338
Files:
docs/CommandGuide/clang
eladcohen added a comment.
Hi Bruno,
The short answer is yes. Essentially it can be done, but we would actually like
for all the users to always get this behavior, implicitly.
The long answer is that there is a history of problems regarding the intrinsic
files:
http://lists.llvm.org/pipermail/
44 matches
Mail list logo
