r284933 - Fix mangling numbers for varargs lambdas; varargs and non-varargs lambdas get

2016-10-22 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Oct 22 23:53:03 2016 New Revision: 284933 URL: http://llvm.org/viewvc/llvm-project?rev=284933=rev Log: Fix mangling numbers for varargs lambdas; varargs and non-varargs lambdas get different lambda-sigs, so they should have different counters. Modified:

[PATCH] D25674: [Concepts] Class template associated constraints

2016-10-22 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/class-template-decl.cpp:12 + +} // end namespace nodiag + I should probably add some template-dependent cases. https://reviews.llvm.org/D25674

[PATCH] D25491: [libcxx] Use C++14 when building libc++ with musl

2016-10-22 Thread Petr Hosek via cfe-commits
phosek updated this revision to Diff 75540. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D25491 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@

r284931 - [clang] Limit clang test to ARM and AArch64 only

2016-10-22 Thread Mandeep Singh Grang via cfe-commits
Author: mgrang Date: Sat Oct 22 19:53:03 2016 New Revision: 284931 URL: http://llvm.org/viewvc/llvm-project?rev=284931=rev Log: [clang] Limit clang test to ARM and AArch64 only Summary: Limit clang/test/Frontend/gnu-mcount.c to ARM and AArch64 only. Reviewers: abdulras, honggyu.kim, rengolin

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

2016-10-22 Thread Mehdi AMINI via cfe-commits
mehdi_amini updated this revision to Diff 75536. mehdi_amini added a comment. typo + clang-format https://reviews.llvm.org/D25888 Files: clang/include/clang/Analysis/Analyses/FormatString.h clang/include/clang/Analysis/Analyses/OSLog.h clang/include/clang/Basic/Builtins.def

[PATCH] D25898: [clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()

2016-10-22 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added reviewers: alexfh, aaron.ballman. malcolm.parsons added a subscriber: cfe-commits. Avoid naked new in unique_ptr.reset() by using make_unique Fixes http://llvm.org/PR27383 https://reviews.llvm.org/D25898 Files:

r284925 - [AVX-512] Remove masked 128/256-bit pshufb builtins. Replace with a select and the older unmaksed builtins.

2016-10-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 22 16:24:42 2016 New Revision: 284925 URL: http://llvm.org/viewvc/llvm-project?rev=284925=rev Log: [AVX-512] Remove masked 128/256-bit pshufb builtins. Replace with a select and the older unmaksed builtins. Modified:

r284927 - [AVX-512] Replace masked 128/256-bit vpmovzx/vpmovsx builtins with native IR.

2016-10-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 22 16:24:48 2016 New Revision: 284927 URL: http://llvm.org/viewvc/llvm-project?rev=284927=rev Log: [AVX-512] Replace masked 128/256-bit vpmovzx/vpmovsx builtins with native IR. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r284926 - [AVX-512] Remove duplicate test cases from the avx512vlbw intrinsic test. These tests already exist in the avx512vl test and represent avx512vl instructions.

2016-10-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 22 16:24:44 2016 New Revision: 284926 URL: http://llvm.org/viewvc/llvm-project?rev=284926=rev Log: [AVX-512] Remove duplicate test cases from the avx512vlbw intrinsic test. These tests already exist in the avx512vl test and represent avx512vl instructions.

r284928 - [AVX-512] Replace masked 128/256-bit saturating add/sub builtins with select and older unmasked builtins.

2016-10-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 22 16:24:52 2016 New Revision: 284928 URL: http://llvm.org/viewvc/llvm-project?rev=284928=rev Log: [AVX-512] Replace masked 128/256-bit saturating add/sub builtins with select and older unmasked builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r284924 - [AVX-512] Remove builtins for 128/256-bit pabsb/pabsw. We can use a select and the older non-masked versions instead.

2016-10-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 22 16:24:38 2016 New Revision: 284924 URL: http://llvm.org/viewvc/llvm-project?rev=284924=rev Log: [AVX-512] Remove builtins for 128/256-bit pabsb/pabsw. We can use a select and the older non-masked versions instead. Modified:

r284929 - [AVX-512] Replace masked 128/256-bit pavg builtins and replace with select and older unmasked builtins.

2016-10-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 22 16:24:56 2016 New Revision: 284929 URL: http://llvm.org/viewvc/llvm-project?rev=284929=rev Log: [AVX-512] Replace masked 128/256-bit pavg builtins and replace with select and older unmasked builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r284923 - [AVX-512] Add typecasts to alignr intrinsics that were modified in r284920.

2016-10-22 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 22 16:24:34 2016 New Revision: 284923 URL: http://llvm.org/viewvc/llvm-project?rev=284923=rev Log: [AVX-512] Add typecasts to alignr intrinsics that were modified in r284920. Modified: cfe/trunk/lib/Headers/avx512vlbwintrin.h Modified:

[PATCH] D24656: [clang-tidy] Add check readability-redundant-declaration

2016-10-22 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Sorry for the delay. I'm on vacation, returning on Monday. The patch looks good when the comments are fixed. Comment at:

[PATCH] D25842: [clang] Limit clang test to ARM and AArch64 only

2016-10-22 Thread Renato Golin via cfe-commits
rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. I haven't tested with ARM and not AArch64 or vice-versa. I'm assuming you have. If so, LGTM. Thanks. https://reviews.llvm.org/D25842

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

2016-10-22 Thread Mehdi AMINI via cfe-commits
mehdi_amini updated this revision to Diff 75534. mehdi_amini added a comment. std::any_of -> llvm::any_of and more magic number replaced with enum https://reviews.llvm.org/D25888 Files: clang/include/clang/Analysis/Analyses/FormatString.h clang/include/clang/Analysis/Analyses/OSLog.h

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-10-22 Thread Benedek Kiss via cfe-commits
falho updated this revision to Diff 75460. falho added a comment. changes according to 2nd review https://reviews.llvm.org/D22346 Files: clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt

[PATCH] D25777: [Sema][TreeTransform] Re-create DesignatedInitExpr when it has a field designator with a valid FieldDecl

2016-10-22 Thread John McCall via cfe-commits
rjmccall added a comment. Thanks, LGTM with a small tweak. Comment at: lib/Sema/TreeTransform.h:8928 +FieldDecl *Field = dyn_cast_or_null( +getDerived().TransformDecl(D.getFieldLoc(), D.getField())); +if (Field != D.getField()) I'm

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

2016-10-22 Thread John McCall via cfe-commits
rjmccall added a comment. Thanks. LGTM. https://reviews.llvm.org/D25844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

2016-10-22 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. I have attached the results of this checker after running it on LLVM. F2522345: results.txt https://reviews.llvm.org/D24894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

2016-10-22 Thread Gábor Horváth via cfe-commits
xazax.hun updated the summary for this revision. xazax.hun removed rL LLVM as the repository for this revision. xazax.hun updated this revision to Diff 75530. xazax.hun marked 3 inline comments as done. xazax.hun added a comment. - Fixed the performance problems. - Altered the diagnostic text. -

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

2016-10-22 Thread Gábor Horváth via cfe-commits
xazax.hun added inline comments. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:26 + unless(hasAnyTemplateArgument(refersToType(voidType(, + hasAnyName("::std::plus", "::std::minus", "::std::multiplies", + "::std::divides",

[PATCH] D21502: Fix heuristics skipping invalid ctor-initializers with C++11

2016-10-22 Thread Olivier Goffart via cfe-commits
ogoffart added a comment. Ping? I guess i coud just commit it now. https://reviews.llvm.org/D21502 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r284894 - [Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation check

2016-10-22 Thread Eugene Zelenko via cfe-commits
Hi, Kim! Sure, it'll be good idea, but I think, it'll be better, if Richard Smith will do this. I just followed r284888, which doesn't contain a lot of explanations or reference to relevant discussion. Eugene. On Sat, Oct 22, 2016 at 12:48 AM, Kim Gräsman wrote: > Hi

Re: [clang-tools-extra] r284894 - [Release notes] Mention removed Clang-tidy misc-pointer-and-integral-operation check

2016-10-22 Thread Kim Gräsman via cfe-commits
Hi Eugene, On Sat, Oct 22, 2016 at 12:35 AM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Fri Oct 21 17:35:58 2016 > New Revision: 284894 > > URL: http://llvm.org/viewvc/llvm-project?rev=284894=rev > Log: > [Release notes] Mention removed

[PATCH] D25888: Add support for __builtin_os_log_format[_buffer_size]

2016-10-22 Thread David Majnemer via cfe-commits
majnemer added inline comments. Comment at: clang/include/clang/Analysis/Analyses/OSLog.h:117-129 +return std::any_of( +Items.begin(), Items.end(), +[](const OSLogBufferItem ) { return item.getIsPrivate(); }); + } + + bool getHasPublicItems() const { +