[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL285176: [CodeGen] Don't emit lifetime intrinsics for some local variables (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24693?vs=74814=75832#toc Repository: rL LLVM

r285176 - [CodeGen] Don't emit lifetime intrinsics for some local variables

Author: vitalybuka Date: Wed Oct 26 00:42:30 2016 New Revision: 285176 URL: http://llvm.org/viewvc/llvm-project?rev=285176=rev Log: [CodeGen] Don't emit lifetime intrinsics for some local variables Summary: Current generation of lifetime intrinsics does not handle cases like: ``` { char

[PATCH] D25902: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285175: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask. (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D25902?vs=75557=75830#toc Repository:

r285175 - [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask.

Author: ctopper Date: Wed Oct 26 00:35:38 2016 New Revision: 285175 URL: http://llvm.org/viewvc/llvm-project?rev=285175=rev Log: [AVX-512] Fix the operand order for all calls to __builtin_ia32_vfmaddss3_mask. Summary: The preserved input should be the first argument and the vector inputs should

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

jlebar added a comment. Doesn't look like we changed any testcases when we changed this behavior? The change in behavior may be unobservable, but even still it seems worthwhile to have tests that check that we're not doing any of the alternatives we considered. Comment at:

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

jlebar added a comment. Is it possible to write a testcase for the using-declaration change? https://reviews.llvm.org/D25809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285162 - Use printf instead of "echo -ne".

Author: ruiu Date: Tue Oct 25 22:38:48 2016 New Revision: 285162 URL: http://llvm.org/viewvc/llvm-project?rev=285162=rev Log: Use printf instead of "echo -ne". Not all echo commands support "-e". Modified: cfe/trunk/test/Driver/response-file-extra-whitespace.c Modified:

[PATCH] D19853: [safestack] Add -fruntime-init to support invoking functions during runtime init

mlemay-intel abandoned this revision. mlemay-intel added a comment. I was able to setup a temporary thread control block early enough in musl libc initialization to obviate the need for an attribute like runtime_init. https://reviews.llvm.org/D19853

r285160 - [modules] Fix assert if multiple update records provide a definition for a

Author: rsmith Date: Tue Oct 25 21:31:56 2016 New Revision: 285160 URL: http://llvm.org/viewvc/llvm-project?rev=285160=rev Log: [modules] Fix assert if multiple update records provide a definition for a class template specialization and that specialization has attributes. Modified:

r285132 - [codeview] emit debug info for indirect virtual base classes

Author: inglorion Date: Tue Oct 25 17:19:32 2016 New Revision: 285132 URL: http://llvm.org/viewvc/llvm-project?rev=285132=rev Log: [codeview] emit debug info for indirect virtual base classes Summary: Fixes PR28281. MSVC lists indirect virtual base classes in the field list of a class. This

[PATCH] D25974: Fix implementation of the likely resolution of core issue 253 to support class based arrays.

itessier created this revision. itessier added a subscriber: cfe-commits. https://reviews.llvm.org/D16552 implemented the likely resolution of core issue 253, but didn't include support for class based array fields. E.g.: struct A { } struct B { A a[2]; } const B b; // Fails, but should

[PATCH] D25579: [codeview] emit debug info for indirect virtual base classes

This revision was automatically updated to reflect the committed changes. Closed by commit rL285132: [codeview] emit debug info for indirect virtual base classes (authored by inglorion). Changed prior to commit: https://reviews.llvm.org/D25579?vs=75381=75804#toc Repository: rL LLVM

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

jlebar added a comment. In https://reviews.llvm.org/D25640#579238, @tra wrote: > I'm OK with the change, but the comments suggest that things may be more > complicated. > How about disabling assert for CUDA only? I don't think that is the right approach. This function has nothing to do with

[PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

This revision was automatically updated to reflect the committed changes. Closed by commit rL285158: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24695?vs=72908=75827#toc Repository: rL LLVM

r285159 - [Sema] Handle CaseStmt and DefaultStmt as SwitchCase

Author: vitalybuka Date: Tue Oct 25 21:00:00 2016 New Revision: 285159 URL: http://llvm.org/viewvc/llvm-project?rev=285159=rev Log: [Sema] Handle CaseStmt and DefaultStmt as SwitchCase Summary: rsmith Differential Revision: https://reviews.llvm.org/D25665 Modified:

r285158 - [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

Author: vitalybuka Date: Tue Oct 25 20:59:57 2016 New Revision: 285158 URL: http://llvm.org/viewvc/llvm-project?rev=285158=rev Log: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place Summary: D24693 will need access to it from other places Reviewers: eugenis Subscribers:

r285154 - [cxx_status] update comment

Author: rsmith Date: Tue Oct 25 20:37:36 2016 New Revision: 285154 URL: http://llvm.org/viewvc/llvm-project?rev=285154=rev Log: [cxx_status] update comment Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

Re: [libcxx] r249738 - Split out of .

Committed as r285152. On Tue, Oct 25, 2016 at 3:09 PM, Richard Smith wrote: > Missed one change from the test suite: > > Index: test/Modules/cstd.m > === > --- test/Modules/cstd.m (revision 285117) > +++

r285152 - Treat module headers wrapped by our builtin headers as implicitly being textual

Author: rsmith Date: Tue Oct 25 20:08:55 2016 New Revision: 285152 URL: http://llvm.org/viewvc/llvm-project?rev=285152=rev Log: Treat module headers wrapped by our builtin headers as implicitly being textual headers. We previously got this check backwards and treated the wrapper header as being

[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

mclow.lists added a comment. Looks better than before. Repository: rL LLVM https://reviews.llvm.org/D24372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285150 - Implement name mangling proposal for exception specifications from cxx-abi-dev 2016-10-11.

Author: rsmith Date: Tue Oct 25 20:05:54 2016 New Revision: 285150 URL: http://llvm.org/viewvc/llvm-project?rev=285150=rev Log: Implement name mangling proposal for exception specifications from cxx-abi-dev 2016-10-11. This has the following ABI impact: 1) Functions whose parameter or return

[PATCH] D25241: [libcxx] Improve code generation for vector::clear().

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D25241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25958: [libc++] Silence "unused parameter" warnings in test/support/archetypes.hpp

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D25958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25850: Accept nullability annotations (_Nullable) on array parameters

jordan_rose marked an inline comment as done. jordan_rose added a comment. Oops. Ignore the API notes file, which is only in Swift's branch of Clang right now. Repository: rL LLVM https://reviews.llvm.org/D25850 ___ cfe-commits mailing list

[PATCH] D25850: Accept nullability annotations (_Nullable) on array parameters

jordan_rose retitled this revision from "[WIP] Accept nullability annotations (_Nullable) on array parameters" to "Accept nullability annotations (_Nullable) on array parameters". jordan_rose updated the summary for this revision. jordan_rose updated this revision to Diff 75820. jordan_rose

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

ahatanak updated this revision to Diff 75819. ahatanak marked 2 inline comments as done. ahatanak added a comment. Skip the step to correct typo if ParseInitializer returns ExprError(). Add a test case that exercises the change. https://reviews.llvm.org/D25206 Files:

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

tra added a comment. I'm OK with the change, but the comments suggest that things may be more complicated. How about disabling assert for CUDA only? https://reviews.llvm.org/D25640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25940: [analyzer] LibraryFunctions: Fix errors due to different integral types and typedefs on different architectures.

dcoughlin added a comment. Are the parameter types actually needed? I think in general the rest of the analyzer uses arity alone. Is the idea to allow for overloads in C++? If so, then I think this equivalent-up-to-size-and-sign approach will disallow those overloads.

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra updated this revision to Diff 75816. tra added a comment. - handle using declarations found in the overload set we check. https://reviews.llvm.org/D25809 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra updated this revision to Diff 75812. tra added a comment. - Instead of relying on the first attribute we find, check all matching ones. - Specializations inherit their target attributes from their base template only. Their effective target always matches that of the template and is no

Re: r284256 - Link static PIE programs against rcrt0.o on OpenBSD

On 10/18/16 22:13, Brad Smith via cfe-commits wrote: On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote: On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote: Author: emaste Date: Fri Oct 14 12:59:53 2016 New Revision: 284256 URL:

Re: r284272 - Implement no_sanitize_address for global vars

ping On Mon, Oct 17, 2016 at 5:57 PM, Kostya Serebryany wrote: > Did you code-review this? > (sorry if I missed it) > > On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: dougk >> Date: Fri Oct 14 14:55:09 2016

r285140 - [Myriad] Find libc++ adjacent to libstdc++

Author: dougk Date: Tue Oct 25 18:02:30 2016 New Revision: 285140 URL: http://llvm.org/viewvc/llvm-project?rev=285140=rev Log: [Myriad] Find libc++ adjacent to libstdc++ Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

jordan_rose added a comment. > `_Nonnull` in this position seems very similar to `static` (which typically > also implies non-nullness). I wasn't actually sure if it was okay to assume this, but the standard does seem pretty clear: > If the keyword `static` also appears within the `[` and `]`

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

zaks.anna added inline comments. Comment at: test/Analysis/CFNumber.c:39 + unsigned char scalar = 0; + CFNumberGetValue(x, kCFNumberSInt16Type, ); // expected-warning{{A CFNumber object that represents a 16-bit integer is used to initialize an 8-bit integer; 8 bits of the

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

mehdi_amini added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:951 Init = ParseInitializer(); + Init = Actions.CorrectDelayedTyposInExpr(Init.get()); rsmith wrote: > ahatanak wrote: > > mehdi_amini wrote: > > > What happens when

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

rsmith added inline comments. Comment at: lib/Parse/ParseExprCXX.cpp:951 Init = ParseInitializer(); + Init = Actions.CorrectDelayedTyposInExpr(Init.get()); ahatanak wrote: > mehdi_amini wrote: > > What happens when there is no typo

[PATCH] D25206: [Parser] Correct typo after lambda capture initializer is parsed

ahatanak added reviewers: bruno, erik.pilkington, majnemer. ahatanak added a comment. Add more reviewers. https://reviews.llvm.org/D25206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D25343: [OpenCL] Mark group functions as convergent in opencl-c.h

Hello, > As far as I understand the whole problem is that the optimized functions are > marked by __attribute__((pure)). If the attribute is removed from your > example, we get LLVM dump preserving correctness: > > define i32 @bar(i32 %x) local_unnamed_addr #0 { > entry: > %call = tail call

Re: [libcxx] r249738 - Split out of .

Missed one change from the test suite: Index: test/Modules/cstd.m === --- test/Modules/cstd.m (revision 285117) +++ test/Modules/cstd.m (working copy) @@ -1,5 +1,5 @@ // RUN: rm -rf %t -// RUN: %clang_cc1 -fsyntax-only -isystem

Re: [libcxx] r249738 - Split out of .

This was a thinko on my part: clang's builtin headers include_next the system headers, not the other way around, so the system headers should be implicitly textual, not clang's headers. This patch fixes the problem for me with glibc. Does this help for Darwin too? On Tue, Oct 25, 2016 at 2:01 PM,

[PATCH] D25761: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285127: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D25761?vs=75174=75801#toc Repository: rL LLVM

r285127 - Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation.

Author: srhines Date: Tue Oct 25 16:44:35 2016 New Revision: 285127 URL: http://llvm.org/viewvc/llvm-project?rev=285127=rev Log: Use linker flag --fix-cortex-a53-843419 on Android ARM64 compilation. Summary: This is only forced on if there is no non-Cortex-A53 CPU specified as well. Android's

r285126 - CodeGen: be more conservative about setting section

Author: compnerd Date: Tue Oct 25 16:43:28 2016 New Revision: 285126 URL: http://llvm.org/viewvc/llvm-project?rev=285126=rev Log: CodeGen: be more conservative about setting section The section names currently are MachO specific. Only set the section on the variables if the file format is

[PATCH] D25954: [OpenCL] Add missing atom_xor for 64 bit to opencl-c.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL285125: [OpenCL] Add missing atom_xor for 64 bit to opencl-c.h (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D25954?vs=75740=75797#toc Repository: rL LLVM

r285125 - [OpenCL] Add missing atom_xor for 64 bit to opencl-c.h

Author: yaxunl Date: Tue Oct 25 16:37:05 2016 New Revision: 285125 URL: http://llvm.org/viewvc/llvm-project?rev=285125=rev Log: [OpenCL] Add missing atom_xor for 64 bit to opencl-c.h Differential Revision: https://reviews.llvm.org/D25954 Modified: cfe/trunk/lib/Headers/opencl-c.h Modified:

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:94 + else if (isa(RS)) { +// FIXME: Presence of an IVar region has priority over this branch, because +// ObjC objects are on the heap even if the core doesn't realize this.

[PATCH] D25954: [OpenCL] Add missing atom_xor for 64 bit to opencl-c.h

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D25954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285120 - [index] Fixes for locations and relations in Objective C categories and getters/setters

Author: akirtzidis Date: Tue Oct 25 16:11:22 2016 New Revision: 285120 URL: http://llvm.org/viewvc/llvm-project?rev=285120=rev Log: [index] Fixes for locations and relations in Objective C categories and getters/setters - Add entries for protocols on categories - Add relation between categories

Re: [libcxx] r249738 - Split out of .

On Mon, Oct 24, 2016 at 4:58 PM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Oct 24, 2016 at 4:17 PM, Richard Smith > wrote: > > On Mon, Oct 24, 2016 at 3:30 PM, Bruno Cardoso Lopes > > wrote: > >> > >> >

[libcxx] r285117 - Fix nullptr tests

Author: ericwf Date: Tue Oct 25 15:45:17 2016 New Revision: 285117 URL: http://llvm.org/viewvc/llvm-project?rev=285117=rev Log: Fix nullptr tests Modified: libcxx/trunk/include/__nullptr libcxx/trunk/test/std/language.support/support.types/nullptr_t.pass.cpp Modified:

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a reviewer: beanz. mgorny added a subscriber: beanz. mgorny added a comment. @beanz, could you also look at this one? I'd like to replace CLANG_LIBDIR_SUFFIX with the runtimes suffix, and for this I'd have to get rid of this CLANG_LIBDIR_SUFFIX occurrence as well. However, I don't

[libcxxabi] r285107 - Get libc++abi building with LLVM_ENABLE_MODULES

Author: ericwf Date: Tue Oct 25 15:07:49 2016 New Revision: 285107 URL: http://llvm.org/viewvc/llvm-project?rev=285107=rev Log: Get libc++abi building with LLVM_ENABLE_MODULES Modified: libcxxabi/trunk/src/CMakeLists.txt Modified: libcxxabi/trunk/src/CMakeLists.txt URL:

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499 case Type::Adjusted: - case Type::Decayed: + case Type::Decayed: { // Decayed and adjusted types use the adjusted type in LLVM and DWARF. -return CreateType( -

[libcxx] r285102 - Update revision number in CHANGELOG.TXT

Author: ericwf Date: Tue Oct 25 14:44:38 2016 New Revision: 285102 URL: http://llvm.org/viewvc/llvm-project?rev=285102=rev Log: Update revision number in CHANGELOG.TXT Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT Modified: libcxx/trunk/lib/abi/CHANGELOG.TXT URL:

[libcxx] r285101 - [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

Author: ericwf Date: Tue Oct 25 14:43:44 2016 New Revision: 285101 URL: http://llvm.org/viewvc/llvm-project?rev=285101=rev Log: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib Summary: This patch turns on `-fvisibility-inlines-hidden` when building

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rL285101: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions… (authored by EricWF). Changed prior to commit: https://reviews.llvm.org/D25593?vs=75770=75772#toc Repository:

[PATCH] D25593: [libcxx] Build with -fvisibility-inlines-hidden -- Remove 20 inline definitions from the dylib

EricWF updated this revision to Diff 75770. EricWF added a comment. - Address review comments by adding better documentation in the CHANGELOG.TXT. https://reviews.llvm.org/D25593 Files: CMakeLists.txt lib/abi/CHANGELOG.TXT lib/abi/x86_64-linux-gnu.abilist Index:

[libcxx] r285100 - [libc++] Fix modules build - Rework __refstring definition

Author: ericwf Date: Tue Oct 25 14:33:14 2016 New Revision: 285100 URL: http://llvm.org/viewvc/llvm-project?rev=285100=rev Log: [libc++] Fix modules build - Rework __refstring definition Summary: `__libcpp_refstring` currently has two different definitions. First there is the complete

[PATCH] D25958: [libc++] Silence "unused parameter" warnings in test/support/archetypes.hpp

CaseyCarter created this revision. CaseyCarter added reviewers: EricWF, mclow.lists. CaseyCarter added a subscriber: cfe-commits. Fairly straightforward: simply removes the parameter names from the unused parameters. https://reviews.llvm.org/D25958 Files: test/support/archetypes.hpp

r285098 - Reapply r284265: "[Sema] Refactor context checking for availability diagnostics"

Author: epilk Date: Tue Oct 25 14:05:50 2016 New Revision: 285098 URL: http://llvm.org/viewvc/llvm-project?rev=285098=rev Log: Reapply r284265: "[Sema] Refactor context checking for availability diagnostics" The problem with the original commit was that some of Apple's headers depended on an

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

NoQ added inline comments. Comment at: test/Analysis/CFNumber.c:39 + unsigned char scalar = 0; + CFNumberGetValue(x, kCFNumberSInt16Type, ); // expected-warning{{A CFNumber object that represents a 16-bit integer is used to initialize an 8-bit integer; 8 bits of the

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

jordan_rose added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499 case Type::Adjusted: - case Type::Decayed: + case Type::Decayed: { // Decayed and adjusted types use the adjusted type in LLVM and DWARF. -return CreateType( -

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao updated this revision to Diff 75741. sfantao marked 3 inline comments as done. sfantao added a comment. - Fix typos and use StringRef() instead of const char * to follow what the Driver does today when it comes to specify the bound architectures. https://reviews.llvm.org/D21853 Files:

[PATCH] D25954: [OpenCL] Add missing atom_xor for 64 bit to opencl-c.h

yaxunl created this revision. yaxunl added a reviewer: Anastasia. yaxunl added subscribers: cfe-commits, b-sumner. https://reviews.llvm.org/D25954 Files: lib/Headers/opencl-c.h Index: lib/Headers/opencl-c.h === ---

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

NoQ updated this revision to Diff 75739. NoQ marked 2 inline comments as done. NoQ added a comment. Consider a lot more dispatch_once_t regions: improve diagnostics for local structs containing predicates, find ivar structs with predicates. Address a couple of review comments, discuss the rest.

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

NoQ added inline comments. Comment at: test/Analysis/dispatch-once.m:13 + +void test_stack() { + dispatch_once_t once; dcoughlin wrote: > Should the tests for dispatch_once in unix-fns.c be moved here? In fact we need to de-duplicate code with unix.API's

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao marked 7 inline comments as done. sfantao added a comment. Hi Hal, Thanks for the review! Comments inlined. Comment at: include/clang/Driver/Action.h:504 + /// unbundling action. + struct DependingActionInfoTy final { +/// \brief The tool chain of the depending

[PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

sfantao added a comment. Hi Hal, Thanks for the review! Comment at: lib/Driver/ToolChains.cpp:2854 + case options::OPT_shared: + case options::OPT_static: + case options::OPT_fPIC: hfinkel wrote: > And also? > > case options::OPT_dynamic:

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao added a comment. Hi Hal, Thanks for the review! Comments inlined. Comment at: lib/Driver/Tools.cpp:334 + LksStream << " OpenMP Offload Linker Script.\n"; + LksStream << "*/\n"; + LksStream << "TARGET(binary)\n"; hfinkel wrote: > We should also say

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 75730. sfantao marked 3 inline comments as done. sfantao added a comment. - Address Hal Finkel comments - fix comments/fix linker script comment. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); AlexeySotkin wrote: > bader

[PATCH] D25949: [Driver] Refactor distro detection & classification as a separate API

mgorny created this revision. mgorny added reviewers: bruno, bkramer. mgorny added a subscriber: cfe-commits. Herald added subscribers: modocache, beanz. Refactor the Distro enum along with helper functions into a full-fledged Distro class, inspired by llvm::Triple, and make it a public API. The

[PATCH] D25948: [VFS] Replace TimeValue usage with std::chrono

labath created this revision. labath added reviewers: benlangmuir, zturner. labath added a subscriber: cfe-commits. NFCI https://reviews.llvm.org/D25948 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/FileSystemStatCache.cpp lib/Basic/VirtualFileSystem.cpp

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao updated this revision to Diff 75722. sfantao marked 7 inline comments as done. sfantao added a comment. - Fix typos and add test tht checks phases when OpenMP and CUDA are used simultaneously. https://reviews.llvm.org/D21845 Files: lib/Driver/Driver.cpp

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao added a comment. Hi Hal, Thanks for the review! Fixed the typos in the new diff. Comment at: lib/Driver/Driver.cpp:1949 +SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs)); + // hfinkel wrote: > Since we can have both

[PATCH] D25937: [Sema] -Wunused-variable warning for variables with array types should behave similarly to variables with scalar types

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. There's no reason for this to only consider constant-sized arrays, and you should use getBaseElementTypeUnsafe() so you look through nested array types. That method is a no-op

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

bruno added a comment. Hi, Nice, thanks for working on this! Comment at: lib/Sema/SemaExpr.cpp:8051 + if (!LHSVecType) { +assert(RHSVecType && "RHSVecType is not a vector!"); if (!tryVectorConvertAndSplat(*this, (IsCompAssign ? nullptr : ),

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

mgorny added inline comments. Comment at: unittests/Driver/ToolChainsTest.cpp:154 + "BUG_REPORT_URL=\"https://bugs.debian.org/\"\n;)); + ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem)); +} bruno wrote: >

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

arphaman updated this revision to Diff 75712. arphaman added a comment. The updated patch addresses Richard's comment by making sure the fixit isn't emitted when the destructor call is invalid. Repository: rL LLVM https://reviews.llvm.org/D25817 Files: lib/Sema/SemaExprCXX.cpp

r285076 - [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

Author: mgorny Date: Tue Oct 25 10:33:32 2016 New Revision: 285076 URL: http://llvm.org/viewvc/llvm-project?rev=285076=rev Log: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older Disable the OpenSUSE rules for OpenSUSE versions older than 11 as they are incompatible with the old

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

This revision was automatically updated to reflect the committed changes. Closed by commit rL285076: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D24954?vs=75704=75713#toc Repository: rL LLVM

r285074 - [Driver] Support obtaining active toolchain from gcc-config on Gentoo

Author: mgorny Date: Tue Oct 25 10:07:41 2016 New Revision: 285074 URL: http://llvm.org/viewvc/llvm-project?rev=285074=rev Log: [Driver] Support obtaining active toolchain from gcc-config on Gentoo Support using gcc-config to determine the correct GCC toolchain location on Gentoo. In order to do

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On 2016-Oct-24, at 21:43, Mehdi AMINI wrote: > > mehdi_amini created this revision. > mehdi_amini added a reviewer: dexonsmith. > mehdi_amini added a subscriber: cfe-commits. > > We're only doing it with -flto currently, however it never "hurt" > to pass it, and users

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

bruno added a comment. This is great! Comment at: unittests/Driver/ToolChainsTest.cpp:154 + "BUG_REPORT_URL=\"https://bugs.debian.org/\"\n;)); + ASSERT_EQ(DebianStretch, DetectDistro(DebianStretchSidFileSystem)); +} Can

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. ship it. https://reviews.llvm.org/D25661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 75708. sdardis marked an inline comment as done. sdardis added a comment. Extra testing for cases where the operand on the left of an operation is a vector. Removed two spurious checks for vector types. https://reviews.llvm.org/D25866 Files:

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

This revision was automatically updated to reflect the committed changes. Closed by commit rL285074: [Driver] Support obtaining active toolchain from gcc-config on Gentoo (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25661?vs=75707=75710#toc Repository: rL LLVM

[PATCH] D25661: [Driver] Support obtaining active toolchain from gcc-config on Gentoo

mgorny updated this revision to Diff 75707. mgorny marked 3 inline comments as done. mgorny added a comment. Thanks for the review. Implemented all three suggestions. https://reviews.llvm.org/D25661 Files: lib/Driver/ToolChains.cpp

[PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao added a comment. Hi Hal, Thanks for the review! Comment at: include/clang/Basic/DiagnosticDriverKinds.td:163 +def err_drv_expecting_fopenmp_with_fopenmp_targets : Error< + "The option -fopenmp-targets must be used in conjunction with a -fopenmp option compatible

r285073 - CodeGen: mark protocols as common data

Author: compnerd Date: Tue Oct 25 09:50:44 2016 New Revision: 285073 URL: http://llvm.org/viewvc/llvm-project?rev=285073=rev Log: CodeGen: mark protocols as common data This allows for the coalescing of the protocol declarations. When the protocols are declared in headers, multiple definitions

[PATCH] D25869: [Driver] Add unit tests for DetectDistro()

mgorny planned changes to this revision. mgorny added inline comments. Comment at: unittests/Driver/ToolChainsTest.cpp:15 +// FIXME: I presume this is not the correct way of doing this +#include "../lib/Driver/ToolChains.h" +#include "clang/Basic/VirtualFileSystem.h"

[PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

sfantao updated this revision to Diff 75705. sfantao marked an inline comment as done. sfantao added a comment. - Address Hal Finkel comments - make diagnostic message more informative. https://reviews.llvm.org/D21843 Files: include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D24954: [Driver] Disable OpenSUSE rules for OpenSUSE/SLES 10 and older

mgorny updated this revision to Diff 75704. mgorny added a comment. Updated to perform `.startswith()` check before splitting. https://reviews.llvm.org/D24954 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolChains.cpp

[PATCH] D25935: [OpenCL] Diagnose variadic arguments

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. https://reviews.llvm.org/D25935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25942: Fix crash in implicit default constructor creation for a template record specialization that has a field declaration with an initializer expression

arphaman created this revision. arphaman added reviewers: rjmccall, rsmith. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch fixes a NULL pointer crash that happens when clang is trying to create an implicit default constructor for a

[PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

sfantao updated this revision to Diff 75698. sfantao marked 10 inline comments as done. sfantao added a comment. - Address Hal Finkel suggestions - rename functions/reorder code/fix comments. https://reviews.llvm.org/D21840 Files: include/clang/Driver/Action.h lib/Driver/Driver.cpp Index:

[PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

sfantao added a comment. Hi Hal, Thanks for the review! In https://reviews.llvm.org/D21840#555719, @hfinkel wrote: > The naming here is a bit hard to follow, we have 'dependent action', > 'dependency action', 'depending action', and I think they're all supposed to > mean the same thing. Only

[PATCH] D25936: Fix format string for err_os_log_argument_to_big (currently unused)

sammccall added a comment. In https://reviews.llvm.org/D25936#578341, @mehdi_amini wrote: > Good catch! How did you find this? We've got a library that parses diagnostics that consumes DiagnosticSemaKinds.inc, and it failed to parse this message format. > We need a test though. > (I can

  1   2   >