[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

This revision was automatically updated to reflect the committed changes. Closed by commit rL285266: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument… (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D24799?vs=75452=75980#toc Repository:

r285266 - [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

Author: dberris Date: Wed Oct 26 23:56:14 2016 New Revision: 285266 URL: http://llvm.org/viewvc/llvm-project?rev=285266=rev Log: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed Summary: Added the code which explicitly emits an error in Clang in case

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. Actually I tried again, but still the patch doesn't apply cleanly through git (and it still complains of whitespace issues). Let me go through this manually again, and see whether there are still failures that come up. https://reviews.llvm.org/D24799

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Thanks @rSerge -- I'll land this now. https://reviews.llvm.org/D24799 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26019: [AVX-512] Use scalar vfmsub/vfnmsub mask3 intrinsics instead of inverting the mask argument of a vfmadd intrinsic.

craig.topper created this revision. craig.topper added reviewers: delena, igorb. craig.topper added a subscriber: cfe-commits. Inverting the mask argument currently fails isel and even if that was fixed it does not reflect the intended semantics of the intrinsic.

[PATCH] D25857: [tsan][clang] Introduce a function attribute to disable TSan checking at run time

kubabrecka added a comment. Does this also disable checking for the compiler generated `.cxx_destruct` Obj-C methods? Can we add a testcase both here and into compiler-rt? https://reviews.llvm.org/D25857 ___ cfe-commits mailing list

Re: r285263 - Fix bug when compiling CUDA code with -emit-llvm and -o.

Thank you for fixing this! On Wed, Oct 26, 2016 at 5:53 PM, Samuel Antao via cfe-commits wrote: > Author: sfantao > Date: Wed Oct 26 19:53:34 2016 > New Revision: 285263 > > URL: http://llvm.org/viewvc/llvm-project?rev=285263=rev > Log: > Fix bug when compiling CUDA

[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao added a comment. In https://reviews.llvm.org/D18172#580276, @jlebar wrote: > Hi, Samuel. > > This change introduced a new crash / assertion failure in the driver. > > $ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null > > > Before this patch, we get an error (perhaps not

r285264 - Remove check for -o option in offloading actions builder.

Author: sfantao Date: Wed Oct 26 20:08:58 2016 New Revision: 285264 URL: http://llvm.org/viewvc/llvm-project?rev=285264=rev Log: Remove check for -o option in offloading actions builder. This check is also present when jobs are built, so the offloading builder check is not needed anymore.

r285263 - Fix bug when compiling CUDA code with -emit-llvm and -o.

Author: sfantao Date: Wed Oct 26 19:53:34 2016 New Revision: 285263 URL: http://llvm.org/viewvc/llvm-project?rev=285263=rev Log: Fix bug when compiling CUDA code with -emit-llvm and -o. In this case the device code is not injected into an host action and therefore the user should get an error

[PATCH] D21675: New ODR checker for modules

rtrieu added a comment. In https://reviews.llvm.org/D21675#560297, @rsmith wrote: > There are a bunch of cases here that do this: > > if (auto t = getThing()) > ID.addThing(t); > if (auto t = getOtherThing()) > ID.addThing(t); > > > That will result in hash collisions between objects

[PATCH] D21675: New ODR checker for modules

rtrieu updated this revision to Diff 75970. rtrieu marked 2 inline comments as done. https://reviews.llvm.org/D21675 Files: include/clang/AST/DeclBase.h include/clang/AST/DeclCXX.h include/clang/AST/Stmt.h include/clang/AST/TemplateBase.h include/clang/AST/Type.h

r285258 - Refactor call emission to package the function pointer together with

Author: rjmccall Date: Wed Oct 26 18:46:34 2016 New Revision: 285258 URL: http://llvm.org/viewvc/llvm-project?rev=285258=rev Log: Refactor call emission to package the function pointer together with abstract information about the callee. NFC. The goal here is to make it easier to recognize

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar added a comment. So, good news -- these three builtins are already constexpr-evaluatable. :) I'll add a test. https://reviews.llvm.org/D25403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

mehdi_amini reopened this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Reopen: this hasn't been committed yet apparently. @sashab : are you still interested in moving this forward? https://reviews.llvm.org/D24289

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL285254: Unconditionally pass `-lto_library` to the linker on Darwin (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D25932?vs=75668=75963#toc Repository: rL LLVM

r285254 - Unconditionally pass `-lto_library` to the linker on Darwin

Author: mehdi_amini Date: Wed Oct 26 18:23:08 2016 New Revision: 285254 URL: http://llvm.org/viewvc/llvm-project?rev=285254=rev Log: Unconditionally pass `-lto_library` to the linker on Darwin We're only doing it with -flto currently, however it never "hurt" to pass it, and users that are

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

hfinkel added a comment. In https://reviews.llvm.org/D25403#580444, @jlebar wrote: > //Let "CE" mean "constexpr-evaluatable". // > > libc++ attempts to be backwards-compatible with old versions of clang, right? Yea, we'd need to ifdef the test for older versions of Clang. I've just summarized

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar added a comment. //Let "CE" mean "constexpr-evaluatable". // libc++ attempts to be backwards-compatible with old versions of clang, right? Old versions of clang are going to fail, since the builtin will not be CE. Is the idea to write a test that checks that, if __builtin_isfinite is

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

hfinkel added a comment. In https://reviews.llvm.org/D25403#580439, @jlebar wrote: > > I'm not sure about that. It seems like a useful feature for the builtins to > > have. Logically speaking, they should be constexpr. > > I agree that it's logically correct for the builtins to be >

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

chandlerc added a comment. In https://reviews.llvm.org/D23754#580277, @mgorny wrote: > In https://reviews.llvm.org/D23754#580268, @beanz wrote: > > > @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional > > sense. It more closely aligns with the tools vended by LLVM even

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar added a comment. > I'm not sure about that. It seems like a useful feature for the builtins to > have. Logically speaking, they should be constexpr. I agree that it's logically correct for the builtins to be constexpr-evaluatable. My point is just that doing this work and then writing

[PATCH] D25876: [analyzer] Report CFNumberGetValue API misuse

This revision was automatically updated to reflect the committed changes. Closed by commit rL285253: [analyzer] Report CFNumberGetValue API misuse (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D25876?vs=75488=75961#toc Repository: rL LLVM

r285253 - [analyzer] Report CFNumberGetValue API misuse

Author: zaks Date: Wed Oct 26 17:51:47 2016 New Revision: 285253 URL: http://llvm.org/viewvc/llvm-project?rev=285253=rev Log: [analyzer] Report CFNumberGetValue API misuse This patch contains 2 improvements to the CFNumber checker: - Checking of CFNumberGetValue misuse. - Treating all CFNumber

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

hfinkel added a comment. In https://reviews.llvm.org/D25403#580432, @jlebar wrote: > In https://reviews.llvm.org/D25403#580422, @hfinkel wrote: > > > Okay. Why not fix the Clang builtins so that they're evaluatable for > > constant inputs in a constexpr context? Then we can do this and test the

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar added a comment. In https://reviews.llvm.org/D25403#580422, @hfinkel wrote: > Okay. Why not fix the Clang builtins so that they're evaluatable for constant > inputs in a constexpr context? Then we can do this and test the change. I am not sure how much value we would derive from

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

hfinkel added a comment. In https://reviews.llvm.org/D25403#580416, @jlebar wrote: > > Is this because the functions are in instead of in are > > you don't want to mark all of as host/device? > > Yes. cmath is its own beast; we need to have our own implementation of it in > order to direct

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

jlebar added a comment. > Is this because the functions are in instead of in are you > don't want to mark all of as host/device? Yes. cmath is its own beast; we need to have our own implementation of it in order to direct the std functions to the appropriate low-level device functions.

[PATCH] D25403: [CUDA] Mark __libcpp_{isnan, isinf, isfinite} as constexpr.

hfinkel added a comment. ... > > >> I guess I don't understand the motivation for this change. > > To make work in CUDA, we do the following terrible, awful, > horrible, no good thing: ...well, I can just show you the code. >

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Driver/Tools.cpp:334 + LksStream << " OpenMP Offload Linker Script.\n"; + LksStream << "*/\n"; + LksStream << "TARGET(binary)\n";

r285251 - [CUDA] Move device placement new definitions into a wrapper header.

Author: jlebar Date: Wed Oct 26 17:13:26 2016 New Revision: 285251 URL: http://llvm.org/viewvc/llvm-project?rev=285251=rev Log: [CUDA] Move device placement new definitions into a wrapper header. Previously, these were always included -- after this change, you have to #include , which is

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Driver/Driver.cpp:2091 +InputArg->getOption().getKind() == llvm::opt::Option::InputClass && +!types::isSrcFile(HostAction->getType()))

[PATCH] D21848: [Driver][OpenMP] Add logic for offloading-specific argument translation.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285250 - [CUDA] Switch cuda_wrappers/complex to use a proper include guard instead of #pragma once.

Author: jlebar Date: Wed Oct 26 17:13:20 2016 New Revision: 285250 URL: http://llvm.org/viewvc/llvm-project?rev=285250=rev Log: [CUDA] Switch cuda_wrappers/complex to use a proper include guard instead of #pragma once. This is consistent with the rest of our internal headers. Modified:

[PATCH] D25556: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list

ahatanak updated this revision to Diff 75956. ahatanak added a comment. Add the variable to the list of potential captures only if it's declared outside of the lambda expression. I don't think we need to check that the variable is declared outside of the lambda because

[PATCH] D21843: [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21840: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25925: [clang-tidy] Update cert-err58-cpp to match its new generalised form.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D25925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman added a comment. In https://reviews.llvm.org/D22346#580242, @falho wrote: > removed semicolon, and replaced it with a comma that only appears in .cpp > diagnostics The semicolon was the correct punctuator to use, but thank you for moving it into the cpp message. > test cases

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho updated this revision to Diff 75935. falho marked an inline comment as done. falho added a comment. removed semicolon, and replaced it with a comma that only appears in .cpp diagnostics test cases corrected according to this removed junk .swo file https://reviews.llvm.org/D22346 Files:

[PATCH] D25925: [clang-tidy] Update cert-err58-cpp to match its new generalised form.

malcolm.parsons updated this revision to Diff 75951. malcolm.parsons added a comment. Add more tests. https://reviews.llvm.org/D25925 Files: clang-tidy/cert/StaticObjectExceptionCheck.cpp docs/clang-tidy/checks/cert-err58-cpp.rst test/clang-tidy/cert-static-object-exception.cpp Index:

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:274 +if (Invalid) + continue; +std::ofstream OutFile(FilePath.c_str()); zaks.anna wrote: > Would it be better to break if the buffer is invalid? > Should this be

[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao added a comment. Hi Justin Thanks for letting me know. I'm looking into it. Thanks again, Samuel Repository: rL LLVM https://reviews.llvm.org/D18172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25204: Register Calling Convention, Clang changes

joerg added a comment. Can we please avoid adding more (pseudo) keywords in the double-underscore name space? Those tend to be used a lot by existing libc implementations and existing attribute cases like __strong and __weak have created enough trouble. https://reviews.llvm.org/D25204

[PATCH] D25898: [clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()

malcolm.parsons updated this revision to Diff 75947. malcolm.parsons added a comment. Remove braces. Use Twine. https://reviews.llvm.org/D25898 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h docs/ReleaseNotes.rst

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

zaks.anna added a comment. Please, add multi-file tests and tests where a line is covered more than once. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262 + +static void dumpCoverageInfo(llvm::SmallVectorImpl , + SourceManager ) {

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

mgorny added a comment. In https://reviews.llvm.org/D23754#580268, @beanz wrote: > @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional > sense. It more closely aligns with the tools vended by LLVM even though it is > a shared library not an executable. > > Runtime

[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

jlebar added a comment. Hi, Samuel. This change introduced a new crash / assertion failure in the driver. $ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null Before this patch, we get an error (perhaps not as helpful as we might want, but still): clang-3.8: error: cannot specify

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

beanz added a comment. @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional sense. It more closely aligns with the tools vended by LLVM even though it is a shared library not an executable. Runtime libraries are specifically libraries that products of clang are linked

[PATCH] D25992: [RecursiveASTVisitor] Visit the implicit expression of a CXXDefaultArgExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL285239: [RecursiveASTVisitor] Visit the implicit expression of a CXXDefaultArgExpr (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D25992?vs=75899=75944#toc

r285239 - [RecursiveASTVisitor] Visit the implicit expression of a CXXDefaultArgExpr

Author: malcolm.parsons Date: Wed Oct 26 15:39:54 2016 New Revision: 285239 URL: http://llvm.org/viewvc/llvm-project?rev=285239=rev Log: [RecursiveASTVisitor] Visit the implicit expression of a CXXDefaultArgExpr Summary: The matcher varDecl(hasDescendant(

[PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many elements are allocated

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I appreciate the doc for each of the magic numbers. https://reviews.llvm.org/D25483 ___ cfe-commits mailing list

[PATCH] D26007: [libc++] Cleanup non-portable std::any tests

EricWF added inline comments. Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:36 +using DecayTag = std::decay_t; +static_assert(!std::is_constructible::value, ""); +} CaseyCarter wrote: > I'm generously calling

[PATCH] D26007: [libc++] Cleanup non-portable std::any tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL285234: Cleanup nonportable behavior in tests for std::any (authored by CaseyCarter). Changed prior to commit: https://reviews.llvm.org/D26007?vs=75936=75938#toc Repository: rL LLVM

[libcxx] r285234 - Cleanup nonportable behavior in tests for std::any

Author: caseycarter Date: Wed Oct 26 15:18:13 2016 New Revision: 285234 URL: http://llvm.org/viewvc/llvm-project?rev=285234=rev Log: Cleanup nonportable behavior in tests for std::any Fixes MS issues 63, 64, and 65. test/std/utilities/any/any.class/any.cons/move.pass.cpp: * "Moves are always

[PATCH] D26007: [libc++] Cleanup non-portable std::any tests

CaseyCarter marked 2 inline comments as done. CaseyCarter added a comment. DecayTag destroyed. https://reviews.llvm.org/D26007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26007: [libc++] Cleanup non-portable std::any tests

CaseyCarter removed rL LLVM as the repository for this revision. CaseyCarter updated this revision to Diff 75936. CaseyCarter added a comment. Cleanup nonportable behavior in tests for `std::any` Fixes MS issues 63, 64, and 65. test/std/utilities/any/any.class/any.cons/move.pass.cpp: - "Moves

[PATCH] D25995: Add documentation for transparent_union attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the improved docs! Repository: rL LLVM https://reviews.llvm.org/D25995 ___ cfe-commits mailing list

[PATCH] D25992: [RecursiveASTVisitor] Visit the implicit expression of a CXXDefaultArgExpr

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D25992 ___ cfe-commits mailing list

[PATCH] D26007: [libc++] Cleanup non-portable std::any tests

EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:1 +//===--===// +//

[PATCH] D25898: [clang-tidy] Enhance modernize-make-unique to handle unique_ptr.reset()

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:74 + if (Construct) { +checkConstruct(SM, Construct, Type, New); Can elide the braces for the `if` and `else`. Comment at:

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

rsmith added inline comments. Comment at: include/clang/Lex/Preprocessor.h:283-286 + Off = 0, + Recording = 1, + Replaying = 2, + Done = 3 What's the difference between the `Off` and `Done` states? They seem to be the same to me?

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

erikjv added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2061-2062 + auto Builder = Diag(R.getNameLoc(), diagnostic) << Name; + if (Name.isIdentifier()) +Builder << SourceRange(R.getNameLoc()); return true; rsmith wrote: > I'm indifferent on this

[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2509 +to suppress specific clang-tidy warnings. They can be attached to a scope, +statement or type. The ``[[gsl::suppress]]`` is an alias of ``[[clang::suppress]]`` +which is intended to be used

[PATCH] D26007: [libc++] Cleanup non-portable std::any tests

CaseyCarter added inline comments. Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:36 +using DecayTag = std::decay_t; +static_assert(!std::is_constructible::value, ""); +} I'm generously calling this a "libc++

[PATCH] D26007: [libc++] Cleanup non-portable std::any tests

CaseyCarter created this revision. CaseyCarter added reviewers: EricWF, mclow.lists. CaseyCarter added a subscriber: cfe-commits. CaseyCarter set the repository for this revision to rL LLVM. Cleanup nonportable behavior in tests for `std::any` Fixes MS issues 63, 64, and 65.

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

rsmith added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2061-2062 + auto Builder = Diag(R.getNameLoc(), diagnostic) << Name; + if (Name.isIdentifier()) +Builder << SourceRange(R.getNameLoc()); return true; I'm indifferent on this change: I don't

[PATCH] D24085: arm: Fix ttype encoding assertion failure.

mclow.lists added inline comments. Comment at: src/cxa_personality.cpp:363 + "Unexpected TTypeEncoding"); (void)ttypeEncoding; logan wrote: > mclow.lists wrote: > > It's not clear to me how this accomplishes what you want. > > You're looking for

[PATCH] D25958: [libc++] Silence "unused parameter" warnings in test/support/archetypes.hpp

CaseyCarter closed this revision. CaseyCarter added a comment. Committed as r285213. https://reviews.llvm.org/D25958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:26 + unless(hasAnyTemplateArgument(refersToType(voidType(, + hasAnyName("::std::plus", "::std::minus", "::std::multiplies", + "::std::divides",

[PATCH] D25985: [analyzer] Export coverage information from the analyzer.

xazax.hun removed rL LLVM as the repository for this revision. xazax.hun updated this revision to Diff 75923. https://reviews.llvm.org/D25985 Files: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h lib/StaticAnalyzer/Core/AnalyzerOptions.cpp lib/StaticAnalyzer/Core/ExprEngine.cpp

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman added a comment. clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo was added and should not have been; also, there's one minor issue with the diagnostic wording that is still outstanding. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35 +

[PATCH] D26002: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion

syzaara created this revision. syzaara added reviewers: nemanjai, kbarton, amehsan, sfertile, jtony, lei. syzaara added subscribers: cfe-commits, echristo. Implement builtins for prototypes: signed int vec_cntlz_lsbb (vector signed char); signed int vec_cntlz_lsbb (vector unsigned char); signed

[PATCH] D25604: Add support for Mageia Linux

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Please add a stub tree and tests. You can find similar tests for other Linux distros in 'tests/Driver'. https://reviews.llvm.org/D25604

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane updated this revision to Diff 75919. https://reviews.llvm.org/D25204 Files: include/clang-c/Index.h include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/Specifiers.h include/clang/Basic/TokenKinds.def lib/AST/Expr.cpp

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane marked 8 inline comments as done. erichkeane added a comment. New diff coming that fixes Reid & David's comments https://reviews.llvm.org/D25204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25204: Register Calling Convention, Clang changes

majnemer added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:433 Out << Prefix; + mangleName(D); Please remove this stray newline. Comment at: lib/CodeGen/TargetInfo.cpp: + if (classifyArgumentType(FD->getType(), +

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

aaron.ballman requested changes to this revision. aaron.ballman added inline comments. This revision now requires changes to proceed. Comment at: include/clang/Basic/Attr.td:1291 + let Subjects = SubjectList<[ObjCInterface], ErrorDiag>; + let Documentation = [Undocumented]; +}

[libcxx] r285213 - Silence unused parameter warnings in archetypes.hpp

Author: caseycarter Date: Wed Oct 26 12:22:25 2016 New Revision: 285213 URL: http://llvm.org/viewvc/llvm-project?rev=285213=rev Log: Silence unused parameter warnings in archetypes.hpp Reviewed at: https://reviews.llvm.org/D25958 Modified: libcxx/trunk/test/support/archetypes.hpp Modified:

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

manmanren accepted this revision. manmanren added a reviewer: manmanren. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman Repository: rL LLVM https://reviews.llvm.org/D25993 ___ cfe-commits mailing list

Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

If you're working on it, let's just wait for that :-) On Wed, Oct 26, 2016 at 12:01 PM, Erik Pilkington wrote: > Hi Nico, > All that is left for the diagnostic to make sense it CodeGen support for > @available, which is something I’m working on now. I should have a

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

hiraditya updated this revision to Diff 75915. hiraditya added a comment. Added macro to keep the definition of destructor of basic_string in string.cpp https://reviews.llvm.org/D25624 Files: libcxx/include/string libcxx/src/string.cpp Index: libcxx/src/string.cpp

[PATCH] D25937: [Sema] -Wunused-variable warning for variables with array types should behave similarly to variables with scalar types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Please add a line testing the nested-array case to warn-unused-variables.cpp, but with that, LGTM. Repository: rL LLVM https://reviews.llvm.org/D25937

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

jordan_rose added a comment. Looks good from my end. Repository: rL LLVM https://reviews.llvm.org/D25993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25204: Register Calling Convention, Clang changes

rnk added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1263 +On x86 targets, this attribute changes the calling convention to +__regcall convention. This convention aims to pass as many arguments +as possible in registers. It also tries to utilize registers for

r285211 - AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.

Author: yaxunl Date: Wed Oct 26 11:40:21 2016 New Revision: 285211 URL: http://llvm.org/viewvc/llvm-project?rev=285211=rev Log: AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x. Patch by Laurent Morichetti. Differential Revision: https://reviews.llvm.org/D25920 Modified:

[PATCH] D25920: AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285211: AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x. (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D25920?vs=75627=75912#toc Repository: rL LLVM

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

sebpop marked 2 inline comments as done. sebpop added inline comments. Comment at: libcxx/include/memory:3802 +{ + return __libcpp_atomic_add(, 1, _AO_Relaxed); +} EricWF wrote: > Why add `increment` and `decrement` at all? Just manually inline >

[PATCH] D24991: Inline hot functions in libcxx shared_ptr implementation.

sebpop removed rL LLVM as the repository for this revision. sebpop updated this revision to Diff 75908. sebpop added a comment. The patch also implements the idea that Marshall proposed in: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161010/173780.html > I have an idea; it involves

[PATCH] D25920: AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.

tstellarAMD added a comment. LGTM. https://reviews.llvm.org/D25920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25995: Add documentation for transparent_union attribute

arphaman created this revision. arphaman added a reviewer: aaron.ballman. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a bit of documentation for the `transparent_union` attribute. Repository: rL LLVM

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane added a comment. After much debate, the architects have agreed to change the "Decoration" section to the following. The next patch does these, so I'm ready for continued review. Thanks for your patience! -Erich __regcall Decoration Names of functions that use __regcall are

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane updated this revision to Diff 75903. erichkeane added a comment. Corrected Decoration settings to match the soon-to-be-updated spec. https://reviews.llvm.org/D25204 Files: include/clang-c/Index.h include/clang/AST/Type.h include/clang/Basic/Attr.td

Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

Hi Nico, All that is left for the diagnostic to make sense it CodeGen support for @available, which is something I’m working on now. I should have a patch up for it in a couple days. I suppose it was a mistake to mention upgrading to something that doesn’t work yet, if this is an inconvenience

r285206 - [CMake] Adding example distribution CMake cache files

Author: cbieneman Date: Wed Oct 26 10:41:38 2016 New Revision: 285206 URL: http://llvm.org/viewvc/llvm-project?rev=285206=rev Log: [CMake] Adding example distribution CMake cache files These cache file are provided as an example of how to set up simple multi-stage CMake builds. I have a batch

[PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

thakis added a comment. Erik, are you planning on adding the later phases soon? At the moment, due to this patch, clang emits "enclose 'setAllowsAutomaticWindowTabbing:' in an @available check to silence this warning" but then errors out when trying to use @available. This is proving to be

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); Anastasia wrote: >

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

AlexeySotkin updated this revision to Diff 75893. AlexeySotkin added a comment. Setting UnnamedAddr to Global https://reviews.llvm.org/D25305 Files: lib/CodeGen/CGDecl.cpp test/CodeGenOpenCL/private-array-initialization.cl Index: test/CodeGenOpenCL/private-array-initialization.cl

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

arphaman created this revision. arphaman added reviewers: aaron.ballman, jordan_rose. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds an `objc_subclassing_restricted` attribute into clang. This attribute acts similarly to

  1   2   >