[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, thanks. Comment at: clang/lib/Sema/SemaDecl.cpp:5762-5768 -#ifndef NDEBUG - // AST quite reasonably asserts that it's working on a function - // definition.

[PATCH] D26062: Alternative solution for detecting libc++'s version.

rsmith added a comment. This is perfect for my needs, thanks! https://reviews.llvm.org/D26062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added a comment. I found a bug in this which I need to fix, but while I'm at it, in doing more testing on this, I came across the following corner case: template struct static_separate_template { typedef T element; static T *a_static_field; }; extern template

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

ddcc added a comment. To summarize, here is a list of changes: - General - Fixed some issues with formatting (`clang-format`) - Fixed inconsistent capitalization following camel case style guidelines - `ConstraintManager.h` - Renamed `assumeWithinInclusiveRange*()` to

[PATCH] D26044: Factor out libc++ version file to allow Clang to more easily sniff for the installed version

EricWF added a comment. @rsmith I would really like to avoid the cost of an additional include in `<__config>`. Would something like https://reviews.llvm.org/D26062 work instead? Repository: rL LLVM https://reviews.llvm.org/D26044 ___

[PATCH] D26062: Alternative solution for detecting libc++'s version.

EricWF created this revision. EricWF added reviewers: rsmith, mclow.lists. EricWF added subscribers: cfe-commits, rsmith. This patch presents an alternative approach to adding a <__version> header and including it from <__config>. Instead of using a `<__version>` header this patch adds a

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added subscribers: cfe-commits, rgov, NoQ, xazax.hun. Herald added a subscriber: mgorny. SimpleConstraintManager is difficult to use, and makes assumptions about capabilities of the constraint manager. This patch

r285378 - [Modules] Make test from r285377 darwin specific

Author: bruno Date: Thu Oct 27 21:37:04 2016 New Revision: 285378 URL: http://llvm.org/viewvc/llvm-project?rev=285378=rev Log: [Modules] Make test from r285377 darwin specific Appease buildbots: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55876 Modified:

r285377 - [Modules] Add testcase for builtins used in umbrella headers

Author: bruno Date: Thu Oct 27 21:30:45 2016 New Revision: 285377 URL: http://llvm.org/viewvc/llvm-project?rev=285377=rev Log: [Modules] Add testcase for builtins used in umbrella headers This used to work before r284797 + r285152, which exposed something interesting; some users include builtins

[PATCH] D26002: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion

syzaara updated this revision to Diff 76110. syzaara added a comment. Remove extra blank line. https://reviews.llvm.org/D26002 Files: include/clang/Basic/BuiltinsPPC.def lib/Headers/altivec.h test/CodeGen/builtins-ppc-p9vector.c Index: test/CodeGen/builtins-ppc-p9vector.c

[PATCH] D26057: [coroutines] Add CoawaitDependentExpr AST node and use it to properly build await_transform.

EricWF added inline comments. Comment at: lib/AST/ExprClassification.cpp:191 case Expr::DesignatedInitUpdateExprClass: + // FIXME How should we classify co_await expressions while they're still + // dependent? @rsmith: What's the correct way to classify

[PATCH] D26057: [coroutines] Add CoawaitDependentExpr AST node and use it to properly build await_transform.

EricWF updated this revision to Diff 76157. EricWF added a comment. - Remove old FIXME - Correct doc for CoawaitDependentExpr. https://reviews.llvm.org/D26057 Files: include/clang/AST/ExprCXX.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D26057: [coroutines] Add CoawaitDependentExpr AST node and use it to properly build await_transform.

EricWF created this revision. EricWF added reviewers: rsmith, GorNishanov. EricWF added subscribers: cfe-commits, rsmith. Herald added a subscriber: mehdi_amini. This patch has two primary changes: 1. Defines a new AST node `CoawaitDependentExpr` for representing co_await expressions while the

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

spyffe created this revision. spyffe added reviewers: bruno, akyrtzi, a.sidorin. spyffe added a subscriber: cfe-commits. When the `ASTImporter`imports a source location, it avoids importing macro expansions by calling `getSpellingLoc()`. That's great in most cases, but for macros defined in

r285370 - Fix a crash on invalid code.

Author: rtrieu Date: Thu Oct 27 19:15:24 2016 New Revision: 285370 URL: http://llvm.org/viewvc/llvm-project?rev=285370=rev Log: Fix a crash on invalid code. The diagnostic was attempting to access the QualType of a TypeDecl by calling TypeDecl::getTypeForDecl. However, the Type pointer stored

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

jlebar added a comment. OK, I can add new flags with the best of 'em. I got rid of a super ugly hack I found that was working around the same problem I was trying to work around here. (And I verified that if I don't call setWillHaveBody, a testcase fails.) I can split this out into two

[PATCH] D25640: [CUDA] [AST] Allow isInlineDefinitionExternallyVisible to be called on functions without bodies.

jlebar updated this revision to Diff 76118. jlebar added a comment. Add WillHaveBody flag. https://reviews.llvm.org/D25640 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Sema/SemaDecl.cpp clang/test/SemaCUDA/gnu-inline.cu Index:

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane updated this revision to Diff 76117. erichkeane added a comment. Remove single-underscore version of _regcall kw. https://reviews.llvm.org/D25204 Files: include/clang-c/Index.h include/clang/AST/Type.h include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D26044: Factor out libc++ version file to allow Clang to more easily sniff for the installed version

rsmith created this revision. rsmith added reviewers: mclow.lists, EricWF. rsmith added a subscriber: cfe-commits. rsmith set the repository for this revision to rL LLVM. Clang would like to enable some language-version-specific functionality only if the installed C++ standard library supports

[PATCH] D25204: Register Calling Convention, Clang changes

rnk added a comment. In https://reviews.llvm.org/D25204#581477, @erichkeane wrote: > In general, I can see the benefit of this rule, however in the case of > calling conventions, I would think that keeping them all orthogonal is > important. Having "most" calling conventions work one way, and

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

dberris added a comment. It was in the .cpp file, and was mostly trailing whitespace. This is what I did: curl https://reviews.llvm.org/file/data/d72xn56ybspvx3ovex36/PHID-FILE-vzd63mvia62eq7e32iho/D24799.diff | git apply - -p0 --whitespace=fix And I got the following: :6: trailing

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane added a comment. In https://reviews.llvm.org/D25204#581469, @rnk wrote: > Remember the fight over _Atomic with MSVC's STL? The fallacy of the > implementer's namespace is that there is only one implementer. > https://llvm.org/bugs/show_bug.cgi?id=19043 > > We should prefer adding

[PATCH] D25204: Register Calling Convention, Clang changes

rnk added a comment. Remember the fight over _Atomic with MSVC's STL? The fallacy of the implementer's namespace is that there is only one implementer. https://llvm.org/bugs/show_bug.cgi?id=19043 We should prefer adding `__attribute__`s and `__declspec`s instead of keywords when possible.

[libcxx] r285352 - [libcxx] Make regex_match backtrack when search fails

Author: timshen Date: Thu Oct 27 16:40:34 2016 New Revision: 285352 URL: http://llvm.org/viewvc/llvm-project?rev=285352=rev Log: [libcxx] Make regex_match backtrack when search fails Summary: Fixes PR19851. alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out locale-related

[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails

This revision was automatically updated to reflect the committed changes. timshen marked an inline comment as done. Closed by commit rL285352: [libcxx] Make regex_match backtrack when search fails (authored by timshen). Changed prior to commit:

r285349 - [docs] Update the TSan and MSan docs to refer to the new no_sanitize attribute

Author: zaks Date: Thu Oct 27 16:38:44 2016 New Revision: 285349 URL: http://llvm.org/viewvc/llvm-project?rev=285349=rev Log: [docs] Update the TSan and MSan docs to refer to the new no_sanitize attribute TSan and MSan were the only remaining sanitizers referring to the deprecated attribute for

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. In https://reviews.llvm.org/D23752#581436, @mgorny wrote: > This really doesn't solve the problems we have. We don't want to build and > install two almost-identical copies of compiler-rt and clang headers, when we > can just build one and make clang use it.

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added a comment. This really doesn't solve the problems we have. We don't want to build and install two almost-identical copies of compiler-rt and clang headers, when we can just build one and make clang use it. https://reviews.llvm.org/D23752

Re: r285281 - Fix MSVC warning about missing 'this' from lambda default capture mode

> On 27 Oct 2016, at 13:25, Erik Verbruggen wrote: > > Eh? Preprocessor::IsFileLexer(const IncludeStackInfo &) is static and doesn't > need 'this'... Apparently MSVC mistakingly confuses that method with the > non-static Preprocessor::IsFileLexer() method? You’re not

[PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many elements are allocated

STL_MSFT closed this revision. STL_MSFT added a comment. Committed r285346. Thanks!! https://reviews.llvm.org/D25483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. In https://reviews.llvm.org/D23752#581427, @mgorny wrote: > In https://reviews.llvm.org/D23752#581416, @chandlerc wrote: > > > I don't get it. > > > > There is nothing "RUNTIMES" about it. And this variable is actually used to > > produce real libraries: libclang,

[libcxx] r285346 - [PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many elements are allocated

Author: stl_msft Date: Thu Oct 27 16:25:12 2016 New Revision: 285346 URL: http://llvm.org/viewvc/llvm-project?rev=285346=rev Log: [PATCH] D25483: [libcxx] [test] Fix non-Standard assumptions about how many elements are allocated Modified:

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

mgorny added a comment. In https://reviews.llvm.org/D23752#581416, @chandlerc wrote: > I don't get it. > > There is nothing "RUNTIMES" about it. And this variable is actually used to > produce real libraries: libclang, etc. > > It's just the LIBDIR_SUFFIX. That's it. The reason it is called >

[PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro set the repository for this revision to rL LLVM. loladiro updated this revision to Diff 76102. loladiro added a comment. Rebased on current master. Repository: rL LLVM https://reviews.llvm.org/D13330 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

chandlerc added a comment. I don't get it. There is nothing "RUNTIMES" about it. And this variable is actually used to produce real libraries: libclang, etc. It's just the LIBDIR_SUFFIX. That's it. The reason it is called CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

zaks.anna added a comment. >> Actually, I always test first on real code, and it seemed to be inlined. But >> now, even if I >> removed the pragma it was not inlined. Looks like this patch is interfering with this inlining suppression. We had many false positives without it. Mainly, the

[PATCH] D13330: Implement __attribute__((unique_instantiation))

majnemer added a comment. I think this looks good but I'd like @rsmith to take a look. https://reviews.llvm.org/D13330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285341 - Add documentation describing the components of a complete toolchain including Clang.

Author: rsmith Date: Thu Oct 27 15:55:56 2016 New Revision: 285341 URL: http://llvm.org/viewvc/llvm-project?rev=285341=rev Log: Add documentation describing the components of a complete toolchain including Clang. Added: cfe/trunk/docs/Toolchain.rst Modified:

[PATCH] D25654: [Sema] Don't perform aggregate initialization for types with explicit constructors

EricWF updated this revision to Diff 76095. EricWF added a comment. - Disallow classes with inherited constructors - Add tests under `test/CXX/drs/dr15xx.cpp` I still only implemented this change in C++1z, please let me know if you want me to backport the DR. https://reviews.llvm.org/D25654

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

dcoughlin accepted this revision. dcoughlin added a comment. LGTM. Comment at: test/Analysis/number-object-conversion.m:98 + +#define NULL_INSIDE_MACRO NULL +void test_NULL_inside_macro(NSNumber *p) { This is great! And a good catch.

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro added a comment. Hmm, the rebased version of this introduces new errors in `test/Modules/cxx-templates.cpp`. That test didn't exist when I wrote this code and I'm not familiar with templates. @rsmith could you take a look, error is: error: 'error' diagnostics seen but not expected:

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro updated this revision to Diff 76094. loladiro added a comment. Rebased patch Repository: rL LLVM https://reviews.llvm.org/D13419 Files: lib/AST/Decl.cpp lib/AST/DeclCXX.cpp test/CodeGenCXX/visibility.cpp Index: test/CodeGenCXX/visibility.cpp

[PATCH] D25657: include-fixer: Don't overwrite buffer changes

Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in https://reviews.llvm.org/rL285060. Please specify "Differential revision: " as last line of commit message. https://reviews.llvm.org/D25657 ___ cfe-commits mailing

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

beanz added a comment. This looks like it is in the direction I would expect. Please let me know once the final patch is ready. Comment at: lib/Driver/Tools.cpp:2021 std::string Plugin = - ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so"; +

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho added a comment. Cool! Thank you for the reviews! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for working on this! https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

falho updated this revision to Diff 76072. falho marked an inline comment as done. falho added a comment. in cpp diagnostics message: comma changed back to semicolon, + curly braces removed testfiles corrected accordingly https://reviews.llvm.org/D22346 Files:

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

jwhowarth added a comment. In https://reviews.llvm.org/D25932#581167, @mehdi_amini wrote: > I just verified that I reproduce with -flto and an previous clang version. This issue will only be triggered if you build with "-DCMAKE_INSTALL_PREFIX:PATH=/sw/opt/llvm-4.0" to place llvm in a buried

[PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

loladiro added a comment. Ok then, will commit. Repository: rL LLVM https://reviews.llvm.org/D24372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro added a comment. Since this was approved, I'll rebase and commit. Repository: rL LLVM https://reviews.llvm.org/D13419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails

timshen updated this revision to Diff 76088. timshen added a comment. Added http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2273 as comments. https://reviews.llvm.org/D26026 Files: libcxx/include/regex libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp Index:

[PATCH] D13330: Implement __attribute__((unique_instantiation))

loladiro added a comment. I came across a situation again where this would be useful to have. I know this was approved, but looking it looks like I wanted @majnemer to have another look. https://reviews.llvm.org/D13330 ___ cfe-commits mailing list

[PATCH] D26026: [libcxx] Make regex_match backtrack when search fails

timshen marked an inline comment as done. timshen added inline comments. Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374 std::cmatch m; const char s[] = "tournament"; +assert(std::regex_match(s, m,

[PATCH] D26002: Implement vector count leading/trailing bytes with zero lsb and vector parity builtins - clang portion

kbarton accepted this revision. kbarton added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

LLVM buildmaster will be updated and restarted at 3 PM Pacific time today

Hello everyone, LLVM buildmaster will be updated and restarted at 3 PM Pacific time today. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25204: Register Calling Convention, Clang changes

joerg added a comment. The __ namespace is shared between all parts of the implementation, not just the compiler. The convention in the past was that compiler keywords will end in a __ as well, but calling conventions and Objective C broke that convention. I still think it is something that

[PATCH] D21845: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

sfantao added a comment. A PR was generated as requested by Hal explaining why we do not generate jobs for NVPTX targets yet. https://llvm.org/bugs/show_bug.cgi?id=30812 https://reviews.llvm.org/D21845 ___ cfe-commits mailing list

[PATCH] D26041: [clang-tidy] Extend misc-use-after-move to support unique_ptr and shared_ptr.

mboehme created this revision. mboehme added a reviewer: alexfh. mboehme added a subscriber: cfe-commits. As a unique_ptr or shared_ptr that has been moved from is guaranteed to be null, we only warn if the pointer is dereferenced. https://reviews.llvm.org/D26041 Files:

r285331 - [coroutines] Add diagnostics for copy/move assignment operators and functions with deduced return types.

Author: ericwf Date: Thu Oct 27 13:43:28 2016 New Revision: 285331 URL: http://llvm.org/viewvc/llvm-project?rev=285331=rev Log: [coroutines] Add diagnostics for copy/move assignment operators and functions with deduced return types. Summary: The title says it all. Additionally this patch

[PATCH] D25292: [coroutines] Add diagnostics for copy/move assignment operators and functions with deduced return types.

EricWF updated this revision to Diff 76076. EricWF added a comment. Resolved merge conflicts. https://reviews.llvm.org/D25292 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coroutines.cpp

[PATCH] D25204: Register Calling Convention, Clang changes

majnemer added a comment. The __ namespace is reserved for us and I can't imagine how __regcall would upset any existing code out there. https://reviews.llvm.org/D25204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285327 - Use -fopenmp=libomp in all OpenMP offloading tests.

Author: sfantao Date: Thu Oct 27 13:29:57 2016 New Revision: 285327 URL: http://llvm.org/viewvc/llvm-project?rev=285327=rev Log: Use -fopenmp=libomp in all OpenMP offloading tests. This will make sure the right features are being tested even for machines that default to libgomp. Modified:

[PATCH] D21857: [Driver][OpenMP] Add support to create jobs for unbundling actions.

sfantao updated this revision to Diff 76069. sfantao added a comment. - Rebase. https://reviews.llvm.org/D21857 Files: include/clang/Driver/Action.h include/clang/Driver/Driver.h include/clang/Driver/Tool.h lib/Driver/Action.cpp lib/Driver/Driver.cpp lib/Driver/Tool.cpp

r285326 - [Driver][OpenMP] Add support to create jobs for unbundling actions.

Author: sfantao Date: Thu Oct 27 13:14:55 2016 New Revision: 285326 URL: http://llvm.org/viewvc/llvm-project?rev=285326=rev Log: [Driver][OpenMP] Add support to create jobs for unbundling actions. Summary: This patch adds the support to create jobs for the `OffloadBundlingAction` which will

r285325 - [Driver][OpenMP] Add support to create jobs for bundling actions.

Author: sfantao Date: Thu Oct 27 13:04:42 2016 New Revision: 285325 URL: http://llvm.org/viewvc/llvm-project?rev=285325=rev Log: [Driver][OpenMP] Add support to create jobs for bundling actions. Summary: This patch adds the support to create a job for the `OffloadBundlingAction` which will

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. I reproduced with clang that ships with XCode by doing: ln -s `xcrun -find clang` /tmp/clang /tmp/clang /tmp/main.cpp -flto clang: warning: libLTO.dylib relative to clang installed dir not found; using 'ld' default search path instead `

[PATCH] D21853: [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

sfantao updated this revision to Diff 76064. sfantao marked an inline comment as done. sfantao added a comment. - Add comment explaing that the bundler tool can detect if the input file is a bundle or not. https://reviews.llvm.org/D21853 Files: include/clang/Driver/Action.h

r285324 - [Driver][OpenMP] Update actions builder to create unbundling action when necessary.

Author: sfantao Date: Thu Oct 27 13:00:51 2016 New Revision: 285324 URL: http://llvm.org/viewvc/llvm-project?rev=285324=rev Log: [Driver][OpenMP] Update actions builder to create unbundling action when necessary. Summary: Each time that offloading support is requested by the user and the input

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

jwhowarth added a comment. Opened https://llvm.org/bugs/show_bug.cgi?id=30811 since the inability for symlinks to be handled in locating libLTO.dylib defeats the purpose of this commit. Repository: rL LLVM https://reviews.llvm.org/D25932 ___

r285323 - [Driver][OpenMP] Update actions builder to create bundling action when necessary.

Author: sfantao Date: Thu Oct 27 12:50:43 2016 New Revision: 285323 URL: http://llvm.org/viewvc/llvm-project?rev=285323=rev Log: [Driver][OpenMP] Update actions builder to create bundling action when necessary. Summary: In order to save the user from dealing with multiple output files (for host

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. I just verified that I reproduce with -flto and an previous clang version. Repository: rL LLVM https://reviews.llvm.org/D25932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. Since you re-open this revision, can you clarify how this is triggering the bug you mention? It seems like the issue already existed? Repository: rL LLVM https://reviews.llvm.org/D25932 ___ cfe-commits mailing list

[PATCH] D25204: Register Calling Convention, Clang changes

erichkeane added a comment. I guess I'm not sure how to respond to that... Calling conventions traditionally use double underscore to prevent from stomping on user keywords. Additionally, this is in a specification that has an existing implementation available, so I'm not sure what could be

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

jwhowarth reopened this revision. jwhowarth added a comment. This approach doesn't work if the user installs clang in a buried subdirectory such as /sw/opt/llvm-4.0 but accesses the compilers via a /sw/bin/clang-4.0 symlink pointing at /sw/opt/llvm-4.0/bin/clang-4.0... $ /sw/bin/clang-4.0

r285320 - [Driver][OpenMP] Add logic for offloading-specific argument translation.

Author: sfantao Date: Thu Oct 27 12:39:44 2016 New Revision: 285320 URL: http://llvm.org/viewvc/llvm-project?rev=285320=rev Log: [Driver][OpenMP] Add logic for offloading-specific argument translation. Summary: This patch includes support for argument translation that is specific of a given

r285319 - [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

Author: sfantao Date: Thu Oct 27 12:31:22 2016 New Revision: 285319 URL: http://llvm.org/viewvc/llvm-project?rev=285319=rev Log: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains. Summary: This patch adds logic to create jobs for OpenMP offloading

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 76062. sfantao added a comment. - Capitalize Clang in the regression test too. https://reviews.llvm.org/D21847 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/openmp-offload.c Index:

[PATCH] D21847: [Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc tool chains.

sfantao updated this revision to Diff 76061. sfantao marked 2 inline comments as done. sfantao added a comment. - Capitalize Clang in linker script comment and explain that the linker script dump option is required to test the driver with -###. https://reviews.llvm.org/D21847 Files:

[PATCH] D24378: [CodeGen] Provide an appropriate alignment for dynamic allocas

This revision was automatically updated to reflect the committed changes. Closed by commit rL285316: [CodeGen] Provide an appropriate alignment for dynamic allocas (authored by majnemer). Changed prior to commit: https://reviews.llvm.org/D24378?vs=70789=76060#toc Repository: rL LLVM

r285316 - [CodeGen] Provide an appropriate alignment for dynamic allocas

Author: majnemer Date: Thu Oct 27 12:18:24 2016 New Revision: 285316 URL: http://llvm.org/viewvc/llvm-project?rev=285316=rev Log: [CodeGen] Provide an appropriate alignment for dynamic allocas GCC documents __builtin_alloca as aligning the storage to at least __BIGGEST_ALIGNMENT__. MSVC

[PATCH] D25895: [MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation

This revision was automatically updated to reflect the committed changes. Closed by commit rL285315: [MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation (authored by majnemer). Changed prior to commit: https://reviews.llvm.org/D25895?vs=75523=76059#toc Repository: rL

r285315 - [MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation

Author: majnemer Date: Thu Oct 27 12:11:51 2016 New Revision: 285315 URL: http://llvm.org/viewvc/llvm-project?rev=285315=rev Log: [MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation getClassAtVTableLocation hunts through virtual bases without using the MDC layout which is

r285314 - [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.

Author: sfantao Date: Thu Oct 27 12:08:03 2016 New Revision: 285314 URL: http://llvm.org/viewvc/llvm-project?rev=285314=rev Log: [Driver][OpenMP] Add specialized action builder for OpenMP offloading actions. Summary: This patch adds a new specialized action builder to create OpenMP offloading

r285311 - [Driver][OpenMP] Create tool chains for OpenMP offloading kind.

Author: sfantao Date: Thu Oct 27 11:38:05 2016 New Revision: 285311 URL: http://llvm.org/viewvc/llvm-project?rev=285311=rev Log: [Driver][OpenMP] Create tool chains for OpenMP offloading kind. Summary: This patch adds new logic to create the necessary tool chains to support offloading for

[PATCH] D26035: Expand -Wlogical-not-parentheses to also fire on `!x & A`.

thakis closed this revision. thakis added a comment. 285310 https://reviews.llvm.org/D26035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285310 - Expand -Wlogical-not-parentheses to also fire on `!x & A`.

Author: nico Date: Thu Oct 27 11:32:06 2016 New Revision: 285310 URL: http://llvm.org/viewvc/llvm-project?rev=285310=rev Log: Expand -Wlogical-not-parentheses to also fire on `!x & A`. This is a misspelling of the intended !(x & A) negated bit test that happens in practice every now and then. I

r285307 - [Driver][CUDA][OpenMP] Reimplement tool selection in the driver.

Author: sfantao Date: Thu Oct 27 11:29:20 2016 New Revision: 285307 URL: http://llvm.org/viewvc/llvm-project?rev=285307=rev Log: [Driver][CUDA][OpenMP] Reimplement tool selection in the driver. Summary: This creates a tool selector in the driver that replaces the existing one. The goal is to

r285306 - [coroutines] Add allocation and deallocation substatements.

Author: gornishanov Date: Thu Oct 27 11:28:31 2016 New Revision: 285306 URL: http://llvm.org/viewvc/llvm-project?rev=285306=rev Log: [coroutines] Add allocation and deallocation substatements. Summary: SemaCoroutine: Add allocation / deallocation substatements. CGCoroutine/Test: Emit allocation

Re: r285287 - Add const versions of Expr::getInits() and Expr::inits()

On 27 Oct 2016 5:21 am, "Erik Verbruggen via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: erikjv Date: Thu Oct 27 07:12:08 2016 New Revision: 285287 URL: http://llvm.org/viewvc/llvm-project?rev=285287=rev Log: Add const versions of Expr::getInits() and Expr::inits() Modified:

Re: r285295 - Do not print include_next/pragma once warnings when input is a header.

On 27 Oct 2016 7:26 am, "Erik Verbruggen via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: erikjv Date: Thu Oct 27 09:17:10 2016 New Revision: 285295 URL: http://llvm.org/viewvc/llvm-project?rev=285295=rev Log: Do not print include_next/pragma once warnings when input is a header.

[PATCH] D26035: Expand -Wlogical-not-parentheses to also fire on `!x & A`.

thakis added a comment. Thanks! Landing… Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224 + // These already err, don't also warn. + !x &= 1; // expected-error{{expression is not assignable}} + !x |= 1; // expected-error{{expression is not assignable}}

[PATCH] D26035: Expand -Wlogical-not-parentheses to also fire on `!x & A`.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, very nice! (with one clarifying question) Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224 + // These already err, don't also warn. + !x &= 1; //

[PATCH] D25909: [analyzer] MacOSXApiChecker: Disallow dispatch_once predicates on heap and in ivars.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks great! Please, commit. https://reviews.llvm.org/D25909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26035: Expand -Wlogical-not-parentheses to also fire on `!x & A`.

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. This is a misspelling of the intended `!(x & A)` negated bit test that happens in practice every now and then. I ran this on Chromium and all its dependencies, and it fired 0 times -- no false

[PATCH] D26034: [CodeCompletion] Block property setters: Use dynamic priority heuristic

arphaman created this revision. arphaman added a reviewer: akyrtzi. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch implements a heuristic that I mentioned in https://reviews.llvm.org/D25520. When completing blocks properties that

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

NoQ updated this revision to Diff 76043. NoQ added a comment. - Fix warning messages, finally, hopefully. - Make handling of macros much more careful, because errors of form `x == Y`, where X is an `NSNumber` pointer, and `Y` is a custom macro that expands to `0`, were found.

[PATCH] D24799: [XRay] Check in Clang whether XRay supports the target when -fxray-instrument is passed

rSerge added a comment. @dberris , thanks! I ran clang-format on Tools.cpp , then just copy-pasted the changed piece. Do you remember, was the whitespace problem in this file? Or was it in the tests? Repository: rL LLVM https://reviews.llvm.org/D24799

r285301 - Attempt to make clang-format.py python 3 - compatible.

Author: alexfh Date: Thu Oct 27 10:15:23 2016 New Revision: 285301 URL: http://llvm.org/viewvc/llvm-project?rev=285301=rev Log: Attempt to make clang-format.py python 3 - compatible. Modified: cfe/trunk/tools/clang-format/clang-format.py Modified:

[PATCH] D26030: Add shebang.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. These scripts aren't `+x`. Maybe you want to make them executable as well. Also, scan-build-py adds `# -*- coding: utf-8 -*-` as well to its python executables. Repository: rL LLVM

[libcxx] r285300 - Move 'quoted' for string_view from to (where the other versions of 'quoted' live. No functional change.

Author: marshall Date: Thu Oct 27 10:10:07 2016 New Revision: 285300 URL: http://llvm.org/viewvc/llvm-project?rev=285300=rev Log: Move 'quoted' for string_view from to (where the other versions of 'quoted' live. No functional change. Modified: libcxx/trunk/include/iomanip

  1   2   >