Re: r284256 - Link static PIE programs against rcrt0.o on OpenBSD

2016-10-29 Thread Brad Smith via cfe-commits
On 10/25/16 19:34, Brad Smith via cfe-commits wrote: On 10/18/16 22:13, Brad Smith via cfe-commits wrote: On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote: On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote: Author: emaste Date: Fri Oct 14

r285511 - clang/test/Driver/openmp-offload.c: Relax expressions if "ld.exe" exists, like mingw.

2016-10-29 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Oct 29 21:58:48 2016 New Revision: 285511 URL: http://llvm.org/viewvc/llvm-project?rev=285511=rev Log: clang/test/Driver/openmp-offload.c: Relax expressions if "ld.exe" exists, like mingw. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified:

Re: r285341 - Add documentation describing the components of a complete toolchain including Clang.

2016-10-29 Thread Will Dietz via cfe-commits
(Agreed, thanks!) ~Will On Sat, Oct 29, 2016 at 5:50 PM, Sean Silva via cfe-commits wrote: > This is awesome Richard. Thanks! > > -- Sean Silva > > On Thu, Oct 27, 2016 at 1:55 PM, Richard Smith via cfe-commits > wrote: >> >> Author:

Re: r285341 - Add documentation describing the components of a complete toolchain including Clang.

2016-10-29 Thread Sean Silva via cfe-commits
This is awesome Richard. Thanks! -- Sean Silva On Thu, Oct 27, 2016 at 1:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Oct 27 15:55:56 2016 > New Revision: 285341 > > URL: http://llvm.org/viewvc/llvm-project?rev=285341=rev > Log: > Add

[PATCH] D25925: [clang-tidy] Update cert-err58-cpp to match its new generalised form.

2016-10-29 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 76318. malcolm.parsons added a comment. Check calls to operator new. https://reviews.llvm.org/D25925 Files: clang-tidy/cert/StaticObjectExceptionCheck.cpp docs/clang-tidy/checks/cert-err58-cpp.rst

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

2016-10-29 Thread Joerg Sonnenberger via cfe-commits
On Fri, Oct 28, 2016 at 06:06:50AM -, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Oct 28 01:06:50 2016 > New Revision: 285382 > > URL: http://llvm.org/viewvc/llvm-project?rev=285382=rev > Log: > Add __libcpp_version file and __libcpp_library_version function. I really

[PATCH] D26032: [ASTMatcher] Add operatorNew matcher for cxxNewExpr

2016-10-29 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 76316. malcolm.parsons added a comment. Extend hasDeclaration instead. https://reviews.llvm.org/D26032 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatchers/ASTMatchersInternal.h

[PATCH] D25316: [clang-tidy] Enhance modernize-use-auto to casts

2016-10-29 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. ping. https://reviews.llvm.org/D25316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26119: [clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init

2016-10-29 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. Unnamed bitfields cannot be initialized. Bitfields cannot be in-class initialized. https://reviews.llvm.org/D26119

r285504 - [AVX-512] Remove masked 128/256-bit sqrt builtins and replace them with unmasked builtins and a select.

2016-10-29 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 29 14:02:10 2016 New Revision: 285504 URL: http://llvm.org/viewvc/llvm-project?rev=285504=rev Log: [AVX-512] Remove masked 128/256-bit sqrt builtins and replace them with unmasked builtins and a select. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r285502 - [AVX-512] Remove masked 128/256-bit floating point max/min builtins. Use unmasked builtins with select instead.

2016-10-29 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 29 14:02:03 2016 New Revision: 285502 URL: http://llvm.org/viewvc/llvm-project?rev=285502=rev Log: [AVX-512] Remove masked 128/256-bit floating point max/min builtins. Use unmasked builtins with select instead. Modified:

r285505 - [AVX-512] Remove 128/256-bit masked pmulhrsw/pmulhuw/pmulhw builtins and use unmasked builtins and select instead.

2016-10-29 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 29 14:02:14 2016 New Revision: 285505 URL: http://llvm.org/viewvc/llvm-project?rev=285505=rev Log: [AVX-512] Remove 128/256-bit masked pmulhrsw/pmulhuw/pmulhw builtins and use unmasked builtins and select instead. Modified:

r285503 - [AVX-512] Remove masked 128/256-bit pmuludq/pmuldq builtins and replace them with unmasked builtins and a select.

2016-10-29 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Oct 29 14:02:07 2016 New Revision: 285503 URL: http://llvm.org/viewvc/llvm-project?rev=285503=rev Log: [AVX-512] Remove masked 128/256-bit pmuludq/pmuldq builtins and replace them with unmasked builtins and a select. Modified:

[PATCH] D23765: Fix for clang PR 29087

2016-10-29 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4390-4391 // resolution point. if (isa(ND)) continue; +// UsingDecl itself is not a constructor You also need to handle the case of an inherited constructor

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

2016-10-29 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/AST/DeclCXX.cpp:1349-1354 + while (!CTD->isMemberSpecialization()) { +auto *NewCTD = CTD->getInstantiatedFromMemberTemplate(); +if (!NewCTD) break; CTD = NewCTD; }

r285500 - Factor finding of libc++ include path out of building -cc1 arguments.

2016-10-29 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sat Oct 29 12:28:48 2016 New Revision: 285500 URL: http://llvm.org/viewvc/llvm-project?rev=285500=rev Log: Factor finding of libc++ include path out of building -cc1 arguments. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/ToolChains.h Modified:

[PATCH] D26118: [clang-tidy] Change readability-redundant-member-init to get base type from constructor

2016-10-29 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, Eugene.Zelenko. malcolm.parsons added a subscriber: cfe-commits. Fixes PR30835 https://reviews.llvm.org/D26118 Files: clang-tidy/readability/RedundantMemberInitCheck.cpp Index:

[PATCH] D26117: [Devirtualization] Decorate vfunction load with invariant.load

2016-10-29 Thread Piotr Padlewski via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285497: [Devirtualization] Decorate vfunction load with invariant.load (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D26117?vs=76303=76306#toc Repository: rL LLVM

r285497 - [Devirtualization] Decorate vfunction load with invariant.load

2016-10-29 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Sat Oct 29 10:28:30 2016 New Revision: 285497 URL: http://llvm.org/viewvc/llvm-project?rev=285497=rev Log: [Devirtualization] Decorate vfunction load with invariant.load Summary: This patch was introduced one year ago, but because my google account was disabled, I didn't get

r285496 - NFC small format

2016-10-29 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Sat Oct 29 10:28:25 2016 New Revision: 285496 URL: http://llvm.org/viewvc/llvm-project?rev=285496=rev Log: NFC small format Modified: cfe/trunk/lib/Analysis/UninitializedValues.cpp Modified: cfe/trunk/lib/Analysis/UninitializedValues.cpp URL:

[PATCH] D26117: [Devirtualization] Decorate vfunction load with invariant.load

2016-10-29 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 76303. Prazek added a comment. Updated comment and reformatted https://reviews.llvm.org/D26117 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index: test/CodeGenCXX/virtual-function-calls.cpp

[PATCH] D26117: [Devirtualization] Decorate vfunction load with invariant.load

2016-10-29 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 76302. Prazek added a comment. rebae https://reviews.llvm.org/D26117 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index: test/CodeGenCXX/virtual-function-calls.cpp

[PATCH] D26117: [Devirtualization] Decorate vfunction load with invariant.load

2016-10-29 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. merging with master. Gonna update patch in a minute. https://reviews.llvm.org/D26117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26117: [Devirtualization] Decorate vfunction load with invariant.load

2016-10-29 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. Here is commit from last year https://reviews.llvm.org/D13279 https://reviews.llvm.org/D26117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26117: [Devirtualization] Decorate vfunction load with invariant.load

2016-10-29 Thread Piotr Padlewski via cfe-commits
Prazek created this revision. Prazek added reviewers: rsmith, rengolin. Prazek added subscribers: cfe-commits, rjmccall, nlewycky. This patch was introduced one year ago, but because my google account was disabled, I didn't get email with failing buildbot and I missed revert of this commit. There

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

2016-10-29 Thread Aleksei Sidorin via cfe-commits
a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Looks good. But I think it will be good to put the files in Input to a separate directory. https://reviews.llvm.org/D26054 ___

[PATCH] D24869: [cfe] [test] Fix detecting LLVM zlib support in stand-alone builds

2016-10-29 Thread Michał Górny via cfe-commits
mgorny added a comment. Non-gentle ping? https://reviews.llvm.org/D24869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

2016-10-29 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: ddunbar, beanz. mgorny added a subscriber: cfe-commits. Add the build llvm_shlib_dir into LD_LIBRARY_PATH before the directory specified as llvm_libs_dir, in order to fix stand-alone builds attempting to use installed clang libraries. In case

[PATCH] D12839: Extend MoveConstructorInitCheck to also flag constructor arguments passed by value and can be moved assigned to fields.

2016-10-29 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. The modernize-pass-by-value check does the same thing: test/clang-tidy/misc-move-constructor-init.cpp:98:12: warning: pass by value and use std::move [modernize-pass-by-value] Positive(Movable M) : M_(M) {} ^