r285544 - Add support for __builtin_alloca_with_align

Author: majnemer Date: Mon Oct 31 00:37:48 2016 New Revision: 285544 URL: http://llvm.org/viewvc/llvm-project?rev=285544=rev Log: Add support for __builtin_alloca_with_align __builtin_alloca always uses __BIGGEST_ALIGNMENT__ for the alignment of the allocation. __builtin_alloca_with_align

r285543 - Make output of ast-print closer to C++ code

Author: sepavloff Date: Mon Oct 31 00:11:12 2016 New Revision: 285543 URL: http://llvm.org/viewvc/llvm-project?rev=285543=rev Log: Make output of ast-print closer to C++ code Put semicolon after non-defining method declaration and a class specialization body. Modified:

r285539 - [AVX-512] Remove many of the masked 128/256-bit shift builtins and replace them with unmasked builtins and selects.

Author: ctopper Date: Sun Oct 30 23:30:51 2016 New Revision: 285539 URL: http://llvm.org/viewvc/llvm-project?rev=285539=rev Log: [AVX-512] Remove many of the masked 128/256-bit shift builtins and replace them with unmasked builtins and selects. Modified:

r285540 - [AVX-512] Remove masked vector extract builtins and replace with native shufflevectors and selects.

Author: ctopper Date: Sun Oct 30 23:30:56 2016 New Revision: 285540 URL: http://llvm.org/viewvc/llvm-project?rev=285540=rev Log: [AVX-512] Remove masked vector extract builtins and replace with native shufflevectors and selects. Unfortunately, the backend currently doesn't fold masks into the

[libcxx] r285538 - Add 'inline' but not 'always_inline' to std::strings destructor.

Author: ericwf Date: Sun Oct 30 22:42:50 2016 New Revision: 285538 URL: http://llvm.org/viewvc/llvm-project?rev=285538=rev Log: Add 'inline' but not 'always_inline' to std::strings destructor. Adding both 'inline' and 'always_inline' to the destructor has been contentious. However most of the

[libcxx] r285537 - Remove additional function template definitions from the dylib

Author: ericwf Date: Sun Oct 30 22:40:29 2016 New Revision: 285537 URL: http://llvm.org/viewvc/llvm-project?rev=285537=rev Log: Remove additional function template definitions from the dylib Modified: libcxx/trunk/include/string libcxx/trunk/lib/abi/CHANGELOG.TXT

[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

mehdi_amini added a comment. I talked with Eric on IRC, he mentioned some benchmarks were ran. I'd like to understand what was the baseline? Here we add *both* the inline keyword and the always_inline attribute. I'd like to know if there is a benchmarks that shows that always_inline is

[PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

loladiro added a comment. I'm really out of my depth in this code, but it looks like that test case is triggering the one code path in that function that is actually correct. Could you adjust it to trigger the code path behind the first if statement? Repository: rL LLVM

r285533 - [analyzer] NumberObjectConversion: support more types, misc updates.

Author: dergachev Date: Sun Oct 30 22:08:48 2016 New Revision: 285533 URL: http://llvm.org/viewvc/llvm-project?rev=285533=rev Log: [analyzer] NumberObjectConversion: support more types, misc updates. Support CFNumberRef and OSNumber objects, which may also be accidentally converted to plain

[PATCH] D25731: [analyzer] NumberObjectConversion: Support OSNumber and CFNumberRef.

This revision was automatically updated to reflect the committed changes. Closed by commit rL285533: [analyzer] NumberObjectConversion: support more types, misc updates. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D25731?vs=76043=76349#toc Repository: rL LLVM

[PATCH] D25624: Added 'inline' attribute to basic_string's destructor

mehdi_amini added a comment. Before this gets re-committed, I'd like to understand why only the destructor? https://reviews.llvm.org/D25624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r285532 - Optimize filesystem::path by providing weaker exception guarantees.

Author: ericwf Date: Sun Oct 30 21:46:25 2016 New Revision: 285532 URL: http://llvm.org/viewvc/llvm-project?rev=285532=rev Log: Optimize filesystem::path by providing weaker exception guarantees. path uses string::append to construct, append, and concatenate paths. Unfortunatly string::append

Re: [libcxx] r285456 - Added 'inline' attribute to basic_string's destructor

Hi All, This problem was caused by the definition of _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY. The issue was fixed in r285531, which also adds linkage tests for std::strings destructor. @Adtiya feel free to recommit this change. /Eric On Fri, Oct 28, 2016 at 7:00 PM, Mehdi Amini via

[libcxx] r285531 - Fix _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to always have default visibility.

Author: ericwf Date: Sun Oct 30 21:07:23 2016 New Revision: 285531 URL: http://llvm.org/viewvc/llvm-project?rev=285531=rev Log: Fix _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to always have default visibility. This prevent the symbols from being both externally available and hidden, which causes

[PATCH] D25857: [tsan][clang] Introduce a function attribute to disable TSan checking at run time

dvyukov added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:717 + // Ignore TSan memory acesses from within dealloc and all of its calees at + // run time. This is unpleasant. We had recursive ignores in the old Valgrind-based tsan, but

[PATCH] D26132: [clang-format] Skip over AnnotatedLines with >50 levels of nesting.

sammccall updated this revision to Diff 76348. sammccall added a comment. Fixing style. https://reviews.llvm.org/D26132 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D26132: [clang-format] Skip over AnnotatedLines with >50 levels of nesting.

sammccall created this revision. sammccall added a reviewer: djasper. sammccall added a subscriber: cfe-commits. Herald added a subscriber: klimek. Skip over AnnotatedLines with >50 levels of nesting; don't format them. Reasoning: - ExpressionParser uses a lot of stack for these, bad in some

[libcxx] r285530 - Improve performance of constructing filesystem::path from strings.

Author: ericwf Date: Sun Oct 30 18:53:50 2016 New Revision: 285530 URL: http://llvm.org/viewvc/llvm-project?rev=285530=rev Log: Improve performance of constructing filesystem::path from strings. This patch fixes a performance bug when constructing or appending to a path from a string or

[libcxx] r285526 - Rewrite std::filesystem::path iterators and parser

Author: ericwf Date: Sun Oct 30 18:30:38 2016 New Revision: 285526 URL: http://llvm.org/viewvc/llvm-project?rev=285526=rev Log: Rewrite std::filesystem::path iterators and parser This patch entirely rewrites the parsing logic for paths. Unlike the previous implementation this one stores

r285525 - Fix clang installed path to handle case where clang is invoked through a symlink

Author: mehdi_amini Date: Sun Oct 30 18:26:13 2016 New Revision: 285525 URL: http://llvm.org/viewvc/llvm-project?rev=285525=rev Log: Fix clang installed path to handle case where clang is invoked through a symlink This code path is used when generating the path to libLTO.dylib, which is passed

[PATCH] D26075: Change from "XFAIL: libcpp-no-exceptions" to "UNSUPPORTED: libcpp-no-exceptions" tests that only check exceptions and nothing else

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM as well. https://reviews.llvm.org/D26075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r285524 - Add start of filesystem benchmarks

Author: ericwf Date: Sun Oct 30 17:53:00 2016 New Revision: 285524 URL: http://llvm.org/viewvc/llvm-project?rev=285524=rev Log: Add start of filesystem benchmarks Added: libcxx/trunk/benchmarks/filesystem.bench.cpp Modified: libcxx/trunk/CMakeLists.txt

[PATCH] D26082: Support for Python 3 in libclang python bindings

jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 76344. jbcoe added a comment. Remove mistakenly committed debugging output. https://reviews.llvm.org/D26082 Files: bindings/python/clang/cindex.py

[PATCH] D26075: Change from "XFAIL: libcpp-no-exceptions" to "UNSUPPORTED: libcpp-no-exceptions" tests that only check exceptions and nothing else

rmaprath added a comment. This looks sensible to me. I'll let @EricWF approve. / Asiri https://reviews.llvm.org/D26075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

> As I said, this is not a decision based on the libc++ version. It is at least partially based on the libc++ version. We obviously can't enable the feature if libc++ does not yet support them. /Eric On Sun, Oct 30, 2016 at 2:00 PM, Joerg Sonnenberger via cfe-commits <

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

daphnediane added a comment. ping. FYI I have found some additional similar cases when AlignConsecutiveDeclarations is also true, that I'll see if I can document/test case etc. at some point. https://reviews.llvm.org/D24703 ___ cfe-commits

[libcxxabi] r285523 - Mark thread exit test as unsupported w/o threads

Author: ericwf Date: Sun Oct 30 15:05:52 2016 New Revision: 285523 URL: http://llvm.org/viewvc/llvm-project?rev=285523=rev Log: Mark thread exit test as unsupported w/o threads Modified: libcxxabi/trunk/test/cxa_thread_atexit_test.pass.cpp Modified:

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode added a comment. @mgehre: Yes it does - in your case AST looks like `ifStmt(b) - CompoundStmt - ifStmt(c)`, so ifStmt's don't have direct parent-child relations. But there is another problem: while(a) if (b) return 1; else doSomething(2); In such case, generated

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

On Sun, Oct 30, 2016 at 01:49:53PM -0600, Eric Fiselier via cfe-commits wrote: > > E.g. presence of libc++ won't tell you if you can use sized deallocation > > as that's a ABI library issue. > > The value of __libcpp_version could easily be updated by vendors to store > the version of the

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

> E.g. presence of libc++ won't tell you if you can use sized deallocation as that's a ABI library issue. The value of __libcpp_version could easily be updated by vendors to store the version of the system dylib, so I don't see why this wouldn't work. > So, why again should clang care about

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

On Sun, Oct 30, 2016 at 12:54:28PM -0600, Eric Fiselier wrote: > Richard requested this change. Take a look at > https://reviews.llvm.org/D26044 for more rational. I don't see much rational and in fact, I disagree with some of the mentioned items. E.g. presence of libc++ won't tell you if you can

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

mgehre added a comment. With this fix, is there still a warning on the following code? if(b) { ... if(c) return; else doSomething() ... } I would expect that the check still warns on it. https://reviews.llvm.org/D26125

Re: [libcxx] r285382 - Add __libcpp_version file and __libcpp_library_version function.

Richard requested this change. Take a look at https://reviews.llvm.org/D26044 for more rational. On Sat, Oct 29, 2016 at 2:28 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Oct 28, 2016 at 06:06:50AM -, Eric Fiselier via cfe-commits > wrote: > > Author:

[PATCH] D26082: Support for Python 3 in libclang python bindings

jbcoe retitled this revision from "Incomplete support for Python 3 in libclang python bindings" to "Support for Python 3 in libclang python bindings". jbcoe updated the summary for this revision. jbcoe updated this revision to Diff 76338. jbcoe added a comment. Python bindings tests now pass in

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

djasper added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt( idlecode wrote: > djasper wrote: > >

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode planned changes to this revision. idlecode added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt(

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

djasper added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt( idlecode wrote: > djasper wrote: > >

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode marked an inline comment as done. idlecode added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt(

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

djasper added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt( idlecode wrote: > djasper wrote: > >

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode marked an inline comment as done. idlecode added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt(

r285519 - Fixing "type" issue for (epi32)

Author: mzuckerm Date: Sun Oct 30 09:54:05 2016 New Revision: 285519 URL: http://llvm.org/viewvc/llvm-project?rev=285519=rev Log: Fixing "type" issue for (epi32) and replaceing hardcoded inf with clang builtin inf "__builtin_inff()" for float ({max|min}_{pd|ps}) Modified:

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

djasper added inline comments. Comment at: clang-tidy/readability/ElseAfterReturnCheck.cpp:28 stmt(forEach( - ifStmt(hasThen(stmt( + ifStmt(unless(hasParent(ifStmt())), + hasThen(stmt( I think this now effectively does:

[PATCH] D26125: [clang-tidy] Fixed else-after-return warning in cascade if statement

idlecode created this revision. idlecode added reviewers: djasper, malcolm.parsons, omtcyfz. idlecode added a subscriber: cfe-commits. Fix applied to else in a cascade if statements changed program semantics in cases when not all previous branches resulted in flow change. Fixes PR30652

r285516 - [AVX-512] Remove masked 128/256-bit builtins for vpmaddwd and vpmaddubsw. Replace with unmasked builtins and select.

Author: ctopper Date: Sun Oct 30 02:11:34 2016 New Revision: 285516 URL: http://llvm.org/viewvc/llvm-project?rev=285516=rev Log: [AVX-512] Remove masked 128/256-bit builtins for vpmaddwd and vpmaddubsw. Replace with unmasked builtins and select. Modified:

Re: r284256 - Link static PIE programs against rcrt0.o on OpenBSD

- Original Message - > From: "Brad Smith via cfe-commits" > To: "Ed Maste" , sisnk...@gmail.com, > cfe-commits@lists.llvm.org > Sent: Sunday, October 30, 2016 12:57:44 AM > Subject: Re: r284256 - Link static PIE programs against rcrt0.o on