r286796 - Add explicit (void) cast to result of unique_ptr::release()

Author: ericwf Date: Mon Nov 14 01:03:50 2016 New Revision: 286796 URL: http://llvm.org/viewvc/llvm-project?rev=286796=rev Log: Add explicit (void) cast to result of unique_ptr::release() Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL:

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to `Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()`

EricWF updated this revision to Diff 77769. EricWF added a comment. - Add `[[no_discard]]` to various smart pointer observers including `get()` and `operator*()`. https://reviews.llvm.org/D26596 Files: docs/UsingLibcxx.rst include/__config include/__hash_table include/__mutex_base

[PATCH] D22997: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

faisalv removed rL LLVM as the repository for this revision. faisalv updated this revision to Diff 77767. faisalv marked 4 inline comments as done. faisalv added a comment. Addressed Aaron's requests regarding improving formatting and assert messages. Thanks! https://reviews.llvm.org/D22997

[libcxxabi] r286793 - __cxa_demangle: allow demangling invocation blocks

Author: compnerd Date: Sun Nov 13 21:07:47 2016 New Revision: 286793 URL: http://llvm.org/viewvc/llvm-project?rev=286793=rev Log: __cxa_demangle: allow demangling invocation blocks The block invocation function uses an extension where the prefix is ___Z as opposed to _Z. This should make the

[libcxx] r286792 - Fix ABI configuration detection on OS X

Author: ericwf Date: Sun Nov 13 21:03:13 2016 New Revision: 286792 URL: http://llvm.org/viewvc/llvm-project?rev=286792=rev Log: Fix ABI configuration detection on OS X Modified: libcxx/trunk/lib/abi/CMakeLists.txt Modified: libcxx/trunk/lib/abi/CMakeLists.txt URL:

[libcxx] r286791 - Fix CMake set syntax

Author: ericwf Date: Sun Nov 13 20:51:30 2016 New Revision: 286791 URL: http://llvm.org/viewvc/llvm-project?rev=286791=rev Log: Fix CMake set syntax Modified: libcxx/trunk/lib/abi/CMakeLists.txt Modified: libcxx/trunk/lib/abi/CMakeLists.txt URL:

[PATCH] D26544: [PPC] support for arithmetic builtins in the FE

nemanjai added inline comments. Comment at: lib/Headers/altivec.h:314 + vector signed int __carry = __c & __mask; + return vec_add(vec_add(__a, __b), __mask); +} I don't understand why we're adding `__mask` to the sum of `__a` and `__b`. Shouldn't that be

[libcxxabi] r286788 - __cxa_demangle: ensure that we have a mangled symbol

Author: compnerd Date: Sun Nov 13 19:55:54 2016 New Revision: 286788 URL: http://llvm.org/viewvc/llvm-project?rev=286788=rev Log: __cxa_demangle: ensure that we have a mangled symbol Ensure that we have a mangled symbol before attempting to demangle it. We would previously treat any input as a

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

nemanjai added inline comments. Comment at: lib/Headers/altivec.h:11908 +#define vec_extract4b(__a, __b) \ + vec_reve((vector unsigned long long) \ +

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to `Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()`

EricWF updated this revision to Diff 77764. EricWF added a comment. - Fix tests containing discarded values. - Fix two more instances of discarded `unique_ptr::release()` in the headers. https://reviews.llvm.org/D26596 Files: docs/UsingLibcxx.rst include/__config include/__hash_table

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to `Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()`

EricWF updated this revision to Diff 77763. EricWF added a comment. - Fix even more instances of `unique_ptr::release()` with a discarded value. Hopefully this is the last of them. https://reviews.llvm.org/D26596 Files: docs/UsingLibcxx.rst include/__config include/__hash_table

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to `Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()`

EricWF updated this revision to Diff 77762. EricWF added a comment. - Apply no-discard to `string_view::empty()` and friends. - Fix discarded use of `unique_ptr::release()` within libc++. https://reviews.llvm.org/D26596 Files: docs/UsingLibcxx.rst include/__config include/__hash_table

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to `Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()`

EricWF updated this revision to Diff 77761. EricWF added a comment. - Add missing newlines in added tests. https://reviews.llvm.org/D26596 Files: docs/UsingLibcxx.rst include/__config include/__mutex_base include/forward_list include/list include/map include/memory

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to `Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()`

EricWF retitled this revision from "[RFC] Add _LIBCPP_NO_DISCARD and apply it to unique_ptr::release()" to "[RFC] Add _LIBCPP_NO_DISCARD and apply it to `Container::empty()`, `unique_ptr::release()`, and `Lockable::try_lock()` ". EricWF updated the summary for this revision. EricWF updated this

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to unique_ptr::release()

mclow.lists added a comment. Note: I'm not unsympathetic to the situation that Chandler describes; I just don't want to manage a potentially unbounded (but probably more than 20) set of macros. https://reviews.llvm.org/D26596 ___ cfe-commits

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to unique_ptr::release()

mclow.lists added a comment. In https://reviews.llvm.org/D26596#593948, @chandlerc wrote: > I think we want dedicated macros to disable each added [[nodiscard]]. My concern here is that I expect that there will be a lot of these. Off the top of my head, I can name: - Every smart pointer's

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated the summary for this revision. teemperor updated this revision to Diff 77759. teemperor added a comment. - Rebased patch to the current trunk state. - Replaced runtime polymorphism with templates. - Constraint interface now only has one method signature.

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor planned changes to this revision. teemperor added a comment. - I ran all real-world tests (sqlite, etc.) before rebasing to trunk. I'm not 100% confident that I correctly merged everything, so I'll rerun them just in case. The normal clang test-suite passes, so it looks good.

Re: [PATCH] Warning for main returning a bool.

Friendly ping. Any further thoughts on this suggested warning? On Sat, Nov 5, 2016 at 1:48 PM Manuel Klimek wrote: > +richard > > On Fri, Oct 14, 2016 at 10:18 AM Joshua Hurwitz via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > See attached. > > Returning a bool from

[libcxx] r286784 - Add docs for use-configurable libc++ features

Author: ericwf Date: Sun Nov 13 17:00:30 2016 New Revision: 286784 URL: http://llvm.org/viewvc/llvm-project?rev=286784=rev Log: Add docs for use-configurable libc++ features Modified: libcxx/trunk/docs/UsingLibcxx.rst Modified: libcxx/trunk/docs/UsingLibcxx.rst URL:

[libcxx] r286783 - Fix GCC libc++abi build

Author: ericwf Date: Sun Nov 13 16:27:00 2016 New Revision: 286783 URL: http://llvm.org/viewvc/llvm-project?rev=286783=rev Log: Fix GCC libc++abi build Modified: libcxx/trunk/CMakeLists.txt libcxx/trunk/test/libcxx/compiler.py libcxx/trunk/test/libcxx/test/config.py

[libcxxabi] r286783 - Fix GCC libc++abi build

Author: ericwf Date: Sun Nov 13 16:27:00 2016 New Revision: 286783 URL: http://llvm.org/viewvc/llvm-project?rev=286783=rev Log: Fix GCC libc++abi build Modified: libcxxabi/trunk/CMakeLists.txt libcxxabi/trunk/test/lit.site.cfg.in Modified: libcxxabi/trunk/CMakeLists.txt URL:

[PATCH] D26596: [RFC] Add _LIBCPP_NO_DISCARD and apply it to unique_ptr::release()

EricWF created this revision. EricWF added reviewers: mclow.lists, chandlerc. EricWF added a subscriber: cfe-commits. The title says it all. I just want to check that we agree on the general direction of this patch. Specifically that libc++ should be free to apply `no_discard` where we feel

[libcxx] r286779 - Implement LWG 2770 - Make tuple_size defined for all T

Author: ericwf Date: Sun Nov 13 14:43:50 2016 New Revision: 286779 URL: http://llvm.org/viewvc/llvm-project?rev=286779=rev Log: Implement LWG 2770 - Make tuple_size defined for all T Modified: libcxx/trunk/include/__tuple libcxx/trunk/include/tuple

[libcxx] r286774 - Fix PR30979 - tuple is constructible from move_only const

Author: ericwf Date: Sun Nov 13 13:54:31 2016 New Revision: 286774 URL: http://llvm.org/viewvc/llvm-project?rev=286774=rev Log: Fix PR30979 - tuple is constructible from move_only const& Modified: libcxx/trunk/include/tuple

[PATCH] D26589: Add static analyzer checker for finding infinite recursion

k-wisniewski created this revision. k-wisniewski added reviewers: zaks.anna, dcoughlin, dergachev.a. k-wisniewski added a subscriber: cfe-commits. Herald added a subscriber: mgorny. This is the very first version of a checker that aims to find cases of infinite recursion. It relies on Add

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

k-wisniewski created this revision. k-wisniewski added reviewers: dergachev.a, dcoughlin, zaks.anna. k-wisniewski added a subscriber: cfe-commits. Hi, I've been working on a checker that uses RegionChanges interface and needed to access to LocationContext. Another change is an easy way to

[PATCH] D24085: arm: Fix ttype encoding assertion failure.

logan closed this revision. logan added a comment. Thanks for reviewing. Committed as https://reviews.llvm.org/rL286760. https://reviews.llvm.org/D24085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r286760 - arm: Fix ttype encoding assertion failure.

Author: logan Date: Sun Nov 13 08:44:41 2016 New Revision: 286760 URL: http://llvm.org/viewvc/llvm-project?rev=286760=rev Log: arm: Fix ttype encoding assertion failure. GCC 4.7 or newer emits 0x90 (indirect | pcrel) as the ttype encoding. This would hit an assertion in cxa_personality.cpp.

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

logan closed this revision. logan added a comment. Thanks. Committed as https://reviews.llvm.org/rL286759. https://reviews.llvm.org/D24082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r286759 - [CMake] Fix libc++abi arm build w/o libunwind.

Author: logan Date: Sun Nov 13 08:42:15 2016 New Revision: 286759 URL: http://llvm.org/viewvc/llvm-project?rev=286759=rev Log: [CMake] Fix libc++abi arm build w/o libunwind. This commit fixes libc++abi build when LLVM unwinder (libunwind_llvm) is not enabled. This commit fixes the problem by

[PATCH] D26587: [X86][AVX512][InlineASM][MS][clang] (I|G)CC Memory adjustments compatibility

coby created this revision. coby added reviewers: m_zuckerman, rnk, myatsina. coby added a subscriber: cfe-commits. coby set the repository for this revision to rL LLVM. (I|G)CC will adjust a missing size qualifier on an indirect memory reference according to a certain logic, which is presented

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

rjmccall added a comment. In https://reviews.llvm.org/D26196#593741, @yaxunl wrote: > >> It seems the casting from a pointer to different address space is not > >> affected by this change. When a null pointer is casted to different > >> address space, it is casted the same way as an ordinary