[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli marked 5 inline comments as done. fpetrogalli added a comment. I updated the comments related to code formatting. https://reviews.llvm.org/D27250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. You did just some minor changes. The main questions are still unanswered. https://reviews.llvm.org/D27250 ___ cfe-commits mailing

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli updated this revision to Diff 79734. fpetrogalli added a comment. Rebase plus apply clang format. https://reviews.llvm.org/D27250 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CGCall.cpp lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

arphaman created this revision. arphaman added reviewers: bruno, akyrtzi. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. Code completion results for class methods already include instance methods from Objective-C root classes. This patch

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

djasper added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:82-94 + /// \brief Adds a replacement that inserts \p Text at \p Loc. If this + /// insertion conflicts with an existing insertion (at the same position), + /// this will be inserted

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

malcolm.parsons added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +//

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:82-94 + /// \brief Adds a replacement that inserts \p Text at \p Loc. If this + /// insertion conflicts with an existing insertion (at the same position), + /// this will be inserted before

[clang-tools-extra] r288244 - [include-fixer] Don't skip repeated lookups in plugin mode.

Author: d0k Date: Wed Nov 30 08:37:40 2016 New Revision: 288244 URL: http://llvm.org/viewvc/llvm-project?rev=288244=rev Log: [include-fixer] Don't skip repeated lookups in plugin mode. In this mode not all the errors are fixed so it doesn't make sense to ignore later ones. Modified:

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx removed rL LLVM as the repository for this revision. flx updated this revision to Diff 79732. flx marked an inline comment as done. https://reviews.llvm.org/D27248 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp test/clang-tidy/performance-unnecessary-value-param.cpp

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

flx added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +// marked with

[PATCH] D27142: [clang-tidy] Make format style customizable

malcolm.parsons added a subscriber: cfe-commits. malcolm.parsons added a comment. Always subscribe cfe-commits. Repository: rL LLVM https://reviews.llvm.org/D27142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

malcolm.parsons added inline comments. Comment at: clang-tidy/misc/MiscStringCompareCheck.cpp:48 + Finder->addMatcher(ifStmt(hasCondition(binaryOperator(hasOperatorName("=="), +hasLHS(strCompare +

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

djasper added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + ioeric wrote: > ioeric wrote: > > klimek wrote: > >

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79729. madsravn marked 3 inline comments as done. madsravn added a comment. Diff reflecting changes suggested by comments. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + ioeric wrote: > klimek wrote: > > ioeric wrote: > >

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson added a comment. In https://reviews.llvm.org/D27251#609014, @nemanjai wrote: > Thank you for fixing these issues. I certainly see how the shifts really need > to get the signedness right because the right shifts need to fill with the > sign bit (so that vector bool will still have all 0

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric updated this revision to Diff 79728. ioeric added a comment. - Make key customize-able. https://reviews.llvm.org/D27054 Files: include/clang/Tooling/Refactoring/EditList.h lib/Tooling/CMakeLists.txt lib/Tooling/Refactoring/CMakeLists.txt lib/Tooling/Refactoring/EditList.cpp

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

nemanjai added a comment. Thank you for fixing these issues. I certainly see how the shifts really need to get the signedness right because the right shifts need to fill with the sign bit (so that vector bool will still have all 0 or all 1 bits). However, I don't really follow why the

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + klimek wrote: > ioeric wrote: > > djasper wrote: > >

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. 1. Please provide full context for your changes (check this document how to do this http://llvm.org/docs/Phabricator.html). 2. Use clang-format for all your changes. 3. Do not use

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman added a comment. > Also, the following code (which is not valid) crashes with ToT trunk, > > @property (nonatomic) int OuterType::InnerType > > > but compiles without any errors with your patch applied. Do you know why > clang doesn't error out? This worked because clang continued

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman updated this revision to Diff 79722. arphaman added a comment. The updated patch performs the check in `ShouldEnterDeclaratorScope`. Repository: rL LLVM https://reviews.llvm.org/D26922 Files: lib/Parse/ParseDecl.cpp lib/Sema/SemaCXXScopeSpec.cpp test/SemaObjCXX/crash.mm

[PATCH] D27255: Protect std::ostream::sentry test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip test that throws an exception. https://reviews.llvm.org/D27255 Files: test/std/input.output/iostream.format/output.streams/ostream_sentry/destruct.pass.cpp

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Replace throw with TEST_THROW and skip tests that throw exceptions https://reviews.llvm.org/D27254 Files:

[PATCH] D27253: Protect futures test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip tests that expect an exception be thrown. https://reviews.llvm.org/D27253 Files: test/std/thread/futures/futures.promise/move_assign.pass.cpp Index:

[PATCH] D27252: Protect sequences test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Replace throw with TEST_THROW and protect tests that do throw. Also add missing assert(false). https://reviews.llvm.org/D27252 Files:

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + djasper wrote: > I wonder whether we should always

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric updated this revision to Diff 79716. ioeric marked 4 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D27054 Files: include/clang/Tooling/Refactoring/EditList.h lib/Tooling/CMakeLists.txt lib/Tooling/Refactoring/CMakeLists.txt

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman added a comment. In https://reviews.llvm.org/D26922#608815, @ahatanak wrote: > Yes, I meant ParseDecl:5266. Reading the comment in > ShouldEnterDeclaratorScope, it seemed to me that it shouldn't return true in > this context (when parsing an objective-c). Yes, I agree that it's

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman added a comment. In https://reviews.llvm.org/D26922#608815, @ahatanak wrote: > Yes, I meant ParseDecl:5266. Reading the comment in > ShouldEnterDeclaratorScope, it seemed to me that it shouldn't return true in > this context (when parsing an objective-c). > > Also, the following code

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli created this revision. fpetrogalli added a reviewer: cfe-commits. This patch generates a list of global external variables that are passed to the llvm::TargetLibraryInfo (TLI) to enable the vectorization of loops containing calls to function that are marked with a #pragma omp declare

[PATCH] D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

djasper added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + I wonder whether we should always use a

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

malcolm.parsons added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +//

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added a comment. Ping. Daniel, could you take a look? Manuel and I would like your opinion on this. https://reviews.llvm.org/D27054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D27248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27091: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ added a comment. Hmm, i'm thinking of just the opposite - refactor the CallEvent methods to use the respective new ProgramState methods. This way we'd avoid touching the CallEvent allocator for a simple Environment lookup, while still avoiding code duplication.

[PATCH] D26760: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ commandeered this revision. NoQ edited reviewers, added: k-wisniewski; removed: NoQ. NoQ added a comment. Seems to become outdated with https://reviews.llvm.org/D27091. https://reviews.llvm.org/D26760 ___ cfe-commits mailing list

[PATCH] D26589: Add static analyzer checker for finding infinite recursion

NoQ commandeered this revision. NoQ added a reviewer: k-wisniewski. NoQ added a comment. Seems to become outdated with https://reviews.llvm.org/D27092. https://reviews.llvm.org/D26589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ commandeered this revision. NoQ added a reviewer: k-wisniewski. NoQ added a comment. Seems to become outdated with https://reviews.llvm.org/D27090. https://reviews.llvm.org/D26588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

<    1   2