Author: matze
Date: Sat Dec 3 23:55:09 2016
New Revision: 288614
URL: http://llvm.org/viewvc/llvm-project?rev=288614=rev
Log:
TableGen: Adapt to llvm r288612
Modified:
cfe/trunk/utils/TableGen/ClangASTNodesEmitter.cpp
cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp
Modified:
compnerd added inline comments.
Comment at: tools/libclang/CXType.cpp:151-153
+ if (A.getKind() != TemplateArgument::Type)
+return MakeCXType(QualType(), TU);
+ return MakeCXType(A.getAsType(), TU);
Isn't this more compact as:
return
smeenai added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7710
+(Context.getTargetInfo().getCXXABI().isMicrosoft() ||
+ Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment())) {
+ // In the MS ABI, an explicit instantiation definition
smeenai updated this revision to Diff 80193.
smeenai added a comment.
Addressing comments
https://reviews.llvm.org/D26657
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/windows-itanium-dllexport.cpp
Index: test/CodeGenCXX/windows-itanium-dllexport.cpp
Author: sylvestre
Date: Sat Dec 3 17:22:45 2016
New Revision: 288605
URL: http://llvm.org/viewvc/llvm-project?rev=288605=rev
Log:
Add the --no-color option to the git call in the doc when using
clang-format-diff
Modified:
cfe/trunk/docs/ClangFormat.rst
Author: djg
Date: Sat Dec 3 17:03:52 2016
New Revision: 288604
URL: http://llvm.org/viewvc/llvm-project?rev=288604=rev
Log:
[WebAssembly] Revert r288447.
Revert r288447 which introduced -mdirect. It turns out we don't need a
custom flag for this, as the information we need is in the target
yixiang updated this revision to Diff 80192.
yixiang added a comment.
- Don't reset indent for statements with multiple blocks.
https://reviews.llvm.org/D27383
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
smeenai added inline comments.
Comment at: src/functional.cpp:1
+//===--- functional.cpp
---===//
+//
Should I clang-format new files? I based the style of this file on the existing
source files, but clang-format
smeenai added inline comments.
Comment at: lib/CMakeLists.txt:162
-# Add a object library that contains the compiled source files.
+# Add an object library that contains the compiled source files.
add_library(cxx_objects OBJECT ${exclude_from_all} ${LIBCXX_SOURCES}
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
bad_function_call is currently an empty class, so any object files using
that class will end up with their own copy of its typeinfo, typeinfo
ddcc added a comment.
Yeah, I had to implement implicit type promotion and conversion, because Z3
checks expression types pretty strictly.
https://reviews.llvm.org/D27365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: ioeric
Date: Sat Dec 3 09:28:03 2016
New Revision: 288586
URL: http://llvm.org/viewvc/llvm-project?rev=288586=rev
Log:
[clang-move] don't miss ',' in json output when there are duplicate elements.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified:
EricWF added a comment.
Sorry about Herald adding me as a reviewer. I need to fix my filters.
https://reviews.llvm.org/D27384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
skalinichev added a project: clang-c.
skalinichev updated this revision to Diff 80179.
https://reviews.llvm.org/D27384
Files:
test/Index/print-type.cpp
tools/libclang/CXType.cpp
Index: tools/libclang/CXType.cpp
===
---
skalinichev created this revision.
skalinichev added a subscriber: cfe-commits.
Herald added a reviewer: EricWF.
This was accidentally broken in r287024
https://reviews.llvm.org/D27384
Files:
test/Index/print-type.cpp
tools/libclang/CXType.cpp
Index: tools/libclang/CXType.cpp
Author: skalinichev
Date: Sat Dec 3 06:53:06 2016
New Revision: 288582
URL: http://llvm.org/viewvc/llvm-project?rev=288582=rev
Log:
[libclang] Fix python tests
It was broken in r286421
Modified:
cfe/trunk/bindings/python/tests/cindex/test_cursor.py
madsravn updated this revision to Diff 80177.
madsravn added a comment.
Did as comments suggested: Fixed the description about compare returning -1, 0
or 1. Fixed the ast matcher to only find compare with one argument.
Clang-formatted everything. Added a new test (str.compare("foo")) and wrote
yixiang added a comment.
> Can you add tests in unittests/Format/FormatTest.cpp (probably next to
> TEST_F(FormatTest, FormatsBlocks) {..})?
> What's the behavior when there is more than one block?
Unit tests added.
> Also note that we have some requirements for additional options (mainly to
yixiang updated this revision to Diff 80176.
yixiang added a comment.
- Added unit test for ObjCBlockResetsIndent.
https://reviews.llvm.org/D27383
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
djasper added a comment.
I think generally, this makes sense.
Can you add tests in unittests/Format/FormatTest.cpp (probably next to
TEST_F(FormatTest, FormatsBlocks) {..})?
What's the behavior when there is more than one block?
Also note that we have some requirements for additional options
yixiang abandoned this revision.
yixiang added a comment.
Sending as another diff using arcanist. This one doesn't have proper file
context for reviewing.
https://reviews.llvm.org/D27382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yixiang created this revision.
yixiang added a reviewer: djasper.
yixiang added subscribers: cfe-commits, klimek.
Add a new clang-format style option ObjCBlockResetsIndent of type bool. It
defaults to false.
When true, ObjC blocks resets indentation to that of its owner block.
The resetting
yixiang added a reviewer: djasper.
yixiang added a subscriber: cfe-commits.
yixiang updated this revision to Diff 80174.
https://reviews.llvm.org/D27382
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
23 matches
Mail list logo
