[libcxx] r288778 - Fix stdio module build on OS X

Author: ericwf Date: Tue Dec 6 01:40:46 2016 New Revision: 288778 URL: http://llvm.org/viewvc/llvm-project?rev=288778&view=rev Log: Fix stdio module build on OS X Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://llvm.org/viewvc/llv

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

Hahnfeld added a comment. Ping! https://reviews.llvm.org/D25669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

Hahnfeld added a comment. Ping! https://reviews.llvm.org/D26244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

mclow.lists accepted this revision. mclow.lists added a comment. I'd appreciate it if someone made a note to revisit this test when the clang bug is fixed, and change the `#ifndef __clang__ ` to something like `#ifndef __clang__ || clang_version < `". This LGTM. https://reviews.llvm.org/D

[PATCH] D27424: Add the diagnose_if attribute to clang.

EricWF added a comment. Awesome, this is exactly what I was hoping for! Thanks for working on this! I'm a bit surprised that the attribute fails to evaluate the condition as a constant expression during the evaluation of constexpr functions. Ex: #define DIAG(...) __attribute__((diagnose_if(_

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

amaiorano added a comment. In https://reviews.llvm.org/D27438#614219, @hans wrote: > When building the snapshots and releases, I usually put the SVN revision > number in there to avoid this same problem: > http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25 Ah, right, I was wonde

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. When building the snapshots and releases, I usually put the SVN revision number in there to avoid this same problem: http://llvm-cs.pcc.me.uk/utils/release/build_llvm_package.bat#25 Your patch se

[PATCH] D27360: [clang] Fix D26214: Move error handling out of MC and to the callers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288762: [clang] Fix D26214: Move error handling out of MC and to the callers. (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D27360?vs=80314&id=80369#toc Repository: rL LLVM

r288762 - [clang] Fix D26214: Move error handling out of MC and to the callers.

Author: mgrang Date: Mon Dec 5 20:49:16 2016 New Revision: 288762 URL: http://llvm.org/viewvc/llvm-project?rev=288762&view=rev Log: [clang] Fix D26214: Move error handling out of MC and to the callers. Summary: Related llvm patch: https://reviews.llvm.org/D27359 Reviewers: echristo, t.p.northov

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

danielcdh added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745 if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs && !CGM.getCodeGenOpts().EmitGcovNotes && + !CGM.getCodeGenOpts().Profi

[PATCH] D27360: [clang] Fix D26214: Move error handling out of MC and to the callers.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Im not the biggest fan of this. However, having some validation is probably better than not. We can come up with a better way to address this in the future when needed I suppose. https

[libcxx] r288760 - std::get<0>([std::variant constant expression]) *is* noexcept.

Author: caseycarter Date: Mon Dec 5 20:28:19 2016 New Revision: 288760 URL: http://llvm.org/viewvc/llvm-project?rev=288760&view=rev Log: std::get<0>([std::variant constant expression]) *is* noexcept. Differential review: http://reviews.llvm.org/D27436 Modified: libcxx/trunk/test/std/utiliti

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

CaseyCarter updated this revision to Diff 80365. CaseyCarter added a comment. Address review comments: - Annotate the clang bug which the conditional compilation is avoiding. - Assure the expression in question is not noexcept when not a constant expression. - Cover get_type https://reviews.ll

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

echristo added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2743-2745 if (LinkageName == Name || (!CGM.getCodeGenOpts().EmitGcovArcs && !CGM.getCodeGenOpts().EmitGcovNotes && + !CGM.getCodeGenOpts().Profil

r288756 - Clean up some Sema checking code. NFC

Author: rtrieu Date: Mon Dec 5 19:42:28 2016 New Revision: 288756 URL: http://llvm.org/viewvc/llvm-project?rev=288756&view=rev Log: Clean up some Sema checking code. NFC - Rename CheckMinZero to CheckMaxUnsignedZero to reflect its actual purpose. - Remove unused parameters from CheckAbsoluteVal

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land. Comment at: test/std/utilities/variant/variant.get/get_index.pass.cpp:39 constexpr V v(42); -ASSERT_NOT_NOEXCEPT(std::get<0>(v)); +#ifndef __clang__ +ASSERT_

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 80361. smeenai added a comment. Addressing @compnerd's comments https://reviews.llvm.org/D26949 Files: src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handlers.hpp src/cxa_new_

Re: clang-format-vsix: versioning patch and show stderrors patch

I've created the two reivews on phabricator: https://reviews.llvm.org/D27438 https://reviews.llvm.org/D27440 Thanks! On Mon, 5 Dec 2016 at 11:01 Manuel Klimek wrote: > On Mon, Dec 5, 2016 at 3:53 PM Antonio Maiorano > wrote: > > Hi Manuel, > > Okay, I'll submit both patches via phabricator as

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

amaiorano added a comment. With this change, I now get the following message box when my .clang-format has an invalid field named "SomeInvalidField": F2652560: 0.png I do have to wonder whether the real bug is the fact that clang-format returns a success stat

[libcxx] r288755 - Fix C++03 modules build

Author: ericwf Date: Mon Dec 5 19:34:24 2016 New Revision: 288755 URL: http://llvm.org/viewvc/llvm-project?rev=288755&view=rev Log: Fix C++03 modules build Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://llvm.org/viewvc/llvm-proje

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

STL_MSFT added a comment. I also saw get_type.pass.cpp failing. I would recommend commenting the ifndef with the clang bug URL you found. https://reviews.llvm.org/D27436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

amaiorano created this revision. amaiorano added reviewers: klimek, hans, zturner. amaiorano added a subscriber: cfe-commits. When clang-format outputs to stderr but returns 0, the extension will format the code anyway. This happens, for instance, when there's a syntax error or unknown value in

[PATCH] D27439: [libcxx][modules] Fix 's module definition

EricWF created this revision. EricWF added reviewers: rsmith, manmanren, bruno. EricWF added subscribers: cfe-commits, rsmith. Currently libc++'s `stddef.h` is treated as a textual header by the module map, and technically this is correct because the header is non-modular (at least during normal

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

amaiorano created this revision. amaiorano added reviewers: klimek, hans, zturner. amaiorano added a subscriber: cfe-commits. Herald added a subscriber: mgorny. Presently, the version number of the VSIX matches the LLVM version number. However, as this number doesn't change often, it means that a

[PATCH] D26623: [libcxx] [test] Swapping non-equal non-POCS allocators is UB.

STL_MSFT updated this revision to Diff 80352. STL_MSFT added a comment. Merged with the recent addition of static_cast to various lines in the unordered container tests. No actual changes to the diff, only to the context. https://reviews.llvm.org/D26623 Files: test/std/containers/associativ

[PATCH] D27268: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288752. https://reviews.llvm.org/D27268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27269: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288753. https://reviews.llvm.org/D27269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27025: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288749. https://reviews.llvm.org/D27025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27267: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288751. https://reviews.llvm.org/D27267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27266: [libcxx] [test] Remove spurious semicolons.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288750. https://reviews.llvm.org/D27266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27024: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288748. https://reviews.llvm.org/D27024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27023: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288747. https://reviews.llvm.org/D27023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

compnerd added a comment. Please don't canonicalize the triple that way. The behavior of `armv7-unknown-linux-gnueabi` is different from `armv7-unknown-linux-gnueabihf` which is different from `armv7-unknown-linux-gnueabihf -mfloat-abi=hard`. I agree that this is absolutely terrible and unexp

[PATCH] D27022: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288746. https://reviews.llvm.org/D27022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27021: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 8/12.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, r288745. https://reviews.llvm.org/D27021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r288752 - [libcxx] [test] D27268: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4.

Author: stl_msft Date: Mon Dec 5 19:14:43 2016 New Revision: 288752 URL: http://llvm.org/viewvc/llvm-project?rev=288752&view=rev Log: [libcxx] [test] D27268: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4. Use static_cast when

[libcxx] r288753 - [libcxx] [test] D27269: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4.

Author: stl_msft Date: Mon Dec 5 19:14:51 2016 New Revision: 288753 URL: http://llvm.org/viewvc/llvm-project?rev=288753&view=rev Log: [libcxx] [test] D27269: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4. test/std/containers/

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

CaseyCarter added inline comments. Comment at: test/std/utilities/variant/variant.get/get_index.pass.cpp:39 constexpr V v(42); -ASSERT_NOT_NOEXCEPT(std::get<0>(v)); +#ifndef __clang__ +ASSERT_NOEXCEPT(std::get<0>(v)); THAT'S RIGHT, A CLANG BUG (https

[libcxx] r288751 - [libcxx] [test] D27267: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4.

Author: stl_msft Date: Mon Dec 5 19:14:29 2016 New Revision: 288751 URL: http://llvm.org/viewvc/llvm-project?rev=288751&view=rev Log: [libcxx] [test] D27267: Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4. Replace "int n = str

[libcxx] r288750 - [libcxx] [test] D27266: Remove spurious semicolons.

Author: stl_msft Date: Mon Dec 5 19:14:06 2016 New Revision: 288750 URL: http://llvm.org/viewvc/llvm-project?rev=288750&view=rev Log: [libcxx] [test] D27266: Remove spurious semicolons. Modified: libcxx/trunk/test/std/containers/unord/unord.multimap/unord.multimap.cnstr/range_size_hash_equa

[libcxx] r288749 - [libcxx] [test] D27025: Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12.

Author: stl_msft Date: Mon Dec 5 19:13:51 2016 New Revision: 288749 URL: http://llvm.org/viewvc/llvm-project?rev=288749&view=rev Log: [libcxx] [test] D27025: Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12. Various changes: test/std/algorithms/alg.sorting/alg.merge/inplace_merge.

[libcxx] r288748 - [libcxx] [test] D27024: Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.

Author: stl_msft Date: Mon Dec 5 19:13:40 2016 New Revision: 288748 URL: http://llvm.org/viewvc/llvm-project?rev=288748&view=rev Log: [libcxx] [test] D27024: Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12. Change "unsigned n = 0;" to "int n = 0;". It's being compared to int eleme

[libcxx] r288747 - [libcxx] [test] D27023: Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

Author: stl_msft Date: Mon Dec 5 19:13:29 2016 New Revision: 288747 URL: http://llvm.org/viewvc/llvm-project?rev=288747&view=rev Log: [libcxx] [test] D27023: Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12. Add static_cast. In these cases, the values are guaranteed to be small-ish

[libcxx] r288746 - [libcxx] [test] D27022: Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12.

Author: stl_msft Date: Mon Dec 5 19:13:14 2016 New Revision: 288746 URL: http://llvm.org/viewvc/llvm-project?rev=288746&view=rev Log: [libcxx] [test] D27022: Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12. Add static_cast to more comparisons. (Performed manually, unlike part 8/12

[PATCH] D27436: [libcxx] [test] std::get<0>([std::variant constant expression]) *is* noexcept

CaseyCarter created this revision. CaseyCarter added reviewers: EricWF, mclow.lists. CaseyCarter added a subscriber: cfe-commits. noexcept(foo) is true when foo is a constant expression. https://reviews.llvm.org/D27436 Files: test/std/utilities/variant/variant.get/get_index.pass.cpp Index:

[PATCH] D27268: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4.

STL_MSFT updated this revision to Diff 80348. STL_MSFT added a comment. Changed data members to size_t as requested (also changed parameters for consistency). https://reviews.llvm.org/D27268 Files: test/std/utilities/optional/optional.specalg/make_optional_explicit_initializer_list.pass.cpp

[libcxx] r288743 - Add support for writing -verify shell tests

Author: ericwf Date: Mon Dec 5 19:02:15 2016 New Revision: 288743 URL: http://llvm.org/viewvc/llvm-project?rev=288743&view=rev Log: Add support for writing -verify shell tests Modified: libcxx/trunk/test/libcxx/compiler.py libcxx/trunk/test/libcxx/test/config.py libcxx/trunk/test/lib

[PATCH] D27023: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

STL_MSFT updated this revision to Diff 80347. STL_MSFT added a comment. Changed loop indices to int as requested. https://reviews.llvm.org/D27023 Files: test/std/algorithms/alg.modifying.operations/alg.move/move.pass.cpp test/std/algorithms/alg.modifying.operations/alg.move/move_backward.pa

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The macOS thread-local variable finalizer routines do not handle the case where a termination function registers another termination function correctly, causing this test to fail.

Re: r288626 - Revert "Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include the headers of the module textually in this case, still enforcing the modules se

On 4 December 2016 at 20:44, Richard Smith wrote: > On 4 Dec 2016 2:44 pm, "Daniel Jasper via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Author: djasper > Date: Sun Dec 4 16:34:37 2016 > New Revision: 288626 > > URL: http://llvm.org/viewvc/llvm-project?rev=288626&view=rev > Log: > R

r288741 - Revert r288626, which reverts r288449. Original commit message:

Author: rsmith Date: Mon Dec 5 18:40:17 2016 New Revision: 288741 URL: http://llvm.org/viewvc/llvm-project?rev=288741&view=rev Log: Revert r288626, which reverts r288449. Original commit message: Recover better from an incompatible .pcm file being provided by -fmodule-file=. We try to include t

r288740 - Add test for r288732, warn on unsigned zero in std::max

Author: rtrieu Date: Mon Dec 5 18:27:21 2016 New Revision: 288740 URL: http://llvm.org/viewvc/llvm-project?rev=288740&view=rev Log: Add test for r288732, warn on unsigned zero in std::max Added: cfe/trunk/test/SemaCXX/warn-max-unsigned-zero.cpp Added: cfe/trunk/test/SemaCXX/warn-max-unsigne

r288738 - Additional test file missed from r288737.

Author: rsmith Date: Mon Dec 5 18:14:22 2016 New Revision: 288738 URL: http://llvm.org/viewvc/llvm-project?rev=288738&view=rev Log: Additional test file missed from r288737. Added: cfe/trunk/test/Modules/redundant-include.mm Added: cfe/trunk/test/Modules/redundant-include.mm URL: http://ll

r288737 - [modules] Use the "redundant #include" diagnostic rather than the "module

Author: rsmith Date: Mon Dec 5 18:12:39 2016 New Revision: 288737 URL: http://llvm.org/viewvc/llvm-project?rev=288737&view=rev Log: [modules] Use the "redundant #include" diagnostic rather than the "module import can't appear here" diagnostic if an already-visible module is textually entered (bec

Re: [PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

From a Darwin perspective, this LGTM (it's what we're shipping on macOS 10.12 and iOS 10). Eric, do you have a good idea for how to test this? > On 2016-Dec-05, at 14:36, Bruno Cardoso Lopes via Phabricator > wrote: > > bruno created this revision. > bruno added reviewers: mclow.lists, dexons

[libcxx] r288736 - Allow enabling/disabling testing with module using env LIBCXX_USE_MODULES=1

Author: ericwf Date: Mon Dec 5 18:01:04 2016 New Revision: 288736 URL: http://llvm.org/viewvc/llvm-project?rev=288736&view=rev Log: Allow enabling/disabling testing with module using env LIBCXX_USE_MODULES=1 The Clang modules implementation breaks enough that libc++ needs an easy way to enable/d

[libcxx] r288735 - Add module definitions for headers

Author: ericwf Date: Mon Dec 5 17:55:34 2016 New Revision: 288735 URL: http://llvm.org/viewvc/llvm-project?rev=288735&view=rev Log: Add module definitions for headers Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://llvm.org/viewv

[libcxx] r288733 - Add module definitions for string_view

Author: ericwf Date: Mon Dec 5 17:53:23 2016 New Revision: 288733 URL: http://llvm.org/viewvc/llvm-project?rev=288733&view=rev Log: Add module definitions for string_view Modified: libcxx/trunk/include/module.modulemap libcxx/trunk/include/string_view Modified: libcxx/trunk/include/modu

r288732 - Warn on unsigned zero in call to std::max

Author: rtrieu Date: Mon Dec 5 17:41:46 2016 New Revision: 288732 URL: http://llvm.org/viewvc/llvm-project?rev=288732&view=rev Log: Warn on unsigned zero in call to std::max New default warning that triggers when an unsigned zero is used in a call to std::max. For unsigned values, zero is the m

[libcxx] r288730 - Add modules for any/optional/variant

Author: ericwf Date: Mon Dec 5 17:33:19 2016 New Revision: 288730 URL: http://llvm.org/viewvc/llvm-project?rev=288730&view=rev Log: Add modules for any/optional/variant Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL: http://llvm.org/view

r288723 - [docs] Use x86_64 and i386 instead of x86 as arch for triples.

Author: fhahn Date: Mon Dec 5 16:52:20 2016 New Revision: 288723 URL: http://llvm.org/viewvc/llvm-project?rev=288723&view=rev Log: [docs] Use x86_64 and i386 instead of x86 as arch for triples. Summary: x86 is not a valid arch for target triples, but x86_64 and i386 are. Reviewers: rengolin, si

[libcxx] r288728 - Adjust libc++ test infastructure to fully support modules

Author: ericwf Date: Mon Dec 5 17:16:07 2016 New Revision: 288728 URL: http://llvm.org/viewvc/llvm-project?rev=288728&view=rev Log: Adjust libc++ test infastructure to fully support modules This patch overhalls the libc++ test format/configuration in order to fully support modules. By "fully su

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai added a comment. https://reviews.llvm.org/D27430 should unblock this. https://reviews.llvm.org/D25208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 80334. smeenai added a comment. Rebasing https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config Index: include/__config === --- include/__config +++

[PATCH] D27430: [libc++] Annotate template methods with visibility

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added subscribers: cfe-commits, thakis. https://reviews.llvm.org/D25208 switches `_LIBCPP_TYPE_VIS` to expand to default visibility instead of default type visibility, in order to ease building libc++ with hidden

[PATCH] D26960: [docs] Use x86_64 and i386 instead of x86 as arch for triples.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288723: [docs] Use x86_64 and i386 instead of x86 as arch for triples. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D26960?vs=78842&id=80332#toc Repository: rL LLVM https:/

r288721 - CodeGen: fix windows itanium RTTI in EH mode

Author: compnerd Date: Mon Dec 5 16:40:20 2016 New Revision: 288721 URL: http://llvm.org/viewvc/llvm-project?rev=288721&view=rev Log: CodeGen: fix windows itanium RTTI in EH mode When emitting RTTI for EH only, we would mark the locally defined (LinkOnceODR) RTTI definition as dllimport, which i

[PATCH] D27140: Allow clang to write compilation database records

arichardson added a comment. It would also be good to append --sysroot=DEFAULT_SYSROOT if DEFAULT_SYSROOT is not empty and there is no explicit --sysroot flag. That way the compilation database can also be consumed by a libclang based too that does not have the same DEFAULT_SYSROOT set. Repos

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

bruno created this revision. bruno added reviewers: mclow.lists, dexonsmith, EricWF. bruno added a subscriber: cfe-commits. CLOCK_MONOTONIC is only defined on Darwin on libc versions >= 1133 and its behaviour differs from Linux. CLOCK_UPTIME on Darwin actually matches CLOCK_MONOTONIC on Linux, du

[PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added a comment. Ping :) https://reviews.llvm.org/D14274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27360: [clang] Fix D26214: Move error handling out of MC and to the callers.

mgrang updated this revision to Diff 80314. https://reviews.llvm.org/D27360 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/Tools.cpp test/Driver/defsym.s tools/driver/cc1as_main.cpp Index: tools/driver/cc1as_main.cpp ==

[PATCH] D27360: [clang] Fix D26214: Move error handling out of MC and to the callers.

mgrang added a comment. Moved error checking up to the driver and added another test case. https://reviews.llvm.org/D27360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26376: Undef stdatomic.h macro definitions that are defining functions provided in libc++

mehdi_amini abandoned this revision. mehdi_amini added a comment. Thanks for the information! Closing this. https://reviews.llvm.org/D26376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D27365: [analyzer] Print type for SymbolRegionValues when dumping to stream

This revision was automatically updated to reflect the committed changes. Closed by commit rL288696: [analyzer] Print type for SymbolRegionValues when dumping to stream (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D27365?vs=80310&id=80311#toc Repository: rL LLVM htt

[PATCH] D27365: [analyzer] Print type for SymbolRegionValues when dumping to stream

ddcc updated this revision to Diff 80310. ddcc added a comment. Fix rebase https://reviews.llvm.org/D27365 Files: lib/StaticAnalyzer/Core/SymbolManager.cpp test/Analysis/expr-inspection.c Index: test/Analysis/expr-inspection.c ==

r288696 - [analyzer] Print type for SymbolRegionValues when dumping to stream

Author: ddcc Date: Mon Dec 5 14:30:11 2016 New Revision: 288696 URL: http://llvm.org/viewvc/llvm-project?rev=288696&view=rev Log: [analyzer] Print type for SymbolRegionValues when dumping to stream Reviewers: NoQ, dcoughlin, zaks.anna Subscribers: cfe-commits Differential Revision: https://rev

[PATCH] D27424: Add the diagnose_if attribute to clang.

george.burgess.iv created this revision. george.burgess.iv added reviewers: rsmith, aaron.ballman. george.burgess.iv added subscribers: EricWF, cfe-commits. This patch adds the `diagnose_if` attribute to clang. `diagnose_if` is meant to be a less powerful version of `enable_if`: it doesn't inter

[PATCH] D27383: Add a new clang-format style option ObjCBlockResetsIndent.

yixiang added a comment. Discover a case where my code breaks. When the block signature has a return type in it, the indent doesn't gets reset properly. I need to fix this. // clang-format -style='{ObjCBlockResetsIndent: true}' test.m [self callAsyncMethodWithParam:2 withCompletio

[libcxxabi] r288692 - [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS

Author: smeenai Date: Mon Dec 5 13:42:11 2016 New Revision: 288692 URL: http://llvm.org/viewvc/llvm-project?rev=288692&view=rev Log: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS It's useful to be able to disable visibility annotations entirely; for example, if we're building libc++a

[PATCH] D26950: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS

This revision was automatically updated to reflect the committed changes. Closed by commit rL288692: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26950?vs=78809&id=80306#toc Repository: rL LLVM https://re

Re: [PATCH] D26376: Undef stdatomic.h macro definitions that are defining functions provided in libc++

On 5 December 2016 at 11:34, Mehdi AMINI via Phabricator < revi...@reviews.llvm.org> wrote: > mehdi_amini added a comment. > > In https://reviews.llvm.org/D26376#597614, @mclow.lists wrote: > > > More info - The following code: > > > > #include > > int main () {} > > > > > > fails to compile

[libcxx] r288690 - [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

Author: smeenai Date: Mon Dec 5 13:40:12 2016 New Revision: 288690 URL: http://llvm.org/viewvc/llvm-project?rev=288690&view=rev Log: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS It's useful to be able to disable visibility annotations entirely; for example, if we're building libc++ static

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

This revision was automatically updated to reflect the committed changes. Closed by commit rL288690: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26934?vs=79359&id=80304#toc Repository: rL LLVM https://reviews.

[PATCH] D27153: [libc++] Make __num_get_float hidden

smeenai added a comment. In https://reviews.llvm.org/D27153#613140, @EricWF wrote: > In https://reviews.llvm.org/D27153#606296, @smeenai wrote: > > > I'm having some second thoughts about this. Visibility for template > > functions makes my head spin :/ Is there a general policy we've been > >

r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

Author: vitalybuka Date: Mon Dec 5 13:25:00 2016 New Revision: 288689 URL: http://llvm.org/viewvc/llvm-project?rev=288689&view=rev Log: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec Summary: Similar to r288685. getExceptionSpec returned structure with pointers to tempo

[PATCH] D27422: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL288689: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D27422?vs=80299&id=80300#toc Repository: r

[PATCH] D26376: Undef stdatomic.h macro definitions that are defining functions provided in libc++

mehdi_amini added a comment. In https://reviews.llvm.org/D26376#597614, @mclow.lists wrote: > More info - The following code: > > #include > int main () {} > > > fails to compile on either gcc 6.2 (locally), gcc 7 head (online compiler) or > MSVC (online compiler). Interesting, that le

[PATCH] D27422: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

vitalybuka created this revision. vitalybuka added a reviewer: rsmith. vitalybuka added subscribers: cfe-commits, aizatsky. Similar to r288685. getExceptionSpec returned structure with pointers to temporarily object created by computeImplicitExceptionSpec. https://reviews.llvm.org/D27422 Files:

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

mkuper added a comment. If there are real-life usecases, then GCC-compatible behavior is probably better than just rejecting it outright, so I'm retracting my comment from PR30426. (I would probably have liked x86_64 with -mno-sse2 and no -msoft-float to be an error, but I would also like a po

[PATCH] D27420: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL288685: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D27420?vs=80290&id=80292#toc Repository: rL LLVM https:

r288685 - Fix stack-use-after-scope in EvaluateImplicitExceptionSpec

Author: vitalybuka Date: Mon Dec 5 12:30:22 2016 New Revision: 288685 URL: http://llvm.org/viewvc/llvm-project?rev=288685&view=rev Log: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec Summary: getExceptionSpec returns structure with pointers to temporarily object created by computeImp

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

danielcdh added a comment. ping https://reviews.llvm.org/D25435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

> Perhaps that is the problem (that there are two modes that do different > things)? Could we make the double overload be present but unselectable to > diagnose this problem in that mode too? If we could resolve the overload candidate to prefer ‘int -> float’ than ‘int->double’, it would work b

[PATCH] D27420: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec

vitalybuka created this revision. vitalybuka added a reviewer: rsmith. vitalybuka added subscribers: cfe-commits, aizatsky. getExceptionSpec returns structure with pointers to temporarily object created by computeImplicitExceptionSpec. https://reviews.llvm.org/D27420 Files: lib/Sema/SemaDeclC

[PATCH] D25417: [libcxxabi] Fix alignment of allocated exceptions in 32 bit builds

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I thought we had gotten this merged already. Oops. LGTM with the minor tweak for windows. Comment at: src/fallback_malloc.cpp:206 +return fallback_malloc(size); }

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

This revision was automatically updated to reflect the committed changes. Closed by commit rL288682: [Sema] Respect DLL attributes more faithfully (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26657?vs=80193&id=80289#toc Repository: rL LLVM https://reviews.llvm.o

r288682 - [Sema] Respect DLL attributes more faithfully

Author: smeenai Date: Mon Dec 5 12:01:35 2016 New Revision: 288682 URL: http://llvm.org/viewvc/llvm-project?rev=288682&view=rev Log: [Sema] Respect DLL attributes more faithfully On MSVC, if an implicit instantiation already exists and an explicit instantiation definition with a DLL attribute is

[PATCH] D26949: [libc++abi] Clean up visibility

compnerd added a comment. I really like the clean up this does. It removes the unnecessary usage of the GCC pragmas and cleans up the definitions by using the headers more properly. Comment at: src/abort_message.h:19 -__attribute__((visibility("hidden"), noreturn)) +_LIBCXX

Re: [PATCH] D27387: [libc++] Add a key function for bad_function_call

Yes, they are: -- $ clang -dM -x c /dev/null -E -mmacosx-version-min=10.10.0 | grep VERSION_MIN #define __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ 101000 -- However, they're somewhat awkward, extremely vendor-specific, and unrelated to libc++ version numbers. I think a separate ABI flag would

[PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

arphaman updated this revision to Diff 80285. arphaman marked 2 inline comments as done. arphaman added a comment. The updated patch addresses Bruno's comments. Repository: rL LLVM https://reviews.llvm.org/D16533 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp l

  1   2   >