Author: djasper
Date: Mon Dec 19 01:26:11 2016
New Revision: 290084
URL: http://llvm.org/viewvc/llvm-project?rev=290084=rev
Log:
clang-format: Allow "single column" list layout even if that violates the
column limit.
Single-column layout basically means that we format the list with one
element
Hi Piotr,
Thank you for your detailed comments :)
I would love some help with the other fixit. I have some notes on it at
home. But my main catch is that is an implicit cast to boolean from
str.compare(str) with maybe an ! in front of it. And I need to fix that to
str.compare(str) == 0 or
echuraev updated this revision to Diff 81917.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D27569
Files:
include/clang/AST/OperationKinds.def
include/clang/Sema/Initialization.h
include/clang/Sema/Overload.h
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExprAgg.cpp
xiangzhai added a comment.
LLVMBUG-31017 https://llvm.org/bugs/show_bug.cgi?id=31017#c4
In https://reviews.llvm.org/D16171#540261, @phabricss wrote:
> On 09/12/2016 01:26 PM, Nick Lewycky wrote:
>
> > Firstly, I thought glibc had applied a patch to fix this bug? As in, the
> > error is correct
Author: rsmith
Date: Sun Dec 18 22:21:36 2016
New Revision: 290082
URL: http://llvm.org/viewvc/llvm-project?rev=290082=rev
Log:
Add __cpp_structured_bindings feature test macro for structured bindings, per
latest (provisional) draft of SD-6.
Modified:
Author: rsmith
Date: Sun Dec 18 22:16:03 2016
New Revision: 290081
URL: http://llvm.org/viewvc/llvm-project?rev=290081=rev
Log:
[c++1z] cxx_status: mark p0195r2 as done.
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor.cpp
cfe/trunk/test/Lexer/cxx-features.cpp
Author: rsmith
Date: Sun Dec 18 22:08:53 2016
New Revision: 290080
URL: http://llvm.org/viewvc/llvm-project?rev=290080=rev
Log:
[c++1z] P0195R2: Support pack-expansion of using-declarations.
This change introduces UsingPackDecl as a marker for the set of UsingDecls
produced by pack expansion of
Author: yaxunl
Date: Sun Dec 18 20:55:53 2016
New Revision: 290075
URL: http://llvm.org/viewvc/llvm-project?rev=290075=rev
Log:
Add a lit test for PR31374
Differential Revision: https://reviews.llvm.org/D27909
Added:
cfe/trunk/test/CodeGenObjC/nullptr-assert.m
Added:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290075: Add a lit test for PR31374 (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D27909?vs=81907=81910#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27909
Files:
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks!
Comment at: test/CodeGenObjC/nullptr-assert.m:1
+// RUN: %clang_cc1 -Wno-objc-root-class -triple x86_64-- -emit-llvm -o - %s
+// REQUIRES: asserts
yaxunl created this revision.
yaxunl added a reviewer: thakis.
yaxunl added a subscriber: cfe-commits.
https://reviews.llvm.org/D27909
Files:
test/CodeGenObjC/nullptr-assert.m
Index: test/CodeGenObjC/nullptr-assert.m
===
---
Prazek added a comment.
Do you need some help with implementing the other fixit, or you just need some
extra time? It seems to be almost the same as your second fixit
Comment at: clang-tidy/misc/StringCompareCheck.cpp:69-70
+diag(Matched->getLocStart(),
+ "do not
Author: rsmith
Date: Sun Dec 18 16:01:46 2016
New Revision: 290072
URL: http://llvm.org/viewvc/llvm-project?rev=290072=rev
Log:
Fix name hiding and redeclaration checking for dependent local
using-declarations.
Modified:
cfe/trunk/lib/Sema/SemaDeclCXX.cpp
Author: rsmith
Date: Sun Dec 18 15:39:37 2016
New Revision: 290071
URL: http://llvm.org/viewvc/llvm-project?rev=290071=rev
Log:
Fix some interactions between C++11 and C++14 features and using-declarations:
* a dependent non-type using-declaration within a function template can be
valid, as
majnemer added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:433-434
void CGDebugInfo::CreateCompileUnit() {
+ SmallString<32> Checksum;
+ llvm::DIFile::ChecksumKind CSKind = llvm::DIFile::CSK_None;
Formatting looks wrong
madsravn updated this revision to Diff 81885.
madsravn added a comment.
Small changes made by suggestions. strCompare is now with uppercase: StrCompare
Checking for str.compare(str) == {-1,1} as well.
https://reviews.llvm.org/D27210
Files:
clang-tidy/misc/CMakeLists.txt
malcolm.parsons abandoned this revision.
malcolm.parsons added a comment.
Abandon until we have a plan.
https://reviews.llvm.org/D25659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: rksimon
Date: Sun Dec 18 08:12:38 2016
New Revision: 290063
URL: http://llvm.org/viewvc/llvm-project?rev=290063=rev
Log:
Wdocumentation fix
Modified:
cfe/trunk/include/clang/Basic/OpenCLOptions.h
Modified: cfe/trunk/include/clang/Basic/OpenCLOptions.h
URL:
amaiorano added a comment.
In https://reviews.llvm.org/D27440#624917, @djasper wrote:
> Yes.. return non-zero seems right. This is an error condition.
Hi @djasper ,
I started looking into making the changes to clang-format to have it return an
error code when it's unable to parse the
mgorny created this revision.
mgorny added reviewers: sdmitrouk, rengolin, zatrazz.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: dberris, aemerson.
Implement the missing __floattitf() and __floatuntitf() functions, to
convert 128-bit (unsigned) integers to quad-precision
20 matches
Mail list logo
