r290329 - Speculative revert of r290310 to see if that's the change that's making some of

Author: rsmith Date: Thu Dec 22 01:24:39 2016 New Revision: 290329 URL: http://llvm.org/viewvc/llvm-project?rev=290329=rev Log: Speculative revert of r290310 to see if that's the change that's making some of the bots unhappy. Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified:

r290326 - [CrashReproducer] Add support for merging -ivfsoverlay

Author: bruno Date: Thu Dec 22 01:06:03 2016 New Revision: 290326 URL: http://llvm.org/viewvc/llvm-project?rev=290326=rev Log: [CrashReproducer] Add support for merging -ivfsoverlay Merge all VFS mapped files inside -ivfsoverlay inputs into the vfs overlay provided by the crash reproducer. This

[PATCH] D27710: [analyzer] Prohibit ExplodedGraph's edges duplicating

zaks.anna added a comment. If this is a common mistake for checker writers, we could consider adding assertions that check for this situation. We should make sure that we do not to add any release builds overhead. Maybe we could put this check behind NDEBUG or ensure that whatever code is

r290319 - Make FormatStyle.GetStyleOfFile test work on MSVC

Author: amaiorano Date: Wed Dec 21 23:10:07 2016 New Revision: 290319 URL: http://llvm.org/viewvc/llvm-project?rev=290319=rev Log: Make FormatStyle.GetStyleOfFile test work on MSVC Modify getStyle to use vfs::FileSystem::makeAbsolute just like FS.addFile does, rather than sys::fs::make_absolute.

r290315 - Sema: print qualified name for overload candidates

Author: compnerd Date: Wed Dec 21 22:26:57 2016 New Revision: 290315 URL: http://llvm.org/viewvc/llvm-project?rev=290315=rev Log: Sema: print qualified name for overload candidates Print the fully qualified names for the overload candidates. This makes it easier to tell what the ambiguity is.

r290310 - Only substitute into type of non-type template parameter once, rather than

Author: rsmith Date: Wed Dec 21 21:52:37 2016 New Revision: 290310 URL: http://llvm.org/viewvc/llvm-project?rev=290310=rev Log: Only substitute into type of non-type template parameter once, rather than twice, in finalization of template argumetn deduction. Modified:

r290304 - Driver: remove unnecessary parameter

Author: compnerd Date: Wed Dec 21 21:09:02 2016 New Revision: 290304 URL: http://llvm.org/viewvc/llvm-project?rev=290304=rev Log: Driver: remove unnecessary parameter We can query the Triple and EffectiveTriple from the ToolChain. Avoid passing in the argument and query it in the function.

r290305 - Driver: use the triple to query the arch, not the toolchain

Author: compnerd Date: Wed Dec 21 21:09:04 2016 New Revision: 290305 URL: http://llvm.org/viewvc/llvm-project?rev=290305=rev Log: Driver: use the triple to query the arch, not the toolchain Although the result is the same, the intent is much more clear this way: we care about the architecture we

r290303 - Driver: rename parameter to reduce confusion

Author: compnerd Date: Wed Dec 21 21:09:00 2016 New Revision: 290303 URL: http://llvm.org/viewvc/llvm-project?rev=290303=rev Log: Driver: rename parameter to reduce confusion The parameter to ParsePICOpts passed the effective triple and then used that in a few places and used the actual triple

r290297 - Add the alloc_size attribute to clang, attempt 2.

Author: gbiv Date: Wed Dec 21 20:50:20 2016 New Revision: 290297 URL: http://llvm.org/viewvc/llvm-project?rev=290297=rev Log: Add the alloc_size attribute to clang, attempt 2. This is a recommit of r290149, which was reverted in r290169 due to msan failures. msan was failing because we were

[PATCH] D28037: [PowerPC, DAGCombiner] Change vec_sl to a << (b % (sizeof(a) * 8)), and fold it back to a << b.

timshen created this revision. timshen added reviewers: kbarton, hfinkel, iteratee, echristo, bogner. timshen added subscribers: llvm-commits, cfe-commits. Herald added subscribers: amehsan, nemanjai, mehdi_amini. For a << b (as original vec_sl does), if b >= sizeof(a) * 8, the behavior is

[clang-tools-extra] r290289 - [clang-tidy] Ignore `size() == 0` in the container implementation.

Author: alexfh Date: Wed Dec 21 17:44:23 2016 New Revision: 290289 URL: http://llvm.org/viewvc/llvm-project?rev=290289=rev Log: [clang-tidy] Ignore `size() == 0` in the container implementation. Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak added a comment. In https://reviews.llvm.org/D27680#628272, @rjmccall wrote: > Wouldn't it be simpler to just record an insertion point for the beginning of > the current lexical scope and insert the lifetime.begin there instead of at > the current IP? I'm not sure I understood your

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin added a comment. In https://reviews.llvm.org/D27773#629171, @dcoughlin wrote: > I already committed this, but I'll address the feedback in a follow-on commit. I should have written "I already committed this, *so* I'll address the feedback in a follow-on commit."

Re: [clang-tools-extra] r290202 - [clang-tidy] Add modernize-use-default-member-init check

It'd be the issue if the test depended on installed headers. The builder doesn't have MS headers installed. On Thu, Dec 22, 2016 at 1:27 AM Aaron Ballman wrote: > On Tue, Dec 20, 2016 at 5:58 PM, Malcolm Parsons > wrote: > > On 20 December

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

dcoughlin added a comment. I already committed this, but I'll address the feedback in a follow-on commit. Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:172 +const CXXConstructorCall *Call, CheckerContext ) const { + assert(Call->getNumArgs() > 0); +

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak updated this revision to Diff 82279. ahatanak marked an inline comment as done. ahatanak added a comment. Remove Addr and Size from CallLifetimeEnd. https://reviews.llvm.org/D27680 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGStmt.cpp

[PATCH] D28034: [ASTMatchers] Add hasInClassInitializer traversal matcher for FieldDecl.

malcolm.parsons created this revision. malcolm.parsons added reviewers: sbenza, bkramer, klimek. malcolm.parsons added a subscriber: cfe-commits. I needed to know whether a FieldDecl had an in-class initializer for https://reviews.llvm.org/D26453. I used a narrowing matcher there, but a

[PATCH] D28033: [analyzer] Treat pointers to static member functions as function pointers

dcoughlin created this revision. dcoughlin added a reviewer: kromanenkov. dcoughlin added subscribers: cfe-commits, NoQ, zaks.anna. Sema treats pointers to static member functions as having function pointer type, so treat treat them as function pointer values in the analyzer as well. This

r290276 - Perform type-checking for a converted constant expression in a template

Author: rsmith Date: Wed Dec 21 15:42:57 2016 New Revision: 290276 URL: http://llvm.org/viewvc/llvm-project?rev=290276=rev Log: Perform type-checking for a converted constant expression in a template argument even if the expression is value-dependent (we need to suppress the final portion of the

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

On Wed, Dec 21, 2016 at 6:42 AM, Senthil Kumar Selvaraj via Phabricator via cfe-commits wrote: > saaadhu added a comment. > > Would someone with a llvm bugzilla account please file the PR for me? New > user registration is disabled, and I've been waiting for >

Re: [PATCH] D27123: Add AVR target and toolchain to Clang

I'm happy to file a bug if you give me a description > Would one of the reviewers commit the patch for me? I'm happy to commit it, so long as somebody else signs off on it. On Thu, Dec 22, 2016 at 12:42 AM, Senthil Kumar Selvaraj via Phabricator < revi...@reviews.llvm.org> wrote: > saaadhu

r290268 - ARM: define a macro for the FPv5 FPU in ARM mode.

Author: tnorthover Date: Wed Dec 21 14:49:43 2016 New Revision: 290268 URL: http://llvm.org/viewvc/llvm-project?rev=290268=rev Log: ARM: define a macro for the FPv5 FPU in ARM mode. FPv5 is in Cortex-M7 and the 64-bit CPUs when running in 32-bit mode. The name is from the Cortex-M7 TRM.

[PATCH] D27898: [compiler-rt] [builtins] Implement __floattitf() & __floatuntitf()

weimingz added a comment. The patch looks good to me. https://reviews.llvm.org/D27898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27898: [compiler-rt] [builtins] Implement __floattitf() & __floatuntitf()

weimingz added a comment. Thanks for the formatting. Regarding the refactoring, Regarding factoring out common code, I think it's OK to do it in a follow-up patch. For readability, it should be OK. For example, fp_add_impl.inc is used by float, double and long double.

r290262 - Make some diagnostic tests C++11 clean.

Author: probinson Date: Wed Dec 21 12:33:17 2016 New Revision: 290262 URL: http://llvm.org/viewvc/llvm-project?rev=290262=rev Log: Make some diagnostic tests C++11 clean. Differential Revision: http://reviews.llvm.org/D27794 Modified: cfe/trunk/test/FixIt/fixit.cpp

[PATCH] D27794: Make some diagnostic tests C++11 clean

This revision was automatically updated to reflect the committed changes. Closed by commit rL290262: Make some diagnostic tests C++11 clean. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27794?vs=81977=82248#toc Repository: rL LLVM

[PATCH] D27794: Make some diagnostic tests C++11 clean

probinson marked an inline comment as done. probinson added a comment. FIXME added. https://reviews.llvm.org/D27794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27710: [analyzer] Prohibit ExplodedGraph's edges duplicating

zaks.anna added a comment. To deal with non-determinism, you can sort the results by non-pointer values, such as identifiers, before producing the warnings. It is not clear if you want to print all warnings or only the first one. Is it an option to list all dead symbols in one warning message?

Re: r290146 - Fix completely bogus types for some builtins:

On 12/20/2016 6:56 PM, Richard Smith wrote: On 20 December 2016 at 18:14, Richard Smith > wrote: On 19 December 2016 at 17:00, Friedman, Eli via cfe-commits > wrote:

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This side looks good. Comment at: lib/CodeGen/CGDebugInfo.cpp:325 +llvm::DIFile::ChecksumKind +CGDebugInfo::getChecksum(FileID FID, SmallString<32> ) const { + Checksum.clear();

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

zaks.anna added a comment. Looks great overall. I have minor comments below. Thanks for the awesome comments!!! Comment at: lib/StaticAnalyzer/Checkers/GTestChecker.cpp:152 + + ProgramStateRef State = C.getState(); + This could be moved up as you are using

[PATCH] D27794: Make some diagnostic tests C++11 clean

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Everything here looks good to me. Comment at: test/FixIt/fixit.cpp:28 +// In C++11 this gets 'expected unqualified-id' which fixit can't fix. +#if __cplusplus < 201103L

r290259 - clang-format: Fix bug in handling of single-column lists.

Author: djasper Date: Wed Dec 21 11:02:06 2016 New Revision: 290259 URL: http://llvm.org/viewvc/llvm-project?rev=290259=rev Log: clang-format: Fix bug in handling of single-column lists. Members that are themselves wrapped in fake parentheses would lead to AvoidBinPacking be set on the wrong

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons updated this revision to Diff 82239. malcolm.parsons added a comment. Move hasBody check into matcher. The matcher checks the function is a definition. https://reviews.llvm.org/D28022 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value

Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

On Wed, Dec 21, 2016 at 11:47 AM, Reid Kleckner wrote: > On Wed, Dec 21, 2016 at 8:36 AM, Aaron Ballman > wrote: >> >> That change appears to have been lost, and I would like to see them >> brought back. I think they may have gotten lost during the

[PATCH] D28023: [analyzer] Fix leak false positives before no-return functions caused by incomplete analyses.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. With the change Aleksei suggested (can you get the CFGStmtMap from the AnalysisDeclContext?), looks good to me. I especially like the test! Comment at:

r290258 - Wdocumentation fix

Author: rksimon Date: Wed Dec 21 10:39:09 2016 New Revision: 290258 URL: http://llvm.org/viewvc/llvm-project?rev=290258=rev Log: Wdocumentation fix Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL:

Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

On Wed, Dec 21, 2016 at 8:36 AM, Aaron Ballman wrote: > That change appears to have been lost, and I would like to see them > brought back. I think they may have gotten lost during the rebase, as > they were present in https://reviews.llvm.org/D26846?id=78569. > I

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

aaron.ballman added inline comments. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:96 - // Do not trigger on non-const value parameters when: - // 1. they are in a constructor definition since they can likely trigger - //modernize-pass-by-value which

Re: [PATCH] D26846: __uuidof() and declspec(uuid("...")) should be allowed on enumeration types

On Tue, Dec 20, 2016 at 5:58 PM, Kevin Puetz via Phabricator wrote: > puetzk added a comment. > > I see that you added a FIXME mentioning that it should be C++-only, but I > don't see where you actually did anything that would make it so. What am I > missing? You

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added a reviewer: RKSimon. RKSimon added a comment. Also, I don't think there is any clzero support on clang yet so adding that feature probably isn't safe. You may need to put up a separate clzero patch for review, preferably including _mm_clzero support to the headers as well.

Re: [clang-tools-extra] r290202 - [clang-tidy] Add modernize-use-default-member-init check

On Tue, Dec 20, 2016 at 5:58 PM, Malcolm Parsons wrote: > On 20 December 2016 at 22:32, Aaron Ballman wrote: >> On Tue, Dec 20, 2016 at 4:26 PM, Malcolm Parsons via cfe-commits >> wrote: >>> Author: malcolm.parsons

[PATCH] D28023: [analyzer] Fix leak false positives before no-return functions caused by incomplete analyses.

a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:3363 +// we're post-dominated by. +// FIXME: This is far from enough to handle the incomplete analysis case. +// We may be post-dominated in subsequent blocks, or even

[PATCH] D27710: [analyzer] Prohibit ExplodedGraph's edges duplicating

ilya-palachev added a comment. In https://reviews.llvm.org/D27710#628069, @zaks.anna wrote: > Are there any negative effects from having the duplicates in edges? Yes, you're right; in current implementation there seems to be no negative effects from this, since duplicate edges are quite rare,

[PATCH] D28023: [analyzer] Fix leak false positives before no-return functions caused by incomplete analyses.

a.sidorin added a comment. Looks useful and mostly good. A small advice is in inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:3294 + // Find the node's current statement in the CFG. + // FIXME: CFG lookup should be made easier. + const CFG =

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons updated this revision to Diff 82237. malcolm.parsons marked 3 inline comments as done. malcolm.parsons added a comment. Add some variables. Improve comments. https://reviews.llvm.org/D28022 Files: clang-tidy/performance/UnnecessaryValueParamCheck.cpp

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

a.sidorin added a comment. Looks good for me, but I'm not a reviewer. Thank you Devin! Comment at: test/Driver/analyzer-target-enabled-checkers.cpp:7 // CHECK-DARWIN: "-analyzer-checker=core" +// CHECK-DARWIN-SAME: "-analyzer-checker=apiModeling" // CHECK-DARWIN-SAME:

[PATCH] D26453: [clang-tidy] Remove duplicated check from move-constructor-init

malcolm.parsons added a comment. https://reviews.llvm.org/D28022 changes performance-unnecessary-value-param so that it handles this part of modernize-pass-by-value. So this isn't the end of the story here yet. Comment at:

[PATCH] D27898: [compiler-rt] [builtins] Implement __floattitf() & __floatuntitf()

mgorny updated this revision to Diff 82235. mgorny marked an inline comment as done. mgorny added a comment. I think I've shifted all of `{`/`}` to be in line with keywords. As for the splitting the code, you're probably right. However, I'd rather do that in a separate patch (I'll add it to my

[PATCH] D26453: [clang-tidy] Remove duplicated check from move-constructor-init

alexfh added a comment. LG. In https://reviews.llvm.org/D26453#592934, @flx wrote: > In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote: > > > Add ValuesOnly option to modernize-pass-by-value. > > > Thanks for doing this. Alex, would this work for us? Yep, I think so.

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:114 if (AllDeclRefExprs.size() == 1 && -

[PATCH] D28023: [analyzer] Fix leak false positives before no-return functions caused by incomplete analyses.

NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun, a.sidorin. NoQ added a subscriber: cfe-commits. Consider an example: void foo(int y) { void *x = malloc(1); assert(y); // macro that expands to "if (!y) exit(1);" free(x); } In CFG block

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Just one minor inline nit. Other than that, LGTM. Comment at: test/CodeGen/builtins-ppc-error.c:5 +// RUN: -triple powerpc64-unknown-unknown -fsyntax-only \ +// RUN:

[PATCH] D28022: [clang-tidy] Handle constructors in performance-unnecessary-value-param

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, flx, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: JDevlieghere. modernize-pass-by-value doesn't warn about value parameters that cannot be moved, so

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

ioeric added a comment. I'm not quite convinced/sure if we want to match all partial specializations just for `std::function`. We filtered out template specialization because there could be multiple specializations for a template in different headers and it was not clear which one we would

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

hokein added a comment. In https://reviews.llvm.org/D27920#628586, @ioeric wrote: > Why do we allow partially specialization but fully specialization now? Could > you elaborate in the cl description? Done. https://reviews.llvm.org/D27920 ___

[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC

klimek added inline comments. Comment at: lib/Format/Format.cpp:1920-1922 + std::error_code EC = FS->makeAbsolute(Path); + assert(!EC); + (void)EC; amaiorano wrote: > klimek wrote: > > I think if makeAbsolute doesn't work, we will probably want to err out

[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC

amaiorano added inline comments. Comment at: lib/Format/Format.cpp:1920-1922 + std::error_code EC = FS->makeAbsolute(Path); + assert(!EC); + (void)EC; klimek wrote: > I think if makeAbsolute doesn't work, we will probably want to err out here: > if (EC) { >

[PATCH] D27123: Add AVR target and toolchain to Clang

saaadhu added a comment. Would someone with a llvm bugzilla account please file the PR for me? New user registration is disabled, and I've been waiting for llvm-ad...@lists.llvm.org to respond for nearly a week now. And how should I proceed after that? Would one of the reviewers commit the

[PATCH] D28015: [OpenMP] Sema and parsing for 'target teams distribute' pragma

ABataev added a comment. LG https://reviews.llvm.org/D28015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27920: [find-all-symbols] Index partial template specializations.

ioeric added a comment. Why do we allow partially specialization but fully specialization now? Could you elaborate in the cl description? https://reviews.llvm.org/D27920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26167: [Clang-tidy] check for malloc, realloc and free calls

malcolm.parsons added a comment. In https://reviews.llvm.org/D26167#622792, @malcolm.parsons wrote: > In https://reviews.llvm.org/D26167#621942, @JonasToth wrote: > > > what do you think about configuration of the allocating functions? e.g. for > > aligned memory you must use OS-specific

[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Apart from the error handling LG. Thanks! Comment at: lib/Format/Format.cpp:1920-1922 + std::error_code EC = FS->makeAbsolute(Path); + assert(!EC); + (void)EC;