hintonda added a comment.
The problem is that when a noexcept(bool expr) specification is invalid, e.g.,
bad bool expr, the NoexceptType in Parser::tryParseExceptionSpecification is
set to EST_None and returned. This will mean the FunctionDecl type won't have
an exception TypeLoc, but the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290781: [clang] Fix clean build of generate-order-file
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D28153?vs=82715=82755#toc
Repository:
rL LLVM
Author: alexshap
Date: Fri Dec 30 23:25:52 2016
New Revision: 290781
URL: http://llvm.org/viewvc/llvm-project?rev=290781=rev
Log:
[clang] Fix clean build of generate-order-file
This diff fixes the clean build of the target generate-order-file.
In llvm/tools/clang/CMakeLists.txt
Author: rsmith
Date: Fri Dec 30 21:33:42 2016
New Revision: 290780
URL: http://llvm.org/viewvc/llvm-project?rev=290780=rev
Log:
Remove redundant assertion.
Modified:
cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
URL:
Author: jdennett
Date: Fri Dec 30 19:04:02 2016
New Revision: 290777
URL: http://llvm.org/viewvc/llvm-project?rev=290777=rev
Log:
Typo fix in AST matcher documentation: s/aribtrary/arbitrary/
Modified:
cfe/trunk/docs/LibASTMatchers.rst
Modified: cfe/trunk/docs/LibASTMatchers.rst
URL:
arpith-jacob updated this revision to Diff 82750.
arpith-jacob added a comment.
Alexey, thank you for your review. I've updated the patch addressing your
comments.
- I experimented with various ways of changing the name of the outlined
function. In the end I decided against moving the two
Author: compnerd
Date: Fri Dec 30 18:00:21 2016
New Revision: 290775
URL: http://llvm.org/viewvc/llvm-project?rev=290775=rev
Log:
random: include __config before building
We need to include __config to ensure that we know what random
implementation is being used. Fixes compilation for Windows.
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D28022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
I've noticed a few more minor issues. Otherwise looks good.
Thank you for the new check!
Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:27-38
+ const auto
On 30 Dec 2016 3:06 pm, "Simon Pilgrim via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: rksimon
Date: Fri Dec 30 16:55:33 2016
New Revision: 290773
URL: http://llvm.org/viewvc/llvm-project?rev=290773=rev
Log:
Wdocumentation fix
Thanks, but please be careful you don't introduce
Author: rksimon
Date: Fri Dec 30 16:55:33 2016
New Revision: 290773
URL: http://llvm.org/viewvc/llvm-project?rev=290773=rev
Log:
Wdocumentation fix
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp
URL:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290766: [clang] Minor fix to libASTMatcherTutorial (authored
by madsravn).
Changed prior to commit:
https://reviews.llvm.org/D28180?vs=82735=82742#toc
Repository:
rL LLVM
Author: madsravn
Date: Fri Dec 30 14:49:44 2016
New Revision: 290766
URL: http://llvm.org/viewvc/llvm-project?rev=290766=rev
Log:
[clang] Minor fix to libASTMatcherTutorial
There was a small error in the code in the tutorial. The tutorial contains a
few errors which results in code not being
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the documentation fix!
https://reviews.llvm.org/D28180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: compnerd
Date: Fri Dec 30 12:45:03 2016
New Revision: 290762
URL: http://llvm.org/viewvc/llvm-project?rev=290762=rev
Log:
CodeGen: use a StringSwitch instead of cascasding ifs
Change the cascading ifs to a StringSwitch to simplify the conversion of
the relocation model. NFC
Modified:
madsravn created this revision.
madsravn added reviewers: aaron.ballman, malcolm.parsons.
madsravn added a subscriber: cfe-commits.
The tutorial contains a few errors which results in code not being able to
compile.
One error was described here: https://llvm.org/bugs/show_bug.cgi?id=25583 .
I
sebpop added a comment.
In https://reviews.llvm.org/D27068#632685, @EricWF wrote:
> Holy crap those improvements are impressive.
You're welcome.
> This LGTM. I'm assuming @mclow.lists has nothing left to say about this.
Thanks for your review and LGTM.
I addressed your last comment, added
SilverGeri updated this revision to Diff 82732.
SilverGeri added a comment.
remove redundant `allOf` statements;
refactor test's comment checking part
https://reviews.llvm.org/D21298
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeleteNullPointerCheck.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290761: improve performance of string::find (authored by
spop).
Changed prior to commit:
https://reviews.llvm.org/D27068?vs=80134=82731#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27068
Author: spop
Date: Fri Dec 30 12:01:36 2016
New Revision: 290761
URL: http://llvm.org/viewvc/llvm-project?rev=290761=rev
Log:
improve performance of string::find
string::find used to call the generic algorithm ::find. The patch special
case string::find such that it ultimately gets converted to
mgorny added a comment.
In https://reviews.llvm.org/D26796#632602, @compnerd wrote:
> This would need an upgrade path, since the output name can actually be
> different from the `AchTypeName` (e.g. i386 vs i686).
I was considering committing this alongside with the i686 removal, and assuming
Author: marshall
Date: Fri Dec 30 11:42:11 2016
New Revision: 290758
URL: http://llvm.org/viewvc/llvm-project?rev=290758=rev
Log:
Fix some 'FIXME's in the tests.
Modified:
libcxx/trunk/test/std/experimental/func/func.searchers/func.searchers.boyer_moore/hash.pred.pass.cpp
Author: alexfh
Date: Fri Dec 30 09:15:14 2016
New Revision: 290756
URL: http://llvm.org/viewvc/llvm-project?rev=290756=rev
Log:
[clang-tidy] google-explicit-constructor: ignore macros
Modified:
clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp
lefticus marked an inline comment as done.
lefticus added a subscriber: EricFowler.
lefticus added a comment.
@EricFowler I have too many other things going on right now to be able to look
at it for at least the next few months.
https://reviews.llvm.org/D22584
Author: ericwf
Date: Fri Dec 30 08:05:52 2016
New Revision: 290754
URL: http://llvm.org/viewvc/llvm-project?rev=290754=rev
Log:
Recommit r290750: Fix PR19460 - std::ios is convertible to int.
There were two problems with the initial fix.
1. The added tests flushed out that we misconfigured
Author: alexfh
Date: Fri Dec 30 07:25:03 2016
New Revision: 290753
URL: http://llvm.org/viewvc/llvm-project?rev=290753=rev
Log:
[clang-tidy] google-explicit-constructor: ignore template instantiations
Modified:
clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp
Author: ericwf
Date: Fri Dec 30 07:11:17 2016
New Revision: 290752
URL: http://llvm.org/viewvc/llvm-project?rev=290752=rev
Log:
Revert r290750 - Fix PR19460 - std::ios is convertible to int.
Modified:
libcxx/trunk/include/ios
Author: ericwf
Date: Fri Dec 30 06:44:58 2016
New Revision: 290750
URL: http://llvm.org/viewvc/llvm-project?rev=290750=rev
Log:
Fix PR19460 - std::ios is convertible to int.
std::basic_ios has an operator bool(). In C++11 and later
it is explicit, and only allows contextual implicit conversions.
Author: ericwf
Date: Fri Dec 30 06:45:30 2016
New Revision: 290751
URL: http://llvm.org/viewvc/llvm-project?rev=290751=rev
Log:
Add missing include in test.
Modified:
libcxx/trunk/test/std/input.output/iostreams.base/ios/iostate.flags/bool.pass.cpp
Modified:
EricWF added a comment.
In https://reviews.llvm.org/D21599#481593, @dsanders wrote:
> I haven't used it that way either and I'm not sure it's a supported build for
> libcxx but most LLVM projects support a standalone build as far as I know.
> Can someone from the libcxx project confirm whether
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
Resigning as reviewer. These changes are quite old, and can be redone if
needed. In all likelihood I think I would rather remove the symbols from the
dylib instead of keep them.
Repository:
rL
rmaprath abandoned this revision.
rmaprath added a comment.
Most of this is no longer needed. I'll submit patches for the parts that are
actually needed (e.g. nanosleep) later on. Thanks.
https://reviews.llvm.org/D20874
___
cfe-commits mailing
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
@gribozavr The tests have changed a bunch since this patch was created. I took
the liberty of re-merging the tests. You can find the updated patch here:
EricWF added a comment.
Have you filed a bug against GCC regarding its current behavior?
Also it seems like a bad idea to add `-fabi-version=6`, since it selects an
older ABI version and not a newer one. Testing the old behavior is not what we
want.
I think the best plan is to simply split
Author: ed
Date: Fri Dec 30 04:44:00 2016
New Revision: 290748
URL: http://llvm.org/viewvc/llvm-project?rev=290748=rev
Log:
Remove mblen(), mbtowc() and wctomb() from the thread-unsafe functions.
Back in r240527 I added a knob to prevent thread-unsafe functions from
being exposed. mblen(),
EricWF added a comment.
Maybe if we want to improve the failure mode we can add a
`_LIBCPP_ASSERT(__new_last <= __end, "invalid range")`?
https://reviews.llvm.org/D17053
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF requested changes to this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision now requires changes to proceed.
Added a bunch of inline comments.
The biggest requested change is removing the `__atomic_support` header. We only
need one atomic call within the
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Holy crap those improvements are impressive.
This LGTM. I'm assuming @mclow.lists has nothing left to say about this.
Comment at: libcxx/include/__string:542
+template
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290747: [clang-tidy] Add check 'misc-string-compare'.
(authored by madsravn).
Changed prior to commit:
https://reviews.llvm.org/D27210?vs=82521=82721#toc
Repository:
rL LLVM
Author: madsravn
Date: Fri Dec 30 04:09:46 2016
New Revision: 290747
URL: http://llvm.org/viewvc/llvm-project?rev=290747=rev
Log:
[clang-tidy] Add check 'misc-string-compare'.
I have a created a new check for clang tidy: misc-string-compare. This will
check for incorrect usage of
EricWF added a comment.
@lefticus Are you still interested in working on this? If so could you please
split the changes for `array` into a separate patch? Marshall seems to have
implemented some of the changes in `` and that's causing merge
conflicts.
https://reviews.llvm.org/D22584
a.sidorin added a comment.
Kareem, I have re-checked it and I cannot see the failure. But I'm not going to
commit it until NY holidays end (and, anyway, I will not commit it if somebody
has failing tests). Could you describe your configuration?
https://reviews.llvm.org/D26753
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
Resigning as a reviewer since this revision is dead.
https://reviews.llvm.org/D23831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
I don't feel comfortable reviewing driver changes, since I never work on that
code.
https://reviews.llvm.org/D26244
___
cfe-commits mailing list
EricWF added a comment.
In https://reviews.llvm.org/D25811#586053, @kparzysz wrote:
> In https://reviews.llvm.org/D25811#586000, @arphaman wrote:
>
> > I've tested this patch on OS X and these 4 tests that you've changed now
> > fail.
> >
> > The `XFAIL: with_system_cxx_lib` lines don't have
Author: ericwf
Date: Fri Dec 30 03:28:58 2016
New Revision: 290746
URL: http://llvm.org/viewvc/llvm-project?rev=290746=rev
Log:
Get ctype_byname tests passing on Linux.
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp
Author: xazax
Date: Fri Dec 30 03:20:10 2016
New Revision: 290745
URL: http://llvm.org/viewvc/llvm-project?rev=290745=rev
Log:
Fix another nondeterminism in a tidy test.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-suspicious-enum-usage-strict.cpp
Modified:
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:114
/// \brief Get the name of the capture helper.
- StringRef getHelperName() const override { return ".omp_outlined."; }
+ StringRef getHelperName() const override { return "__omp_outlined__"; }
48 matches
Mail list logo
