Author: compnerd
Date: Thu Jan 5 10:02:32 2017
New Revision: 291123
URL: http://llvm.org/viewvc/llvm-project?rev=291123&view=rev
Log:
CodeGen: plumb header search down to the IAS
inline assembly may use the `.include` directive to include other
content into the file. Without the integrated asse
mgorny added a comment.
In https://reviews.llvm.org/D28304#636669, @dvyukov wrote:
> User -march flag won't help as runtime is prebuilt.
I meant the flag used by the compiler vendor when compiler-rt is built.
> SCUDO is sse4.2, but tsan is sse3. Do you actually see any problems with
> sse3? I
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D28298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
Ok, LGTM! Thanks!
https://reviews.llvm.org/D28257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
hokein added a comment.
In https://reviews.llvm.org/D28315#636821, @amaiorano wrote:
> Is there a way to run tests without ninja? I'm on Windows. If not, I'll use
> my Linux VM.
It is not related to the build system. There should be a `check-clang-tools`
project, you can run tests by building
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252
+ // \brief Flags associated the device global.
+ int32_t Flags;
+
Hahnfeld wrote:
> sfantao wrote:
> > Hahnfeld wrote:
> > > Is that intentionally not in the `protected` s
sfantao updated this revision to Diff 83236.
sfantao marked 2 inline comments as done.
sfantao added a comment.
- Privatize Order, Flags and Kind of the offload entry.
https://reviews.llvm.org/D28298
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGOpenMP
Author: arpith
Date: Thu Jan 5 09:24:05 2017
New Revision: 291121
URL: http://llvm.org/viewvc/llvm-project?rev=291121&view=rev
Log:
[OpenMP] Update target codegen for NVPTX device.
This patch includes updates for codegen of the target region for the NVPTX
device. It moves initializers from the c
jroelofs added a comment.
Testcase?
https://reviews.llvm.org/D28346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amaiorano added a comment.
In https://reviews.llvm.org/D28315#636670, @hokein wrote:
> In https://reviews.llvm.org/D28315#635865, @amaiorano wrote:
>
> > I made these changes, and they build, but I didn't really test them. Are
> > there unit tests for these tools that I can run?
>
>
> If you use
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252
+ // \brief Flags associated the device global.
+ int32_t Flags;
+
sfantao wrote:
> Hahnfeld wrote:
> > Is that intentionally not in the `protected` section below?
> Yes,
sfantao marked an inline comment as done.
sfantao added a comment.
Hi Jonas,
Thanks for the review.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252
+ // \brief Flags associated the device global.
+ int32_t Flags;
+
Hahnfeld wrote:
> Is that intenti
arphaman created this revision.
arphaman added reviewers: rsmith, rnk, bruno.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that clang avoids the redundant -Wshadow warning for
variables that already get a "redefinition of "
rmaprath added a comment.
In https://reviews.llvm.org/D28316#636700, @EricWF wrote:
> In https://reviews.llvm.org/D28316#636686, @rmaprath wrote:
>
> > (btw, do those docs updates land on some web URL automagically when
> > committed?).
>
>
> Assuming the builder isn't broken then yes, the docs
NoQ added a comment.
> Do not check if the return status has been compared to error (or no error) at
> the time when leaks are reported since the status symbol might no longer be
> alive. Instead, pattern match on the assume and stop tracking allocated
> symbols on error paths.
Aha, i see! So
arphaman created this revision.
arphaman added reviewers: doug.gregor, t.p.northover.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch defines __OBJC_BOOL_IS_BOOL for C code as well, since Objective-C's
BOOL can be also used by C code.
EricWF updated this revision to Diff 83211.
EricWF marked an inline comment as done.
https://reviews.llvm.org/D28316
Files:
CMakeLists.txt
docs/DesignDocs/ThreadingSupportAPI.rst
docs/index.rst
include/__config
include/__config_site.in
include/__threading_support
lib/CMakeLists.txt
EricWF marked 3 inline comments as done.
EricWF added a comment.
In https://reviews.llvm.org/D28316#636686, @rmaprath wrote:
> (btw, do those docs updates land on some web URL automagically when
> committed?).
Assuming the builder isn't broken then yes, the docs should automagically
update wi
Author: hokein
Date: Thu Jan 5 04:06:58 2017
New Revision: 291096
URL: http://llvm.org/viewvc/llvm-project?rev=291096&view=rev
Log:
No canonical-prefixes match in avr-toolchain.c.
Modified:
cfe/trunk/test/Driver/avr-toolchain.c
Modified: cfe/trunk/test/Driver/avr-toolchain.c
URL:
http://ll
rmaprath added a comment.
This is much better (few nits inline). And many thanks for the docs update
(btw, do those docs updates land on some web URL automagically when committed?).
I think we should point out on the docs that
`_LIBCPP_HAS_THREAD_LIBRARY_EXTERNAL` is only meant for `libc++` dev
rengolin added a comment.
Please, add tests to test/Driver.
https://reviews.llvm.org/D28238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added a comment.
In https://reviews.llvm.org/D28315#635865, @amaiorano wrote:
> I made these changes, and they build, but I didn't really test them. Are
> there unit tests for these tools that I can run?
If you use ninja build, you can run `ninja check-clang-tools` to run all tests.
h
dvyukov added a comment.
Yes, for tsan runtime detection does not make lots of sense -- we only have few
SSE instructions on inlined fast path. The SSE code provides quite substantial
speedup. User -march flag won't help as runtime is prebuilt. SCUDO is sse4.2,
but tsan is sse3. Do you actually
Author: ericwf
Date: Thu Jan 5 03:06:30 2017
New Revision: 291094
URL: http://llvm.org/viewvc/llvm-project?rev=291094&view=rev
Log:
Add gcc-[56] clang-3.[678] to list of XFAILS for variant tests. Patch from
Michael Park
Modified:
libcxx/trunk/test/libcxx/utilities/variant/variant.variant/v
Author: ericwf
Date: Thu Jan 5 03:03:43 2017
New Revision: 291093
URL: http://llvm.org/viewvc/llvm-project?rev=291093&view=rev
Log:
Use C++11 static_assert in variant tests. Patch from Michael Park
Modified:
libcxx/trunk/test/libcxx/utilities/variant/variant.variant/variant.assign/copy.pass
EricWF updated this revision to Diff 83201.
EricWF added a comment.
- Address inline comments
https://reviews.llvm.org/D28316
Files:
CMakeLists.txt
docs/DesignDocs/ThreadingSupportAPI.rst
docs/index.rst
include/__config
include/__config_site.in
include/__threading_support
lib/CMak
smeenai added inline comments.
Comment at: docs/DesignDocs/ThreadingSupportAPI.rst:17
+
+The ``<__threading_support>`` header is where libc++ defines it's internal
+threading interface. It contains forward declarations of the internal threading
s/it's/its
https
Author: ericwf
Date: Thu Jan 5 02:07:17 2017
New Revision: 291091
URL: http://llvm.org/viewvc/llvm-project?rev=291091&view=rev
Log:
Get tests linking on Windows.
This patch is a temporary hack to get the tests passing on
Windows.
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified:
EricWF added a comment.
@compnerd Just waiting on @rmaprath before committing. This is a breaking
change for his use case since this patch changes the semantics of
`_LIBCPP_HAS_THREAD_API_EXTERNAL` and `-DLIBCXX_HAS_EXTERNAL_THREAD_API`.
https://reviews.llvm.org/D28316
_
dylanmckay created this revision.
dylanmckay added a reviewer: jroelofs.
dylanmckay added a subscriber: cfe-commits.
This tells clang about all of the different AVR microcontrollers.
It also adds code to define the correct preprocessor macros for each
device.
https://reviews.llvm.org/D28346
Fi
101 - 130 of 130 matches
Mail list logo
