Re: [PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

I started the llvm-dev thread for the instruction location tradeoffs (removing the location from instructions to improve profiling support - possibly at the cost of other debug info consumers). The motivation for this flag is different - for added functionality that's generally (imho/based on

[PATCH] D28473: Implement http://wg21.link/P0426 Constexpr for std::char_traits

rsmith added inline comments. Comment at: include/__string:248 +#if _LIBCPP_STD_VER <= 14 +return (const char_type*) memchr(__s, to_int_type(__a), __n); +#else We can add another builtin to Clang to support this case if you'd like. (There's also a way to

[PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

echristo added a comment. I don't think this ever was hashed out in the llvm-dev thread? https://reviews.llvm.org/D25435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#639887, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#639874, @probinson wrote: > > > Over the weekend I had a thought: Why is -O0 so special here? That is, > > after going to all this trouble to propagate -O0 to LTO,

Re: r291058 - [Sema] Mark undefined ctors as deleted. NFC.

That's a good point, but I don't think they're a big issue: this code has apparently been this way since 2010, and I only hit this problem because I was blindly adding `const` to things and looking for what broke. :) If someone feels differently, I'm happy to swap this to use SFINAE magic. On

[libcxx] r291466 - [Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW

Author: bruno Date: Mon Jan 9 13:21:48 2017 New Revision: 291466 URL: http://llvm.org/viewvc/llvm-project?rev=291466=rev Log: [Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW Use CLOCK_UPTIME_RAW in case clock_gettime is available on Darwin. On Apple platforms only CLOCK_UPTIME_RAW or

r291465 - PCH: fix a regression that reports a module is defined in both pch and pcm.

Author: mren Date: Mon Jan 9 13:20:18 2017 New Revision: 291465 URL: http://llvm.org/viewvc/llvm-project?rev=291465=rev Log: PCH: fix a regression that reports a module is defined in both pch and pcm. In r276159, we started to say that a module X is defined in a pch if we specify -fmodule-name

[PATCH] D28415: PCH: fix a regression that reports a module is defined in both pch and pcm

This revision was automatically updated to reflect the committed changes. Closed by commit rL291465: PCH: fix a regression that reports a module is defined in both pch and pcm. (authored by mren). Changed prior to commit: https://reviews.llvm.org/D28415?vs=83431=83660#toc Repository: rL

[PATCH] D25435: Add -fdebug-info-for-profiling to emit more debug info for sample pgo profile collection

danielcdh added a comment. Thanks David for the reivew. Could you also help take a look at https://reviews.llvm.org/D25434, as it depends on the TargetOptions.h change in that patch. Thanks, Dehao https://reviews.llvm.org/D25435 ___ cfe-commits

[PATCH] D28473: Implement http://wg21.link/P0426 Constexpr for std::char_traits

mclow.lists added inline comments. Comment at: include/__string:261 + +// inline _LIBCPP_CONSTEXPR_AFTER_CXX14 +// int I will remove this block before committing. https://reviews.llvm.org/D28473 ___ cfe-commits

[PATCH] D28473: Implement http://wg21.link/P0426 Constexpr for std::char_traits

mclow.lists created this revision. mclow.lists added reviewers: EricWF, rsmith. mclow.lists added a subscriber: cfe-commits. Make `assign`/`length`/`find`/`compare` for `std::char_traits` constexpr. This makes using `string_view`s at compile time easier. Use the compiler intrinsics when

[PATCH] D28472: Move _PairT declaration out of __hash_combine to avoid warning under C++98

dim created this revision. dim added reviewers: EricWF, mclow.lists. dim added subscribers: emaste, cfe-commits. Some parts of the FreeBSD tree are still compiled with C++98, and until https://reviews.llvm.org/rL288554 this has always worked fine. After that, a complaint about the newly

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:409 +llvm::FunctionType *FnTy = +llvm::FunctionType::get(CGM.VoidTy, {}, /*isVarArg*/ false); +

[PATCH] D28425: Lit C++11 Compatibility Patch - nonthrowing destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rL291458: [Lit Test] Make tests C++11 compatible - nothrow destructors (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D28425?vs=83470=83651#toc Repository: rL LLVM

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

dlj updated this revision to Diff 83650. dlj added a comment. - Fix lit checks. https://reviews.llvm.org/D28427 Files: lib/AST/ExprConstant.cpp test/CXX/basic/basic.start/basic.start.init/p2.cpp test/CodeGenCXX/global-array-destruction.cpp Index:

[PATCH] D28427: Allow constexpr construction of subobjects unconditionally, not just in C++14.

dlj added a comment. Test added, and fixed another one that I missed before. https://reviews.llvm.org/D28427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

mehdi_amini added a comment. In https://reviews.llvm.org/D28404#639874, @probinson wrote: > Over the weekend I had a thought: Why is -O0 so special here? That is, > after going to all this trouble to propagate -O0 to LTO, how does this > generalize to propagating -O1 or any other specific -O

[PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In https://reviews.llvm.org/D21113#627413, @francisco.lopes wrote: > I'm waiting for this to land as well, it's crucial for coding windows code > with libclang assistance on a linux machine. I'm not actively working on this, so it might take a while. In the meantime, I

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. Over the weekend I had a thought: Why is -O0 so special here? That is, after going to all this trouble to propagate -O0 to LTO, how does this generalize to propagating -O1 or any other specific -O option? (Maybe this question would be better dealt with on the dev

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

berenm added a comment. Yes you are right, I believe it's happening for comma-separated declaration list. I think the algorithm tries to keep it clear that the pointer / reference marks are for each declared identifier and not part of the common type. I think that splitting the declarations

r291453 - [MS] Mark default args of exported default constructors as used

Author: rnk Date: Mon Jan 9 11:27:17 2017 New Revision: 291453 URL: http://llvm.org/viewvc/llvm-project?rev=291453=rev Log: [MS] Mark default args of exported default constructors as used Fixes a regression introduced in r291045, which would lead to link errors. While we should no longer

[PATCH] D28415: PCH: fix a regression that reports a module is defined in both pch and pcm

benlangmuir added a comment. LGTM https://reviews.llvm.org/D28415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291452 - Split dllexport default constructor closure tests out into a separate file

Author: rnk Date: Mon Jan 9 11:25:30 2017 New Revision: 291452 URL: http://llvm.org/viewvc/llvm-project?rev=291452=rev Log: Split dllexport default constructor closure tests out into a separate file test/CodeGenCXX/dllexport.cpp has grown quite large at this point. NFC Added:

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

arpith-jacob updated this revision to Diff 83641. arpith-jacob added a comment. Use i1 type for bool after all. But this time use the api ConvertType(). https://reviews.llvm.org/D28145 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

r291448 - [MS] Fix function type mangling of default ctor closures

Author: rnk Date: Mon Jan 9 11:04:37 2017 New Revision: 291448 URL: http://llvm.org/viewvc/llvm-project?rev=291448=rev Log: [MS] Fix function type mangling of default ctor closures Use the canonical decl in pointer comparisons with the default constructor closure decl. Otherwise we don't

r291450 - Follow up to r291448: use isStructorDecl in one more place

Author: rnk Date: Mon Jan 9 11:09:59 2017 New Revision: 291450 URL: http://llvm.org/viewvc/llvm-project?rev=291450=rev Log: Follow up to r291448: use isStructorDecl in one more place This pointer comparison has shown to be error-prone, so use the standard helper for it. NFC Modified:

[PATCH] D28461: [clang] Enable using --section-ordering-file option of ld.gold

This revision was automatically updated to reflect the committed changes. Closed by commit rL291449: [clang] Enable using --section-ordering-file option of ld.gold (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D28461?vs=83582=83637#toc Repository: rL LLVM

r291449 - [clang] Enable using --section-ordering-file option of ld.gold

Author: alexshap Date: Mon Jan 9 11:06:24 2017 New Revision: 291449 URL: http://llvm.org/viewvc/llvm-project?rev=291449=rev Log: [clang] Enable using --section-ordering-file option of ld.gold This diffs enables using --section-ordering-file option of ld.gold via the variable CLANG_ORDER_FILE.

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added a comment. In https://reviews.llvm.org/D28018#639765, @GGanesh wrote: > Fallback to CK_BTVER1 is ok but not to CK_BTVER2. This is not possible > because of the partial YMM writes. They have different behavior for znver1 > with AVX and their legacy SIMD counterparts. So, as of now

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

mclow.lists abandoned this revision. mclow.lists added a comment. This was resolved by https://reviews.llvm.org/D26829 https://reviews.llvm.org/D26667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28315: Update tools to use new getStyle API

amaiorano added a comment. In https://reviews.llvm.org/D28315#639559, @ioeric wrote: > I ran `ninja check-all` with https://reviews.llvm.org/D28081 and > https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed, namely: > > Clang :: Format/style-on-command-line.cpp > Clang

Re: r291058 - [Sema] Mark undefined ctors as deleted. NFC.

Alternatively could make the bool ctor a template with some SFINAE to restrict it to only parameters of type bool - thus blocking all conversions there, if they're particularly problematic. On Wed, Jan 4, 2017 at 5:32 PM George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

Re: [PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

Alexey, Thanks for the pointer. I've updated the patch using CGF.ConvertTypeForMem(CGM.getContext().BoolTy); to get the type for 'bool'. On my machine it returns i8. The compiler produces code for a simple OpenMP program that links and seems to run fine on the GPU with my runtime. I also

[PATCH] D28018: AMD family 17h (znver1) enablement

GGanesh updated this revision to Diff 83626. GGanesh added a comment. Fallback to CK_BTVER1 is ok but not to CK_BTVER2. This is not possible because of the partial YMM writes. They have different behavior for znver1 with AVX and their legacy SIMD counterparts. So, as of now leaving them to

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

arpith-jacob updated this revision to Diff 83631. arpith-jacob marked an inline comment as done. arpith-jacob added a comment. Using CGF.ConvertTypeForMem(Context.getBoolType()) to get the right type for 'bool' rather than using i1. https://reviews.llvm.org/D28145 Files:

[PATCH] D28419: clang-tools-extra: add gitattributes to disable EOL conversions on checkout of test source files

amaiorano added a comment. Hello, sorry for the lack of details here. I will re-run the tests later and report here the tests that are failing along with output. The main issue is that when using Git on Windows, by default the installer will set core.autocrlf to true, which is a Git config

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

nemanjai added inline comments. Comment at: test/CodeGen/builtins-ppc-extractword-error.c:2 +// REQUIRES: powerpc-registered-target +// XFAIL: powerpc + I think this will fail on all the powerpc targets, such as powerpc64le, etc. Which isn't what you want I

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons updated this revision to Diff 83624. malcolm.parsons added a comment. Don't warn in a dependent context. Remove spurious expected-warning. https://reviews.llvm.org/D28467 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td

[clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

Author: d0k Date: Mon Jan 9 09:18:28 2017 New Revision: 291446 URL: http://llvm.org/viewvc/llvm-project?rev=291446=rev Log: [include-fixer] Load symbol index asynchronously. We don't actually need the index until parse time, so fetch it in the background and start parsing. By the time it is

[PATCH] D28467: [Sema] Add warning for unused lambda captures

arphaman added inline comments. Comment at: test/SemaCXX/uninitialized.cpp:1437 } else { -[fname]{}; +[fname] { (void)fname; }; // expected-warning {{lambda capture 'fname' is not used}} } I think that expected-warning shouldn't be used here as

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

berenm added a comment. I'm trying to think of a scenario where *, && or & before tokens to be aligned would not indicate pointers or references, but as the alignment is only done for now on declarations and assignments, I can't find one. Maybe you could add one more test case to check Left

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

xazax.hun added a comment. Did you experience any problems with the array out of bounds check lately? In case it was stable on large code-bases and did not give too many false positives, I think it might be worth to move that check out of alpha at the same time, so users who do not turn on

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP added a comment. ping https://reviews.llvm.org/D27651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

Arpith, I'm afraid that bool type is translated to i8 or even to i32 type rather than to i1. I believe you'd better to use CGF.ConvertTypeForMem(Context.getBoolType())to get the correct return type for bool rather than simply i1. You'd better to check how bool(...) function type is converted

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, rsmith. malcolm.parsons added a subscriber: cfe-commits. Warn when a lambda explicitly captures something that is not used in its body. The warning is part of -Wunused and can be enabled with

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

arpith-jacob marked 2 inline comments as done. arpith-jacob added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:365 +llvm::FunctionType *FnTy = +llvm::FunctionType::get(llvm::Type::getInt1Ty(CGM.getLLVMContext()), +

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added inline comments. Comment at: lib/Basic/Targets.cpp:3189 break; + case CK_ZNVER1: +setFeatureEnabledImpl(Features, "adx", true); GGanesh wrote: > RKSimon wrote: > > Same as what I asked on D28017 - is there an accepted order that we should

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

arpith-jacob updated this revision to Diff 83609. arpith-jacob added a comment. Moved CommonActionTy to CGOpenMPRuntimeNVPTX.cpp and renamed it to NVPTXActionTy, allowing us to customize the class in the future, if necessary. https://reviews.llvm.org/D28145 Files:

r291439 - [cxx1z-constexpr-lambda] [NFC] Add a FIXME to reinstate certain restrictions on constexpr lambdas from appearing within function-signatures (CWG1607)

background, see Richard's comments: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170109/181998.html A patch to fix this is being worked on. Thanks! Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm-project/cfe

[PATCH] D28419: clang-tools-extra: add gitattributes to disable EOL conversions on checkout of test source files

malcolm.parsons resigned from this revision. malcolm.parsons removed a reviewer: malcolm.parsons. malcolm.parsons added a comment. Which tests? How does this interact with svn's eol-style property? Resigning as not something I know about. https://reviews.llvm.org/D28419

r291437 - Use the same ABI logic for AArch64 Big Endian as in other places

Author: joerg Date: Mon Jan 9 05:40:41 2017 New Revision: 291437 URL: http://llvm.org/viewvc/llvm-project?rev=291437=rev Log: Use the same ABI logic for AArch64 Big Endian as in other places covering polys. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp Modified:

Re: r291416 - [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions.

On Mon, Jan 9, 2017 at 12:13 AM, Richard Smith wrote: > On 8 January 2017 at 19:02, Faisal Vali via cfe-commits > wrote: >> >> Author: faisalv >> Date: Sun Jan 8 21:02:53 2017 >> New Revision: 291416 >> >> URL:

r291436 - Extend NetBSD/AArch64 to cover Big Endian as well.

Author: joerg Date: Mon Jan 9 05:22:14 2017 New Revision: 291436 URL: http://llvm.org/viewvc/llvm-project?rev=291436=rev Log: Extend NetBSD/AArch64 to cover Big Endian as well. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp

r291434 - clang-format: Improve support for override/final as variable names.

Author: djasper Date: Mon Jan 9 05:04:07 2017 New Revision: 291434 URL: http://llvm.org/viewvc/llvm-project?rev=291434=rev Log: clang-format: Improve support for override/final as variable names. Before: bool a = f() &(); bool a = f() &(); void f(const MyOverride & override); void

[libcxx] r291433 - [libcxx] Fix externally-threaded shared library builds after r291275.

Author: asiri Date: Mon Jan 9 04:38:56 2017 New Revision: 291433 URL: http://llvm.org/viewvc/llvm-project?rev=291433=rev Log: [libcxx] Fix externally-threaded shared library builds after r291275. Need to allow unresolved symbols in the dylib. This was previously done for

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:100 + StringRef ReplacementStr = + IsNoThrow ? NoexceptMacro.empty() ? "noexcept" : NoexceptMacro +: DtorOrOperatorDel ? "noexcept(false)" : "";

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

NoQ accepted this revision. NoQ added a reviewer: NoQ. NoQ added a comment. In https://reviews.llvm.org/D28330#637075, @zaks.anna wrote: > I did not think of solution #1! It's definitely better than the pattern > matching I've added here. However, this checker fires so infrequently, that I >

[PATCH] D28260: Add an argumentsAre matcher

klimek added a reviewer: bkramer. klimek added a comment. +benjamin https://reviews.llvm.org/D28260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291430: [analyzer] Add checker for iterators dereferenced beyond their range. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D25660?vs=81224=83596#toc Repository: rL LLVM

r291430 - [analyzer] Add checker for iterators dereferenced beyond their range.

Author: xazax Date: Mon Jan 9 03:52:32 2017 New Revision: 291430 URL: http://llvm.org/viewvc/llvm-project?rev=291430=rev Log: [analyzer] Add checker for iterators dereferenced beyond their range. Patch by: Adam Balogh! Differential Revision: https://reviews.llvm.org/D25660 Added:

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:100 + StringRef ReplacementStr = + IsNoThrow ? NoexceptMacro.empty() ? "noexcept" : NoexceptMacro +

[PATCH] D28315: Update tools to use new getStyle API

ioeric added a comment. I ran `ninja check-all` with https://reviews.llvm.org/D28081 and https://reviews.llvm.org/D28315 (in Linux), and some lit tests failed, namely: Clang :: Format/style-on-command-line.cpp Clang Tools :: clang-apply-replacements/basic.cpp Clang Tools ::

[PATCH] D28208: Remove isIgnored()-test that is more expensive than the analysis behind it

djasper closed this revision. djasper added a comment. Landed as r290842. https://reviews.llvm.org/D28208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28418: Fixing test to work when the compiler defaults to a different C++ standard version

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28465: clang-format: [JS] ASI after imports

This revision was automatically updated to reflect the committed changes. Closed by commit rL291428: clang-format: [JS] ASI after imports (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D28465?vs=83593=83594#toc Repository: rL LLVM https://reviews.llvm.org/D28465

[PATCH] D28465: clang-format: [JS] ASI after imports

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r291428 - clang-format: [JS] ASI after imports

Author: mprobst Date: Mon Jan 9 02:56:36 2017 New Revision: 291428 URL: http://llvm.org/viewvc/llvm-project?rev=291428=rev Log: clang-format: [JS] ASI after imports Summary: Automatic semicolon insertion should break import and export statements: Before, this would format on one line: //

[PATCH] D28465: clang-format: [JS] ASI after imports

mprobst created this revision. mprobst added a reviewer: klimek. mprobst added a subscriber: cfe-commits. Automatic semicolon insertion should break import and export statements: Before, this would format on one line: // Note: no semi after 'x' below! import {x} from 'x' export function

[PATCH] D28419: clang-tools-extra: add gitattributes to disable EOL conversions on checkout of test source files

ioeric added a comment. I'm not entirely sure about this change... looping in Manuel. https://reviews.llvm.org/D28419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28255: [OpenMP] support the 'is_device_ptr' clause with 'target parallel for' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28252: [OpenMP] Sema and parsing for 'target teams distribute simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Sema/SemaOpenMP.cpp:6444 + + CapturedStmt *CS = cast(AStmt); + // 1.2.2 OpenMP Language Terminology auto *

[PATCH] D28243: [OpenMP] Add missing regression test for pragma distribute, clause firstprivate

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:63 +/// Common pre(post)-action for different OpenMP constructs. +class CommonActionTy final : public PrePostActionTy { + llvm::Value *EnterCallee; I don't think it is good to name it

Re: [PATCH] D28279: [clang-move] Support moving type alias declarations.

Testing phab parsing... On Wed, Jan 4, 2017 at 4:01 PM Haojian Wu via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL290967: [clang-move] Support moving type alias > declarations.

[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

rsmith added a comment. This makes sense to me in principle, but I'd like @chandlerc to weigh in. https://reviews.llvm.org/D26244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291427 - Implement C++ DR1391 (wg21.link/cwg1391)

Author: rsmith Date: Mon Jan 9 02:01:21 2017 New Revision: 291427 URL: http://llvm.org/viewvc/llvm-project?rev=291427=rev Log: Implement C++ DR1391 (wg21.link/cwg1391) Check for implicit conversion sequences for non-dependent function template parameters between deduction and substitution. The

<    1   2