Re: [PATCH] D28467: [Sema] Add warning for unused lambda captures

2017-01-19 Thread Malcolm Parsons via cfe-commits
On 19 January 2017 at 03:47, Aaron Ballman wrote: > It is not used in an unevaluated context -- that is a bug. It is an evaluated expression, but is it odr-used? C++14 [basic.def.odr] p3: A variable x whose name appears as a potentially-evaluated expression ex is

[PATCH] D28862: [compiler-rt] [test] Use approximate comparison on float types

2017-01-19 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Just to be clear, the values also differ per -O0 vs -O2. I'm not sure if we can even reliably figure that out. I've tried to work around the issue by building everything in 387 mode. However, in that case muldc3_test has even larger mismatches and didn't really want to

[PATCH] D28849: [compiler-rt] [test] Fix page address logic in clear_cache_test

2017-01-19 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 84947. mgorny retitled this revision from "[compiler-rt] [test] Fix page address logic in clear_cache_test to use binary negation" to "[compiler-rt] [test] Fix page address logic in clear_cache_test". mgorny edited the summary of this revision. mgorny added a

<    1   2