[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

rgov added a comment. Are all the changes here related to the extension/truncation support, for instance the changes to `test/Analysis/malloc.c`? Can you move misc. cleanup changes to another review? https://reviews.llvm.org/D28955 ___

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

rgov added a comment. Do you think you could upload the patch omitting all of the test case changes for now? Maybe include one as an example but it seems to be just adding `%z3_cc1` so we don't need to see all of them right now. The KLEE project has a useful abstraction layer around multiple

[PATCH] D21675: New ODR checker for modules

rtrieu added a comment. After changing the ODRHash class a bit, the new performance numbers are 3% in debug and 1-1.5% in release builds. https://reviews.llvm.org/D21675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r292694 - [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code.

Author: jlebar Date: Fri Jan 20 19:00:32 2017 New Revision: 292694 URL: http://llvm.org/viewvc/llvm-project?rev=292694=rev Log: [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code. Summary: Specifically, we upgrade llvm.nvvm.: * brev{32,64} * clz.{i,ll} * popc.{i,ll} *

[PATCH] D28793: [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292694: [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28793?vs=85206=85221#toc Repository: rL LLVM

[libcxx] r292689 - Fix recent build errors

Author: ericwf Date: Fri Jan 20 18:57:29 2017 New Revision: 292689 URL: http://llvm.org/viewvc/llvm-project?rev=292689=rev Log: Fix recent build errors Modified: libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.hash/hash_unique_ptr.pass.cpp

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen added inline comments. Comment at: llvm/include/llvm/ADT/APFloat.h:1039 + /// \brief Operator+ overload which provides the default + /// \c nmNearestTiesToEven rounding mode and *no* error checking. APFloat operator+(const APFloat ) const { echristo

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

timshen updated this revision to Diff 85217. timshen marked 2 inline comments as done. timshen added a comment. Stylish changes. https://reviews.llvm.org/D27872 Files: clang/test/CodeGen/ppc64-complex-parms.c llvm/include/llvm/ADT/APFloat.h llvm/lib/Support/APFloat.cpp

[libcxx] r292684 - Implement P0513R0 - "Poisoning the Hash"

Author: ericwf Date: Fri Jan 20 18:02:12 2017 New Revision: 292684 URL: http://llvm.org/viewvc/llvm-project?rev=292684=rev Log: Implement P0513R0 - "Poisoning the Hash" Summary: Exactly what the title says. This patch also adds a `std::hash` specialization in C++17, but it was not added by

[PATCH] D28938: Implement P0513R0 - "Poisoning the Hash"

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I feel comfortable with this in its current state. https://reviews.llvm.org/D28938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

bruno added a comment. How does this interact (if at all) with classes annotated with `__attribute__((objc_root_class))`? Comment at: lib/Sema/SemaCodeComplete.cpp:5259 SelIdents, CurContext, Selectors, AllowSameLength, Results,

[PATCH] D28849: [compiler-rt] [test] Fix page address logic in clear_cache_test

mgorny updated this revision to Diff 85208. mgorny marked an inline comment as done. mgorny added a comment. Fixed the missing change. Also created a local variable to avoid calling the sysconf three times. https://reviews.llvm.org/D28849 Files: test/builtins/Unit/clear_cache_test.c

[PATCH] D28793: [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code.

jlebar updated this revision to Diff 85206. jlebar added a comment. Get rid of h2f intrinsics. Thank you for the careful reviews, Art. https://reviews.llvm.org/D28793 Files: clang/include/clang/Basic/BuiltinsNVPTX.def llvm/include/llvm/IR/IntrinsicsNVVM.td llvm/lib/IR/AutoUpgrade.cpp

[PATCH] D28974: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL292671: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D28974?vs=85199=85205#toc Repository: rL LLVM

r292671 - [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

Author: phosek Date: Fri Jan 20 16:53:38 2017 New Revision: 292671 URL: http://llvm.org/viewvc/llvm-project?rev=292671=rev Log: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia The 32-bit architectures are no longer supported by Fuchsia. Differential Revision:

[PATCH] D28974: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D28974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28974: [Basic] Remove the 32-bit x86 and ARM targets for Fuchsia

phosek created this revision. Herald added subscribers: rengolin, aemerson. The 32-bit architectures are no longer supported by Fuchsia. Repository: rL LLVM https://reviews.llvm.org/D28974 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

[PATCH] D28843: IRGen: Start using the WriteThinLTOBitcode pass.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292662: IRGen: Start using the WriteThinLTOBitcode pass. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D28843?vs=84907=85198#toc Repository: rL LLVM

r292662 - IRGen: Start using the WriteThinLTOBitcode pass.

Author: pcc Date: Fri Jan 20 16:39:16 2017 New Revision: 292662 URL: http://llvm.org/viewvc/llvm-project?rev=292662=rev Log: IRGen: Start using the WriteThinLTOBitcode pass. This is the final change necessary to support CFI with ThinLTO. Differential Revision: https://reviews.llvm.org/D28843

[PATCH] D28973: Supresses misc-move-constructor-init warning for const fields.

lethalantidote created this revision. Supresses misc-move-constructor init warning for const fields. https://reviews.llvm.org/D28973 Files: clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp clang-tools-extra/test/clang-tidy/misc-move-constructor-init.cpp Index:

Re: [PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

On 20 January 2017 at 11:53, Eric Fiselier via Phabricator < revi...@reviews.llvm.org> wrote: > EricWF added a comment. > > @rsmith I looked for an alternative provider for aligned allocation but > couldn't find one, which is quite unfortunate. Is this going to mess up the > `__libcpp_version`

r292659 - [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

Author: timshen Date: Fri Jan 20 16:05:33 2017 New Revision: 292659 URL: http://llvm.org/viewvc/llvm-project?rev=292659=rev Log: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8)) For a << b (as original vec_sl does), if b >= sizeof(a) * 8, the behavior is undefined. However, Power

[PATCH] D28037: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

This revision was automatically updated to reflect the committed changes. Closed by commit rL292659: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8)) (authored by timshen). Changed prior to commit: https://reviews.llvm.org/D28037?vs=83140=85194#toc Repository: rL LLVM

[PATCH] D28037: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

timshen added a comment. In https://reviews.llvm.org/D28037#652021, @echristo wrote: > Going to commit this? I'd like to commit https://reviews.llvm.org/D28329 first. If we commit this now, the normal code will be slower. https://reviews.llvm.org/D28037

Re: [PATCH] D28037: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

Please go ahead and commit, we'll worry about speed after correctness. -eric On Fri, Jan 20, 2017 at 2:10 PM Tim Shen via Phabricator < revi...@reviews.llvm.org> wrote: > timshen added a comment. > > In https://reviews.llvm.org/D28037#652021, @echristo wrote: > > > Going to commit this? > > >

[PATCH] D28793: [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. There are couple of bits to be deleted. LGTM otherwise. Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:671-672 def int_nvvm_h2f : GCCBuiltin<"__nvvm_h2f">,

[PATCH] D28037: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

echristo added a comment. Going to commit this? https://reviews.llvm.org/D28037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Chance of disturbances in access llvm lab today

Hello everyone, We continue to works on llvm lab network. There is small chance of disturbances in access llvm lab today. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28793: [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code.

jlebar updated this revision to Diff 85189. jlebar marked an inline comment as done. jlebar added a comment. Address tra's review comments. > Perhaps we should add the list of such intrinsics and what happens to them in > a comment section in NVPTXIntrinsics.td. sgtm, done.

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On 20 January 2017 at 19:46, Eric Fiselier wrote: > This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. > We should merge this into 4.0 to help get `check-all` clean. Hi Eric, All good on my side, pass with GCC 5.4 and 6.3. Can you attach all commits that

Re: r291905 - [Sema] Add warning for unused lambda captures

This warns about code like constexpr int foo = 4; []() { use(foo); } That's correct, but removing then makes MSVC complain about this code like "error C3493: 'foo' cannot be implicitly captured because no default capture mode has been specified". A workaround is to make foo static const

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

Yes, the crash may happen only on CodeGenFunction destruction Best regards, Alexey Bataev 21 ???. 2017 ?., ? 0:04, Reid Kleckner > ???(?): Thanks! Does this match the logic for starting a function in OpenMP? Also, the test shouldn't have REQUIRES:

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

Thanks! Does this match the logic for starting a function in OpenMP? Also, the test shouldn't have REQUIRES: x86-registered-target. On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev > Date: Fri Jan 20 02:57:28 2017 > New

Re: r292522 - Don't inline dllimport functions referencing non-imported methods

The first Chrome DLL build with this change is crashing during compilation: https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%28dll%29/builds/8380/ The previous build fails with a link error, so the revision range for the new crash is 292501 - 292526. Only the DLL builders are

r292643 - Revert "Don't inline dllimport functions referencing non-imported methods"

Author: rnk Date: Fri Jan 20 14:44:50 2017 New Revision: 292643 URL: http://llvm.org/viewvc/llvm-project?rev=292643=rev Log: Revert "Don't inline dllimport functions referencing non-imported methods" This reverts commit r292522. It appears to be causing crashes in builds using dllimport.

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

dlj added a comment. Ping? https://reviews.llvm.org/D28478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28477: Add LF_ prefix to LibFunc enums in TargetLibraryInfo.

dlj added a comment. Ping? https://reviews.llvm.org/D28477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28007: Switch TableGen to emit calls to ASTRecordReader for AttrPCHRead.

dlj added a comment. Ping? https://reviews.llvm.org/D28007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r292639 - Revert r292508 given that we intend to remove driver options for cxx modules.

Author: mren Date: Fri Jan 20 14:03:00 2017 New Revision: 292639 URL: http://llvm.org/viewvc/llvm-project?rev=292639=rev Log: Revert r292508 given that we intend to remove driver options for cxx modules. Removed: cfe/trunk/test/Modules/check-syntax.mm Modified:

[PATCH] D28938: Implement P0513R0 - "Poisoning the Hash"

EricWF updated this revision to Diff 85172. EricWF added a comment. - Fix bitset test that was overflowing the stack. - Add tests that basic_string_view hashes to the same value as an equivalent basic_string. https://reviews.llvm.org/D28938 Files: include/__functional_base

[PATCH] D28931: Disable aligned new/delete on Apple platforms without posix_memalign

EricWF added a comment. @rsmith I looked for an alternative provider for aligned allocation but couldn't find one, which is quite unfortunate. Is this going to mess up the `__libcpp_version` detection Clang does? https://reviews.llvm.org/D28931

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7. We should merge this into 4.0 to help get `check-all` clean. /Eric On Fri, Jan 20, 2017 at 12:34 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jan 20 13:34:19 2017

[libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

Author: ericwf Date: Fri Jan 20 13:34:19 2017 New Revision: 292638 URL: http://llvm.org/viewvc/llvm-project?rev=292638=rev Log: Fix catch_reference_nullptr.pass.cpp test for GCC. This test contained an implicit conversion from nullptr to bool. Clang warns about this but the test had supressed

r292637 - [docs] Regenerate DiagnosticsReference.rst. We don't have automatic generation of this set up server-side yet.

Author: rsmith Date: Fri Jan 20 13:27:09 2017 New Revision: 292637 URL: http://llvm.org/viewvc/llvm-project?rev=292637=rev Log: [docs] Regenerate DiagnosticsReference.rst. We don't have automatic generation of this set up server-side yet. Modified: cfe/trunk/docs/DiagnosticsReference.rst

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

We should merge this patch into the 4.0 release branch. It is needed to make "check-all" pass when using GCC 4, 5 and 6. /Eric On Fri, Jan 20, 2017 at 5:54 AM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Fri Jan 20 06:54:45 2017 > New Revision:

r292636 - AMDGPU: Add builtin for getreg intrinsic

Author: arsenm Date: Fri Jan 20 13:24:22 2017 New Revision: 292636 URL: http://llvm.org/viewvc/llvm-project?rev=292636=rev Log: AMDGPU: Add builtin for getreg intrinsic Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn.cl

RE: r292568 - [test] Remove an unwanted match for `UNSUPPORTED:`.

I'd call this a bug in lit; it shouldn't be matching partial tokens. --paulr > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of > Greg Parker via cfe-commits > Sent: Thursday, January 19, 2017 6:12 PM > To: cfe-commits@lists.llvm.org >

r292635 - [Sema] Remove dead typedef

Author: bruno Date: Fri Jan 20 13:04:01 2017 New Revision: 292635 URL: http://llvm.org/viewvc/llvm-project?rev=292635=rev Log: [Sema] Remove dead typedef Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL:

[PATCH] D28832: Improve redefinition errors pointing to the same header.

bruno added a comment. Thanks Vassil. @rsmith is this ok for you? https://reviews.llvm.org/D28832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r292632 - Fix actually-reachable llvm_unreachable.

Author: rsmith Date: Fri Jan 20 12:50:12 2017 New Revision: 292632 URL: http://llvm.org/viewvc/llvm-project?rev=292632=rev Log: Fix actually-reachable llvm_unreachable. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp cfe/trunk/test/CodeGenCXX/mangle.cpp Modified:

[PATCH] D28946: [analyzer] Fix memory space for block-captured static locals.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM! It would be good to get this into the clang 4.0 svn branch, too. I think Hans Wennborg is managing this. See

Re: r292508 - Module: Improve diagnostic message when cxx modules are disabled and @import is used in Objective CXX.

On 20 Jan 2017 9:49 am, "Manman Ren" wrote: On Thu, Jan 19, 2017 at 1:27 PM, Richard Smith wrote: > On 19 Jan 2017 11:16 am, "Manman Ren via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Author: mren > Date: Thu Jan 19 13:05:55 2017 >

[PATCH] D28933: Revert the return type for `emplace_(back|front)` to `void` in C++14 and before

EricWF added a comment. I hate that we have to conditionalize this change at all, but your changes LGTM. https://reviews.llvm.org/D28933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. @pekka.jaaskelainen, I just compiled the release 4.0 branch and it all works for me as expected: clang -cc1 -triple spir64-unknown-unknown test.cl clang -target spir64-unknown-unknown test.cl https://reviews.llvm.org/D28080

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

ahatanak added a comment. If they are equal, the loop can continue because a UsingDecl doesn't hide a UsingShadowDecl that is tied to it. Repository: rL LLVM https://reviews.llvm.org/D28514 ___ cfe-commits mailing list

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

ahatanak added a comment. In the example I showed, wouldn't the DeclContext for all the UsingDecls and UsingShadowDecls be the FunctionDecl for foo1? Maybe you can check whether UsingShadowDecl::getUsingDecl() (which returns the UsingDecl which is tied to the UsingShadowDecl) is equal to the

[PATCH] D28835: [coroutines] NFC: Refactor Sema::CoroutineBodyStmt construction.

GorNishanov added a comment. @rsmith, Looking good? https://reviews.llvm.org/D28835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28793: [NVPTX] Auto-upgrade some NVPTX intrinsics to LLVM target-generic code.

tra added a comment. Now that we've removed ton of @llvm.nvvm intrinsics from .td files, we have no easy way to tell that we still do support these intrinsics (mostly for the sake of libdevice?) by upgrading them. Perhaps we should add the list of such intrinsics and what happens to them in a

Re: r292508 - Module: Improve diagnostic message when cxx modules are disabled and @import is used in Objective CXX.

On Thu, Jan 19, 2017 at 1:27 PM, Richard Smith wrote: > On 19 Jan 2017 11:16 am, "Manman Ren via cfe-commits" < > cfe-commits@lists.llvm.org> wrote: > > Author: mren > Date: Thu Jan 19 13:05:55 2017 > New Revision: 292508 > > URL:

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Sorry for the delay, I though you were still iterating with @aprantl for some reason. LGTM https://reviews.llvm.org/D28299 ___

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

arphaman updated this revision to Diff 85151. arphaman added a comment. Ensure that the UsingShadowDecl and UsingDecl are in the same DeclContext. Repository: rL LLVM https://reviews.llvm.org/D28514 Files: lib/Sema/SemaLookup.cpp test/Index/complete-cached-globals.cpp Index:

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

arphaman added a comment. In https://reviews.llvm.org/D28514#651675, @ahatanak wrote: > This is not invalid: > > namespace Foo { > class C { }; > } > namespace Bar { class C { }; } > > void foo1() { > using Foo::C; > { > using Bar::C; > } > } > I see, that could

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

ahatanak added a comment. This is not invalid: namespace Foo { class C { }; } namespace Bar { class C { }; } void foo1() { using Foo::C; { using Bar::C; } } Repository: rL LLVM https://reviews.llvm.org/D28514 ___

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

ahatanak added a comment. I had something like the following code in mind (which is not invalid). Does usingdecl Bar::C hide Foo::C ? namespace Foo { class C { }; } namespace Bar { class C { }; } using Foo::C; { using Bar::C; } Repository: rL LLVM

[PATCH] D28514: [CodeCompletion] Reset the hidden declaration obtained after lookup when caching UsingShadowDecls

arphaman added inline comments. Comment at: lib/Sema/SemaLookup.cpp:3433 + // is not hidden by the using declaration. + if (isa(ND) && isa(D)) +continue; ahatanak wrote: > Do we have to check that ND's UsingDecl is equal to D? Or we don't have

[PATCH] D28771: [Analyzer] Various fixes for the IteratorPastEnd checker

NoQ added a comment. Thanks for the update, most welcome! Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:234 +if (Call.getNumArgs() >= 1) { + const auto = static_cast(Call); + handleRandomIncrOrDecr(C,

[PATCH] D28349: [Frontend] The macro that describes the Objective-C bool type should be defined in C as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL292617: [Frontend] The macro that describes the Objective-C bool type should (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D28349?vs=83354=85143#toc Repository: rL LLVM

r292617 - [Frontend] The macro that describes the Objective-C bool type should

Author: arphaman Date: Fri Jan 20 10:48:25 2017 New Revision: 292617 URL: http://llvm.org/viewvc/llvm-project?rev=292617=rev Log: [Frontend] The macro that describes the Objective-C bool type should be defined for non Objective-C code as well rdar://29794915 Differential Revision:

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

ddcc added a comment. - This patch introduces a virtual overloaded `llvm::APFloat getSymVal()` for returning the value of known floating-point constants. In the long term, both `getSymVal()` functions should probably be refactored to return something like a `llvm::Con - There are also

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. This is a fairly large patch, but the core of it is the actual implementation of the Z3 constraint solver backend. In its current form, the backend is implemented as a Clang plugin, but I also have a git commit that has it inside the static analyzer. The non-plugin

Re: [PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

On Fri, 20 Jan 2017 at 11:26 Eric Liu via Phabricator < revi...@reviews.llvm.org> wrote: ioeric added a comment. In https://reviews.llvm.org/D28943#651536, @amaiorano wrote: > In https://reviews.llvm.org/D28943#651489, @ioeric wrote: > > > In https://reviews.llvm.org/D28943#651488, @amaiorano

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

ioeric added a comment. In https://reviews.llvm.org/D28943#651536, @amaiorano wrote: > In https://reviews.llvm.org/D28943#651489, @ioeric wrote: > > > In https://reviews.llvm.org/D28943#651488, @amaiorano wrote: > > > > > In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > > > > > > >

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

Hello Mikael, Did you try again with the removal of the redundant test (D28943)? On Fri, 20 Jan 2017 at 08:34 Mikael Holmén wrote: > Hi, > > On 01/20/2017 02:20 PM, Antonio Maiorano wrote: > > Hi Mikael, > > > > Just to be sure, did you build clang-format before

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

ddcc created this revision. With the Z3 constraint manager, symbolic extension and truncation of variables can be fully reasoned about. https://reviews.llvm.org/D28955 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

ddcc created this revision. Herald added a subscriber: mgorny. With the Z3 constraint manager, symbolic floating-point constraints can also be reasoned about. This commit includes a basic floating-point checker for domain errors with math functions. https://reviews.llvm.org/D28954 Files:

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

ddcc updated this revision to Diff 85139. ddcc added a comment. Fix rebase https://reviews.llvm.org/D28953 Files: include/clang/StaticAnalyzer/Checkers/SValExplainer.h lib/StaticAnalyzer/Core/SValBuilder.cpp lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/bitwise-ops.c

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

ddcc updated this revision to Diff 85136. ddcc added a comment. Rebase https://reviews.llvm.org/D26061 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h

[PATCH] D25817: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

This revision was automatically updated to reflect the committed changes. Closed by commit rL292615: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D25817?vs=75712=85135#toc Repository:

r292615 - [Sema] Improve the error diagnostic for dot destructor calls on pointer objects

Author: arphaman Date: Fri Jan 20 09:38:58 2017 New Revision: 292615 URL: http://llvm.org/viewvc/llvm-project?rev=292615=rev Log: [Sema] Improve the error diagnostic for dot destructor calls on pointer objects This commit improves the mismatched destructor type error by detecting when the

Re: [libcxx] r292582 - Still expose std::align_val_t in C++17 even if we don't have aligned new/delete.

On Thu, Jan 19, 2017 at 10:40 PM, Eric Fiselier wrote: > Hi All, > > This patch addresses issues introduced by r292564. Specifically it makes > `align_val_t.pass.cpp` pass in C++17 even if the system > doesn't support aligned new/delete. > > Because r292564 was merged into 4.0,

[PATCH] D28729: [clang-tidy] Add -enable-alpha-checks command

Prazek added a comment. Ok, I didn't know that it is this easy to run alpha checks from clang. https://reviews.llvm.org/D28729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27710: [analyzer] Prohibit ExplodedGraph's edges duplicating

NoQ added a comment. In https://reviews.llvm.org/D27710#650396, @ilya-palachev wrote: > I don't understand why the following test passes, because each of two > checkers: `MallocChecker` and `SimpleStreamChecker` are using > `generateNonFatalErrorNode` method: That's because error nodes

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

amaiorano added a comment. In https://reviews.llvm.org/D28943#651489, @ioeric wrote: > In https://reviews.llvm.org/D28943#651488, @amaiorano wrote: > > > In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > > > > > @amaiorano: The test itself is correct. It's just that this test failed >

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

Hi, On 01/20/2017 02:20 PM, Antonio Maiorano wrote: Hi Mikael, Just to be sure, did you build clang-format before running this test? Yes I did. I compiled a clean trunk, ran the test, got the failure. Possibly related, one of the tests I added was just removed for being redundant:

Re: [PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

You mean you build a modified version of clang-format where Style is initialized to getGoogleStyle()? I had wondered whether adding a -defaultStyle argument might be useful, specifically in the case where you want to pass in yaml that simply tweaks the default style, but I figured it's not much

[PATCH] D28946: [analyzer] Fix memory space for block-captured static locals.

NoQ created this revision. When a block that is being analyzed as top-level captures static local variables declared in a function (which itself is not being analyzed) surrounding the block, it puts such variables into the unknown memory space, similarly to the stack locals of those functions

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

Hi Mikael, Just to be sure, did you build clang-format before running this test? Possibly related, one of the tests I added was just removed for being redundant: https://reviews.llvm.org/D28943 On Fri, Jan 20, 2017 at 7:50 AM Mikael Holmén wrote: > Hi Antonio, > >

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

ioeric added a comment. In https://reviews.llvm.org/D28943#651488, @amaiorano wrote: > In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > > > @amaiorano: The test itself is correct. It's just that this test failed in > > our internal test. We could've fixed it internally, but the fix

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

amaiorano added a comment. In https://reviews.llvm.org/D28943#651470, @ioeric wrote: > @amaiorano: The test itself is correct. It's just that this test failed in > our internal test. We could've fixed it internally, but the fix would be > ugly. Since the intended behavior is already covered in

[libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

Author: ericwf Date: Fri Jan 20 06:54:45 2017 New Revision: 292607 URL: http://llvm.org/viewvc/llvm-project?rev=292607=rev Log: Don't default older GCC's to C++17, but C++14 or C++11 instead Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py

Re: PATCH: re-enable OpenCL extensions

On 19.01.2017 23:43, Liu, Yaxun (Sam) wrote: I think the supported extensions for a target should be as accurate as possible, for it to be useful. Setting all extensions to be supported on all targets will defeat its purpose. I agree on the first part, but arrive at the exact opposite

[libcxx] r292606 - Revert "Don't default older GCC's to C++17, but C++14 or C++11 instead"

Author: ericwf Date: Fri Jan 20 06:52:59 2017 New Revision: 292606 URL: http://llvm.org/viewvc/llvm-project?rev=292606=rev Log: Revert "Don't default older GCC's to C++17, but C++14 or C++11 instead" The commit isn't quite right, and I want to only have to merge one commit into 4.0 Modified:

[libcxx] r292605 - Don't default older GCC's to C++17, but C++14 or C++11 instead

Author: ericwf Date: Fri Jan 20 06:46:57 2017 New Revision: 292605 URL: http://llvm.org/viewvc/llvm-project?rev=292605=rev Log: Don't default older GCC's to C++17, but C++14 or C++11 instead Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL292604: [clang-format] Remove redundant test in style-on-command-line.cpp (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D28943?vs=85117=85122#toc Repository: rL LLVM

r292604 - [clang-format] Remove redundant test in style-on-command-line.cpp

Author: krasimir Date: Fri Jan 20 06:39:05 2017 New Revision: 292604 URL: http://llvm.org/viewvc/llvm-project?rev=292604=rev Log: [clang-format] Remove redundant test in style-on-command-line.cpp Summary: rL292562 added a fix to always format if the fallback style is set to "none". In

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

Hi Antonio, The test case Clang :: Format/style-on-command-line.cpp fails for me since this commit. test/Format/style-on-command-line.cpp:40:13: error: expected string not found in input // CHECK10: {{^int\* i;$}} ^ :1:1: note: scanning from here // RUN: clang-format

[PATCH] D28943: [clang-format] Remove redundant test in style-on-command-line.cpp

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. @amaiorano: The test itself is correct. It's just that this test failed in our internal test. We could've fixed it internally, but the fix would be ugly. Since the intended behavior is

[PATCH] D28941: Remove 'RUN: false' from Driver/response-file.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL292600: Remove 'RUN: false' from Driver/response-file.c (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D28941?vs=85111=85114#toc Repository: rL LLVM

r292600 - Remove 'RUN: false' from Driver/response-file.c

Author: krasimir Date: Fri Jan 20 05:06:58 2017 New Revision: 292600 URL: http://llvm.org/viewvc/llvm-project?rev=292600=rev Log: Remove 'RUN: false' from Driver/response-file.c Summary: It seems that rL292518 introduced a RUN: false, but the continuation rL292545 forgot to remove it back. This

[PATCH] D28941: Remove 'RUN: false' from Driver/response-file.c

krasimir added a comment. @bkramer: yes, it passes with RUN: false removed https://reviews.llvm.org/D28941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >