[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

vsk added a comment. In https://reviews.llvm.org/D29369#664366, @regehr wrote: > Out of curiosity, how many of these superfluous checks are not subsequently > eliminated by InstCombine? I don't have numbers from a benchmark prepped. Here's what we get with the 'ubsan-promoted-arith.cpp' test

r293867 - CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC)

Author: compnerd Date: Wed Feb 1 23:45:43 2017 New Revision: 293867 URL: http://llvm.org/viewvc/llvm-project?rev=293867=rev Log: CodeGen: add a LLVM_FALLTHROUGH to a fallthrough (NFC) Drive by cleanup noticed while investigating an IR verifier assertion. Modified:

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, looks good. https://reviews.llvm.org/D29208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

wristow marked 2 inline comments as done. wristow added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1135 MemberExpr *ME2 = dyn_cast(RHS); -if (dyn_cast(ME2->getMemberDecl()) != Field) +if (!ME2 || dyn_cast(ME2->getMemberDecl()) != Field)

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

wristow updated this revision to Diff 86767. wristow added a comment. Code restructured. https://reviews.llvm.org/D29208 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/atomic-dllexport.cpp Index: test/CodeGenCXX/atomic-dllexport.cpp

r293863 - Modules: Simplify CompilerInstance constructor, NFC

Author: dexonsmith Date: Wed Feb 1 23:09:51 2017 New Revision: 293863 URL: http://llvm.org/viewvc/llvm-project?rev=293863=rev Log: Modules: Simplify CompilerInstance constructor, NFC Initialize fields directly in header. Note that the ModuleManager field is an IntrusiveRefCntPtr, so there's no

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

regehr added a comment. Does this check need to be sensitive to the dialect of C/C++ that the user asked for? I know that it used to be the case that the standard could be read either way for this case, but as you observe it is now unambiguously UB. https://reviews.llvm.org/D29437

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

regehr added a comment. Out of curiosity, how many of these superfluous checks are not subsequently eliminated by InstCombine? https://reviews.llvm.org/D29369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24933: Enable configuration files in clang

sepavloff updated this revision to Diff 86761. sepavloff added a comment. Herald added a subscriber: danalbert. Updated patch Use more robust algorithm to determine custom compiler prefix. Bring the code in sync with changes in llvm patch. https://reviews.llvm.org/D24933 Files:

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

vsk created this revision. Teach ubsan to diagnose remainder operations which have undefined behavior due to signed overflow. My copy of the C11 spec draft (6.5.5.6) says that: if the quotient a/b is representable, (a/b)*b + a%b shall equal a; otherwise, the behavior of both a/b and a%b is

r293853 - Fix attribute name in diagnostic message to match actual attribute name.

Author: rsmith Date: Wed Feb 1 19:50:47 2017 New Revision: 293853 URL: http://llvm.org/viewvc/llvm-project?rev=293853=rev Log: Fix attribute name in diagnostic message to match actual attribute name. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

rjmccall added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1135 MemberExpr *ME2 = dyn_cast(RHS); -if (dyn_cast(ME2->getMemberDecl()) != Field) +if (!ME2 || dyn_cast(ME2->getMemberDecl()) != Field) return nullptr;

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

wristow added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1135 MemberExpr *ME2 = dyn_cast(RHS); -if (dyn_cast(ME2->getMemberDecl()) != Field) +if (!ME2 || dyn_cast(ME2->getMemberDecl()) != Field) return nullptr;

r293848 - [CodeGen] Update test after recent changes in llvm (r293846).

Author: davide Date: Wed Feb 1 18:47:53 2017 New Revision: 293848 URL: http://llvm.org/viewvc/llvm-project?rev=293848=rev Log: [CodeGen] Update test after recent changes in llvm (r293846). Modified: cfe/trunk/test/CodeGen/link-bitcode-file.c Modified:

[clang-tools-extra] r293845 - [clang-tidy] misc-argument-comment support for gmock

Author: alexfh Date: Wed Feb 1 18:37:08 2017 New Revision: 293845 URL: http://llvm.org/viewvc/llvm-project?rev=293845=rev Log: [clang-tidy] misc-argument-comment support for gmock Modified: clang-tools-extra/trunk/clang-tidy/misc/ArgumentCommentCheck.cpp

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

vsk updated this revision to Diff 86746. vsk edited the summary of this revision. vsk added a comment. - Remove a stale test case in unsigned-promotion.c. https://reviews.llvm.org/D29369 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/compound-assign-overflow.c

[PATCH] D29432: Modular Codegen: Emit inline asm into users, not modular objects

dblaikie added a comment. Oh, one of the reasons I was sort of compelled to keep the 'classic' AST file compilation working was that when looking at the change history of the test cases exercising it I found that some changes had been motivated by a filed LLVM bug:

Re: Add warning for c++ member variable shadowing

+ std::set bases; +const auto baseName = Specifier->getType()->getAsCXXRecordDecl()->getName(); Please capitalize local variable names. Also, please don't use the record name as a key in your set; that's not guaranteed to be unique. Instead, you could either use a set of canonical types or

[PATCH] D29432: Modular Codegen: Emit inline asm into users, not modular objects

dblaikie created this revision. The best semantics I can come up with (based on discussions with Richard) for inline asm and namespace scope internal linkage variables in modular headers is to emit them into all users and never into modular objects. The reason for this is that such asm might

r293839 - clang-format: Fix incorrect line breaks after forced operator wraps.

Author: djasper Date: Wed Feb 1 17:27:37 2017 New Revision: 293839 URL: http://llvm.org/viewvc/llvm-project?rev=293839=rev Log: clang-format: Fix incorrect line breaks after forced operator wraps. Before: bool x = a // || b // || ;

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

vsk updated this revision to Diff 86739. vsk marked an inline comment as done. vsk added a comment. - Per Eli's comment: check that integers are actually widened, instead of incorrectly assuming they are always widened. I added some test cases for this. - Address the 'fixme' regarding

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

vsk marked an inline comment as done. vsk added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:72 + if (const auto *UO = dyn_cast(Op.E)) +return IsPromotedInteger(UO->getSubExpr()); + efriedma wrote: > Checking isPromotableIntegerType doesn't

r293834 - Change debug-info-for-profiling from a TargetOption to a function attribute.

Author: dehao Date: Wed Feb 1 16:45:21 2017 New Revision: 293834 URL: http://llvm.org/viewvc/llvm-project?rev=293834=rev Log: Change debug-info-for-profiling from a TargetOption to a function attribute. Summary: cfe change for https://reviews.llvm.org/D29203 Reviewers: echristo, dblaikie

[PATCH] D29384: [analyzer] Fix an assertion fail in CStringSyntaxChecker

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for fixing this! Repository: rL LLVM https://reviews.llvm.org/D29384 ___ cfe-commits mailing list

[PATCH] D29205: Change debug-info-for-profiling from a TargetOption to a function attribute.

dblaikie added a comment. Oops, forgot to write stuff so the approval appears on-list. Anyway - looks good/approved. https://reviews.llvm.org/D29205 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. In https://reviews.llvm.org/D28952#659728, @nlopes wrote: > Let me give just 2 more Z3-related suggestions: > > - instead of re-creating the solver, it might be faster to do Z3_solver_reset > - "once in a while" it might be helpful to delete everything (all solvers, >

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Thanks Adrian for the fast response. See some answers below. I will update the code and upload a new patch soon. Comment at: lib/CodeGen/MacroPPCallbacks.cpp:154 +StringRef SearchPath, StringRef RelativePath, const Module *Imported) { + // Only

r293817 - Repoint 'missing typename' diagnostic to the location where 'typename' should be added.

Author: rsmith Date: Wed Feb 1 15:41:18 2017 New Revision: 293817 URL: http://llvm.org/viewvc/llvm-project?rev=293817=rev Log: Repoint 'missing typename' diagnostic to the location where 'typename' should be added. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp

r293815 - Fix hole in our enforcement of rule requiring 'typename' prior to a dependent

Author: rsmith Date: Wed Feb 1 15:36:38 2017 New Revision: 293815 URL: http://llvm.org/viewvc/llvm-project?rev=293815=rev Log: Fix hole in our enforcement of rule requiring 'typename' prior to a dependent name. If the dependent name happened to end in a template-id (X::Y), we would fail to

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

Merged this one in r293813. Cheers, Hans On Wed, Feb 1, 2017 at 1:16 PM, Renato Golin wrote: > Right, the other one was 292607 and has already been merged. Sorry for > the confusion. We just need to merge this one and we're done. > > --renato > > On 1 February 2017 at

[libcxxabi] r293813 - Merging r292638:

Author: hans Date: Wed Feb 1 15:30:36 2017 New Revision: 293813 URL: http://llvm.org/viewvc/llvm-project?rev=293813=rev Log: Merging r292638: r292638 | ericwf | 2017-01-20 11:34:19 -0800 (Fri, 20 Jan 2017) | 9 lines Fix

[PATCH] D29419: [Analyzer] Checker for mismatched iterators

baloghadamsoftware updated this revision to Diff 86709. baloghadamsoftware added a comment. Herald added a subscriber: mgorny. The checker itself disappeared mystically from the previous diff... https://reviews.llvm.org/D29419 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D29419: [Analyzer] Checker for mismatched iterators

baloghadamsoftware created this revision. A new checker to check whether multiple iterators which should refer to the same container refer to different ones. Here we include comparisons, constructors which take an iterator pair and any template function which takes iterator pair(s).

[PATCH] D20561: Warn when taking address of packed member

joerg added a comment. The last review left out the case of naturally aligned packed members, IIRC. I have to go over the warning list in NetBSD again, but I'm moderately sure it is not fixed. The better example is: struct __attribute__((__packed__)) bar { uint16_t x1; uint16_t

[PATCH] D29396: [clang-format] Don't reflow lines starting with TODO, FIXME or XXX.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D29396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

Right, the other one was 292607 and has already been merged. Sorry for the confusion. We just need to merge this one and we're done. --renato On 1 February 2017 at 21:14, Renato Golin wrote: > On 1 February 2017 at 19:33, Hans Wennborg wrote: >> Also

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On 1 February 2017 at 19:33, Hans Wennborg wrote: > Also I'm confused, since I haven't seen anything besides r292638 > mentioned. Are there other changes besides that up for merging? I think the other commits were back-ported by other means (other PRs). Regardless, this is an

r293810 - [CodeGen] Update test after recent changes in llvm (r293799).

Author: davide Date: Wed Feb 1 14:43:28 2017 New Revision: 293810 URL: http://llvm.org/viewvc/llvm-project?rev=293810=rev Log: [CodeGen] Update test after recent changes in llvm (r293799). Modified: cfe/trunk/test/CodeGen/link-bitcode-file.c Modified:

r293808 - [Sema][ObjC] Don't pass a DeclRefExpr that doesn't reference a VarDecl

Author: ahatanak Date: Wed Feb 1 14:22:26 2017 New Revision: 293808 URL: http://llvm.org/viewvc/llvm-project?rev=293808=rev Log: [Sema][ObjC] Don't pass a DeclRefExpr that doesn't reference a VarDecl to WeakObjectProfileTy's constructor. This fixes an assertion failure in WeakObjectProfileTy's

[PATCH] D29415: [Assembler] Inline assembly diagnostics test.

sanwou01 created this revision. Herald added a subscriber: mehdi_amini. Add a test for improved inline assembly diagnostics in llvm. https://reviews.llvm.org/D29415 Files: test/Misc/inline-asm-diags.c Index: test/Misc/inline-asm-diags.c

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. Thanks :) I should get a chance to return to this next week. Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. Thanks - the merge conflicts don't look too bad. I should have it cleaned up by tomorrow. https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [libcxxabi] r292638 - Fix catch_reference_nullptr.pass.cpp test for GCC.

On Tue, Jan 31, 2017 at 11:40 AM, Renato Golin wrote: > On 31 January 2017 at 18:36, Hans Wennborg wrote: Can you attach all commits that need to be backported into a bug against PR31622? We should probably squash them all before

[PATCH] D25674: [Concepts] Class template associated constraints

hubert.reinterpretcast added a comment. Ping! https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP updated this revision to Diff 86681. KP added a comment. Rebase after r293616. Replace isPointerOrReference with a direct check on the token type. https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatTest.cpp Index:

[PATCH] D29208: Prevent ICE in dllexport class with _Atomic() data member

rjmccall requested changes to this revision. rjmccall added inline comments. This revision now requires changes to proceed. Comment at: lib/CodeGen/CGClass.cpp:1135 MemberExpr *ME2 = dyn_cast(RHS); -if (dyn_cast(ME2->getMemberDecl()) != Field) +if (!ME2

[PATCH] D16135: Macro Debug Info support in Clang

aprantl added a comment. Thanks! Couple more inline comments. Comment at: lib/CodeGen/CGDebugInfo.h:415 + /// Get macro debug info. + llvm::DIMacro *CreateMacro(llvm::DIMacroFile *Parent, unsigned MType, It would be good to be a bit more descriptive here.

[PATCH] D28989: [X86][MS]Adjacent comments within multi-line inline assembly statement

rnk accepted this revision. rnk added a comment. Sorry, missed this, looks good. Repository: rL LLVM https://reviews.llvm.org/D28989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29152: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

This revision was automatically updated to reflect the committed changes. Closed by commit rL293800: Drop 'dllimport' when redeclaring inline function template without the… (authored by hans). Changed prior to commit: https://reviews.llvm.org/D29152?vs=85818=86676#toc Repository: rL LLVM

r293800 - Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695)

Author: hans Date: Wed Feb 1 12:52:53 2017 New Revision: 293800 URL: http://llvm.org/viewvc/llvm-project?rev=293800=rev Log: Drop 'dllimport' when redeclaring inline function template without the attribute (PR31695) For non-template dllimport functions, MSVC allows providing an inline

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

If Anna is Ok with it, I'm fine with merging. Thanks, Hans On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev wrote: > Hans, > > This is a fixed and tested version of the previously-merged-and-reverted > r292800, do we still have time to land this into 4.0? > > Thanks, >

[PATCH] D29118: [clang-tidy] safety-no-vector-bool

jbcoe abandoned this revision. jbcoe added a comment. Posting a comment re-opened this patch. The approach taken cannot handle templates using `std::vector`, a radical rework is needed. https://reviews.llvm.org/D29267 introduces the safety critical module with a much simpler check (no

Re: r293787 - [CodeGen][ObjC] Avoid asserting on block pointer types in

OK. Merged in r293797. Thanks, Hans On Wed, Feb 1, 2017 at 9:50 AM, Alex L wrote: > Hi Hans, > > Would it be possible to merge this for 4.0? > > Cheers, > Alex > > On 1 February 2017 at 17:37, Alex Lorenz via cfe-commits > wrote: >> >> Author:

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

efriedma added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:72 + if (const auto *UO = dyn_cast(Op.E)) +return IsPromotedInteger(UO->getSubExpr()); + Checking isPromotableIntegerType doesn't work the way you want it to; types can be "promoted"

Re: r293043 - [analyzer] Fix MacOSXAPIChecker fp with static locals seen from nested blocks.

Hans, This is a fixed and tested version of the previously-merged-and-reverted r292800, do we still have time to land this into 4.0? Thanks, Artem. On 1/25/17 1:21 PM, Artem Dergachev via cfe-commits wrote: Author: dergachev Date: Wed Jan 25 04:21:45 2017 New Revision: 293043 URL:

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Awesome. Thank you all! :) On Wed, Feb 1, 2017 at 9:25 AM, Hans Wennborg wrote: > Merged this (r291963) in r293783. > > And the others (r293360 + r293369) in r293784. > > Thanks, > Hans > > On Tue, Jan 31, 2017 at 7:17 PM, Richard Smith > wrote: > >

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 86669. aaboud marked an inline comment as done. aaboud added a comment. Address Adrian and Richard comments. Please, review the new patch and let me know if I need to change anything else. Thanks, Amjad https://reviews.llvm.org/D16135 Files:

[PATCH] D16135: Macro Debug Info support in Clang

aaboud marked 7 inline comments as done. aaboud added a comment. Thanks Adrian and Richard for the comments, I appreciate that. I am uploading a new patch that address most of the comments. Adrian, I answered some of your comments below. Thanks, Amjad Comment at:

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

erichkeane added a comment. Some quick line-comments here. Comment at: lib/Parse/ParseStmt.cpp:186 // found. -if (Next.isNot(tok::coloncolon)) { +if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat || +Next.isNot(tok::less))) {

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

erichkeane created this revision. As we know, MSVC is pretty relaxed when it comes to 'typename'. Clang so far does a pretty darn good job of permitting the behavior, however there was 1 missed case that compiles in MSVC (as of 2015), but not in clang. I've updated the test for similar ones

Re: r293787 - [CodeGen][ObjC] Avoid asserting on block pointer types in

Hi Hans, Would it be possible to merge this for 4.0? Cheers, Alex On 1 February 2017 at 17:37, Alex Lorenz via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: arphaman > Date: Wed Feb 1 11:37:28 2017 > New Revision: 293787 > > URL: http://llvm.org/viewvc/llvm-project?rev=293787=rev

r293787 - [CodeGen][ObjC] Avoid asserting on block pointer types in

Author: arphaman Date: Wed Feb 1 11:37:28 2017 New Revision: 293787 URL: http://llvm.org/viewvc/llvm-project?rev=293787=rev Log: [CodeGen][ObjC] Avoid asserting on block pointer types in isPointerZeroInitializable rdar://30111891 Added: cfe/trunk/test/CodeGenObjC/block-ptr-type-crash.m

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

KP added a comment. In https://reviews.llvm.org/D27651#661490, @djasper wrote: > I have given stuff in WhitespaceManager access to the actual FormatToken in > r293616. Hopefully that simplifies this patch. Thanks! I'll try to rebase and see what can be improved.

Re: r293360 - Change how we handle diagnose_if attributes.

Merged in r293784, as discussed on the commit thread for r291963. Thanks, Hans On Sun, Jan 29, 2017 at 5:59 PM, George Burgess IV wrote: > Hi! > > Now that the buidbots seem content, I think that this (...along with the > minor fix to the test in r293369) should be

Re: r291963 - [clang] Emit `diagnose_if` warnings from system headers

Merged this (r291963) in r293783. And the others (r293360 + r293369) in r293784. Thanks, Hans On Tue, Jan 31, 2017 at 7:17 PM, Richard Smith wrote: > I'm fine with these patches being merged. Hopefully we still have plenty of > time to shake out any problems between

Re: [PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

On Tue, Jan 31, 2017 at 3:23 PM, Richard Smith wrote: > On 31 January 2017 at 14:49, Hans Wennborg wrote: >> >> Richard, what do you think? I don't believe this fixes a 3.9 >> regression, but the fix looks small, so it might be worth it. > > > I think

[clang-tools-extra] r293771 - [clang-tidy] misc-argument-comment: ignore comments after arguments

Author: alexfh Date: Wed Feb 1 09:28:25 2017 New Revision: 293771 URL: http://llvm.org/viewvc/llvm-project?rev=293771=rev Log: [clang-tidy] misc-argument-comment: ignore comments after arguments Modified: clang-tools-extra/trunk/clang-tidy/misc/ArgumentCommentCheck.cpp

Re: r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.

I've narrowed the problem down to the difference in the linkage type for "clang::ast_matchers::recordDecl" between the module and non-module build: Module: @_ZN5clang12ast_matchersL10recordDeclE = external global %"class.clang::ast_matchers::internal::VariadicDynCastAllOfMatcher.847", align 1

[PATCH] D29339: [OpenMP] Add support for auxiliary triple specification

gtbercea updated this revision to Diff 86635. gtbercea added a comment. Condition changed to only check triple once. Repository: rL LLVM https://reviews.llvm.org/D29339 Files: lib/Driver/Tools.cpp lib/Frontend/CompilerInstance.cpp lib/Frontend/CompilerInvocation.cpp

RE: r290539 - [inline-asm]No error for conflict between inputs\outputs and clobber list

It should. Ziv, there seems to be some bug with the implementation, can you fix it please? Thanks, Marina -Original Message- From: Dimitry Andric [mailto:dimi...@andric.com] Sent: Tuesday, January 31, 2017 22:39 To: Yatsina, Marina Cc: cfe-commits

[PATCH] D29393: [clang-tidy] Don't warn about call to unresolved operator*

malcolm.parsons created this revision. Herald added a subscriber: JDevlieghere. The misc-unconventional-assign-operator check had a false positive warning when the 'operator*' in 'return *this' was unresolved. Change matcher to allow calls to unresolved operator. Fixes PR31531.

[PATCH] D20561: Warn when taking address of packed member

royger added a comment. In https://reviews.llvm.org/D20561#663069, @joerg wrote: > @royger: Your example is missing explicit alignment. packed has two side > effects: remove internal padding and set the alignment to 1. That means that > the offset of base doesn't matter so much because reg

[PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. In https://reviews.llvm.org/D20561#663069, @joerg wrote: > It is not true that all false positives have been fixed, some of the more > complex cases involving nested data structures are still open. I could not find any in bugzilla after a quick search. So please feel

[PATCH] D20561: Warn when taking address of packed member

joerg added a comment. It is not true that all false positives have been fixed, some of the more complex cases involving nested data structures are still open. @royger: Your example is missing explicit alignment. packed has two side effects: remove internal padding and set the alignment to 1.

[clang-tools-extra] r293763 - [clang-tidy] Remove debug logging.

Author: alexfh Date: Wed Feb 1 06:41:34 2017 New Revision: 293763 URL: http://llvm.org/viewvc/llvm-project?rev=293763=rev Log: [clang-tidy] Remove debug logging. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseUsingCheck.cpp Modified:

[PATCH] D20561: Warn when taking address of packed member

royger added a comment. In https://reviews.llvm.org/D20561#663006, @kimgr wrote: > ... and both revisions should be in the 4.0 branch (taken from r291814) > > I was looking forward to this warning to help iron out alignment issues at > compile-time instead of runtime (our ARM CPUs don't like

[PATCH] D20561: Warn when taking address of packed member

kimgr added a comment. ... and both revisions should be in the 4.0 branch (taken from r291814) I was looking forward to this warning to help iron out alignment issues at compile-time instead of runtime (our ARM CPUs don't like unaligned access). @royger, can you expand a little on what you

[PATCH] D6550: ASTImporter: Fix missing SourceLoc imports

a.sidorin added a comment. Hi Gabor. One of the bugs fixed in this patch is still present in master, other two are already fixed. Comment at: lib/AST/ASTImporter.cpp:2749 // Create the imported function. + SourceLocation StartLoc = Importer.Import(D->getInnerLocStart());

[PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. In https://reviews.llvm.org/D20561#662963, @royger wrote: > In https://reviews.llvm.org/D20561#662959, @rogfer01 wrote: > > > We fixed all identified false positives in later patches to this one. So > > maybe you want to check against trunk clang. If trunk still

[PATCH] D20561: Warn when taking address of packed member

royger added a comment. In https://reviews.llvm.org/D20561#662959, @rogfer01 wrote: > We fixed all identified false positives in later patches to this one. So > maybe you want to check against trunk clang. If trunk still diagnoses false > positives, please report them to me and I will be more

[PATCH] D28989: [X86][MS]Adjacent comments within multi-line inline assembly statement

myatsina accepted this revision. myatsina added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D28989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20561: Warn when taking address of packed member

rogfer01 added a comment. In https://reviews.llvm.org/D20561#662922, @royger wrote: > Hi, some targets do not support unaligned accesses so this warning is valuable in terms of portability. In platforms where unaligned accesses are allowed, it may happen that such accesses incur in a

[PATCH] D6549: ASTImporter: Propagate implicit flag to imported record and field decls

a.sidorin added a comment. This should be fixed in r269693. https://reviews.llvm.org/D6549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher constructors.

Hi Benjamin, This commit has caused a linking in our stage 2 modules buildbot at http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA/. Specifically, after this commit 'clang-reorder-fields' gets the following linking error: FAILED: bin/clang-reorder-fields : &&

r293759 - Revert r293518 as it caused module linking error in clang-reorder-fields

Author: arphaman Date: Wed Feb 1 04:52:02 2017 New Revision: 293759 URL: http://llvm.org/viewvc/llvm-project?rev=293759=rev Log: Revert r293518 as it caused module linking error in clang-reorder-fields This commit reverts "r293518 - [ASTMatchers] Sprinkle some constexpr on the global matcher

[PATCH] D20561: Warn when taking address of packed member

royger reopened this revision. royger added a comment. This revision is now accepted and ready to land. Hello, This addition is silly, and too noisy for real world usage. For once, it doesn't really check whether the access is actually unaligned or not, and then on x86 for example unaligned

[PATCH] D29384: [analyzer] Fix an assertion fail in CStringSyntaxChecker

xazax.hun created this revision. Right now CStringSytanxChecker assumes that the argument of a sizeof expression is an expression. The argument can also be a type. In this case an assertion fail will be triggered when the SubExpression is being queried. I fixed this issue and did other minor

[PATCH] D29383: [clang-format] Fix regression about not aligning trailing comments in case they were previously aligned, but at different indent.

This revision was automatically updated to reflect the committed changes. Closed by commit rL293755: [clang-format] Fix regression about not aligning trailing comments in case they… (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D29383?vs=86595=86596#toc Repository:

r293755 - [clang-format] Fix regression about not aligning trailing comments in case they were previously aligned, but at different indent.

Author: krasimir Date: Wed Feb 1 04:10:04 2017 New Revision: 293755 URL: http://llvm.org/viewvc/llvm-project?rev=293755=rev Log: [clang-format] Fix regression about not aligning trailing comments in case they were previously aligned, but at different indent. Summary: Comment reflower was

[PATCH] D29383: [clang-format] Fix regression about not aligning trailing comments in case they were previously aligned, but at different indent.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good https://reviews.llvm.org/D29383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r293754 - Fix Index test after recent clang-format change.

Author: djasper Date: Wed Feb 1 04:00:10 2017 New Revision: 293754 URL: http://llvm.org/viewvc/llvm-project?rev=293754=rev Log: Fix Index test after recent clang-format change. Modified: cfe/trunk/test/Index/overriding-ftemplate-comments.cpp Modified:

r293752 - clang-format: Don't force-wrap multiline RHSs for 2-operand experssions.

Author: djasper Date: Wed Feb 1 03:23:39 2017 New Revision: 293752 URL: http://llvm.org/viewvc/llvm-project?rev=293752=rev Log: clang-format: Don't force-wrap multiline RHSs for 2-operand experssions. This rows back on r288120, r291801 and r292110. I apologize in advance for the churn. All of

[PATCH] D29339: [OpenMP] Add support for auxiliary triple specification

ABataev added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:914-915 + // Create TargetInfo for the other side of CUDA and OpenMP compilation. + if ((getLangOpts().CUDA && !getFrontendOpts().AuxTriple.empty()) || + (getLangOpts().OpenMPIsDevice &&

[PATCH] D29358: [OpenMP] Report an error for -faltivec on anything other than PowerPC.

ABataev added a comment. Did not find any errors in this patch, neither in code, nor in test Repository: rL LLVM https://reviews.llvm.org/D29358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

NoQ added a subscriber: a.sidorin. NoQ added a comment. Hello! Sorry, i'm very distracted recently. I think your new approach should work, however it would be much easier and more straightforward to just ask the store manager to provide the default-bound symbol for a region directly, instead