[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

mati865 marked an inline comment as done. mati865 added a comment. @yaron.keren those includes are not available in native Linux Clang: float128_ex.cc:2:10: fatal error: 'quadmath.h' file not found #include ^ And at least 2 of GCC includes clash with Clang includes: - limits.h

[PATCH] D29778: Declare lgamma library builtins as never being const

jgravelle-google created this revision. POSIX requires lgamma writes to an external global variable, signgam. This prevents annotating lgamma with readnone, which is incorrect on targets that write to signgam. https://reviews.llvm.org/D29778 Files: include/clang/Basic/Builtins.def

r294613 - [c++1z] P0091R3: Basic support for deducing class template arguments via deduction-guides.

Author: rsmith Date: Thu Feb 9 13:17:44 2017 New Revision: 294613 URL: http://llvm.org/viewvc/llvm-project?rev=294613=rev Log: [c++1z] P0091R3: Basic support for deducing class template arguments via deduction-guides. Added: cfe/trunk/test/CXX/expr/expr.post/expr.type.conv/p1.cpp

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. The gcc include dirs in mingw contains headers not available esewhere and thus can't be removed. Notable examples, omp.h - OpenMP functions openacc.h - OpenACC functions quadmath.h - QUADMATH functions https://reviews.llvm.org/D29464

Re: [libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

I'm planning to merge this fix into the 4.0 release branch. Although not a regression, since is a new feature, it would still be nice to ship without this bug. I'll merge these changes later today if there are no objections, and once all the bots pass. /Eric On Thu, Feb 9, 2017 at 12:01 PM,

[libcxx] r294612 - Fix PR31916 - std::visit rejects visitors accepting lvalue arguments

Author: ericwf Date: Thu Feb 9 13:01:22 2017 New Revision: 294612 URL: http://llvm.org/viewvc/llvm-project?rev=294612=rev Log: Fix PR31916 - std::visit rejects visitors accepting lvalue arguments A static assertion was misfiring since it checked is_callable

[PATCH] D29718: [libclang] [OpenCL] Expose half type

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D29718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r294609 - [windows] Fix test for cl driver.

Author: mpividori Date: Thu Feb 9 12:40:52 2017 New Revision: 294609 URL: http://llvm.org/viewvc/llvm-project?rev=294609=rev Log: [windows] Fix test for cl driver. cl-link.c test was failing after r294604 because of the change in the order of parameters. Modified:

[libclc] r294608 - math: Add native_rsqrt builtin function

Author: arsenm Date: Thu Feb 9 12:39:26 2017 New Revision: 294608 URL: http://llvm.org/viewvc/llvm-project?rev=294608=rev Log: math: Add native_rsqrt builtin function Trivial define to rsqrt. Patch by Vedran Miletić Added:

[PATCH] D29661: [clang-tidy] Add -quiet option to suppress extra output

This revision was automatically updated to reflect the committed changes. Closed by commit rL294607: [clang-tidy] Add -quiet option to suppress extra output (authored by ehsan). Changed prior to commit: https://reviews.llvm.org/D29661?vs=87469=87842#toc Repository: rL LLVM

[clang-tools-extra] r294607 - [clang-tidy] Add -quiet option to suppress extra output

Author: ehsan Date: Thu Feb 9 12:32:02 2017 New Revision: 294607 URL: http://llvm.org/viewvc/llvm-project?rev=294607=rev Log: [clang-tidy] Add -quiet option to suppress extra output Summary: This new flag instructs clang-tidy to not output anything except for errors and warnings. This makes it

r294606 - [MS] Implement the __fastfail intrinsic as a builtin

Author: rnk Date: Thu Feb 9 12:31:06 2017 New Revision: 294606 URL: http://llvm.org/viewvc/llvm-project?rev=294606=rev Log: [MS] Implement the __fastfail intrinsic as a builtin __fastfail terminates the process immediately with a special system call. It does not run any process shutdown code or

[PATCH] D29773: Add support for armv7ve flag in clang (PR31358).

manojgupta created this revision. Herald added subscribers: rengolin, aemerson. This is a followup change to add v7ve support to clang for gcc compatibility. Armv7ve addition to llvm is currently being reviewed at https://reviews.llvm.org/D29472 . https://reviews.llvm.org/D29773 Files:

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

madsravn marked 3 inline comments as done. madsravn added inline comments. Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:46 + DeleteExpr, DeleteMemberExpr, + compoundStmt(anyOf(has(DeleteExpr), has(DeleteMemberExpr)), +

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

madsravn updated this revision to Diff 87829. madsravn added a comment. Small change to check. Minor changes to the lit test. https://reviews.llvm.org/D29726 Files: clang-tidy/readability/DeleteNullPointerCheck.cpp clang-tidy/readability/DeleteNullPointerCheck.h

[PATCH] D29772: Create msbuild only when using MSVC

mati865 created this revision. mati865 added a project: clang-c. Herald added a subscriber: mgorny. https://reviews.llvm.org/D29772 Files: tools/driver/CMakeLists.txt Index: tools/driver/CMakeLists.txt === ---

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

rnk added inline comments. Comment at: test/Misc/inline-asm-diags.c:1 +// RUN: not %clang -c --target=armv7a-arm-none-eabi %s -o /dev/null 2>&1 | FileCheck %s + Use `clang -cc1 -S -o /dev/null -verify` to test this. https://reviews.llvm.org/D29770

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

mati865 updated this revision to Diff 87827. mati865 added a comment. Removed adding GCC includes for all mingw hosts. https://reviews.llvm.org/D29464 Files: lib/Driver/MinGWToolChain.cpp test/Driver/mingw.cpp Index: test/Driver/mingw.cpp

[PATCH] D29724: [Driver] Report available language standards on user error

ahatanak added a comment. Test case? Comment at: lib/Frontend/CompilerInvocation.cpp:1709 +Diags.Report(diag::note_drv_supported_value_with_description) + << Std.getName() << Std.getDescription(); + } Is it possible to change the

[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

jgravelle-google added a comment. https://clang.llvm.org/compatibility.html doesn't mention anything about POSIX, only C11 compliance, so I didn't think Clang in general cared about POSIX. That being said I can definitely agree that Clang shouldn't preclude POSIX. I'll open a more-general diff.

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

sanwou01 added a comment. This tests the improved inline asm diagnostics from https://reviews.llvm.org/D29769. https://reviews.llvm.org/D29770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29770: [Assembler] Inline assembly diagnostics test.

sanwou01 created this revision. Add a test for improved inline assembly diagnostics in llvm. https://reviews.llvm.org/D29770 Files: test/Misc/inline-asm-diags.c Index: test/Misc/inline-asm-diags.c === --- /dev/null +++

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

dtzWill requested changes to this revision. dtzWill added a comment. This revision now requires changes to proceed. After some thought, can we discuss why this is a good idea? This increases the cyclomatic complexity of code that already is difficult to reason about, and seems like it's both

[PATCH] D28768: [clang-tidy] Add check 'modernize-return-braced-init-list'

JDevlieghere updated this revision to Diff 87823. JDevlieghere marked 11 inline comments as done. JDevlieghere added a comment. - Fixed issues raised by @alexfh Repository: rL LLVM https://reviews.llvm.org/D28768 Files: clang-tidy/modernize/CMakeLists.txt

[PATCH] D16135: Macro Debug Info support in Clang

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Could you also add support for -g3? It looks like we are supporting -g0 and -g1, so we should probably also mirror -g3. Thanks a lot for all your work! https://reviews.llvm.org/D16135

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

dtzWill accepted this revision. dtzWill added a comment. I've been bitten when attempting to use existence/nature of casts in the AST to reason about the original code, but this looks like it does the right thing in all the situations I can think of. Missing overflows because of a bugged

[PATCH] D29750: [PPC] Enable -fomit-frame-pointer by default for PPC

inouehrs updated this revision to Diff 87821. inouehrs added a comment. Thank you for the comment. I added regression tests for PPC in test/Driver/frame-pointer.c as for other platforms. https://reviews.llvm.org/D29750 Files: lib/Driver/Tools.cpp test/Driver/frame-pointer.c Index:

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87819. aaboud marked 2 inline comments as done. aaboud added a comment. Added test cases for driver debug info macro flags in test/Driver/debug-options.c Applied some changes to the documentation suggested by Ardian. https://reviews.llvm.org/D16135 Files:

[PATCH] D28286: [CodeCompletion] Code complete the missing C++11 keywords

arphaman added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D28286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29768: [TargetInfo] Set 'UseSignedCharForObjCBool' to false by default

arphaman created this revision. The target-specific flag 'UseSignedCharForObjCBool' is used to determine the type for the Objective-C BOOL type. We should set it to `false` by default so that new targets can avoid setting it to `true`. Repository: rL LLVM https://reviews.llvm.org/D29768

[PATCH] D16135: Macro Debug Info support in Clang

aprantl added a comment. Please also add driver testcase (e.g., to test/Driver/debug-options.c). Technically clang does accept -g3 as an option, so we could wire it up for compatibility. I would still keep the -fmacro-debug driver option though. Comment at:

[PATCH] D29661: [clang-tidy] Add -quiet option to suppress extra output

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one comment. Comment at: clang-tidy/tool/ClangTidyMain.cpp:194 +printing statistics about ignored warnings, +check profile data and warnings treated as +errors if

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. @Pekka, do you think there is something more to be done here or can I close this revision now? Apparently, I won't be able to pass` -target` in all cases because `-cc` has to be always the first parameter. Also I am preparing additional text and some minor

[PATCH] D28768: [clang-tidy] Add check 'modernize-return-braced-init-list'

alexfh added a comment. Please mark all addressed comments "Done". Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:60 + // Make sure that the return type matches the constructed type. + const QualType returnType = +

[PATCH] D29262: Fixes to modernize-use-using

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a few comments. Comment at: clang-tidy/modernize/UseUsingCheck.h:24 class UseUsingCheck : public ClangTidyCheck { + public: nit: empty line

[PATCH] D29750: [PPC] Enable -fomit-frame-pointer by default for PPC

hfinkel added a comment. We should have regression tests for this. Maybe update test/Driver/frame-pointer-elim.c? https://reviews.llvm.org/D29750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29764: [OpenCL] Blocks cannot capture/reference another block

Anastasia created this revision. Herald added a subscriber: yaxunl. Adding the last restriction from s6.12.5 OpenCL C v2.0. "A Block cannot reference or capture another Block variable declared in the outer scope". https://reviews.llvm.org/D29764 Files:

[PATCH] D27710: [analyzer] Prohibit ExplodedGraph's edges duplicating

ilya-palachev abandoned this revision. ilya-palachev added a comment. Ok, then, if you see no problem in dual edges, I'm abandoning this revision. Repository: rL LLVM https://reviews.llvm.org/D27710 ___ cfe-commits mailing list

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

hfinkel added a comment. What's the motivation for this? The placement of a local volatile variable is still under the compiler's direction, and unless the address escapes, we still assume we can reason about its aliasing (and, thus, whether or not it is initialized).

[clang-format] patch for bug 26125

https://llvm.org/bugs/show_bug.cgi?id=26125. The proposed patch is in the bug attachment Bug 26125 - Clang format creates unwanted temporary files when batching processing on windows # Summary A file mapping object prevents the temp file from being deleted. This is a 100% repro on Windows. #

[PATCH] D28771: [Analyzer] Various fixes for the IteratorPastEnd checker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:530 + auto value = RVal; + if (auto loc = value.getAs()) { +value = State->getRawSVal(*loc); baloghadamsoftware wrote: > NoQ wrote: > > baloghadamsoftware wrote:

[PATCH] D28772: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma in macro argument pre-expansion mode when skipping a function body

arphaman updated this revision to Diff 87801. arphaman added a comment. Sorry about the delay. As per Richard's suggestion, the updated patch now makes the `_Pragma` parser responsible for initiating the removal of cached tokens. Repository: rL LLVM https://reviews.llvm.org/D28772 Files:

[PATCH] D29506: [OpenMP] Teams reduction on the NVPTX device.

arpith-jacob marked 2 inline comments as done. arpith-jacob added a comment. In https://reviews.llvm.org/D29506#669542, @ABataev wrote: > The patch is too big and quite hard to review? Could you split it into > several smaller parts? Alexey, thank you for your time. I have addressed your

[PATCH] D29758: [OpenMP] Parallel reduction on the NVPTX device.

arpith-jacob created this revision. Herald added a subscriber: jholewinski. This patch implements codegen for the reduction clause on any parallel construct for elementary data types. An efficient implementation requires hierarchical reduction within a warp and a threadblock. It is complicated

[PATCH] D28771: [Analyzer] Various fixes for the IteratorPastEnd checker

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:530 + auto value = RVal; + if (auto loc = value.getAs()) { +value = State->getRawSVal(*loc); NoQ wrote: > baloghadamsoftware wrote: > > NoQ wrote:

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

regehr added a comment. Paging @dtzWill https://reviews.llvm.org/D29369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

filcab added a comment. Minor nits, now. LGTM, but having someone more familiar with clang chime in would be great. Comment at: lib/CodeGen/CGExprScalar.cpp:1700 case LangOptions::SOB_Trapping: +if (getUnwidenedIntegerType(CGF.getContext(), E->getSubExpr()).hasValue())

[libcxx] r294585 - Use protected name for the prototype arguments.

Author: joerg Date: Thu Feb 9 08:12:29 2017 New Revision: 294585 URL: http://llvm.org/viewvc/llvm-project?rev=294585=rev Log: Use protected name for the prototype arguments. Modified: libcxx/trunk/include/__threading_support libcxx/trunk/include/thread Modified:

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

On Sat, Feb 4, 2017 at 8:26 AM, Marcwell Helpdesk via cfe-commits wrote: > Many plugins/tools could benefit from having a generic way for communicating > control directives directly from the source code to itself (via the AST) when > acting, for example, as source

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. > How are you measuring the build time? Total time for, say "ninja clang" with > full parallelism? That'd be hard to measure the actual impact (since it could > be the link time or other things are dominating, etc). If you have a reliable > way to time (I'm assuming

[PATCH] D29262: Fixes to modernize-use-using

krystyna added a comment. ping https://reviews.llvm.org/D29262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29419: [Analyzer] Checker for mismatched iterators

NoQ added a comment. Hello, thanks for another useful checker! I make quite a few of these mistakes regularly. This one looks similar to the `IteratorPastEnd` checker, so much that i'd definitely advice re-using some code. At the very least, functions like `isIterator()` should definitely

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87796. aaboud added a comment. Added flag to control macro debug info generation: 1. -fdebug-macro (-fno-debug-macro) for Clang driver 2. -debug-info-macro for Clang compiler (-cc1) Also, made sure FE will discard this flag when debug info is not required,

[PATCH] D28771: [Analyzer] Various fixes for the IteratorPastEnd checker

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:530 + auto value = RVal; + if (auto loc = value.getAs()) { +value = State->getRawSVal(*loc); baloghadamsoftware wrote: > NoQ wrote: > > Is there a test case for

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

Friendly ping. > On 4 feb 2017, at 14:26, Marcwell Helpdesk wrote: > > Many plugins/tools could benefit from having a generic way for communicating > control directives directly from the source code to itself (via the AST) when > acting, for example, as source code

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

arphaman added a comment. Btw, you mentioned that 'this' must have been null-checked before the method is called. But what if it's called from some part of code that was compiled without `-fsanitize=null`? Wouldn't we still want at least one check to see if 'this' is null in a method?

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

arphaman added a comment. Thanks! I guess for the sake of completeness it might be useful for handle 'this' in parens as well, since it could up in macros: #define MEMBER(x) (x)->y ... MEMBER(this) ... Btw, I was curious if we could do a similar optimization in Objective-C, but

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated this revision to Diff 87792. https://reviews.llvm.org/D15994 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorLexer.h include/clang/Lex/PreprocessorOptions.h include/clang/Serialization/ASTBitCodes.h lib/Frontend/ASTUnit.cpp lib/Lex/Lexer.cpp

[PATCH] D29757: Threading support: Externalize hardware_concurrency()

rmaprath created this revision. Another one of those platform-dependent methods which should live behind the threading API. https://reviews.llvm.org/D29757 Files: include/__threading_support src/thread.cpp Index: src/thread.cpp

[clang-tools-extra] r294578 - [clang-tidy] Fix misc-unused-using-decls false positives in presence of compile errors

Author: alexfh Date: Thu Feb 9 04:41:27 2017 New Revision: 294578 URL: http://llvm.org/viewvc/llvm-project?rev=294578=rev Log: [clang-tidy] Fix misc-unused-using-decls false positives in presence of compile errors Added:

[PATCH] D29755: Cache FileID when translating diagnostics in PCH files

erikjv created this revision. Modules/preambles/PCH files can contain diagnostics, which, when used, are added to the current ASTUnit. For that to work, they are translated to use the current FileManager's FileIDs. When the entry is not the main file, all local source locations will be checked by

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

Ah, ignore me please. I should've read the patch. / Asiri On Thu, Feb 9, 2017 at 9:13 AM, Asiri Rathnayake wrote: > Hi Petr, > > This is breaking static builds of the libraries, cmake complaints with: > > "CMake Error at projects/libcxxabi/src/CMakeLists.txt:134 >

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

This revision was automatically updated to reflect the committed changes. Closed by commit rL294573: Threading support: externalize sleep_for() function. (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D29630?vs=87669=8#toc Repository: rL LLVM

Re: [libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

Hi Petr, This is breaking static builds of the libraries, cmake complaints with: "CMake Error at projects/libcxxabi/src/CMakeLists.txt:134 (target_link_libraries): Target "unwind" of type UTILITY may not be linked into another target. One may link only to STATIC or SHARED libraries, or to

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

bruno created this revision. This fixes PR31863, a regression introduced in r276159. Consider this snippet: struct FVector; struct FVector {}; struct FBox { FVector Min; FBox(int); }; namespace { FBox InvalidBoundingBox(0); } While parsing the DECL_VAR for 'struct FBox', clang

[PATCH] D29704: [XRay] [clang] Allow logging the first argument of a function call.

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. Just a minor comment -- I suspect you're going to wait until the patch to LLVM lands? Comment at: lib/Sema/SemaDeclAttr.cpp:4407 + + // It isn't a parameter index [0;n),

<    1   2