[PATCH] D27387: [libc++] Add a key function for bad_function_call

EricWF added inline comments. Comment at: include/functional:1393 +public: +virtual ~bad_function_call() _NOEXCEPT; + smeenai wrote: > EricWF wrote: > > What's the rationale for making the dtor out-of-line? Couldn't we just use > > `what()` as the key

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

Nice! -- Sean Silva On Tue, Feb 28, 2017 at 5:01 PM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: probinson > Date: Tue Feb 28 19:01:10 2017 > New Revision: 296554 > > URL: http://llvm.org/viewvc/llvm-project?rev=296554=rev > Log: > [PS4] Set our default dialect

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added inline comments. Comment at: include/functional:1393 +public: +virtual ~bad_function_call() _NOEXCEPT; + EricWF wrote: > What's the rationale for making the dtor out-of-line? Couldn't we just use > `what()` as the key function? We could, but

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

rsmith added a comment. In https://reviews.llvm.org/D29753#688834, @bruno wrote: > > It seems to me that the problem here is that `DeclMustBeEmitted` is not > > safe to call in the middle of deserialization if anything > > partially-deserialized might be reachable from the declaration we're >

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

rsmith accepted this revision. rsmith added a comment. Yes, I'm OK with this as a stopgap fix for 4.0. I would have preferred a more full fix for 4.0 but we've run out of time for that, and the PCH case does seem more pressing. https://reviews.llvm.org/D29753

r296584 - [Sema] Add variable captured by a block to the enclosing lambda's

Author: ahatanak Date: Wed Mar 1 00:11:25 2017 New Revision: 296584 URL: http://llvm.org/viewvc/llvm-project?rev=296584=rev Log: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list. Fix Sema::getCurLambda() to return the innermost lambda scope when there is

[PATCH] D25556: [Sema] Add variable captured by a block to the enclosing lambda's potential capture list

This revision was automatically updated to reflect the committed changes. Closed by commit rL296584: [Sema] Add variable captured by a block to the enclosing lambda's (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D25556?vs=86918=90123#toc Repository: rL LLVM

[PATCH] D30459: [libcxxabi] Clean up macro usage

EricWF added a comment. I renamed `LIBCXXABI_ARM_EHABI` to `_LIBCXXABI_ARM_EHABI` so you'll have to merge this change with that. Other than that this LGTM. https://reviews.llvm.org/D30459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30268: Avoid copy of __atoms when char_type is char

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. `__num_get` is externally instantiated. Adding non-template methods or changing method signatures is ABI breaking (As shown by the `check-cxx-abilist` rule output

[PATCH] D27387: [libc++] Add a key function for bad_function_call

EricWF added inline comments. Comment at: include/functional:1393 +public: +virtual ~bad_function_call() _NOEXCEPT; + What's the rationale for making the dtor out-of-line? Couldn't we just use `what()` as the key function? Comment at:

[PATCH] D26949: [libc++abi] Clean up visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL296576: [libc++abi] Clean up visibility (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26949?vs=90119=90120#toc Repository: rL LLVM https://reviews.llvm.org/D26949

[libcxxabi] r296576 - [libc++abi] Clean up visibility

Author: smeenai Date: Tue Feb 28 21:55:57 2017 New Revision: 296576 URL: http://llvm.org/viewvc/llvm-project?rev=296576=rev Log: [libc++abi] Clean up visibility Use the libc++abi visibility macros instead of pragmas or using visibility attributes directly. Clean up redundant attributes on

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 90119. smeenai added a comment. Addressing inline comment https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

dcoughlin added a comment. I'm not sure what is going on. One thing to try is defining the class in clang/test/lit.cfg -- which seems to work for Swift. (See https://github.com/apple/swift/blob/master/test/lit.cfg#L137) We'd still want to only use that class in Analysis/lit.local.cfg.

[libcxx] r296573 - [libcxx] Support threads on Fuchsia

Author: phosek Date: Tue Feb 28 21:09:18 2017 New Revision: 296573 URL: http://llvm.org/viewvc/llvm-project?rev=296573=rev Log: [libcxx] Support threads on Fuchsia Differential Revision: https://reviews.llvm.org/D30278 Modified: libcxx/trunk/src/thread.cpp Modified:

r296572 - Add warning for inconsistent overrides on destructor.

Author: rtrieu Date: Tue Feb 28 21:07:55 2017 New Revision: 296572 URL: http://llvm.org/viewvc/llvm-project?rev=296572=rev Log: Add warning for inconsistent overrides on destructor. The exisiting warning for inconsistent overrides does not include the destructor as it was noted in review that it

[PATCH] D30373: [analyzer] NFC: Update test infrastructure to support multiple constraint managers

dcoughlin added a comment. Saving the relevant portion of the build bot log output before it disappears from the bot: 0.000 [0/1/0] Running all regression tests -- Testing: 31894 tests, 80 threads -- Traceback (most recent call last): File "", line 1, in File

[libcxx] r296571 - Mark test as unsupported in C++11

Author: ericwf Date: Tue Feb 28 20:52:04 2017 New Revision: 296571 URL: http://llvm.org/viewvc/llvm-project?rev=296571=rev Log: Mark test as unsupported in C++11 Modified: libcxx/trunk/test/libcxx/containers/unord/unord.set/missing_hash_specialization.fail.cpp Modified:

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added inline comments. Comment at: src/abort_message.h:19 -__attribute__((visibility("hidden"), noreturn)) - void abort_message(const char* format, ...) -__attribute__((format(printf, 1, 2))); - +_LIBCXXABI_HIDDEN __attribute__((noreturn)) void

[PATCH] D26949: [libc++abi] Clean up visibility

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM minus inline comments. @smeenai confirmed that this patch doesn't change the ABI list for `libc++abi.dylib` using `sym_check.py`. Comment at: src/abort_message.h:19

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 90114. smeenai added a comment. Rebase https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handlers.hpp

[libcxx] r296568 - Fix test failures due to bad test hasher

Author: ericwf Date: Tue Feb 28 20:34:27 2017 New Revision: 296568 URL: http://llvm.org/viewvc/llvm-project?rev=296568=rev Log: Fix test failures due to bad test hasher Modified: libcxx/trunk/test/std/containers/unord/unord.map/unord.map.cnstr/default_noexcept.pass.cpp

[libcxxabi] r296567 - Fix non-reserved macro names LIBCXXABI_NORETURN and LIBCXXABI_ARM_EHABI.

Author: ericwf Date: Tue Feb 28 20:23:54 2017 New Revision: 296567 URL: http://llvm.org/viewvc/llvm-project?rev=296567=rev Log: Fix non-reserved macro names LIBCXXABI_NORETURN and LIBCXXABI_ARM_EHABI. This patch adds the required leading underscore to those macros. Modified:

[libcxx] r296565 - Improve diagnostics when an invalid hash is used in an unordered container.

Author: ericwf Date: Tue Feb 28 20:02:28 2017 New Revision: 296565 URL: http://llvm.org/viewvc/llvm-project?rev=296565=rev Log: Improve diagnostics when an invalid hash is used in an unordered container. This patch adds a static assertion that the specified hash meets the requirements of an

r296562 - [Analyzer] Fix crash in ObjCPropertyChecker on protocol property

Author: dcoughlin Date: Tue Feb 28 19:47:37 2017 New Revision: 296562 URL: http://llvm.org/viewvc/llvm-project?rev=296562=rev Log: [Analyzer] Fix crash in ObjCPropertyChecker on protocol property Fix a crash in the ObjCPropertyChecker when analyzing a 'copy' property of an NSMutable* type in a

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 90109. smeenai added a comment. Rebase atop https://reviews.llvm.org/D29157 and switch to _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90108. smeenai edited the summary of this revision. smeenai added a comment. Addressing comments https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai added inline comments. Comment at: include/string:1100 template +inline _LIBCPP_INLINE_VISIBILITY typename enable_if EricWF wrote: > smeenai wrote: > > EricWF wrote: > > > Why `inline _LIBCPP_INLINE_VISIBILITY` here but

[libcxx] r296561 - Fix PR32097 - is_abstract doesn't work on class templates.

Author: ericwf Date: Tue Feb 28 19:27:14 2017 New Revision: 296561 URL: http://llvm.org/viewvc/llvm-project?rev=296561=rev Log: Fix PR32097 - is_abstract doesn't work on class templates. This patch fixes llvm.org/PR32097 by using the __is_abstract builtin type-trait instead of the previous

[libcxx] r296558 - Updated the XFAIL comment in variant tests.

Author: mpark Date: Tue Feb 28 19:07:56 2017 New Revision: 296558 URL: http://llvm.org/viewvc/llvm-project?rev=296558=rev Log: Updated the XFAIL comment in variant tests. Summary: `ConstexprTestTypes::NoCtors` is an aggregate type (and consequently a literal type) in C++17, but not in C++14

r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

Author: probinson Date: Tue Feb 28 19:01:10 2017 New Revision: 296554 URL: http://llvm.org/viewvc/llvm-project?rev=296554=rev Log: [PS4] Set our default dialect to C++11. NFC for other targets. Reapplies r296209 now that r296549 has fixed what really seems to be the last problematic test.

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF added inline comments. Comment at: include/string:1100 template +inline _LIBCPP_INLINE_VISIBILITY typename enable_if smeenai wrote: > EricWF wrote: > > Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDDEN` everywhere > >

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM, but with a macro other than `_LIBCPP_HIDDEN`. Also could you please add doc explaining the rational for this new macro in depth. I think the summary for this revision would be

r296549 - [Test] Make Lit tests C++11 compatible - IR ordering

Author: lcharles Date: Tue Feb 28 18:10:00 2017 New Revision: 296549 URL: http://llvm.org/viewvc/llvm-project?rev=296549=rev Log: [Test] Make Lit tests C++11 compatible - IR ordering Differential Revision: https://reviews.llvm.org/D30430 Modified:

[PATCH] D30430: Make Lit tests C++11 compatible - IR ordering

This revision was automatically updated to reflect the committed changes. Closed by commit rL296549: [Test] Make Lit tests C++11 compatible - IR ordering (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D30430?vs=90078=90101#toc Repository: rL LLVM

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D29753#688845, @bruno wrote: > > What do folks think? > > IMO we should do it. Go ahead and commit this, but keep the bug open so we can work on fixing it properly

[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

watsond updated this revision to Diff 90087. watsond marked an inline comment as done. watsond added a comment. Fixed logic error, added enum test case https://reviews.llvm.org/D29858 Files: clang-tidy/misc/RedundantExpressionCheck.cpp test/clang-tidy/misc-redundant-expression.cpp Index:

[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

watsond marked 2 inline comments as done. watsond added a comment. In https://reviews.llvm.org/D29858#675055, @etienneb wrote: > Could you add some tests with enums (like the one in your description)? > This is missing and it's a nice to have. Added Comment at:

Re: r296221 - [ODRHash] Move inherited visitor call to end of function.

There's no functional change. This was a mistake I made when splitting the original patch into pieces and I wanted to correct before proceeding with additional changes. On Mon, Feb 27, 2017 at 8:27 AM, David Blaikie wrote: > An explanation as to why the code was moved (&

[PATCH] D30430: Make Lit tests C++11 compatible - IR ordering

tigerleapgorge added a comment. In https://reviews.llvm.org/D30430#688146, @rjmccall wrote: > The C++98 behavior here is not really vital to test precisely; it's just > minor differences in what gets instantiated and when. Hi John, my main concern with CHECK-NOT appearing between CHECK lines

r296521 - [ODRHash] Add basic support for CXXRecordDecl

Author: rtrieu Date: Tue Feb 28 15:24:38 2017 New Revision: 296521 URL: http://llvm.org/viewvc/llvm-project?rev=296521=rev Log: [ODRHash] Add basic support for CXXRecordDecl Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td cfe/trunk/lib/AST/ODRHash.cpp

[PATCH] D30430: Make Lit tests C++11 compatible - IR ordering

tigerleapgorge updated this revision to Diff 90078. tigerleapgorge added a comment. Updated patch. Test only runs in C++11. Added comments to explain CHECK-DAG and CHECK2-NOT. https://reviews.llvm.org/D30430 Files: test/CodeGenCXX/template-instantiation.cpp Index:

[PATCH] D30327: [Sema] Improve side effect checking for unused-lambda-capture warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! In https://reviews.llvm.org/D30327#688254, @malcolm.parsons wrote: > I found this FIXME comment in `Expr::HasSideEffects()`: > > case LambdaExprClass: { > const

[PATCH] D30372: [Driver] Consolidate tools and toolchains by target platform. (NFC)

dlj added a comment. In https://reviews.llvm.org/D30372#688154, @mehdi_amini wrote: > In https://reviews.llvm.org/D30372#687060, @ahatanak wrote: > > > In https://reviews.llvm.org/D30372#687054, @dlj wrote: > > > > > In https://reviews.llvm.org/D30372#686871, @ahatanak wrote: > > > > > > > Have

[PATCH] D28266: Transparent_union attribute should be possible in front of union (rework)

This revision was automatically updated to reflect the committed changes. Closed by commit rL296518: Allow attributes before union definition (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D28266?vs=90056=90075#toc Repository: rL LLVM

r296518 - Allow attributes before union definition

Author: erichkeane Date: Tue Feb 28 14:44:39 2017 New Revision: 296518 URL: http://llvm.org/viewvc/llvm-project?rev=296518=rev Log: Allow attributes before union definition permits typedef union __attribute__((transparent_union)) {...} Differential Revision: https://reviews.llvm.org/D28266

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this LGTM, but you should wait for confirmation from one of the other reviewers before committing. https://reviews.llvm.org/D30166

[PATCH] D28266: Transparent_union attribute should be possible in front of union (rework)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with one formatting nit. Comment at: lib/Sema/SemaDeclAttr.cpp:6201 +void Sema::ProcessDeclAttributeDelayed(Decl *D, const AttributeList *AttrList) { +

[PATCH] D29819: Introduce an 'external_source_symbol' attribute that describes the origin and the nature of a declaration

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, despite a long-ish comment. Comment at: lib/Parse/ParseDeclCXX.cpp:3830-3837 + unsigned NumArgs; + // Some Clang-scoped attributes have some special

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

bruno added a comment. > What do folks think? IMO we should do it. https://reviews.llvm.org/D29753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

bruno added a comment. > It seems to me that the problem here is that `DeclMustBeEmitted` is not safe > to call in the middle of deserialization if anything partially-deserialized > might be reachable from the declaration we're querying, and yet we're > currently calling it in that case.

[PATCH] D29753: [PCH] Avoid early VarDecl emission attempt if no owning module avaiable

hans added a subscriber: mehdi_amini. hans added a comment. To unblock 4.0, I'm leaning towards merging Bruno's patch as a stop-gap fix. I realize it probably only fixes the problem for PCH, and not modules. But PCH is used more widely than modules, so maybe it's good enough for now? We've run

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

On Fri, Feb 24, 2017 at 8:24 AM, Marcwell Helpdesk wrote: > > As interesting the subject of pluggable attributes may be could we please > drop that discussion and focus on the intention of and what the patch > actually does? Two revisions of the patch have been supplied

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

rjmccall added a comment. In https://reviews.llvm.org/D30345#688298, @arphaman wrote: > In https://reviews.llvm.org/D30345#688144, @rjmccall wrote: > > > You're doing this refactor to... support doing another refactor of the same > > code? Why are these patches separate? > > > Not quite, by

r296499 - clang-format: [Java] Fix bug in enum formatting.

Author: djasper Date: Tue Feb 28 12:28:15 2017 New Revision: 296499 URL: http://llvm.org/viewvc/llvm-project?rev=296499=rev Log: clang-format: [Java] Fix bug in enum formatting. Before: public enum VeryLongEnum { ENUM_WITH_MANY_PARAMETERS("aa",

[PATCH] D28266: Transparent_union attribute should be possible in front of union (rework)

erichkeane marked 6 inline comments as done. erichkeane added a comment. Thanks! Changes incoming. https://reviews.llvm.org/D28266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. I will rename it before the upload if that is fine with you. Comment at: unittests/Format/check-coding-style-mozilla.cpp:77 +return mVar; + } // Tiny functions can be written in a single line. + krasimir wrote: > Note that

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru updated this revision to Diff 90053. Herald added a subscriber: mgorny. https://reviews.llvm.org/D30111 Files: test/Format/check-coding-style-mozilla.cpp unittests/Format/CMakeLists.txt Index: unittests/Format/CMakeLists.txt

r296485 - Driver: Update devtoolset usage for RHEL

Author: tstellar Date: Tue Feb 28 10:46:19 2017 New Revision: 296485 URL: http://llvm.org/viewvc/llvm-project?rev=296485=rev Log: Driver: Update devtoolset usage for RHEL - remove path to dts-1.x (corresponds to gcc 4.7) - add path to dts-6 (corresponds to 6.x) Patch By: Maria Gottschalk

r296490 - Migrate all of aarch64-linux-gnu to \01_mcount instead of just when passing along gnueabi as this matches both gcc and what the kernel expects.

Author: echristo Date: Tue Feb 28 11:22:05 2017 New Revision: 296490 URL: http://llvm.org/viewvc/llvm-project?rev=296490=rev Log: Migrate all of aarch64-linux-gnu to \01_mcount instead of just when passing along gnueabi as this matches both gcc and what the kernel expects. More of PR27311

[PATCH] D29221: clang-format-vsix: "format on save" feature

hans added a subscriber: djasper. hans added a comment. >>> My only nit is that I'd prefer "clang-format" instead of "ClangFormat". >>> >>> Manuel: the menu options under Tools currently say "Clang Format >>> {Selection,Document}". What do you think about using "clang-format" here >>> instead?

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

NoQ added subscribers: a.sidorin, NoQ. NoQ added a comment. I think this is great. We've been hearing a lot of complaints on the mailing lists recently about that problem. Did you check that scan-build properly de-duplicates cross-file reports that originate from different clang runs but point

[PATCH] D30465: [mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

brad created this revision. Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64 Repository: rL LLVM https://reviews.llvm.org/D30465 Files: lib/Basic/Targets.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D24933: Enable configuration files in clang

dschuff added a comment. Hello, I work on WebAssembly toolchains (including emscripten, which is more or less the "cross-compiler SDK" use case). There's a lot of history in this review and I haven't looked at the details yet, but does the current summary text reflect the current proposal

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D27054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29819: Introduce an 'external_source_symbol' attribute that describes the origin and the nature of a declaration

arphaman added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:3818-3819 + if (ScopeName && (ScopeName->getName() == "gnu" || +(ScopeName->getName() == "clang" && + AttrName->isStr("external_source_symbol" // GNU-scoped

[PATCH] D29819: Introduce an 'external_source_symbol' attribute that describes the origin and the nature of a declaration

arphaman updated this revision to Diff 90042. arphaman marked 2 inline comments as done. arphaman added a comment. Use `ParseClangAttributeArgs` and add a string to an assert. Repository: rL LLVM https://reviews.llvm.org/D29819 Files: include/clang/Basic/Attr.td

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

thakis added a comment. I'm surprised this is behind a flag. This pragma attempts to be compatible with cl.exe. Does cl.exe do this by default? If so, we should do it by default. If not, why add this as an incompatible thing to an MS extension instead of keying it off some attribute that works

[PATCH] D30268: Avoid copy of __atoms when char_type is char

hiraditya added a comment. Ping https://reviews.llvm.org/D30268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

arphaman added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1414 + +} // end anonymous namespace + vsk wrote: > I don't see the need for two GenericInfo types (although it's plausible it'll > make sense with your upcoming changes!). I had in mind a

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

arphaman updated this revision to Diff 90033. arphaman marked 3 inline comments as done. arphaman added a comment. The updated patch uses just one enum and simplifies the capture search loops. Repository: rL LLVM https://reviews.llvm.org/D30345 Files: lib/CodeGen/CGBlocks.cpp Index:

[PATCH] D30412: [clang-tidy] Fix a false positive on modernize-use-nullptr check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296479: [clang-tidy] Fix a false positive on modernize-use-nullptr check. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D30412?vs=89894=90032#toc Repository: rL LLVM

[clang-tools-extra] r296479 - [clang-tidy] Fix a false positive on modernize-use-nullptr check.

Author: hokein Date: Tue Feb 28 09:29:52 2017 New Revision: 296479 URL: http://llvm.org/viewvc/llvm-project?rev=296479=rev Log: [clang-tidy] Fix a false positive on modernize-use-nullptr check. Summary: The false positive happens on two neighbour CXXDefaultArgExpr AST nodes. like below: ```

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

danielmarjamaki marked an inline comment as done. danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:211 // Generate a report for this bug. - StringRef Desc = - describeUninitializedArgumentInCall(Call,

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

krasimir added a comment. In https://reviews.llvm.org/D30111#688379, @sylvestre.ledru wrote: > @krasimir is that ok with you? Thank you for addressing my comments! The descriptions help to see what's supposed to happen. Now another point with this test is that it tests that already

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

danielmarjamaki updated this revision to Diff 90030. danielmarjamaki added a comment. minor updates. Use llvm::getOrdinalNumber(). Use llvm::Twine. Repository: rL LLVM https://reviews.llvm.org/D30341 Files: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp

[PATCH] D30192: [Sema] Detecting more array index out of bounds

This revision was automatically updated to reflect the committed changes. Closed by commit rL296477: [Sema] Detect more array index out of bounds when C++ overloaded operators are… (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D30192?vs=89183=90027#toc

r296477 - [Sema] Detect more array index out of bounds when C++ overloaded operators are used

Author: danielmarjamaki Date: Tue Feb 28 08:53:50 2017 New Revision: 296477 URL: http://llvm.org/viewvc/llvm-project?rev=296477=rev Log: [Sema] Detect more array index out of bounds when C++ overloaded operators are used Differential Revision: https://reviews.llvm.org/D30192 Modified:

[PATCH] D30459: [libcxxabi] Clean up macro usage

rs created this revision. Herald added a subscriber: mgorny. Convention in libcxxabi is to use !defined(FOO) not !FOO. https://reviews.llvm.org/D30459 Files: CMakeLists.txt include/__cxxabi_config.h include/cxxabi.h src/abort_message.cpp src/config.h src/cxa_default_handlers.cpp

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

rmaprath updated this revision to Diff 90025. rmaprath added a comment. Fixed minor omission. https://reviews.llvm.org/D29818 Files: src/chrono.cpp Index: src/chrono.cpp === --- src/chrono.cpp +++ src/chrono.cpp @@ -11,6 +11,7

[clang-tools-extra] r296472 - Misspelled checker description (argument comment)

Author: alexfh Date: Tue Feb 28 08:13:26 2017 New Revision: 296472 URL: http://llvm.org/viewvc/llvm-project?rev=296472=rev Log: Misspelled checker description (argument comment) Reviewers: alexfh Reviewed By: alexfh Subscribers: Eugene.Zelenko Tags: #clang-tools-extra Patch by Peter Szecsi!

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

ioeric updated this revision to Diff 90018. ioeric marked 3 inline comments as done. ioeric added a comment. - Return const refs in getXXX. https://reviews.llvm.org/D27054 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/CMakeLists.txt

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59 + /// \brief Returns the path of the file containing this atomic change. + std::string getFilePath() const { return FilePath; } + alexshap wrote: > ioeric wrote: > >

[PATCH] D27753: [analyzer] alpha.security.DirtyScalar Checker

gerazo marked an inline comment as done. gerazo added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DirtyScalarChecker.cpp:184 +Ty = Ctx.IntTy; + if (!Ty->isIntegerType() || Ctx.getIntWidth(Ty) <= TooNarrowForBoundCheck) +return false;

Re: r296453 - [clang-format] Fix test failure caused by "rm" on some buildbots.

It's needed: when clang-format does leave temp files behind, they will accumulate over builds and even if that's then fixed, the test would still fail because of the temp files from prior builds. Thankfully, takuni fixed this better in r296460. On Feb 28, 2017 4:14 AM, "Haojian Wu via

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

alexshap added inline comments. Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59 + /// \brief Returns the path of the file containing this atomic change. + std::string getFilePath() const { return FilePath; } + ioeric wrote: > alexshap wrote: >

Re: r296460 - clang/test/Format/inplace.cpp: Avoid using wildcard.

Thanks! That's a good technique, I'll remember it for next time. I wonder if %T should work like that... On Feb 28, 2017 5:17 AM, "NAKAMURA Takumi via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Tue Feb 28 04:05:56 2017 > New Revision: 296460 > > URL:

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

ioeric updated this revision to Diff 90012. ioeric marked an inline comment as done. ioeric added a comment. - Addressed comments. https://reviews.llvm.org/D27054 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/CMakeLists.txt lib/Tooling/Refactoring/AtomicChange.cpp

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

ioeric marked an inline comment as done. ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59 + /// \brief Returns the path of the file containing this atomic change. + std::string getFilePath() const { return FilePath; } +

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

alexshap added inline comments. Comment at: lib/Tooling/Refactoring/AtomicChange.cpp:35 +RemovedHeaders(E.getRemovedHeaders()) { +std::copy(E.getReplacements().begin(), E.getReplacements().end(), + std::back_inserter(Replaces)); if i am

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

alexshap added inline comments. Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59 + /// \brief Returns the path of the file containing this atomic change. + std::string getFilePath() const { return FilePath; } + i assume i might be missing smth -

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric updated this revision to Diff 90011. ioeric added a comment. - Addressed review comments. - Make key customize-able. - Added replace() and insert() to replace current replacement interfaces. - s/EditList/AtomicChange/ https://reviews.llvm.org/D27054 Files:

[PATCH] D27918: [analyzer] OStreamChecker

gamesh411 added a comment. Hello, This checker was developed indeed with internal usage in mind. It should not necessary be added as a default checker. However I have run it on the boost-1.63.0 codebase, and there some some mildly interesting findings in examples and tests. There is also a

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. @krasimir is that ok with you? https://reviews.llvm.org/D30111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29027: [Stack Protection] Add remark for reasons why Stack Protection has been applied

jhenderson abandoned this revision. jhenderson added a comment. Abandoning. Due to changes made in https://reviews.llvm.org/D29023, there is no more need for this patch. The new method followed in that patch means that clang gets support for the new remarks via -Rpass=stack-protector.

[PATCH] D30452: Blacklist @mods and several other JSDoc tags from wrapping.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296467: Blacklist arbitrary @\\w+ JSDoc tags from wrapping. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D30452?vs=8=90001#toc Repository: rL LLVM

r296467 - Blacklist arbitrary @\\w+ JSDoc tags from wrapping.

Author: mprobst Date: Tue Feb 28 05:08:24 2017 New Revision: 296467 URL: http://llvm.org/viewvc/llvm-project?rev=296467=rev Log: Blacklist arbitrary @\\w+ JSDoc tags from wrapping. Summary: Also limits the blacklisting to only apply when the tag is actually followed by a parameter in curly

[PATCH] D30452: Blacklist @mods and several other JSDoc tags from wrapping.

mprobst marked an inline comment as done. mprobst added inline comments. Comment at: lib/Format/Format.cpp:624 +// taze:, and @tag followed by { for a lot of JSDoc tags. +GoogleStyle.CommentPragmas = "(taze:|(@[A-Za-z_0-9-]*[ \\t]*{))";

Re: r296408 - clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

Tweaked in r296460. On Tue, Feb 28, 2017 at 10:28 AM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Nico, > > This commit broke test on one of our builders: > > Clang :: Format/inplace.cpp > > >

[PATCH] D30452: Blacklist @mods and several other JSDoc tags from wrapping.

djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/Format.cpp:624 +// taze:, and @tag followed by { for a lot of JSDoc tags. +GoogleStyle.CommentPragmas = "(taze:|(@[A-Za-z_0-9-]*[

  1   2   >