brad added a comment.
ping?
Repository:
rL LLVM
https://reviews.llvm.org/D30465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fgross marked 6 inline comments as done.
fgross added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:110
+ClassWithSpecialMembers[ID];
+if (find(Members, Kind) == Members.end())
+ Members.push_back(Kind);
---
fgross updated this revision to Diff 90593.
fgross added a comment.
Updated documentation, got rid of code duplication.
https://reviews.llvm.org/D30610
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
docs/clang
mgehre updated this revision to Diff 90592.
mgehre added a comment.
Updated fix for the crash in SemaChecking::RefersToMemberWithReducedAlignment,
so it also works for C code.
https://reviews.llvm.org/D22476
Files:
lib/AST/Expr.cpp
lib/Sema/SemaChecking.cpp
lib/Sema/SemaOverload.cpp
tes
mgehre added inline comments.
Comment at: lib/AST/Expr.cpp:1413
+for (auto *EnableIf : Method->specific_attrs()) {
+ if (EnableIf->getCond()->isTypeDependent())
+return false;
rsmith wrote:
> You should presumably be checking `isValueDependent` h
mgehre updated this revision to Diff 90591.
mgehre marked 4 inline comments as done.
mgehre added a comment.
Thanks for your comments! I'm very sorry for the huge delay. I have now more
time to work on this.
I added all your comments to the commit
and fixed a crash in SemaChecking::RefersToMember
Author: rjmccall
Date: Sat Mar 4 15:46:14 2017
New Revision: 296980
URL: http://llvm.org/viewvc/llvm-project?rev=296980&view=rev
Log:
GCC workaround: use explicit qualification to avoid injected class name.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52625
Modified:
cfe/trunk/include/clang
Author: rjmccall
Date: Sat Mar 4 15:26:29 2017
New Revision: 296979
URL: http://llvm.org/viewvc/llvm-project?rev=296979&view=rev
Log:
Refactor ConstantInitBuilder to allow other frontends to more
easily extend the aggregate-builder API. Stupid missing language
features.
Also add APIs for constr
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
Missing documentation changes for the new options.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:110
+ClassWithSpec
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D30592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
aprantl added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:308
+ /// \brief An abstract representation of regular/ObjC call/message targets.
+ class AbstractCallee {
The \brief is redundant (we use autobrief) and shouldn't be used any more.
ht
Author: akirtzidis
Date: Sat Mar 4 11:54:56 2017
New Revision: 296975
URL: http://llvm.org/viewvc/llvm-project?rev=296975&view=rev
Log:
[index] C++: Improve handling of typedefs as base names in C++ class
declarations
Report the typedef as reference, and desugar it to report the underlying clas
Author: akirtzidis
Date: Sat Mar 4 11:54:53 2017
New Revision: 296974
URL: http://llvm.org/viewvc/llvm-project?rev=296974&view=rev
Log:
[index] ObjC: Improve handling of typedefs as base names in ObjC interface
declarations
- Report the typedef reference occurrence
- Mark super or protocol refe
fgross created this revision.
Herald added subscribers: JDevlieghere, nemanjai.
Added two options to cppcoreguidelines-special-member-functions to allow a more
relaxed checking.
With 'AllowSoleDefaultDtor' set to 1, classes with explicitly defaulted
destructors but no other special members are
sylvestre.ledru created this revision.
Herald added a subscriber: JDevlieghere.
Avoid limitation of 100 groups for regular expressions
Patch by Manuel Grizonnet
reported here:
https://github.com/llvm-mirror/clang-tools-extra/pull/9
https://reviews.llvm.org/D30607
Files:
clang-tidy/tool/run-c
Author: sylvestre
Date: Sat Mar 4 08:06:26 2017
New Revision: 296970
URL: http://llvm.org/viewvc/llvm-project?rev=296970&view=rev
Log:
Replaced UserNullMacros with NullMacros in modernize-use-nullptr check docs
By patch Peter Goldsborough on
https://github.com/llvm-mirror/clang-tools-extra/pull/
fgross updated this revision to Diff 90572.
fgross added a comment.
Updated test case.
https://reviews.llvm.org/D30592
Files:
clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp
test/clang-tidy/misc-throw-by-value-catch-by-reference.cpp
Index: test/clang-tidy/misc-throw-by-value-catch-b
Author: ericwf
Date: Sat Mar 4 06:28:12 2017
New Revision: 296965
URL: http://llvm.org/viewvc/llvm-project?rev=296965&view=rev
Log:
Fix nonsense comment
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://llvm.org/viewvc/llvm-pr
JonasToth added inline comments.
Comment at: docs/clang-tidy/checks/misc-forwarding-reference-overload.rst:38
+constructors. We suppress warnings if the copy and the move constructors are
both
+disabled (deleted or private), because there is nothing the prefect forwarding
+const
leanil marked 6 inline comments as done.
leanil added inline comments.
Comment at: test/clang-tidy/misc-forwarding-reference-overload.cpp:21
+ Person(T &&n);
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: function 'Person' can hide copy
and move constructors [misc-forwarding-re
leanil updated this revision to Diff 90569.
leanil added a comment.
Added changes according to the comments.
Repository:
rL LLVM
https://reviews.llvm.org/D30547
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp
clang-tidy/misc/ForwardingReferenc
21 matches
Mail list logo
