[PATCH] D30423: [ubsan] Detect UB loads from bitfields

2017-03-07 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGenObjC/ubsan-bool.m:26 + // OBJC: [[ICMP:%.*]] = icmp ule i8 [[ASHR]], 1, !nosanitize + // OBJC: call void

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

2017-03-07 Thread Daphne Pfister via Phabricator via cfe-commits
daphnediane added a comment. ping https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30729: [ubsan] Skip range checks for width-limited values

2017-03-07 Thread Vedant Kumar via Phabricator via cfe-commits
vsk updated this revision to Diff 90975. vsk added a comment. - Fix an incorrect comment on the field "e2" in struct S. We emit a check for it because 0b11 = -1 = 3. - Skip the range check on the field "e2" in struct S2, because the range of the bitfield is the same as the range clang infers

[PATCH] D30729: [ubsan] Skip range checks for width-limited values

2017-03-07 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. UBSan can check that scalar loads provide in-range values. When we load a value from a bitfield, we know that the range of the value is constrained by the bitfield's width. This patch teaches UBSan how to use that information to skip emitting some range checks. This

r297246 - [ODRHash] Hash typedefs and usings statements in classes.

2017-03-07 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Tue Mar 7 18:13:19 2017 New Revision: 297246 URL: http://llvm.org/viewvc/llvm-project?rev=297246=rev Log: [ODRHash] Hash typedefs and usings statements in classes. Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified:

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-03-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. Looks good! Sorry for the delay, I was out last week. https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30593: Add correct "-isystem"/"-isysroot" warning handling to static analysis' BugReporter.

2017-03-07 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. Kevin, would you be willing to file a PR on https://bugs.llvm.org with the 9 false positives you are seeing? This will help us suppress them for users who don't use 'suppress-c++-stdlib'. Repository: rL LLVM https://reviews.llvm.org/D30593

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

2017-03-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Both suggestions sound good to me. Thanks! https://reviews.llvm.org/D30700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

2017-03-07 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama added a comment. In https://reviews.llvm.org/D30700#694511, @rnk wrote: > I was thinking `-f[no-]compiler-rt-rpath` or something, but openmp is not > part of compiler-rt. Name recommendations welcome. \ Maybe `-f[no-]rtlib-add-rpath`? > We might also want to reconsider the default

r297143 - [clang-format] Fixed indent issue when adding a comment at the end of a return type in named function declaration.

2017-03-07 Thread Andi-Bogdan Postelnicu via cfe-commits
Author: abpostelnicu Date: Tue Mar 7 08:48:02 2017 New Revision: 297143 URL: http://llvm.org/viewvc/llvm-project?rev=297143=rev Log: [clang-format] Fixed indent issue when adding a comment at the end of a return type in named function declaration. Differential Revision:

r297148 - [clang-format] Followup of D30646 - unbreak the build

2017-03-07 Thread Andi-Bogdan Postelnicu via cfe-commits
Author: abpostelnicu Date: Tue Mar 7 09:20:31 2017 New Revision: 297148 URL: http://llvm.org/viewvc/llvm-project?rev=297148=rev Log: [clang-format] Followup of D30646 - unbreak the build Modified: cfe/trunk/unittests/Format/FormatTest.cpp Modified: cfe/trunk/unittests/Format/FormatTest.cpp

r297227 - [AArch64] Vulcan is now ThunderXT99

2017-03-07 Thread Joel Jones via cfe-commits
Author: joel_k_jones Date: Tue Mar 7 15:24:53 2017 New Revision: 297227 URL: http://llvm.org/viewvc/llvm-project?rev=297227=rev Log: [AArch64] Vulcan is now ThunderXT99 Broadcom Vulcan is now Cavium ThunderX2T99. LLVM Bugzilla: http://bugs.llvm.org/show_bug.cgi?id=32113 Corresponding LLVM

[PATCH] D30720: [include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.

2017-03-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added a subscriber: mgorny. Add fuzzy SymbolIndex, where identifier needn't match exactly. The purpose for this is global autocomplete in clangd. The query will be a partial identifier up to the cursor, and the results will be suggestions. It's in

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

2017-03-07 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich added a comment. In https://reviews.llvm.org/D28445#694906, @zaks.anna wrote: > @vlad.tsyrklevich, > > Do you have commit access or should we commit on your behalf? You should commit on my behalf. https://reviews.llvm.org/D28445

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

2017-03-07 Thread Anna Zaks via Phabricator via cfe-commits
zaks.anna added a comment. @vlad.tsyrklevich, Do you have commit access or should we commit on your behalf? https://reviews.llvm.org/D28445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30711: [coroutines] update coro_end builtin to match llvm

2017-03-07 Thread Gor Nishanov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297224: [coroutines] update coro_end builtin to match llvm (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D30711?vs=90897=90928#toc Repository: rL LLVM

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-07 Thread Kuang He via Phabricator via cfe-commits
kuang_he updated this revision to Diff 90927. kuang_he edited the summary of this revision. kuang_he added a comment. Add fix and update test case for -fzvector option. https://reviews.llvm.org/D30415 Files: lib/Driver/Tools.cpp test/Driver/ppc-features.cpp

r297224 - [coroutines] update coro_end builtin to match llvm

2017-03-07 Thread Gor Nishanov via cfe-commits
Author: gornishanov Date: Tue Mar 7 15:01:08 2017 New Revision: 297224 URL: http://llvm.org/viewvc/llvm-project?rev=297224=rev Log: [coroutines] update coro_end builtin to match llvm Summary: llvm.coro.end intrinsic now returns bool. Updating clang to match it. Reviewers: GorNishanov, rsmith

[libcxxabi] r297215 - Creating release candidate rc4 from release_400 branch

2017-03-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Mar 7 14:58:42 2017 New Revision: 297215 URL: http://llvm.org/viewvc/llvm-project?rev=297215=rev Log: Creating release candidate rc4 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc4/ (props changed) - copied from r297214,

[libcxx] r297214 - Creating release candidate rc4 from release_400 branch

2017-03-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Mar 7 14:58:39 2017 New Revision: 297214 URL: http://llvm.org/viewvc/llvm-project?rev=297214=rev Log: Creating release candidate rc4 from release_400 branch Added: libcxx/tags/RELEASE_400/rc4/ (props changed) - copied from r297213, libcxx/branches/release_40/

[libunwind] r297221 - Creating release candidate rc4 from release_400 branch

2017-03-07 Thread Hans Wennborg via cfe-commits
Author: hans Date: Tue Mar 7 14:59:01 2017 New Revision: 297221 URL: http://llvm.org/viewvc/llvm-project?rev=297221=rev Log: Creating release candidate rc4 from release_400 branch Added: libunwind/tags/RELEASE_400/rc4/ (props changed) - copied from r297220,

r297194 - Use filename in linemarker when compiling preprocessed source (Revised)

2017-03-07 Thread Taewook Oh via cfe-commits
Author: twoh Date: Tue Mar 7 14:20:23 2017 New Revision: 297194 URL: http://llvm.org/viewvc/llvm-project?rev=297194=rev Log: Use filename in linemarker when compiling preprocessed source (Revised) Summary: This is a revised version of D28796. Included test is changed to resolve the target

[PATCH] D30663: Use filename in linemarker when compiling preprocessed source (Revised)

2017-03-07 Thread Taewook Oh via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297194: Use filename in linemarker when compiling preprocessed source (Revised) (authored by twoh). Changed prior to commit: https://reviews.llvm.org/D30663?vs=90735=90912#toc Repository: rL LLVM

Disable fms-extensions?

2017-03-07 Thread Ammarguellat, Zahira via cfe-commits
Hello, Clang implements MS extensions when using -fms-extension. On windows this option is enabled by default. Is there any way of disabling it to mirror the behavior of the /Za (-permissive-) option of CL? Thanks, -Zahira ___ cfe-commits mailing

Re: [libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

2017-03-07 Thread Asiri Rathnayake via cfe-commits
Hi Ed, Could you please always include cfe-commits as a subscriber in you phab reviews? We would like to be aware of these changes in advance before they land. Thanks. / Asiri On 7 Mar 2017 6:27 p.m., "Ed Schouten via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: ed > Date:

[PATCH] D28297: [StaticAnalyzer] Fix crash in CastToStructChecker

2017-03-07 Thread Daniel Marjamäki via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297187: [analyzer] Fix crashes in CastToStruct checker for undefined structs (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D28297?vs=89507=90900#toc Repository: rL

r297187 - [analyzer] Fix crashes in CastToStruct checker for undefined structs

2017-03-07 Thread Daniel Marjamaki via cfe-commits
Author: danielmarjamaki Date: Tue Mar 7 13:20:48 2017 New Revision: 297187 URL: http://llvm.org/viewvc/llvm-project?rev=297187=rev Log: [analyzer] Fix crashes in CastToStruct checker for undefined structs This crash was reported in https://bugs.llvm.org//show_bug.cgi?id=31173 Differential

[PATCH] D30663: Use filename in linemarker when compiling preprocessed source (Revised)

2017-03-07 Thread Bob Haarman via Phabricator via cfe-commits
inglorion accepted this revision. inglorion added a comment. This revision is now accepted and ready to land. Fixing the other issues in a follow-up seems fine. This lgtm. https://reviews.llvm.org/D30663 ___ cfe-commits mailing list

[PATCH] D30711: [coroutines] update coro_end builtin to match llvm

2017-03-07 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov created this revision. Herald added subscribers: EricWF, mehdi_amini. llvm.coro.end intrinsic now returns bool. Updating clang to match it. https://reviews.llvm.org/D30711 Files: include/clang/Basic/Builtins.def test/CodeGenCoroutines/coro-builtins.c Index:

[PATCH] D29923: Send UndefMacroDirective to MacroDefined callback

2017-03-07 Thread Frederich Munch via Phabricator via cfe-commits
marsupial added a comment. ping https://reviews.llvm.org/D29923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30705: clang-format: [JS] allow breaking after non-null assertions.

2017-03-07 Thread Martin Probst via Phabricator via cfe-commits
mprobst updated this revision to Diff 90889. mprobst added a comment. - Introduce TT_JsNonNullAssertion to centralize determining token types. https://reviews.llvm.org/D30705 Files: lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestJS.cpp Index:

[PATCH] D30705: clang-format: [JS] allow breaking after non-null assertions.

2017-03-07 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2292 return false; -// Postfix non-null assertion operator, as in `foo!.bar()`. -if (Right.is(tok::exclaim) && (Left.isOneOf(tok::identifier, tok::r_paren, -

[libunwind] r297175 - Tidy up the way we include EHHeaderParser.hpp.

2017-03-07 Thread Ed Schouten via cfe-commits
Author: ed Date: Tue Mar 7 12:21:51 2017 New Revision: 297175 URL: http://llvm.org/viewvc/llvm-project?rev=297175=rev Log: Tidy up the way we include EHHeaderParser.hpp. Other source files in the source tree tend to include this header file unconditionally. It also parses perfectly fine on ARM

[PATCH] D30705: clang-format: [JS] allow breaking after non-null assertions.

2017-03-07 Thread Martin Probst via Phabricator via cfe-commits
mprobst created this revision. Herald added a subscriber: klimek. Previously clang-format would not break after any !. However in TypeScript, ! can be used as a post fix operator for non-nullability: x.foo()!.bar()!; With this change, clang-format will wrap after the ! if it is likely a

[libunwind] r297174 - Improve readability and correctness of the OS specific libunwind bits.

2017-03-07 Thread Ed Schouten via cfe-commits
Author: ed Date: Tue Mar 7 12:15:52 2017 New Revision: 297174 URL: http://llvm.org/viewvc/llvm-project?rev=297174=rev Log: Improve readability and correctness of the OS specific libunwind bits. All of the access to __exidx_*, dl_iterate_phdr(), etc. is specific to the findUnwindSections()

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

2017-03-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. Can you add a flag pair to control the insertion of rpath into the final binary? As things are currently, clang is basically leaking paths from the machine doing the linking into the final binary, which often will not run on the same machine. I was thinking

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

2017-03-07 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. We were planning adding some extra unittests, too... https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r296927 - Add arch-specific directory to search path

2017-03-07 Thread Pirama Arumuga Nainar via cfe-commits
https://reviews.llvm.org/D30700 changes the driver to always add -rpath, irrespective of whether cross compiling or not. On Mon, Mar 6, 2017 at 10:29 AM, Benjamin Kramer wrote: > On Mon, Mar 6, 2017 at 7:00 PM, Pirama Arumuga Nainar > wrote: > > Adding

[PATCH] D30700: [Driver] Always add arch-specific-subdir to -rpath

2017-03-07 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama created this revision. This patch unconditionally adds -rpath of the arch-specific subdirectory in resource directory (instead of doing so only during native compilation). This patch also re-enables test arch-specific-libdir.c which was silently unsupported because of the REQUIRES tag

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

2017-03-07 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added inline comments. Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:21 + // CHECK: call void @__ubsan_handle_load_invalid_value + return s->e1; +} vsk wrote: > arphaman wrote: > > Can we avoid the check if the bitfield is 2 bits wide? > I don't think

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

2017-03-07 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. @EricWF, LGTM? https://reviews.llvm.org/D26316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

2017-03-07 Thread Vedant Kumar via Phabricator via cfe-commits
vsk updated this revision to Diff 90869. vsk added a comment. - Improve objc test coverage per Jon's suggestions. https://reviews.llvm.org/D30423 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h test/CodeGenCXX/ubsan-bitfields.cpp

[PATCH] D30423: [ubsan] Detect UB loads from bitfields

2017-03-07 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. In https://reviews.llvm.org/D30423#694003, @jroelofs wrote: > I think this might miss loads from bitfield ivars. I'll add a test that shows that this case is covered. > Also, what about the conversion that happens for properties whose backing > ivar is a bitfield? (or

[PATCH] D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas

2017-03-07 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 90864. krasimir added a comment. - Make the test example idiomatic https://reviews.llvm.org/D30697 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index:

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-03-07 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Guide to run the two pass analysis: Process --- These are the steps of XTU analysis: 1. `xtu-build.py` script uses your compilation database and extracts all necessary information from files compiled. It puts all its generated data into a folder (.xtu by

[PATCH] D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas

2017-03-07 Thread Martin Probst via Phabricator via cfe-commits
mprobst accepted this revision. mprobst added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D30697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

2017-03-07 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov updated this revision to Diff 90862. GorNishanov added a comment. - removed '&' that snicked near Location parameter - reordered a few lines to minimize the diff from Eric's version https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

2017-03-07 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov updated this revision to Diff 90861. GorNishanov added a comment. Per's @rsmith feedback in Kona - Added diagnostic if from_address is missing from coroutine_handle - Switch to using BuildDeclarationNameExpr in buildCoroutineHandle https://reviews.llvm.org/D26316 Files:

[PATCH] D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas

2017-03-07 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 90859. krasimir added a comment. - Fix test comment https://reviews.llvm.org/D30697 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index:

[PATCH] D30697: [clang-format] Enable comment reflowing in multiline comments containing pragmas

2017-03-07 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added a subscriber: klimek. This patch enables comment reflowing of lines not matching the comment pragma regex in multiline comments containing comment pragma lines. Previously, these comments were dumped without being reindented to the result.

[PATCH] D30157: [analyzer] Improve valist check

2017-03-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297153: [analyzer] Improve valist checks and move it out from alpha state. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D30157?vs=90676=90855#toc Repository: rL LLVM

r297153 - [analyzer] Improve valist checks and move it out from alpha state.

2017-03-07 Thread Gabor Horvath via cfe-commits
Author: xazax Date: Tue Mar 7 10:04:23 2017 New Revision: 297153 URL: http://llvm.org/viewvc/llvm-project?rev=297153=rev Log: [analyzer] Improve valist checks and move it out from alpha state. This patch makes the valist check more robust to the different AST variants on different platforms and

[PATCH] D30489: [analyzer] catch out of bounds for VLA

2017-03-07 Thread Daniel Marjamäki via Phabricator via cfe-commits
danielmarjamaki added a comment. > Also, in your state dumps no information is actually lost. The fact that the > value of variable sz is reg_$0 is trivial: you could ask the Store what's > the value of the variable sz and it'd say reg_$0 if there are no bindings > over it. Thanks. I have

Re: r297140 - [clang-format] Support namespaces ending in semicolon

2017-03-07 Thread David Blaikie via cfe-commits
Looks to be failing existing tests? FAIL: Clang-Unit :: Format/FormatTests/FormatTest.BreaksLongDeclarations (12427 of 32080) TEST 'Clang-Unit :: Format/FormatTests/FormatTest.BreaksLongDeclarations' FAILED Note: Google Test filter =

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

2017-03-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I believe this should land. Thank you very much for getting this far to get this fixed. My take on the documentation: Return the default value bound to a region in a given store. The default

[libunwind] r297149 - Let arm_section_length store the number of bytes.

2017-03-07 Thread Ed Schouten via cfe-commits
Author: ed Date: Tue Mar 7 09:21:57 2017 New Revision: 297149 URL: http://llvm.org/viewvc/llvm-project?rev=297149=rev Log: Let arm_section_length store the number of bytes. Exception section data that we extract for DWARF gets stored as the offset and the number of bytes. For ARM exception

[PATCH] D30157: [analyzer] Improve valist check

2017-03-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. It's great to see things move out of alpha and finally become actually accessible to the majority of users. Thanks! https://reviews.llvm.org/D30157

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

2017-03-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I'm sorry for the delays; i'm humbly requesting a couple more weeks to get back to this awesome stuff. https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30693: [mips][msa] Remove range checks for non-immediate sld.[bhwd] instructions

2017-03-07 Thread Stefan Maksimovic via Phabricator via cfe-commits
smaksimovic created this revision. Removes immediate range checks for these instructions, since they have GPR rt as their input operand. https://reviews.llvm.org/D30693 Files: lib/Sema/SemaChecking.cpp test/CodeGen/builtins-mips-msa-error.c test/CodeGen/builtins-mips-msa.c Index:

[PATCH] D30688: [clang-format] Support namespaces ending in semicolon

2017-03-07 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297140: [clang-format] Support namespaces ending in semicolon (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D30688?vs=90839=90841#toc Repository: rL LLVM

r297140 - [clang-format] Support namespaces ending in semicolon

2017-03-07 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Tue Mar 7 08:07:43 2017 New Revision: 297140 URL: http://llvm.org/viewvc/llvm-project?rev=297140=rev Log: [clang-format] Support namespaces ending in semicolon Summary: This patch adds support for namespaces ending in semicolon to the namespace comment fixer. source: ```

[PATCH] D30688: [clang-format] Support namespaces ending in semicolon

2017-03-07 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 90839. krasimir added a comment. - Remove braces https://reviews.llvm.org/D30688 Files: lib/Format/NamespaceEndCommentsFixer.cpp unittests/Format/NamespaceEndCommentsFixerTest.cpp Index: unittests/Format/NamespaceEndCommentsFixerTest.cpp

[PATCH] D30688: [clang-format] Support namespaces ending in semicolon

2017-03-07 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Minor nit, otherwise looks good. Comment at: lib/Format/NamespaceEndCommentsFixer.cpp:152 +const FormatToken *EndCommentNextTok = EndCommentPrevTok->Next; +if

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

2017-03-07 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun created this revision. Herald added a subscriber: mgorny. This patch adds support for naive cross translational unit analysis. The aim of this patch is to be minimal to enable the development of the feature on the top of tree. This patch should be an NFC in case XTUDir is not provided

[PATCH] D29117: SPARC: allow usage of floating-point registers in inline ASM

2017-03-07 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. > How do I create full-context-patches? Does this mean just more context lines? > Like 500 or 1000 lines? http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface https://reviews.llvm.org/D29117 ___

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

2017-03-07 Thread Simon Dardis via Phabricator via cfe-commits
sdardis marked 3 inline comments as done. sdardis added a comment. Thanks for getting back to this. I've traced the appearance of the ext_vector type to a piece of code that only produces ext-vector types for comparisons. I'm presuming that's wrong when clang is producing vectors implicitly in

[PATCH] D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets

2017-03-07 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 90832. arphaman marked an inline comment as done. arphaman added a comment. Add a test for non-ext vector type Repository: rL LLVM https://reviews.llvm.org/D28670 Files: include/clang/AST/DeclBase.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets

2017-03-07 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: lib/Sema/SemaDeclObjC.cpp:4312 + for (const ParmVarDecl *P : Method->parameters()) { +if (P->getType()->isVectorType()) { + Loc = P->getLocStart(); bruno wrote: > Assuming objc/c++ can pass/return these, the

[PATCH] D30166: Honor __unaligned in codegen for declarations and expressions

2017-03-07 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 added a comment. Ping? :-) Kind regards https://reviews.llvm.org/D30166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r297133 - [index] Mark categories of test classes with the 'UnitTest' symbol property as well.

2017-03-07 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Tue Mar 7 03:38:08 2017 New Revision: 297133 URL: http://llvm.org/viewvc/llvm-project?rev=297133=rev Log: [index] Mark categories of test classes with the 'UnitTest' symbol property as well. Modified: cfe/trunk/lib/Index/IndexSymbol.cpp

r297131 - [AST/ObjC] Make ObjCCategoryImplDecl consistent with ObjCCategoryDecl and use the category name as its DeclName

2017-03-07 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Tue Mar 7 03:26:07 2017 New Revision: 297131 URL: http://llvm.org/viewvc/llvm-project?rev=297131=rev Log: [AST/ObjC] Make ObjCCategoryImplDecl consistent with ObjCCategoryDecl and use the category name as its DeclName This also addresses the badness in

[PATCH] D30685: [include-fixer] Remove line number from Symbol identity

2017-03-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Remove line number from Symbol identity. For our purposes (include-fixer and clangd autocomplete), function overloads within the same header should mostly be treated as a single combined symbol. We may want to track individual occurrences (line number, full type

[PATCH] D29117: SPARC: allow usage of floating-point registers in inline ASM

2017-03-07 Thread Patrick Boettcher via Phabricator via cfe-commits
pboettch added a comment. On SparcV8 there is no %e register. Regarding soft-float, good question, I'll try. How do I create full-context-patches? Does this mean just more context lines? Like 500 or 1000 lines? https://reviews.llvm.org/D29117

[PATCH] D30636: [analyzer] Fix crash when building CFG with variable of incomplete type

2017-03-07 Thread Martin Böhme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL297129: [analyzer] Fix crash when building CFG with variable of incomplete type (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D30636?vs=90660=90810#toc Repository: rL LLVM

r297129 - [analyzer] Fix crash when building CFG with variable of incomplete type

2017-03-07 Thread Martin Bohme via cfe-commits
Author: mboehme Date: Tue Mar 7 02:42:37 2017 New Revision: 297129 URL: http://llvm.org/viewvc/llvm-project?rev=297129=rev Log: [analyzer] Fix crash when building CFG with variable of incomplete type Summary: I've included a unit test with a function template containing a variable of incomplete