[PATCH] D31276: Add #pragma clang fast_math

anemet created this revision. This adds the new pragma and the first variant, contract_fast. The pragma has the same block scope rules as STDC FP_CONTRACT, i.e. it can be placed at the beginning of a compound statement or at file scope. Similarly to STDC FP_CONTRACT there is no need to use

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

nikola added a comment. Commit r298574, thanks for woking on this folks! https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r298574 - Fix issues in clang-format's AlignConsecutive modes.

Author: nikola Date: Wed Mar 22 21:51:25 2017 New Revision: 298574 URL: http://llvm.org/viewvc/llvm-project?rev=298574=rev Log: Fix issues in clang-format's AlignConsecutive modes. Patch by Ben Harper. Modified: cfe/trunk/lib/Format/WhitespaceManager.cpp

[PATCH] D31234: Implement P0599 - noexcept for hash functions

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 298573 https://reviews.llvm.org/D31234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r298573 - Implement P0599: 'noexcept for hash functions'. Fix a couple of hash functions (optional and unique_ptr) which were mistakenly marked as 'noexcept'. Reviewed as https://review

Author: marshall Date: Wed Mar 22 21:40:28 2017 New Revision: 298573 URL: http://llvm.org/viewvc/llvm-project?rev=298573=rev Log: Implement P0599: 'noexcept for hash functions'. Fix a couple of hash functions (optional and unique_ptr) which were mistakenly marked as 'noexcept'. Reviewed as

[PATCH] D30765: Reexport operator new / delete from libc++abi

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. We'll hear soon enough if this starts causing problems. https://reviews.llvm.org/D30765 ___ cfe-commits mailing list

[PATCH] D31050: [ThinLTO] Clang support for emitting minimized bitcode for thin link

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31022: Implement P0298R3: `std::byte`

EricWF added a comment. I really dislike the circular dependencies between `` and ``. I suspect we can avoid this by only including `` in ``, which would allow `` to depend on ``. @mclow.lists Does that sound good to you? https://reviews.llvm.org/D31022

[PATCH] D22391: [Sema] Add warning for implicitly casting a null constant to a non null pointer type

jordan_rose added a comment. This looks like it's only coming up for declarations. What about assignments? int x; int * _Nonnull p = p = NULL; // warn here? Comment at: lib/Sema/SemaExpr.cpp:7117 +if (E && S.checkNonNullExpr(E)) + return

[libcxx] r298566 - Address post-commit review comments regarding test_workarounds.h

Author: ericwf Date: Wed Mar 22 19:48:59 2017 New Revision: 298566 URL: http://llvm.org/viewvc/llvm-project?rev=298566=rev Log: Address post-commit review comments regarding test_workarounds.h Modified:

r298565 - [coroutines] Implement unhandled_exception changes.

Author: ericwf Date: Wed Mar 22 19:33:33 2017 New Revision: 298565 URL: http://llvm.org/viewvc/llvm-project?rev=298565=rev Log: [coroutines] Implement unhandled_exception changes. Summary: This patch adopts the recent changes that renamed `set_exception(exception_pointer)` to

[PATCH] D31234: Implement P0599 - noexcept for hash functions

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Although it would be useful to test that `hash>` and `hash` do not have noexcept call operators. Alternatively should we make `hash` conditionally noexcept for

[PATCH] D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5"

EricWF added inline comments. Comment at: include/mutex:177 +template unique_lock(unique_lock) +-> unique_lock; // C++17 + mclow.lists wrote: > And what's with the 'M'? (here and below) No idea, but I would remove the explicit deduction guides from this

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

efriedma added a comment. Oh, right... constant folding uses the declared alignment of the global to constant-fold the comparison. (I still think it would be interesting to solve, but maybe orthogonal to some extent.) https://reviews.llvm.org/D30283

[PATCH] D31272: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

mehdi_amini created this revision. Herald added a subscriber: mgorny. The linker would fail because the list of reexported symbols contains new/delete operators. https://reviews.llvm.org/D31272 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt

[PATCH] D31187: Fix removal of out-of-line definitions.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. The patch itself LGTM. I'd like some test coverage, but if this will be covered by some upcoming interpreter piece and you need this to unblock yourselves, that's good enough for me. In any

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

ahatanak updated this revision to Diff 92742. ahatanak added a comment. Update patch. 1. In isSameEntity, call typesAreCompatible instead of hasSameType so that non-prototype function declarations are merged with function prototypes. 2. Define a function (mergeCompatibleFunctionDecls) that

[PATCH] D31269: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

bruno created this revision. When modules come from module map files explicitly specified by -fmodule-map-file= arguments, allow those to override/shadow modules with the same name that are found implicitly by header search. If such a module is looked up by name (e.g. @import), we will always

[PATCH] D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5"

mclow.lists added inline comments. Comment at: include/mutex:176 +template unique_lock(unique_lock) +-> unique_lock; // C++17 EricWF wrote: > This should be guarded behind a feature test macro. I would suggest adding > this to `__config`. > > ``` > #if

[PATCH] D31252: [clang-tidy] add readability-compound-statement-size check.

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Will be good idea to run Clang-tidy modernize and readability checks over new code. Comment at: clang-tidy/readability/CompoundStatementSizeCheck.cpp:41 +

[PATCH] D30283: [ubsan] Reduce alignment checking of C++ object pointers

vsk updated this revision to Diff 92732. vsk added a comment. Per Eli's comment: test that we don't regress alignment-checking for extern globals which aren't arrays. I verified that for this case, there is not functional change. However, there *is* a somewhat surprising IR change even at -O0,

[PATCH] D31260: [libc++] Work around C1XX bug which breaks poisoned hash tests.

CaseyCarter added a comment. I also have no problem with this change. Comment at: test/support/poisoned_hash_helper.hpp:53 using LibraryHashTypes = TypeList< +#if !defined(TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR) #if TEST_STD_VER > 14 I would

[libcxx] r298554 - [libc++] Work around C1XX bug which breaks poisoned hash tests.

Author: ericwf Date: Wed Mar 22 17:41:41 2017 New Revision: 298554 URL: http://llvm.org/viewvc/llvm-project?rev=298554=rev Log: [libc++] Work around C1XX bug which breaks poisoned hash tests. Summary: This is my attempt to work around the C1XX bug described to me by @BillyONeal. Reviewers:

[PATCH] D31260: [libc++] Work around C1XX bug which breaks poisoned hash tests.

EricWF added a comment. In https://reviews.llvm.org/D31260#708139, @BillyONeal wrote: > (Though you might want something like this anyway if you try libc++ with > MSVC++ on Windows...) Exactly why I volunteered to do this. As libc++ and MSVC implement C++17 at different rates I suspect

[PATCH] D31260: [libc++] Work around C1XX bug which breaks poisoned hash tests.

BillyONeal accepted this revision. BillyONeal added a comment. This revision is now accepted and ready to land. I mean, looks good to me, but you really don't need to go there :). (Though you might want something like this anyway if you try libc++ with MSVC++ on Windows...)

[PATCH] D31163: Implement Pp0156r2 "Variadic Lock Guard, version 5"

EricWF added a comment. So Clang only very recently added support for deduction guides. We'll need to add `_LIBCPP_HAS_NO_DEDUCTION_GUIDES` and use it to guard the declarations and the tests. Also I think the explicit deduction guides are incorrect and unneeded. The deduction guides you

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl updated this revision to Diff 92717. yaxunl edited the summary of this revision. yaxunl added a comment. Rename the triple and variable names. https://reviews.llvm.org/D31210 Files: lib/Basic/Targets.cpp test/CodeGenOpenCL/amdgpu-env-amdgiz.cl Index:

r298549 - Actually install scan-build / ccc-analyzer / c++-analyzer on windows

Author: jroelofs Date: Wed Mar 22 16:13:49 2017 New Revision: 298549 URL: http://llvm.org/viewvc/llvm-project?rev=298549=rev Log: Actually install scan-build / ccc-analyzer / c++-analyzer on windows Before, we were only installing the wrappers... oops. Modified:

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

ahmedasadi added inline comments. Comment at: lib/Sema/SemaDecl.cpp:6753 // the constructor initializes the field with the parameter. -if (isa(NewDC) && isa(D)) { - // Remember that this was shadowed so we can either warn about its - // modification or its

[PATCH] D29599: Clang Changes for alloc_align

erichkeane updated this revision to Diff 92709. erichkeane marked an inline comment as done. erichkeane added a comment. Thanks for the review! Tests updated to clarify the cast htat is happening. https://reviews.llvm.org/D29599 Files: include/clang/Basic/Attr.td

[PATCH] D31260: [libc++] Work around C1XX bug which breaks poisoned hash tests.

EricWF created this revision. This is my attempt to work around the C1XX bug described to me by @BillyONeal. https://reviews.llvm.org/D31260 Files: test/support/poisoned_hash_helper.hpp test/support/test.workarounds/c1xx_broken_nullptr_conversion_operator.pass.cpp

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 5 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31252: Clang-tidy: add readability-compound-statement-size check.

JonasToth added a comment. Another thought from me: Maybe it would be sensible to create a check like `complexity-limits` where different forms of complicated constructs are examined. This could include extreme inheritance, excessive amount of members in classes (violation of single

[PATCH] D31248: [X86] Implement __readgsqword (and the rest) as builtins (PR32373)

rnk added a comment. Yep, thanks, looks good! Repository: rL LLVM https://reviews.llvm.org/D31248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31252: Clang-tidy: add readability-compound-statement-size check.

JonasToth added a comment. Hi and welcome to the clang/llvm community :) It seems that you took `readability-size` as starting point and modified it. Thats a good way to learn! My opinion is, that this should land in `readability-function-size`. This is somewhat recursive to function size.

[PATCH] D29858: [clang-tidy] Catch trivially true statements like a != 1 || a != 3

watsond added a comment. Following up. Was this checked in? Do I need to do anything further? https://reviews.llvm.org/D29858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31252: Clang-tidy: add readability-compound-statement-size check.

lebedev.ri added a comment. Do note that clang-tidy/readability/CompoundStatementSizeCheck.cpp is *very* similar to the clang-tidy/readability/FunctionSizeCheck.cpp I'm not sure if it makes sense to have such duplication. But i'm also not sure yet how to deduplicate them. But in the long run, i

[PATCH] D31252: Clang-tidy: add readability-compound-statement-size check.

lebedev.ri created this revision. lebedev.ri added a project: clang-tools-extra. Herald added a subscriber: mgorny. This check is quite similar to the readability-function-size check. But it is more generic. It works for each compound statement, excluding the ones directly related to the

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl added a comment. In https://reviews.llvm.org/D31210#707842, @yaxunl wrote: > In https://reviews.llvm.org/D31210#707832, @rampitec wrote: > > > I also do not exactly like names "old" and "new". This implies we are going > > to switch to "new" permanently and doing transition. That is not

[PATCH] D31210: [AMDGPU] Add new address space mapping

rampitec added a comment. In https://reviews.llvm.org/D31210#707842, @yaxunl wrote: > In https://reviews.llvm.org/D31210#707832, @rampitec wrote: > > > I also do not exactly like names "old" and "new". This implies we are going > > to switch to "new" permanently and doing transition. That is

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl added a comment. In https://reviews.llvm.org/D31210#707832, @rampitec wrote: > I also do not exactly like names "old" and "new". This implies we are going > to switch to "new" permanently and doing transition. That is not clear yet, > however. How about we call the old address space

[PATCH] D31248: [X86] Implement __readgsqword (and the rest) as builtins (PR32373)

This revision was automatically updated to reflect the committed changes. Closed by commit rL298538: [X86] Implement __readgsqword (and the rest) as builtins (PR32373) (authored by hans). Changed prior to commit: https://reviews.llvm.org/D31248?vs=92664=92679#toc Repository: rL LLVM

r298538 - [X86] Implement __readgsqword (and the rest) as builtins (PR32373)

Author: hans Date: Wed Mar 22 14:13:13 2017 New Revision: 298538 URL: http://llvm.org/viewvc/llvm-project?rev=298538=rev Log: [X86] Implement __readgsqword (and the rest) as builtins (PR32373) It seems MS headers have started using __readgsqword, and since it's used in a header that doesn't

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:2029-2040 + if (UseNew) { +Generic = 0; +Global= 1; +Local = 3; +Constant = 4; +Private = 5; + } else { tstellar wrote: > What are

[PATCH] D31210: [AMDGPU] Add new address space mapping

rampitec added a comment. I also do not exactly like names "old" and "new". This implies we are going to switch to "new" permanently and doing transition. That is not clear yet, however. https://reviews.llvm.org/D31210 ___ cfe-commits mailing

[PATCH] D31210: [AMDGPU] Add new address space mapping

tstellar added inline comments. Comment at: lib/Basic/Targets.cpp:2029-2040 + if (UseNew) { +Generic = 0; +Global= 1; +Local = 3; +Constant = 4; +Private = 5; + } else { What are these values used

[PATCH] D31210: [AMDGPU] Add new address space mapping

yaxunl updated this revision to Diff 92674. yaxunl edited the summary of this revision. https://reviews.llvm.org/D31210 Files: lib/Basic/Targets.cpp test/CodeGenOpenCL/amdgpu-env-amdnas.cl Index: test/CodeGenOpenCL/amdgpu-env-amdnas.cl

[PATCH] D30777: Added `applyAtomicChanges` function.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good.. Very nice :) Comment at: lib/Tooling/Refactoring/AtomicChange.cpp:102 + Code.substr(StartPos, EndPos - StartPos).split(Lines, '\n'); + for (llvm::StringRef

[PATCH] D31248: [X86] Implement __readgsqword (and the rest) as builtins (PR32373)

hans created this revision. It seems MS headers have started using __readgsqword, and since it's used in a header that doesn't include intrin.h, we can't implement it as an inline function anymore. That was already the case for __readfsdword, which Saleem added support for in r220859.

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

On 21 March 2017 at 20:11, Breno Guimarães wrote: > Hi, > > Thanks for the suggestions. I actually had tested with a fake header file > (so I could build more interesting testcases) but it didn't occur to me to > actually make it part of the codebase test. > > I was afraid of

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

arphaman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:6753 // the constructor initializes the field with the parameter. -if (isa(NewDC) && isa(D)) { - // Remember that this was shadowed so we can either warn about its - // modification or its

[PATCH] D30018: [XRay] Add __xray_customeevent(...) as a clang-supported builtin

rnk added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:2748 +if (const auto *XRayAttr = +this->CurFuncDecl->getAttr()) { + if (XRayAttr->neverXRayInstrument()) Don't need `this->` Comment at:

[PATCH] D30388: [XRay] Add -fxray-{always, never}-instrument= flags to clang

rnk added inline comments. Comment at: lib/Basic/XRayFunctionFilter.cpp:21 +: AlwaysInstrument( + llvm::SpecialCaseList::createOrDie(AlwaysInstrumentPaths)), + NeverInstrument(llvm::SpecialCaseList::createOrDie(NeverInstrumentPaths)), Hm, phab

[PATCH] D30388: [XRay] Add -fxray-{always, never}-instrument= flags to clang

rnk added a comment. I think you need some driver logic to make sure the xray lists show up in .d files so that modifications to them trigger rebuilds in most build systems. See the SanitizerArgs.cpp driver logic for this. Comment at:

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

ahmedasadi updated this revision to Diff 92659. ahmedasadi added a comment. Updated diff to include context. https://reviews.llvm.org/D31235 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp test/SemaCXX/warn-shadow.cpp Index:

[PATCH] D30810: Preserve vec3 type.

jaykang10 added a comment. > Yes. This would make sense. I am guessing that in vec3->vec4, we will have 3 > loads and 4 stores and in vec4->vec3 we will have 4 loads and 3 stores? It depends on implementation. If you scalarize all vector operations on LLVM IR level before entering llvm's

[PATCH] D30810: Preserve vec3 type.

Anastasia added a comment. In https://reviews.llvm.org/D30810#707176, @jaykang10 wrote: > In https://reviews.llvm.org/D30810#706677, @Anastasia wrote: > > > In https://reviews.llvm.org/D30810#706676, @Anastasia wrote: > > > > > In https://reviews.llvm.org/D30810#699428, @Anastasia wrote: > > > >

[PATCH] D31050: [ThinLTO] Clang support for emitting minimized bitcode for thin link

tejohnson updated this revision to Diff 92647. tejohnson added a comment. Update as per review comments on llvm side patch https://reviews.llvm.org/D31027. https://reviews.llvm.org/D31050 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.h

[PATCH] D31234: Implement P0599 - noexcept for hash functions

mclow.lists updated this revision to Diff 92645. mclow.lists added a comment. Add missing include to the `thread::id` test and mark `unique_ptr`s hash as not noexcept. https://reviews.llvm.org/D31234 Files: include/memory include/optional include/thread include/variant

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

alexfh added a comment. A late comment here: the check seems to suit better readability module instead of misc. Could you move it there? Repository: rL LLVM https://reviews.llvm.org/D27210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31183: [OpenCL] Added parsing for OpenCL vector types.

Anastasia added a comment. Although nothing wrong with the implementation apart from it complicates a bit the understanding of conventional C parse flow by adding extra corner case, I don't see anything in the spec that states explicitly how the vector components should be parsed. I guess with

r298511 - [X86][MMX] Add tests for _mm_set*_* intrinsics

Author: rksimon Date: Wed Mar 22 09:55:43 2017 New Revision: 298511 URL: http://llvm.org/viewvc/llvm-project?rev=298511=rev Log: [X86][MMX] Add tests for _mm_set*_* intrinsics Modified: cfe/trunk/test/CodeGen/mmx-builtins.c Modified: cfe/trunk/test/CodeGen/mmx-builtins.c URL:

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

alexfh added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:133 + StringRef UntrimmedGlob = GlobList.substr(0, GlobList.find(',')); + StringRef Glob = UntrimmedGlob.trim(); + GlobList = GlobList.substr(UntrimmedGlob.size() + 1);

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

alexfh added a comment. There's one more trim() you missed. And the test needs to be updated (`s/\\n/ /`). https://reviews.llvm.org/D30567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31241: [Modules][PCH] Serialize #pragma pack

arphaman created this revision. This patch serializes the state of `#pragma pack`. It preserves the state of the pragma from a PCH/from modules in a file that uses that PCH/those modules. Repository: rL LLVM https://reviews.llvm.org/D31241 Files: include/clang/Serialization/ASTBitCodes.h

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

hokein added inline comments. Comment at: clang-rename/USRLocFinder.cpp:157 +clang::NestedNameSpecifierLoc nested_name_specifier = +TL.castAs().getQualifierLoc(); +if (nested_name_specifier.getNestedNameSpecifier()) ioeric wrote: > Is this cast

[PATCH] D31176: [clang-rename] Support renaming qualified symbol

hokein updated this revision to Diff 92636. hokein marked 14 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D31176 Files: clang-rename/RenamingAction.cpp clang-rename/RenamingAction.h clang-rename/USRFinder.cpp

[PATCH] D25596: alpha.core.Conversion - Fix false positive for 'U32 += S16; ' expression, that is not unsafe

danielmarjamaki updated this revision to Diff 92634. danielmarjamaki added a comment. I added more testcases. There are several undetected "TODO: loss of precision" right now in the tests that I would like to fix. If this patch to fix FP is accepted I will commit it and continue working on the

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:125-126 +} +diag(Ctor->getLocation(), "function %0 can hide copy and move constructors") +<< Ctor; + } xazax.hun wrote: > aaron.ballman wrote:

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:125-126 +} +diag(Ctor->getLocation(), "function %0 can hide copy and move constructors") +<< Ctor; + } xazax.hun wrote: > aaron.ballman wrote:

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

xazax.hun added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:125-126 +} +diag(Ctor->getLocation(), "function %0 can hide copy and move constructors") +<< Ctor; + } aaron.ballman wrote: > xazax.hun wrote: > >

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. Well.. feel free to provide an alternative fix. If the message is more specific and it must be enabled explicitly by an option then maybe it's good enough for me. Repository: rL LLVM https://reviews.llvm.org/D31097

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

curdeius added a comment. Hi Alex, is it OK now? https://reviews.llvm.org/D30567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r298504 - Revert "Correct class-template deprecation behavior"

Author: mboehme Date: Wed Mar 22 08:34:37 2017 New Revision: 298504 URL: http://llvm.org/viewvc/llvm-project?rev=298504=rev Log: Revert "Correct class-template deprecation behavior" This reverts commit r298410 (which produces incorrect warnings, see comments on

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

xazax.hun added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:125-126 +} +diag(Ctor->getLocation(), "function %0 can hide copy and move constructors") +<< Ctor; + } aaron.ballman wrote: > aaron.ballman wrote:

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

curdeius updated this revision to Diff 92630. curdeius added a comment. Trim only spaces. https://reviews.llvm.org/D30567 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp Index:

r298503 - Revert "iFix Test deprecation behavior in C89 mode as a result of r298410"

Author: mboehme Date: Wed Mar 22 08:33:03 2017 New Revision: 298503 URL: http://llvm.org/viewvc/llvm-project?rev=298503=rev Log: Revert "iFix Test deprecation behavior in C89 mode as a result of r298410" This reverts commit r298433. (Required to revert r298410, see comments there.) Modified:

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki added a comment. In https://reviews.llvm.org/D31097#707385, @baloghadamsoftware wrote: > Hi! > > There is an option to disable the checking of widening casts. It is enabled > by default. You can disable it any time. Or, if you find too much false > positives, we can discuss

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:125-126 +} +diag(Ctor->getLocation(), "function %0 can hide copy and move constructors") +<< Ctor; + } aaron.ballman wrote: > leanil wrote: >

Re: [clang-tools-extra] r298499 - [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style

Forgot to mention: patch by Juliusz Toczydłowski! On Wed, Mar 22, 2017 at 1:49 PM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Wed Mar 22 07:49:58 2017 > New Revision: 298499 > > URL: http://llvm.org/viewvc/llvm-project?rev=298499=rev > Log:

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

alexfh added a comment. In https://reviews.llvm.org/D31130#707197, @aaron.ballman wrote: > This change was reverted in r298470. The use of the include is a > problem because this is not a clang-supplied header file. Also, there's a > (good) question about what array decay is happening in the

[clang-tools-extra] r298500 - [clang-tidy] clang-format the last patch. NFC

Author: alexfh Date: Wed Mar 22 07:50:05 2017 New Revision: 298500 URL: http://llvm.org/viewvc/llvm-project?rev=298500=rev Log: [clang-tidy] clang-format the last patch. NFC Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp

[clang-tools-extra] r298501 - [clang-tidy] Tests should not rely on STL headers being available.

Author: alexfh Date: Wed Mar 22 07:50:10 2017 New Revision: 298501 URL: http://llvm.org/viewvc/llvm-project?rev=298501=rev Log: [clang-tidy] Tests should not rely on STL headers being available. Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.py Modified:

[PATCH] D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style

This revision was automatically updated to reflect the committed changes. Closed by commit rL298499: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring… (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D30931?vs=92619=92623#toc Repository: rL

[clang-tools-extra] r298499 - [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style

Author: alexfh Date: Wed Mar 22 07:49:58 2017 New Revision: 298499 URL: http://llvm.org/viewvc/llvm-project?rev=298499=rev Log: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style Summary: Using CaseType::CT_AnyCase for selected identifier results in

[PATCH] D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style

jutocz updated this revision to Diff 92619. jutocz added a comment. I like the idea of using `llvm::None` plus `operator bool` and `operator *`. I've updated the diff to use `llvm::Optional` this way . https://reviews.llvm.org/D30931 Files: clang-tidy/readability/IdentifierNamingCheck.cpp

[PATCH] [PPC64]: Add support for Swift calling convention

Signed-off-by: Andrew Jeffery --- lib/Basic/Targets.cpp | 11 +++ lib/CodeGen/TargetInfo.cpp | 14 -- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp index fdedd91a3e15..6d7f37f2479a 100644

[PATCH] D30534: [analyzer] When creating a temporary object copy, properly copy the value into it.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:281 + // Try to recover some path sensitivity in case we couldn't compute the value. + if (ExV.isUnknown()) +ExV = getSValBuilder().conjureSymbolVal(Result, LC, Ex->getType(),

[PATCH] D30534: [analyzer] When creating a temporary object copy, properly copy the value into it.

NoQ updated this revision to Diff 92618. NoQ marked 4 inline comments as done. NoQ added a comment. Fix review comments! Add a callback order test to ensure that `checkRegionChanges` is called as many (or rather as few) times as necessary. https://reviews.llvm.org/D30534 Files:

Re: [PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

Hi Jon Le 03/21/2017 à 09:11 PM, Jonathan Roelofs a écrit : On 3/21/17 1:53 PM, Christian Bruel via Phabricator wrote: chrib added a comment. In https://reviews.llvm.org/D31140#706411, @jroelofs wrote: Can you clarify the logic here? It's my understanding that: `-fno-exceptions` does

Re: [PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

Just to add to our comments bellow, One experiment I did is to use the nounwind/uwtable combination to achieve what we need. e.g: nounwind= emit nothing nounwind uwtable = emit the .exidx .extab section with the CANTUNWIND However I gave that up because of tests legacy. e.g

r298494 - Remove an overly aggressive assert in r298491 and leave a comment

Author: chandlerc Date: Wed Mar 22 05:38:07 2017 New Revision: 298494 URL: http://llvm.org/viewvc/llvm-project?rev=298494=rev Log: Remove an overly aggressive assert in r298491 and leave a comment explaining why we have to ignore errors here even though in other parts of codegen we can be more

[PATCH] D30567: [clang-tidy] Fix treating non-space whitespaces in checks list.

alexfh added a comment. In https://reviews.llvm.org/D30567#696436, @curdeius wrote: > Hi Alex and sorry for the late reply. > > The main use case is a more readable `.clang-tidy` configuration checks. > Before this correction one can use something like this: > > --- > Checks: ' > ,*,

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

baloghadamsoftware added a comment. Hi! There is an option to disable the checking of widening casts. It is enabled by default. You can disable it any time. Or, if you find too much false positives, we can discuss about setting this option to disabled as default. I am convinced that checking

[PATCH] D31134: [Serialization] Serialize DependentSizedExtVectorType

This revision was automatically updated to reflect the committed changes. Closed by commit rL298493: [Serialization] Serialize DependentSizedExtVectorType (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D31134?vs=92335=92613#toc Repository: rL LLVM

r298493 - [Serialization] Serialize DependentSizedExtVectorType

Author: arphaman Date: Wed Mar 22 05:04:48 2017 New Revision: 298493 URL: http://llvm.org/viewvc/llvm-project?rev=298493=rev Log: [Serialization] Serialize DependentSizedExtVectorType rdar://30659700 Differential Revision: https://reviews.llvm.org/D31134 Added:

[PATCH] D30931: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. A couple of nits, otherwise looks good. Do you need me to commit the patch for you? Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:169

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

arphaman added a comment. Please update the patch to include the full context (`git diff -U99`). Repository: rL LLVM https://reviews.llvm.org/D31235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r298491 - [nonnull] Teach Clang to attach the nonnull LLVM attribute to

Author: chandlerc Date: Wed Mar 22 04:09:13 2017 New Revision: 298491 URL: http://llvm.org/viewvc/llvm-project?rev=298491=rev Log: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes

[PATCH] D31133: Add LibreOffice Clang plugin to ExternalClangExamples.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL298490: Add LibreOffice Clang plugin to ExternalClangExamples.rst (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D31133?vs=92334=92603#toc Repository: rL LLVM

  1   2   >