[clang-tools-extra] r299935 - [clangd] Implement item kind for completion results

Author: krasimir Date: Tue Apr 11 08:27:15 2017 New Revision: 299935 URL: http://llvm.org/viewvc/llvm-project?rev=299935&view=rev Log: [clangd] Implement item kind for completion results Summary: The patch implements the conversion method from CXCursorKind to clangd::CompletionItemKind. Contribu

[PATCH] D29877: Warn about unused static file scope function template declarations.

chapuni added a comment. This brought warnings in llvm tree. Could you take a look, please? http://bb.pgr.jp/builders/clang-3stage-x86_64-linux/builds/14936 (w/o asserts) llvm/include/llvm/ADT/PointerUnion.h:193:13: warning: unused function 'operator==' [-Wunused-function] llvm/include/llvm

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

v.g.vassilev added a comment. How do we proceed with this. Shall we close it? https://reviews.llvm.org/D22638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D31853: [clangd] Implement item kind for completion results

Thanks for the review! Yes, unfortunately I still need someone to commit it. On Apr 11, 2017 15:21, "Krasimir Georgiev via Phabricator" < revi...@reviews.llvm.org> wrote: krasimir added a comment. Do you still need someone to commit this? https://reviews.llvm.org/D31853 __

[PATCH] D31153: Add the ability to use the children() range API in a const-correct manner

aaron.ballman updated this revision to Diff 94809. aaron.ballman added a comment. Addressing David's review feedback. https://reviews.llvm.org/D31153 Files: include/clang/AST/Expr.h include/clang/AST/StmtIterator.h lib/AST/Expr.cpp Index: lib/AST/Expr.cpp

[PATCH] D31853: [clangd] Implement item kind for completion results

krasimir added a comment. Do you still need someone to commit this? https://reviews.llvm.org/D31853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

malcolm.parsons added a comment. The `modernize-use-default-member-init` check now has an option with the same effect, but it is called `UseAssignment`. We should use consistent option names. Is there any way for multiple checks to share an option? https://reviews.llvm.org/D24892 ___

[PATCH] D31887: [clangd] Add documentation page

JonasToth added inline comments. Comment at: docs/clangd.rst:16 + +Clangd is not meant to be used by C/C++ developpers directly but rather from a client implementing the protocol. +A client would be typically implemented in an IDE or an editor. kromanenkov wrote

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

hfinkel added a comment. In https://reviews.llvm.org/D31413#712013, @aaron.ballman wrote: > I'm not certain of a good way to test it, but I have a question about the > value you picked for `init_priority`. My understanding of the values starting > from 101 is that 1-100 are reserved for impleme

[PATCH] D31887: [clangd] Add documentation page

kromanenkov added inline comments. Comment at: docs/clangd.rst:10 + +:program:`clangd` is an implementation of the `Languge Server Protocol `_ leveraging Clang. +Clangd's goal is to provide language "smartness" features like

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev closed this revision. v.g.vassilev marked 5 inline comments as done. v.g.vassilev added a comment. Landed in r299930. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

r299930 - Warn about unused static file scope function template declarations.

Author: vvassilev Date: Tue Apr 11 05:13:54 2017 New Revision: 299930 URL: http://llvm.org/viewvc/llvm-project?rev=299930&view=rev Log: Warn about unused static file scope function template declarations. Reviewed by Richard Smith (D29877)! Modified: cfe/trunk/lib/Sema/Sema.cpp cfe/trunk

[PATCH] D31706: [clang-format] Handle NSString literals by merging tokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rL299927: [clang-format] Handle NSString literals by merging tokens. (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D31706?vs=94218&id=94801#toc Repository: rL LLVM https://re

r299927 - [clang-format] Handle NSString literals by merging tokens.

Author: alexfh Date: Tue Apr 11 04:55:00 2017 New Revision: 299927 URL: http://llvm.org/viewvc/llvm-project?rev=299927&view=rev Log: [clang-format] Handle NSString literals by merging tokens. Summary: This fixes a few outstanding bugs: * incorrect breaking of NSString literals containing double

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr added inline comments. Comment at: lib/Parse/ParseOpenMP.cpp:174 + case OMPD_target_teams_distribute_simd: +DKind = OMPD_simd; +break; ABataev wrote: > huntergr wrote: > > rengolin wrote: > > > I'd like @ABataev to confirm this is th

[PATCH] D31862: docs/clang-tidy/tools/dump_check_docs.py: Remove deprecated script

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D31862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D31887: [clangd] Add documentation page

xazax.hun added a comment. Maybe this is a good time to decide ClangD, Clangd, or clangd is the correct capitalization. Repository: rL LLVM https://reviews.llvm.org/D31887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D31860: Add more examples to clang tidy checkers

alexfh added a comment. Another couple of post-commit comments. Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15 + + void a(int /*i*/) {} + nit: two spaces before the comment. Comment at: docs/clang-tidy/checks/readability-u

[PATCH] D31853: [clangd] Implement item kind for completion results

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! Thank you! https://reviews.llvm.org/D31853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D31760: [lsan] Enable LSan on arm Linux, clang part

This revision was automatically updated to reflect the committed changes. Closed by commit rL299921: [lsan] Enable LSan on arm Linux, clang part (authored by chefmax). Changed prior to commit: https://reviews.llvm.org/D31760?vs=94708&id=94787#toc Repository: rL LLVM https://reviews.llvm.org

r299921 - [lsan] Enable LSan on arm Linux, clang part

Author: chefmax Date: Tue Apr 11 02:22:11 2017 New Revision: 299921 URL: http://llvm.org/viewvc/llvm-project?rev=299921&view=rev Log: [lsan] Enable LSan on arm Linux, clang part This is a compiler part of https://reviews.llvm.org/D29586. Enable LSan on arm Linux. Differential Revision: https://

[clang-tools-extra] r299920 - Add more examples to clang tidy checkers

Author: sylvestre Date: Tue Apr 11 02:10:48 2017 New Revision: 299920 URL: http://llvm.org/viewvc/llvm-project?rev=299920&view=rev Log: Add more examples to clang tidy checkers Reviewers: alexfh Reviewed By: alexfh Subscribers: cfe-commits Tags: #clang-tools-extra Differential Revision: https

r299919 - Add more examples to clang-format configuration

Author: sylvestre Date: Tue Apr 11 02:07:05 2017 New Revision: 299919 URL: http://llvm.org/viewvc/llvm-project?rev=299919&view=rev Log: Add more examples to clang-format configuration Reviewers: djasper Reviewed By: djasper Subscribers: Eugene.Zelenko, klimek, cfe-commits Differential Revision

<    1   2