Re: r261774 - Bail on compilation as soon as a job fails.

2017-04-22 Thread Nico Weber via cfe-commits
On Sat, Apr 22, 2017 at 8:40 PM, Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > [Some necromancy here...] > > This commit effectively reverted r173361 and r173825, breaking UNIX > conformance for our c99 wrapper. > > See: >

Re: r261774 - Bail on compilation as soon as a job fails.

2017-04-22 Thread Duncan P. N. Exon Smith via cfe-commits
[Some necromancy here...] This commit effectively reverted r173361 and r173825, breaking UNIX conformance for our c99 wrapper. See: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/c99.html > When c99 encounters a

[PATCH] D30465: [mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

2017-04-22 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. FYI, you should close this revision manually and cite the commit (https://reviews.llvm.org/rL297098). Also please cite the review and all the reviewers when you commit. E.g. the commit message for that should be: [mips] Set the Int64Type / IntMaxType types correctly

[PATCH] D32309: [libcxx] [test] Resolve compiler warnings in LCM/GCD tests

2017-04-22 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added inline comments. Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:46 +std::gcd(static_cast(0), static_cast(0)))>::value, ""); +const bool result = static_cast>(out) == +

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

2017-04-22 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/test/Headers/stdint-typeof-MINMAX.cpp:1 +// RUN: %clang_cc1 %s -ffreestanding -std=c++1z -fsyntax-only -triple=aarch64-none-none +// RUN: %clang_cc1 %s -ffreestanding -std=c++1z -fsyntax-only -triple=arm-none-none

[PATCH] D32389: [libclang] Expose some target information via the C API.

2017-04-22 Thread Emilio Cobos Álvarez via Phabricator via cfe-commits
emilio added a comment. I'd appreciate if anyone could point me to an appropriate reviewer for this. Thanks in advance! :) Repository: rL LLVM https://reviews.llvm.org/D32389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32389: [libclang] Expose some target information via the C API.

2017-04-22 Thread Emilio Cobos Álvarez via Phabricator via cfe-commits
emilio created this revision. emilio added a project: clang-c. This allows users to query the target triple and target pointer width, which would make me able to fix https://github.com/servo/rust-bindgen/issues/593 and other related bugs in an elegant way (without having to manually parse the

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

2017-04-22 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi updated this revision to Diff 96283. yamaguchi added a comment. Fixed typo. https://reviews.llvm.org/D32341 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/m_and_mm.c Index: test/Driver/m_and_mm.c === ---

[PATCH] D32341: Fix a bug that warnings generated with -M or -MM flags

2017-04-22 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. LGTM modulo the comments. Comment at: test/Driver/m_and_mm.c:7 +// RUN: not grep "warning" %t +#warning "This warning shouldn't shop up with -M and -MM" Typo. https://reviews.llvm.org/D32341