smeenai added a comment.
Also ABI list checks for libc++abi sound awesome.
https://reviews.llvm.org/D32329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Fair enough. I'll probably get to that tomorrow.
https://reviews.llvm.org/D32329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
The reason I've been punting on this is that I want to set up ABI list checks
for libc++abi just like we do for libc++.
@smeenai If you can verify that this change doesn't affect the libc++abi export
lists on OS X and Linux then it LGTM, but I want that to be confirmed b
smeenai added a comment.
Ping.
https://reviews.llvm.org/D32329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: ericwf
Date: Sun May 7 21:09:48 2017
New Revision: 302396
URL: http://llvm.org/viewvc/llvm-project?rev=302396&view=rev
Log:
Fix Windows locale detection
Modified:
libcxx/trunk/utils/libcxx/test/target_info.py
Modified: libcxx/trunk/utils/libcxx/test/target_info.py
URL:
http://llvm.
Author: ericwf
Date: Sun May 7 20:31:50 2017
New Revision: 302394
URL: http://llvm.org/viewvc/llvm-project?rev=302394&view=rev
Log:
Fix shared_mutex dll import errors on Windows
Modified:
libcxx/trunk/include/shared_mutex
Modified: libcxx/trunk/include/shared_mutex
URL:
http://llvm.org/vie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302393: [libc++] Implement exception_ptr on Windows
(authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D32927?vs=98119&id=98120#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: ericwf
Date: Sun May 7 20:17:50 2017
New Revision: 302393
URL: http://llvm.org/viewvc/llvm-project?rev=302393&view=rev
Log:
[libc++] Implement exception_ptr on Windows
Summary:
This patch implements exception_ptr on Windows using the `__ExceptionPtrFoo`
functions provided by MSVC.
The
EricWF updated this revision to Diff 98119.
EricWF added a comment.
- Remove some missed XFAILS
https://reviews.llvm.org/D32927
Files:
include/exception
lib/CMakeLists.txt
src/exception.cpp
src/support/runtime/exception_pointer_msvc.ipp
test/libcxx/thread/futures/futures.promise/set_e
bcraig added a comment.
Getting the test suite green sooner rather than later seems like a good reason
to temporarily pick a 1-3 year solution rather than a 5+ year solution. Also,
as you mention, this isn't all throw away work, so it's still progress.
So yeah, this is fine to go in as is. LG
Author: ericwf
Date: Sun May 7 19:37:31 2017
New Revision: 302391
URL: http://llvm.org/viewvc/llvm-project?rev=302391&view=rev
Log:
Fix DLL import/export on Win32 locale helpers
Modified:
libcxx/trunk/include/support/win32/locale_win32.h
Modified: libcxx/trunk/include/support/win32/locale_w
Author: ericwf
Date: Sun May 7 19:29:32 2017
New Revision: 302390
URL: http://llvm.org/viewvc/llvm-project?rev=302390&view=rev
Log:
Fix DLL import for __time_get_c_storage member functions.
Modified:
libcxx/trunk/include/locale
Modified: libcxx/trunk/include/locale
URL:
http://llvm.org/vie
Author: ericwf
Date: Sun May 7 18:37:38 2017
New Revision: 302389
URL: http://llvm.org/viewvc/llvm-project?rev=302389&view=rev
Log:
Revert "Actually remove the MSVC STL when linking and testing libc++ on Windows"
This reverts commit r302387.
Modified:
libcxx/trunk/utils/libcxx/test/config.p
Author: ericwf
Date: Sun May 7 18:19:14 2017
New Revision: 302387
URL: http://llvm.org/viewvc/llvm-project?rev=302387&view=rev
Log:
Actually remove the MSVC STL when linking and testing libc++ on Windows
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/
Author: ericwf
Date: Sun May 7 17:10:56 2017
New Revision: 302384
URL: http://llvm.org/viewvc/llvm-project?rev=302384&view=rev
Log:
Temporarly XFAIL aligned new/delete tests on Windows.
Libc++ doesn't provide its own definitions of new/delete on Windows,
instead using the versions provided by VC
Author: ericwf
Date: Sun May 7 16:41:58 2017
New Revision: 302382
URL: http://llvm.org/viewvc/llvm-project?rev=302382&view=rev
Log:
Fix Windows test failures caused by identical temp file names.
This patch fixes test failures that occur on Windows because
the tests attempt to generate two distin
Author: ericwf
Date: Sun May 7 16:21:07 2017
New Revision: 302381
URL: http://llvm.org/viewvc/llvm-project?rev=302381&view=rev
Log:
Accept Windows specific output in system error tests
Modified:
libcxx/trunk/test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/generic_category.pa
Author: ericwf
Date: Sun May 7 16:15:28 2017
New Revision: 302380
URL: http://llvm.org/viewvc/llvm-project?rev=302380&view=rev
Log:
Fix two test failures caused by Windows mangling of function types.
On Windows the function template `template void test()` has
the same mangled name when instanti
EricWF added a comment.
In https://reviews.llvm.org/D32927#748119, @bcraig wrote:
> libstdc++ and the Visual Studio C++ runtime have very different compatibility
> expectations.
I only meant to imply that linking to another standard library implementation
hasn't caused major issues
in the pas
vmiklos added a comment.
In https://reviews.llvm.org/D32945#748225, @malcolm.parsons wrote:
> See uses of `OptionsView::getLocalOrGlobal()`.
Ah, I see. Then yes, I think it makes sense; e.g. for the above cppunit case
ideally I want to avoid any kind of warning from macros, since none of them
vmiklos updated this revision to Diff 98108.
https://reviews.llvm.org/D32945
Files:
clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
clang-tidy/modernize/UseDefaultMemberInitCheck.h
docs/clang-tidy/checks/modernize-use-default-member-init.rst
test/clang-tidy/modernize-use-default-member
lebedev.ri added a comment.
And a lot of warnings from code using googletest, highlight:
../src/librawspeed/metadata/ColorFilterArrayTest.cpp:56:1: error: zero as
null pointer constant [-Werror,-Wzero-as-null-pointer-constant]
TEST(ColorFilterArrayTestBasic, Constructor) {
^
googletest/g
lebedev.ri added a comment.
This warning complains about macros from system headers, e.g.
`PTHREAD_MUTEX_INITIALIZER`:
$ ninja -j1 -v
[1/110] /usr/bin/cmake -E __run_iwyu --tidy=/usr/local/bin/clang-tidy
--source=../src/librawspeed/common/DngOpcodes.cpp -- /usr/local/bin/clang++
-DDEBUG -
malcolm.parsons added a comment.
In https://reviews.llvm.org/D32945#748166, @vmiklos wrote:
> In https://reviews.llvm.org/D32945#748135, @malcolm.parsons wrote:
>
> > Should this option be shared?
>
>
> If the alternative is to make this a general clang-tidy option where all but
> these two chec
xazax.hun added inline comments.
Comment at: clang-tidy/cert/PostfixOperatorCheck.cpp:72
+
+ diag(Location, "return type of overloaded %0 is not a constant type")
+ << FuncDecl << FixItHint::CreateInsertion(Location, "const ");
aaron.ballman wrote:
> aaron.
xazax.hun updated this revision to Diff 98097.
xazax.hun marked 3 inline comments as done.
xazax.hun added a comment.
- Fix alphabetical ordering of files in cmake.
- Let clang-format do its job.
https://reviews.llvm.org/D32743
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMake
xazax.hun added inline comments.
Comment at: clang-tidy/misc/SuspiciousMemsetUsageCheck.cpp:21
+void SuspiciousMemsetUsageCheck::registerMatchers(MatchFinder *Finder) {
+ const auto HasCtorOrDtor =
+ eachOf(hasMethod(cxxConstructorDecl(unless(anyOf(
I think
vmiklos added a comment.
In https://reviews.llvm.org/D32945#748135, @malcolm.parsons wrote:
> Should this option be shared?
If the alternative is to make this a general clang-tidy option where all but
these two checks ignore it, I think that's more confusing to the users. Or do
you have an ex
29 matches
Mail list logo
