[PATCH] D33000: Add support for pretty platform names to `@available`/`__builtin_available`

arphaman created this revision. We should allow macOS/iOS/tvOS/watchOS in `@available`/`__builtin_available`. Repository: rL LLVM https://reviews.llvm.org/D33000 Files: include/clang/Basic/Attr.td lib/Parse/ParseExpr.cpp lib/Sema/SemaDeclAttr.cpp test/FixIt/fixit-availability.c

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

baloghadamsoftware added a comment. In https://reviews.llvm.org/D32592#747132, @NoQ wrote: > Then, in methods that deal with iterator `SVal`s directly, i wish we had > hints explaining what's going on in these ~7 cases. In my opinion, that'd > greatly help people understand the code later, and

[PATCH] D32592: [Analyzer] Iterator Checker - Part 1: Minimal Checker for a Simple Test Case

baloghadamsoftware updated this revision to Diff 98275. baloghadamsoftware marked 11 inline comments as done. baloghadamsoftware added a comment. Updated according to the review. https://reviews.llvm.org/D32592 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

Re: [PATCH] D29877: Warn about unused static file scope function template declarations.

On 11/04/17 22:25, Richard Smith wrote: On 11 April 2017 at 08:35, Marshall Clow via Phabricator via cfe-commits > wrote: mclow.lists added a comment. Complete reproducer: // Tested with with: clang++ -std=c++14

[PATCH] D32989: Don't indent JavaScript IIFEs

mprobst added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2362 + ++I; + if (I->Tok->isNot(tok::l_paren)) +return false; One more - do we want to support IIFEs that take arguments? ``` (function(global) { ... }(window)); ```

[PATCH] D32989: Don't indent JavaScript IIFEs

mprobst added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2346 +bool UnwrappedLineParser::isIIFE() const { + // Look for the start of an immediately invoked anonymous function. Why not just a static function? Comment at:

[PATCH] D32997: clang-format: [JS] keep triple slash directives intact.

This revision was automatically updated to reflect the committed changes. Closed by commit rL302523: clang-format: [JS] keep triple slash directives intact. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D32997?vs=98270=98272#toc Repository: rL LLVM

r302523 - clang-format: [JS] keep triple slash directives intact.

Author: mprobst Date: Tue May 9 07:45:48 2017 New Revision: 302523 URL: http://llvm.org/viewvc/llvm-project?rev=302523=rev Log: clang-format: [JS] keep triple slash directives intact. Summary: TypeScript uses triple slash directives of the form: /// For various non-source instructions

[PATCH] D31867: Fix documentation for TargetOptions.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r302521. https://reviews.llvm.org/D31867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32997: clang-format: [JS] keep triple slash directives intact.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D32997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r302522 - [clang-tidy] Minor cleanup + a disabled test case for PR26228. NFC

Author: alexfh Date: Tue May 9 07:41:11 2017 New Revision: 302522 URL: http://llvm.org/viewvc/llvm-project?rev=302522=rev Log: [clang-tidy] Minor cleanup + a disabled test case for PR26228. NFC Modified: clang-tools-extra/trunk/clang-tidy/readability/BracesAroundStatementsCheck.cpp

r302521 - PR5935: Adjust documentation.

Author: vvassilev Date: Tue May 9 07:37:15 2017 New Revision: 302521 URL: http://llvm.org/viewvc/llvm-project?rev=302521=rev Log: PR5935: Adjust documentation. https://reviews.llvm.org/D31867 Patch by Johannes Altmanninger! Modified: cfe/trunk/include/clang/Basic/TargetOptions.h

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

alexfh added a comment. Paweł, are you planning to finish this patch? https://reviews.llvm.org/D30748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32997: clang-format: [JS] keep triple slash directives intact.

mprobst created this revision. Herald added a subscriber: klimek. TypeScript uses triple slash directives of the form: /// For various non-source instructions that should not be wrapped. Reference: https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html

[PATCH] D32900: [mips] Impose a threshold for coercion of aggregates

smaksimovic updated this revision to Diff 98269. smaksimovic added a comment. Herald added a subscriber: krytarowski. Thanks, fixed. https://reviews.llvm.org/D32900 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/mips-aggregate-arg.c Index: test/CodeGen/mips-aggregate-arg.c

[PATCH] D29877: Warn about unused static file scope function template declarations.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Relanded in r302518. https://reviews.llvm.org/D29877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r302518 - Reland "Warn about unused static file scope function template declarations."

Author: vvassilev Date: Tue May 9 06:25:41 2017 New Revision: 302518 URL: http://llvm.org/viewvc/llvm-project?rev=302518=rev Log: Reland "Warn about unused static file scope function template declarations." This patch reinstates r299930, reverted in r299956, as a separate diagnostic option

[libcxx] r302517 - docs: Fix Sphinx detection with out-of-tree builds

Author: tstellar Date: Tue May 9 06:18:03 2017 New Revision: 302517 URL: http://llvm.org/viewvc/llvm-project?rev=302517=rev Log: docs: Fix Sphinx detection with out-of-tree builds Adapt to changes made in r302499. Modified: libcxx/trunk/docs/CMakeLists.txt Modified:

[clang-tools-extra] r302516 - docs: Fix Sphinx detection with out-of-tree builds

Author: tstellar Date: Tue May 9 06:11:52 2017 New Revision: 302516 URL: http://llvm.org/viewvc/llvm-project?rev=302516=rev Log: docs: Fix Sphinx detection with out-of-tree builds Adapt to changes made in r302499. Modified: clang-tools-extra/trunk/docs/CMakeLists.txt Modified:

[PATCH] D32900: [mips] Impose a threshold for coercion of aggregates

sdardis added a comment. Spotted a minor nit. Comment at: test/CodeGen/mips-aggregate-arg.c:36 + f2(g2); + f3(g3); +} Nit: spurious whitespace here. https://reviews.llvm.org/D32900 ___ cfe-commits mailing

[PATCH] D32900: [mips] Impose a threshold for coercion of aggregates

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/CodeGen/mips-aggregate-arg.c:3 +// RUN: %clang_cc1 -triple mips64el-unknown-linux-gnu -S -emit-llvm -o - %s -target-abi n32 | FileCheck

[PATCH] D31588: Fix PR25627: Certain constant local variables must be usable as template arguments (without being odr-used)

faisalv added a comment. *ping* https://reviews.llvm.org/D31588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32543: [X86] Clang option -fuse-init-array has no effect when generating for MCU target

This revision was automatically updated to reflect the committed changes. Closed by commit rL302513: [X86] Clang option -fuse-init-array has no effect when generating for MCU target (authored by n.bozhenov). Changed prior to commit: https://reviews.llvm.org/D32543?vs=97866=98262#toc

[PATCH] D32350: [Analyzer] Exception checker for misuse: uncaught/noncompliant throws

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ExceptionMisuseChecker.cpp:105 + ReportExnSpec(ReportExnSpec) { + // In the beginning we have to parse list formatted options + SmallVector EnabledFuncsVec; All

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

xazax.hun added a comment. Do you have a benchmark how this affects the performance and memory usage when the old constraint manager is used? I wonder if most of people are using the old one, it might make no sense to generate symbolic expressions that can not be solved anyway. Maybe the

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

xazax.hun added a comment. Looks good for me, I only have a few questions. Could you reupload the diff with contexts? It might make the review easier for others. Comment at: lib/AST/ASTImporter.cpp:1311 + EmptyDecl *ToD = EmptyDecl::Create(Importer.getToContext(), DC, Loc);

[PATCH] D32350: [Analyzer] Exception Checker

whisperity added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ExceptionMisuseChecker.cpp:80 + bool WasReThrow; + Types CurrentThrows; // actually alive exceptions + FunctionExceptionsMap There are some comment formatting issues along these lines.

[PATCH] D32825: [clang-format] Improve understanding of combined typedef+record declarations

jtbandes added a comment. Ping :) https://reviews.llvm.org/D32825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2