[libcxxabi] r302978 - [libcxxabi] Align unwindHeader on a double-word boundary.

Author: ahatanak Date: Fri May 12 22:14:49 2017 New Revision: 302978 URL: http://llvm.org/viewvc/llvm-project?rev=302978=rev Log: [libcxxabi] Align unwindHeader on a double-word boundary. r276215 made a change to annotate _Unwind_Exception with attribute "aligned" so that an exception object

[PATCH] D33029: [clang-format] add option for dangling parenthesis

stringham updated this revision to Diff 98873. https://reviews.llvm.org/D33029 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/Format/Format.cpp lib/Format/TokenAnnotator.cpp

r302975 - [ASTImporter] Improve handling of incomplete types

Author: spyffe Date: Fri May 12 19:46:33 2017 New Revision: 302975 URL: http://llvm.org/viewvc/llvm-project?rev=302975=rev Log: [ASTImporter] Improve handling of incomplete types ASTImporter has some bugs when it's importing types that themselves come from an ExternalASTSource. This is exposed

LLVM lab will be unavailable tomorrow for few hours

Hello everyone, LLVM buildmaster and LLVM lab will be unavailable tomorrow Saturday May 13 for about 4 hours (hopefully less) starting 10 AM Pacific time due to network works. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list

r302969 - Add LangOptions method to query whether we are tracking the owning module for a local declaration.

Author: rsmith Date: Fri May 12 19:00:16 2017 New Revision: 302969 URL: http://llvm.org/viewvc/llvm-project?rev=302969=rev Log: Add LangOptions method to query whether we are tracking the owning module for a local declaration. In preparation for expanding this behavior to cover additional

[PATCH] D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization

cynecx added a comment. Gentle ping. Repository: rL LLVM https://reviews.llvm.org/D25051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r302966 - Remove unused tracking of owning module for MacroInfo objects.

Author: rsmith Date: Fri May 12 18:40:52 2017 New Revision: 302966 URL: http://llvm.org/viewvc/llvm-project?rev=302966=rev Log: Remove unused tracking of owning module for MacroInfo objects. Modified: cfe/trunk/include/clang/Lex/MacroInfo.h cfe/trunk/include/clang/Lex/Preprocessor.h

r302965 - [modules] When creating a declaration, cache its owning module immediately

Author: rsmith Date: Fri May 12 18:27:00 2017 New Revision: 302965 URL: http://llvm.org/viewvc/llvm-project?rev=302965=rev Log: [modules] When creating a declaration, cache its owning module immediately rather than waiting until it's queried. Currently this is only applied to local submodule

[PATCH] D31383: [inline asm] "=i" output constraint support - gcc compatiblity

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D31383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32981: [ASTImporter] Improve handling of incomplete types

spyffe marked 2 inline comments as done. spyffe added inline comments. Comment at: tools/clang-import-test/clang-import-test.cpp:263 +AddExternalSource(*CI, Imports); + } bruno wrote: > No need for the curly braces here Okay.

Re: r302932 - [modules] Simplify module macro handling in non-local-submodule-visibility mode.

On 12 May 2017 at 14:19, Juergen Ributzka wrote: > Hi Richard, > > I think this broke modules. > > If I try to compile a simple test program (@import Foundation;) I get the > following error: > ./bin/clang test.m -fmodules -c -isysroot /Applications/Xcode.app/ >

Re: r302932 - [modules] Simplify module macro handling in non-local-submodule-visibility mode.

Hi Richard, I think this broke modules. If I try to compile a simple test program (@import Foundation;) I get the following error: ./bin/clang test.m -fmodules -c -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk While building module

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

I will look at this. Thanks Galina On Fri, May 12, 2017 at 2:00 PM, Richard Smith wrote: > On 12 May 2017 at 13:24, Renato Golin wrote: > >> On 12 May 2017 at 20:46, Diana Picus wrote: >> > On 11 May 2017 at 21:14,

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

On 12 May 2017 at 13:24, Renato Golin wrote: > On 12 May 2017 at 20:46, Diana Picus wrote: > > On 11 May 2017 at 21:14, Richard Smith wrote: > >> Thanks for the revert, fixed up and recommitted in r302817. > >> > >> Any

r302947 - Revert r302932, as it appears to be breaking stage2 for some of our modules-enabled buildbots.

Author: rsmith Date: Fri May 12 15:42:54 2017 New Revision: 302947 URL: http://llvm.org/viewvc/llvm-project?rev=302947=rev Log: Revert r302932, as it appears to be breaking stage2 for some of our modules-enabled buildbots. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified:

[PATCH] D32977: [OpenCL] Emit function-scope variable in constant address space as static variable

yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10286 + // these variables must be a compile time constant. + VDecl->getType().getAddressSpace() == LangAS::opencl_constant) CheckForConstantInitializer(Init, DclT);

[libcxx] r302944 - [test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 1/3.

Author: caseycarter Date: Fri May 12 15:33:32 2017 New Revision: 302944 URL: http://llvm.org/viewvc/llvm-project?rev=302944=rev Log: [test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 1/3. This C++17 Core Language feature isn't necessary when testing std::byte. It's a

[libcxx] r302946 - [test] Add specific test for P0138R2, direct-list-init of fixed enums from integers, part 3/3.

Author: caseycarter Date: Fri May 12 15:33:46 2017 New Revision: 302946 URL: http://llvm.org/viewvc/llvm-project?rev=302946=rev Log: [test] Add specific test for P0138R2, direct-list-init of fixed enums from integers, part 3/3. Test the C++17 Core Language feature independently from other

[libcxx] r302945 - [test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 2/3.

Author: caseycarter Date: Fri May 12 15:33:41 2017 New Revision: 302945 URL: http://llvm.org/viewvc/llvm-project?rev=302945=rev Log: [test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 2/3. This C++17 Core Language feature isn't necessary when testing std::byte. It's a

Re: [clang-tools-extra] r302934 - [include-fixer] Don't throw exception when parsing unknown arguments in

On Fri, May 12, 2017 at 9:01 PM, Haojian Wu via cfe-commits wrote: > Author: hokein > Date: Fri May 12 14:01:02 2017 > New Revision: 302934 > > URL: http://llvm.org/viewvc/llvm-project?rev=302934=rev > Log: > [include-fixer] Don't throw exception when parsing unknown

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

On 12 May 2017 at 20:46, Diana Picus wrote: > On 11 May 2017 at 21:14, Richard Smith wrote: >> Thanks for the revert, fixed up and recommitted in r302817. >> >> Any idea why not a single buildbot sent me any email about this? :( (A >> couple of them

r302941 - [Sema] Silence buildbot failures introduced by r302935

Author: sdardis Date: Fri May 12 14:55:32 2017 New Revision: 302941 URL: http://llvm.org/viewvc/llvm-project?rev=302941=rev Log: [Sema] Silence buildbot failures introduced by r302935 Attempt to silence buildbot failures by pinning the test to a given triple rather than the host's triple.

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

On 11 May 2017 at 21:14, Richard Smith wrote: > Thanks for the revert, fixed up and recommitted in r302817. > > Any idea why not a single buildbot sent me any email about this? :( (A > couple of them were red at the previous change too, but some of them were > not (eg.

r302940 - Remove ignore-empty-index-file option

Author: tejohnson Date: Fri May 12 14:32:17 2017 New Revision: 302940 URL: http://llvm.org/viewvc/llvm-project?rev=302940=rev Log: Remove ignore-empty-index-file option Summary: Clang changes to remove this option and replace with a parameter always set in the context of a ThinLTO distributed

[PATCH] D33134: Remove ignore-empty-index-file option

This revision was automatically updated to reflect the committed changes. Closed by commit rL302940: Remove ignore-empty-index-file option (authored by tejohnson). Changed prior to commit: https://reviews.llvm.org/D33134?vs=98779=98821#toc Repository: rL LLVM

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL302935: [Sema] Support implicit scalar to vector conversions (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D25866?vs=98783=98815#toc Repository: rL LLVM

r302935 - [Sema] Support implicit scalar to vector conversions

Author: sdardis Date: Fri May 12 14:11:06 2017 New Revision: 302935 URL: http://llvm.org/viewvc/llvm-project?rev=302935=rev Log: [Sema] Support implicit scalar to vector conversions This patch teaches clang to perform implicit scalar to vector conversions when one of the operands of a binary

[clang-tools-extra] r302934 - [include-fixer] Don't throw exception when parsing unknown arguments in

Author: hokein Date: Fri May 12 14:01:02 2017 New Revision: 302934 URL: http://llvm.org/viewvc/llvm-project?rev=302934=rev Log: [include-fixer] Don't throw exception when parsing unknown arguments in vim script. Modified:

r302932 - [modules] Simplify module macro handling in non-local-submodule-visibility mode.

Author: rsmith Date: Fri May 12 13:56:03 2017 New Revision: 302932 URL: http://llvm.org/viewvc/llvm-project?rev=302932=rev Log: [modules] Simplify module macro handling in non-local-submodule-visibility mode. When reaching the end of a module, we used to convert its macros to ModuleMacros but

[PATCH] D33134: Remove ignore-empty-index-file option

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:25 ///:= true | false +/// := 1.0 | 2e-3 | 3.45e67 /// := [0-9]+ It'd be good to list the actual grammar rather than a few examples.

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

erichkeane added a comment. Bump :) https://reviews.llvm.org/D32046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

vsk added a comment. Ping. https://reviews.llvm.org/D32842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r302918 - [index] Index template specialization arguments for function templats

Author: arphaman Date: Fri May 12 11:32:26 2017 New Revision: 302918 URL: http://llvm.org/viewvc/llvm-project?rev=302918=rev Log: [index] Index template specialization arguments for function templats Also ensure that class template specialization arguments are covered rdar://31812032 Modified:

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

> On May 11, 2017, at 5:05 PM, Adrian Prantl via cfe-commits > wrote: > >> >> On May 11, 2017, at 4:43 PM, Richard Smith wrote: >> >> I don't think that's quite right; the AST doesn't merge NamespaceDecls. It >> looks like the issue is

r302915 - Simplify DINamespace caching in CGDebugInfo

Author: adrian Date: Fri May 12 11:23:53 2017 New Revision: 302915 URL: http://llvm.org/viewvc/llvm-project?rev=302915=rev Log: Simplify DINamespace caching in CGDebugInfo This addresses review feedback from r302840. By not canonicalizing namespace decls and using lexical decl context instead

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 98783. sdardis marked an inline comment as done. sdardis edited the summary of this revision. sdardis added a comment. Updated error message for logical operations where one operand is a vector and the other isn't. Updated summary. I'll commit this

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

Lekensteyn created this revision. Needed to support something like "floatLiteral(equals(1.0))". The parser for floating point numbers is kept simple, so instead of ".1" you have to use "0.1". https://reviews.llvm.org/D33135 Files: include/clang/ASTMatchers/Dynamic/Diagnostics.h

[PATCH] D33093: [ASTMatchers] Add support for boolean literals

Lekensteyn updated this revision to Diff 98781. Lekensteyn edited the summary of this revision. Lekensteyn added a comment. v2: Minor updates (fixed comment: `// ...` to `///

[PATCH] D29117: SPARC: allow usage of floating-point registers in inline ASM

This revision was automatically updated to reflect the committed changes. Closed by commit rL302913: [SPARC] Support 'f' and 'e' inline asm constraints. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D29117?vs=85708=98782#toc Repository: rL LLVM

r302913 - [SPARC] Support 'f' and 'e' inline asm constraints.

Author: jyknight Date: Fri May 12 11:01:23 2017 New Revision: 302913 URL: http://llvm.org/viewvc/llvm-project?rev=302913=rev Log: [SPARC] Support 'f' and 'e' inline asm constraints. Patch by Patrick Boettcher. Differential Revision: https://reviews.llvm.org/D29117 Added:

[PATCH] D33134: Remove ignore-empty-index-file option

tejohnson created this revision. Herald added subscribers: eraman, mehdi_amini. Clang changes to remove this option and replace with a parameter always set in the context of a ThinLTO distributed backend. Depends on https://reviews.llvm.org/D33133. https://reviews.llvm.org/D33134 Files:

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. Sure. That'd be needed whether they stay, or get moved to test-suite. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 98766. gtbercea added a comment. Address comments. Repository: rL LLVM https://reviews.llvm.org/D29654 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChains/CommonArgs.cpp lib/Driver/ToolChains/CommonArgs.h

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);

r302901 - Enabling the /bigobj flag for SemaDeclAttr.cpp.

Author: aaronballman Date: Fri May 12 09:30:49 2017 New Revision: 302901 URL: http://llvm.org/viewvc/llvm-project?rev=302901=rev Log: Enabling the /bigobj flag for SemaDeclAttr.cpp. This resolves compile errors with MSVC 2015 x64 debug builds where SemaDeclAttr.cpp is hitting the section symbol

[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. In https://reviews.llvm.org/D27334#751921, @echuraev wrote: > So, I think that we have to do some decision about this patch. @Anastasia, > What do you think about it? Please see my comment above. What should we do > with this patch? I am still not convinced adding

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

Anastasia added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated this revision to Diff 98757. https://reviews.llvm.org/D15994 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorLexer.h include/clang/Lex/PreprocessorOptions.h include/clang/Serialization/ASTBitCodes.h lib/Frontend/ASTUnit.cpp lib/Lex/Lexer.cpp

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv marked 8 inline comments as done. erikjv added a comment. Fixed with the next patch. https://reviews.llvm.org/D15994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32977: [OpenCL] Emit function-scope variable in constant address space as static variable

Anastasia accepted this revision. Anastasia added a comment. LGTM! Comment at: lib/Sema/SemaDecl.cpp:10286 + // these variables must be a compile time constant. + VDecl->getType().getAddressSpace() == LangAS::opencl_constant)

r302895 - [Hexagon] Make sure to pass empty struct arguments with nontrivial ctors

Author: kparzysz Date: Fri May 12 08:18:07 2017 New Revision: 302895 URL: http://llvm.org/viewvc/llvm-project?rev=302895=rev Log: [Hexagon] Make sure to pass empty struct arguments with nontrivial ctors Thanks to Richard Smith for the suggested fix. This fixes llvm.org/PR33009 Modified:

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

bcraig added a comment. > I noticed that the Windows STL headers have to do this dance with `new` (even > though they do `(foo)(...)` for `min` and `max`). If we're going to need > to guard against a bunch of macros I would like to use a single approach. > Other than updating the `#if

r302893 - clang-format: [JS] support non-null assertions after all identifiers.

Author: mprobst Date: Fri May 12 08:00:33 2017 New Revision: 302893 URL: http://llvm.org/viewvc/llvm-project?rev=302893=rev Log: clang-format: [JS] support non-null assertions after all identifiers. Summary: Previously: x = namespace !; Now: x = namespace!; Reviewers: djasper

[PATCH] D32332: Add support for transparent overloadable functions in clang

aaron.ballman added a comment. In https://reviews.llvm.org/D32332#751785, @george.burgess.iv wrote: > I'd be happy with that approach. Do you like it, Aaron? I think that makes a lot of sense. > FWIW, I did a bit of archaeology, and it looks like the commit that added the > requirement that

[clang-tools-extra] r302890 - [clang-tidy] Add a test for PR33020

Author: alexfh Date: Fri May 12 06:24:58 2017 New Revision: 302890 URL: http://llvm.org/viewvc/llvm-project?rev=302890=rev Log: [clang-tidy] Add a test for PR33020 Fix committed in clang as r302889. Modified: clang-tools-extra/trunk/test/clang-tidy/misc-use-after-move.cpp Modified:

r302889 - Fix an assertion failure (PR33020).

Author: alexfh Date: Fri May 12 06:24:25 2017 New Revision: 302889 URL: http://llvm.org/viewvc/llvm-project?rev=302889=rev Log: Fix an assertion failure (PR33020). Adding a test separately (tools/extra/test/clang-tidy/misc-use-after-move.cpp). Modified: cfe/trunk/lib/AST/DeclCXX.cpp

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. @jroelofs We'd be ok with tying the test to a specific SDK and maintaining that tie (e.g. bumping it upstream). I was planning to investigate how to make the SDK version checks work, but I don't have the time ATM. Can I get back to you in a week?

[PATCH] D33047: [ClangD] Refactor clangd into separate components

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; klimek wrote: > ilya-biryukov wrote: > > klimek wrote: > > > I'd have expected something that's called LSP server to work on

[PATCH] D33047: [ClangD] Refactor clangd into separate components

ilya-biryukov updated this revision to Diff 98745. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. Addressed new comments https://reviews.llvm.org/D33047 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

[PATCH] D33047: [ClangD] Refactor clangd into separate components

klimek added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; ilya-biryukov wrote: > klimek wrote: > > I'd have expected something that's called LSP server to work on the LSP > > protocol level

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:656-659 + // If the SVal is a LazyCompoundVal it might only cover sub-region of a given + // symbol. For example, the LCV might represent a field in an uninitialized + // struct. In this case, the

[PATCH] D33103: [clang-tidy] TwineLocalCheck: add param # checking

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good, thanks! https://reviews.llvm.org/D33103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r302880 - [analyzer] Add modelling of __builtin_assume

Author: xazax Date: Fri May 12 02:02:54 2017 New Revision: 302880 URL: http://llvm.org/viewvc/llvm-project?rev=302880=rev Log: [analyzer] Add modelling of __builtin_assume Differential Revision: https://reviews.llvm.org/D33092 Added: cfe/trunk/test/Analysis/builtin-assume.c Modified:

[PATCH] D33092: [analyzer] Add checker to model builtin functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL302880: [analyzer] Add modelling of __builtin_assume (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D33092?vs=98609=98731#toc Repository: rL LLVM

[PATCH] D33095: [analyzer] Avoid allocation in Std C function modelling.

This revision was automatically updated to reflect the committed changes. Closed by commit rL302879: [analyzer] Avoid an allocation in Std C function modelling (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D33095?vs=98610=98730#toc Repository: rL LLVM

r302879 - [analyzer] Avoid an allocation in Std C function modelling

Author: xazax Date: Fri May 12 01:53:55 2017 New Revision: 302879 URL: http://llvm.org/viewvc/llvm-project?rev=302879=rev Log: [analyzer] Avoid an allocation in Std C function modelling Differential Revision: https://reviews.llvm.org/D33095 Modified:

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:656-659 + // If the SVal is a LazyCompoundVal it might only cover sub-region of a given + // symbol. For example, the LCV might represent a field in an uninitialized + // struct. In

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich updated this revision to Diff 98726. vlad.tsyrklevich marked 2 inline comments as done. vlad.tsyrklevich added a comment. Minor updates & some clarification on the feedback https://reviews.llvm.org/D30909 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF updated this revision to Diff 98725. EricWF added a comment. - Fix missing `_LIBCPP_POP_MACROS` in `<__threading_support>`. - Add test that each header is unaffected by `min` and `max` macros and that the macros themselves are unaffected. https://reviews.llvm.org/D33080 Files:

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF added a comment. In https://reviews.llvm.org/D33080#752202, @bcraig wrote: > I like the warning that you generate for min and max macros existing. Only on warn on platforms where we don't have `#pragma push_macro/pop_macro`. > Is the push_macro / pop_macro the right way to go though?

[PATCH] D33095: [analyzer] Avoid allocation in Std C function modelling.

xazax.hun added a comment. In https://reviews.llvm.org/D33095#752879, @NoQ wrote: > Is it an actual performance problem? Cause i think i did somehow test the > checker for performance regressions and it seemed all good. I did not measure it. Just spotted by skimming through the code. I think,