r303604 - Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.

Author: gkistanova Date: Tue May 23 00:17:49 2017 New Revision: 303604 URL: http://llvm.org/viewvc/llvm-project?rev=303604=rev Log: Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through. Modified: cfe/trunk/lib/Driver/ToolChains/Myriad.cpp Modified:

[PATCH] D31692: [coroutines] Wrap the body of the coroutine in try-catch

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31692: [coroutines] Wrap the body of the coroutine in try-catch

GorNishanov updated this revision to Diff 99814. GorNishanov added a comment. 1. Heap allocate CxxTryStmt in CGCoroutine. 2. Merge with trunk https://reviews.llvm.org/D31692 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CGCoroutine.cpp lib/Sema/SemaCoroutine.cpp

[PATCH] D33272: Method loadFromCommandLine should be able to report errors

sepavloff updated this revision to Diff 99786. sepavloff marked an inline comment as done. sepavloff added a comment. Addressed reviewer's notes. https://reviews.llvm.org/D33272 Files: include/clang/Tooling/CompilationDatabase.h lib/Frontend/CreateInvocationFromCommandLine.cpp

[PATCH] D33170: [X86] Adding avx512_vpopcntdq feature set and its intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/CodeGen/CGBuiltin.cpp:7526 +llvm::Type *ResultType = ConvertType(E->getType()); +llvm::Function *F =

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

rnk added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:674 + Expr::EvalResult EvlResult; + // Try to evaluate the identifier as enum constant + if (isa(Res->getType()) && Res->EvaluateAsRValue(EvlResult, Please add a comment explaining that non-enum

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

rnk added inline comments. Comment at: include/llvm/MC/MCParser/MCAsmParser.h:64 unsigned ) = 0; + virtual bool EvaluateLookupAsEnum(void *LookupResult,int64_t ) = 0; }; mharoush wrote: > rnk wrote: > > It would be cleaner

r303568 - [index] Index the default template parameter values

Author: arphaman Date: Mon May 22 11:50:54 2017 New Revision: 303568 URL: http://llvm.org/viewvc/llvm-project?rev=303568=rev Log: [index] Index the default template parameter values rdar://32323724 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/index-source.cpp

[PATCH] D33368: [libcxxabi][demangler] Fix a crash in the demangler

erik.pilkington added inline comments. Comment at: src/cxa_demangle.cpp:3036 break; -if (db.names.size() < 2) +if (k1 <= k0) return first; compnerd wrote: > I'm not sure

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

mharoush marked an inline comment as done. mharoush added inline comments. Comment at: lib/Parse/ParseStmtAsm.cpp:100 + // result of a call to LookupInlineAsmIdentifier. + bool EvaluateLookupAsEnum(void *LookupResult, int64_t ) { +if (!LookupResult) return false;

[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good to me https://reviews.llvm.org/D33395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

mharoush updated this revision to Diff 99780. mharoush added a comment. removed functions and dropped an irrelevant test case. Repository: rL LLVM https://reviews.llvm.org/D33277 Files: lib/Sema/SemaStmtAsm.cpp test/CodeGen/x86-ms-inline-asm-enum_feature.cpp Index:

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

mharoush updated this revision to Diff 99778. mharoush added a comment. Using identifier info to pass enum information. Repository: rL LLVM https://reviews.llvm.org/D33278 Files: include/llvm/MC/MCParser/MCAsmParser.h lib/Target/X86/AsmParser/X86AsmParser.cpp Index:

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

mharoush marked an inline comment as done. mharoush added inline comments. Comment at: include/llvm/MC/MCParser/MCAsmParser.h:64 unsigned ) = 0; + virtual bool EvaluateLookupAsEnum(void *LookupResult,int64_t ) = 0; }; rnk

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 added a comment. In https://reviews.llvm.org/D3#760431, @aaron.ballman wrote: > In https://reviews.llvm.org/D3#760419, @jyu2 wrote: > > > In https://reviews.llvm.org/D3#760149, @aaron.ballman wrote: > > > > > As an FYI, there is a related check currently under development in >

[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:11 +#include "../ClangdLSPServer.h" +#include "../JSONRPCDispatcher.h" #include "llvm/Support/CommandLine.h" krasimir wrote: > I'd

[PATCH] D31646: [coroutines] Build GRO declaration and return GRO statement

GorNishanov added a comment. @rsmith barely audible ping https://reviews.llvm.org/D31646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

ilya-biryukov created this revision. Herald added a subscriber: mgorny. Custom vfs::FileSystem is currently used for unit tests. This revision depends on https://reviews.llvm.org/D33397. https://reviews.llvm.org/D33416 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

Re: r303546 - [mips] Support `micromips` attribute

On Mon, May 22, 2017 at 3:57 PM, Aaron Ballman wrote: > On Mon, May 22, 2017 at 8:47 AM, Simon Atanasyan via cfe-commits > wrote: >> Author: atanasyan >> Date: Mon May 22 07:47:43 2017 >> New Revision: 303546 >> >> URL:

[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).

ilya-biryukov updated this revision to Diff 99774. ilya-biryukov added a comment. Got rid of relative includes from parent dir in ClangdMain.cpp. (Addressed krasimir's comments) https://reviews.llvm.org/D33395 Files: clangd/CMakeLists.txt clangd/ClangdMain.cpp clangd/tool/CMakeLists.txt

r303565 - [mips] Add one more check to the micromips attribute test case. NFC

Author: atanasyan Date: Mon May 22 10:53:34 2017 New Revision: 303565 URL: http://llvm.org/viewvc/llvm-project?rev=303565=rev Log: [mips] Add one more check to the micromips attribute test case. NFC Modified: cfe/trunk/test/Sema/attr-micromips.c Modified:

r303564 - [mips] Quote command line options with `` in the micromips attribute description. NFC

Author: atanasyan Date: Mon May 22 10:53:31 2017 New Revision: 303564 URL: http://llvm.org/viewvc/llvm-project?rev=303564=rev Log: [mips] Quote command line options with `` in the micromips attribute description. NFC Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified:

[PATCH] D33415: Replaced WorkerRequest with std::function...

ilya-biryukov created this revision. And implemented a helper function to dump an AST of a file for testing/debugging purposes. https://reviews.llvm.org/D33415 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/ClangdUnitStore.h

r303563 - [index] Index the deleted functions

Author: arphaman Date: Mon May 22 10:42:45 2017 New Revision: 303563 URL: http://llvm.org/viewvc/llvm-project?rev=303563=rev Log: [index] Index the deleted functions rdar://32323386 Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/index-source.cpp Modified:

[PATCH] D33250: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location

This revision was automatically updated to reflect the committed changes. Closed by commit rL303562: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong… (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D33250?vs=99605=99772#toc Repository:

r303562 - [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location

Author: epilk Date: Mon May 22 10:41:12 2017 New Revision: 303562 URL: http://llvm.org/viewvc/llvm-project?rev=303562=rev Log: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location Differential revision: https://reviews.llvm.org/D33250 Modified:

[PATCH] D33304: [WIP][clang-tidy] Add a new module Android and a new check for file descriptors.

yawanng added a comment. I will make some major changes to this CL based on the current suggestions from reviewers and update it for further review later. Thank you for the valuable advice. Repository: rL LLVM https://reviews.llvm.org/D33304

[PATCH] D33412: Add support for #pragma clang section

javed.absar created this revision. Herald added a subscriber: aemerson. This patch adds support for a '#pragma clang section' directive in clang. An RFC was sent out earlier by my colleague James Molloy: http://lists.llvm.org/pipermail/cfe-dev/2017-March/053100.html Purpose: The

r303559 - [index] Visit the default argument values in function definitions

Author: arphaman Date: Mon May 22 10:17:44 2017 New Revision: 303559 URL: http://llvm.org/viewvc/llvm-project?rev=303559=rev Log: [index] Visit the default argument values in function definitions rdar://32323315 Modified: cfe/trunk/lib/Index/IndexDecl.cpp

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);

r303557 - clang-format: [JS] avoid line breaks before unindented r_parens.

Author: mprobst Date: Mon May 22 09:58:26 2017 New Revision: 303557 URL: http://llvm.org/viewvc/llvm-project?rev=303557=rev Log: clang-format: [JS] avoid line breaks before unindented r_parens. The change that enabled wrapping at the previous scope's indentation had unintended side-effects in

[PATCH] D33285: clang-format: do not reflow bullet lists

This revision was automatically updated to reflect the committed changes. Closed by commit rL303556: clang-format: do not reflow bullet lists (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D33285?vs=99436=99764#toc Repository: rL LLVM https://reviews.llvm.org/D33285

r303556 - clang-format: do not reflow bullet lists

Author: typz Date: Mon May 22 09:47:17 2017 New Revision: 303556 URL: http://llvm.org/viewvc/llvm-project?rev=303556=rev Log: clang-format: do not reflow bullet lists Summary: This patch prevents reflowing bullet lists in block comments. It handles all lists supported by doxygen and markdown,

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);

[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz updated this revision to Diff 99763. Typz added a comment. Remove dependency on https://reviews.llvm.org/D33314 https://reviews.llvm.org/D32480 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/NamespaceEndCommentsFixer.cpp lib/Format/UnwrappedLineFormatter.cpp

r303555 - [index] 'using namespace' declarations in functions should record

Author: arphaman Date: Mon May 22 09:39:39 2017 New Revision: 303555 URL: http://llvm.org/viewvc/llvm-project?rev=303555=rev Log: [index] 'using namespace' declarations in functions should record the reference to the namespace rdar://32323190 Modified: cfe/trunk/lib/Index/IndexDecl.cpp

[clang-tools-extra] r303554 - [clang-tidy] misc-move-const-arg shouldn't complain on std::move(lambda)

Author: alexfh Date: Mon May 22 09:30:14 2017 New Revision: 303554 URL: http://llvm.org/viewvc/llvm-project?rev=303554=rev Log: [clang-tidy] misc-move-const-arg shouldn't complain on std::move(lambda) Modified: clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCheck.cpp

[PATCH] D31414: [NFC, Refactor] Modernize TemplateIdAnnotation using TrailingObjects

aaron.ballman added inline comments. Comment at: include/clang/Sema/ParsedTemplate.h:202 + SmallVectorImpl ) { + ; + TemplateIdAnnotation *TemplateId = new (std::malloc( Spurious semi colon? Comment at:

[PATCH] D31414: [NFC, Refactor] Modernize TemplateIdAnnotation using TrailingObjects

faisalv added a comment. *ping* https://reviews.llvm.org/D31414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

echuraev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12449 // function declaration is going to be treated as an error. - if (Diags.getDiagnosticLevel(diag_id, Loc) >= DiagnosticsEngine::Error) { + if (!getLangOpts().OpenCL && +

[PATCH] D33358: [clang-tidy] readability-redundant-declaration false positive for defaulted function

This revision was automatically updated to reflect the committed changes. Closed by commit rL303552: [clang-tidy] readability-redundant-declaration false positive for defaulted… (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D33358?vs=99570=99757#toc Repository: rL

[PATCH] D33354: [clang-tidy] readability-braces-around-statements false positive with char literals

This revision was automatically updated to reflect the committed changes. Closed by commit rL303551: [clang-tidy] readability-braces-around-statements false positive with char… (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D33354?vs=99576=99756#toc Repository: rL

[clang-tools-extra] r303552 - [clang-tidy] readability-redundant-declaration false positive for defaulted function

Author: alexfh Date: Mon May 22 08:58:57 2017 New Revision: 303552 URL: http://llvm.org/viewvc/llvm-project?rev=303552=rev Log: [clang-tidy] readability-redundant-declaration false positive for defaulted function Summary: ``` template struct C { C(); }; template C::C() = default; ```

[clang-tools-extra] r303551 - [clang-tidy] readability-braces-around-statements false positive with char literals

Author: alexfh Date: Mon May 22 08:58:16 2017 New Revision: 303551 URL: http://llvm.org/viewvc/llvm-project?rev=303551=rev Log: [clang-tidy] readability-braces-around-statements false positive with char literals Summary: Single-line if statements cause a false positive when the last token in

[PATCH] D33250: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one change below: Comment at: lib/Sema/SemaDeclAttr.cpp:7256 + bool VisitObjCPropertyRefExpr(ObjCPropertyRefExpr *PRE) { +if (ObjCInterfaceDecl *ID =

[PATCH] D32425: [mips] Make checks in CodeGen/mips-varargs.c less fragile

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM,, https://reviews.llvm.org/D32425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32346: [clang-tidy] New readability check for strlen argument

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/readability-strlen-argument.rst:20 +char *p = new char[(strlen(s) - 1)] +strcpy(p, s); + JonasToth

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

spatel added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7932 break; case X86::BI__builtin_ia32_cmppd256: ID = Intrinsic::x86_avx_cmp_pd_256; 1. Should we handle the 'pd256' version the same way? 2. How about the 0xb ('false')

[PATCH] D32346: [clang-tidy] New readability check for strlen argument

alexfh added inline comments. Comment at: clang-tidy/readability/StrlenArgumentCheck.cpp:23-24 + Finder->addMatcher( + callExpr(anyOf(callee(functionDecl(hasName("::strlen"))), + callee(functionDecl(hasName("std::strlen", +

[PATCH] D33272: Method loadFromCommandLine should be able to report errors

alexfh added inline comments. Comment at: lib/Tooling/CompilationDatabase.cpp:164 +// to user. +} else if (DiagLevel >= DiagnosticsEngine::Error) + Other.HandleDiagnostic(DiagLevel, Info); Another couple of nits: 1. the comment below would probably

[PATCH] D33272: Method loadFromCommandLine should be able to report errors

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you! This looks good with one nit (see the inline comment). Comment at: lib/Tooling/CompilationDatabase.cpp:292 + if (Argc == 0) { +ErrorMsg = "error: no

[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

malhar1995 updated this revision to Diff 99750. malhar1995 added a comment. Addressed previous comments (removed Schrodinger from lock state names, changed method name setAppropriateLockState to resolvePossiblyDestroyedMutex, added an assert in resolvePossiblyDestroyedMutex, formatted the code

[PATCH] D33304: [WIP][clang-tidy] Add a new module Android and a new check for file descriptors.

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/android/FileDescriptorCheck.cpp:25 + callExpr( + callee(functionDecl(allOf( +

Re: r303546 - [mips] Support `micromips` attribute

On Mon, May 22, 2017 at 8:47 AM, Simon Atanasyan via cfe-commits wrote: > Author: atanasyan > Date: Mon May 22 07:47:43 2017 > New Revision: 303546 > > URL: http://llvm.org/viewvc/llvm-project?rev=303546=rev > Log: > [mips] Support `micromips` attribute > > This patch

[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz added a comment. Merging the 2 options is definitely a "safe" option, as it prevents ensures only the most obvious behavior is accessible. However, it has significant (IMO) drawbacks: - "Compact" is a not an namespace indentation type, this will make the option quite confusing - If

[PATCH] D33350: [clangd] Switch to incomplete translation units

This revision was automatically updated to reflect the committed changes. Closed by commit rL303547: [clangd] Switch to incomplete translation units (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D33350?vs=99535=99749#toc Repository: rL LLVM

[clang-tools-extra] r303547 - [clangd] Switch to incomplete translation units

Author: krasimir Date: Mon May 22 07:49:08 2017 New Revision: 303547 URL: http://llvm.org/viewvc/llvm-project?rev=303547=rev Log: [clangd] Switch to incomplete translation units Summary: This speeds up code completion. All the cool kids (ycmd) are doing it. Reviewers: bkramer, ilya-biryukov

[PATCH] D33364: [mips] Support micromips attribute passed by front-end

This revision was automatically updated to reflect the committed changes. Closed by commit rL303545: [mips] Support micromips attribute passed by front-end (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D33364?vs=99590=99747#toc Repository: rL LLVM

[PATCH] D33363: [mips] Support `micromips` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL303546: [mips] Support `micromips` attribute (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D33363?vs=99703=99748#toc Repository: rL LLVM https://reviews.llvm.org/D33363

r303546 - [mips] Support `micromips` attribute

Author: atanasyan Date: Mon May 22 07:47:43 2017 New Revision: 303546 URL: http://llvm.org/viewvc/llvm-project?rev=303546=rev Log: [mips] Support `micromips` attribute This patch adds support for the `micromips` and `nomicromips` attributes for MIPS targets. Differential revision:

[PATCH] D33285: clang-format: do not reflow bullet lists

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks great! https://reviews.llvm.org/D33285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33354: [clang-tidy] readability-braces-around-statements false positive with char literals

alexfh added a comment. I'm going to commit the patch for you, but I guess, you might want to ask for commit access (http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access). https://reviews.llvm.org/D33354 ___ cfe-commits mailing list

[PATCH] D33354: [clang-tidy] readability-braces-around-statements false positive with char literals

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you for investigating this! https://reviews.llvm.org/D33354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

RKSimon added a comment. Test _mm256_cmp_pd as well? Comment at: lib/CodeGen/CGBuiltin.cpp:7922 case X86::BI__builtin_ia32_cmpps256: + if (CC == 0xf) { + Value *Vec = Builder.CreateVectorSplat(Ops[0]->getType()->getVectorNumElements(), You

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:335 unsigned Unsigned; +double Double; bool Boolean; Lekensteyn wrote: > aaron.ballman wrote: > > Lekensteyn wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D33094: [ASTMatchers] Add clang-query support for equals matcher

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3846 + CXXBoolLiteralExpr, + IntegerLiteral), +

[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).

krasimir added inline comments. Comment at: clangd/tool/ClangdMain.cpp:11 +#include "../ClangdLSPServer.h" +#include "../JSONRPCDispatcher.h" #include "llvm/Support/CommandLine.h" I'd suggest to not have parent directory includes, but add them to the cmake

[PATCH] D33405: Mark all ARCMT test files as binary files in git, just like with svn

erikjv created this revision. Herald added a subscriber: javed.absar. This is a work-around for ARCMT's inability to handle Windows-style line terminators (\r\n) correctly. The underlying problem seems to be that line terminators are assumed to be 1 character long. So with files ending with \r\n

[PATCH] D33045: [libclang] Avoid more stats than necessary for reparse.

nik updated this revision to Diff 99740. https://reviews.llvm.org/D33045 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp tools/libclang/CIndexCodeCompletion.cpp Index: tools/libclang/CIndexCodeCompletion.cpp

[PATCH] D33045: [libclang] Avoid more stats than necessary for reparse.

nik added a comment. In https://reviews.llvm.org/D33045#759436, @ilya-biryukov wrote: > Are there any other callers to getMainBufferWithPrecompiledPreamble? Yes. Huch, right... don't know why I didn't adapted those. Done now. > Maybe they cause LibclangReparseTest.ReparseWithModule to fail?

Re: [PATCH] D33393: [PATCH] Libcxxabi Demangler PR32890

FYI: Passes "make check-cxxabi" for LLVM in trunk on my machine (x86-64, Ubuntu 16.04) with following standard configuration: lit.py: /src/try/llvm/projects/libcxx/utils/libcxx/test/config.py:150: note: Using compiler: /usr/local/bin/clang++ lit.py:

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

bader added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);

[PATCH] D33364: [mips] Support micromips attribute passed by front-end

sdardis added a comment. You should also add a test case to test/CodeGen/Mips/ showing that this attribute sets the assembler into micromips mode for some trivial function, along with another function without micromips being generated as non micromips code. Repository: rL LLVM

[PATCH] D33364: [mips] Support micromips attribute passed by front-end

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D33364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33363: [mips] Support `micromips` attribute

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D33363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33401: [mips] Add runtime options to enable/disable generation of madd.fmt, msub.fmt

smaksimovic created this revision. Herald added a subscriber: arichardson. Added options to clang are -mmadd4 and -mno-madd4, used to enable or disable generation of madd.fmt and similar instructions respectively, as per GCC. https://reviews.llvm.org/D33401 Files:

[PATCH] D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments

This revision was automatically updated to reflect the committed changes. Closed by commit rL303541: [clang-format] Keep trailing preprocessor line comments separate from the… (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D33394?vs=99731=99734#toc Repository: rL

r303541 - [clang-format] Keep trailing preprocessor line comments separate from the following section comments

Author: krasimir Date: Mon May 22 05:07:56 2017 New Revision: 303541 URL: http://llvm.org/viewvc/llvm-project?rev=303541=rev Log: [clang-format] Keep trailing preprocessor line comments separate from the following section comments Summary: r303415 changed the way a sequence of line comments

[PATCH] D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments

krasimir updated this revision to Diff 99731. krasimir marked an inline comment as done. krasimir added a comment. - Remove parentheses https://reviews.llvm.org/D33394 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestComments.cpp Index:

[PATCH] D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments

djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/UnwrappedLineParser.cpp:106 + isLineComment(*Token) && Token->NewlinesBefore == 1 && + Token->OriginalColumn ==

[PATCH] D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:106 + isLineComment(*Token) && Token->NewlinesBefore == 1 && + Token->OriginalColumn == PreviousToken->OriginalColumn); }

[PATCH] D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments

krasimir updated this revision to Diff 99729. krasimir marked an inline comment as done. krasimir added a comment. - Address review comments https://reviews.llvm.org/D33394 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestComments.cpp Index:

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

teemperor updated this revision to Diff 99728. teemperor edited the summary of this revision. teemperor added a comment. - Now unhiding/unowning the created functions like Richard suggested. - Extended the test case to stress test the lookup with the new visibility settings.

[PATCH] D32480: clang-format: Add CompactNamespaces option

djasper added a comment. What I mean is that you should remove the CompactNamespace option and instead let this be configured by an additional enum value in NamespaceIndentation. https://reviews.llvm.org/D32480 ___ cfe-commits mailing list

[PATCH] D32480: clang-format: Add CompactNamespaces option

Typz added inline comments. Comment at: include/clang/Format/Format.h:358 + /// \endcode + bool BinPackNamespaces; + djasper wrote: > Typz wrote: > > djasper wrote: > > > Typz wrote: > > > > djasper wrote: > > > > > This is not bin packing at all. Maybe

[PATCH] D32525: [clang-format] Add SpaceBeforeColon option

djasper added a comment. Hm, can't really remember what I meant by "my comment". Probably not important. So, I still see two problems: - I would not count the link you mentioned as a publicly accessible style guide. - I don't think the naming and granularity of this option is right. You

[PATCH] D33398: Remove __unaligned preventively when mangling types in Itanium ABI

rogfer01 created this revision. `__unaligned` is not currently mangled in any way and as such is not a relevant qualifier for substitutions. This may cause that, when it is the only qualifier, the substitution is added twice which triggers an assertion. The simplest thing to do is to remove

[PATCH] D32178: Delete unstable integration tests

arphaman added a comment. Ok, I will commit them sometime this week then. https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33397: Allow to use vfs::FileSystem for file accesses inside ASTUnit.

ilya-biryukov created this revision. https://reviews.llvm.org/D33397 Files: include/clang/Frontend/ASTUnit.h include/clang/Frontend/CompilerInvocation.h lib/Frontend/ASTUnit.cpp lib/Frontend/CompilerInvocation.cpp Index: lib/Frontend/CompilerInvocation.cpp

[PATCH] D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments

djasper added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:106 + isLineComment(*Token) && Token->NewlinesBefore == 1 && + Token->OriginalColumn == PreviousToken->OriginalColumn); } Any chance of moving this logic to

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

Lekensteyn added inline comments. Comment at: include/clang/ASTMatchers/Dynamic/VariantValue.h:335 unsigned Unsigned; +double Double; bool Boolean; aaron.ballman wrote: > Lekensteyn wrote: > > aaron.ballman wrote: > > > This may or may not be a

[PATCH] D32480: clang-format: Add CompactNamespaces option

djasper added inline comments. Comment at: include/clang/Format/Format.h:358 + /// \endcode + bool BinPackNamespaces; + Typz wrote: > djasper wrote: > > Typz wrote: > > > djasper wrote: > > > > This is not bin packing at all. Maybe CompactNamespaces? Or > > >

[PATCH] D33094: [ASTMatchers] Add clang-query support for equals matcher

Lekensteyn added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3846 + CXXBoolLiteralExpr, + IntegerLiteral), +

[PATCH] D33394: [clang-format] Keep trailing preprocessor line comments separate from the following section comments

krasimir created this revision. Herald added a subscriber: klimek. r303415 changed the way a sequence of line comments following a preprocessor macro is handled, which has the unfortunate effect of aligning a trailing preprocessor line comment and following unrelated section comments, so:

[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).

ilya-biryukov created this revision. Herald added a subscriber: mgorny. This commit itself doesn't add any unit tests, but one that does will follow shortly. https://reviews.llvm.org/D33395 Files: clangd/CMakeLists.txt clangd/ClangdMain.cpp clangd/tool/CMakeLists.txt

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

djasper added inline comments. Comment at: include/clang/Format/Format.h:699 + /// This option is **deprecated* and is retained for backwards compatibility. bool BreakConstructorInitializersBeforeComma; I don't think you need to keep this around. The YAML

[PATCH] D32477: clang-format: Allow customizing the penalty for breaking assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL303534: clang-format: Allow customizing the penalty for breaking assignment (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D32477?vs=99415=99720#toc Repository: rL LLVM

r303534 - clang-format: Allow customizing the penalty for breaking assignment

Author: typz Date: Mon May 22 03:28:17 2017 New Revision: 303534 URL: http://llvm.org/viewvc/llvm-project?rev=303534=rev Log: clang-format: Allow customizing the penalty for breaking assignment Summary: Add option to customize the penalty for breaking assignment This allows increasing the

[PATCH] D33393: [PATCH] Libcxxabi Demangler PR32890

marcel created this revision. Check whether the string (db.names.back().first) is longer than 7 characters before inserting another string at index 8. https://reviews.llvm.org/D33393 Files: CREDITS.TXT src/cxa_demangle.cpp test/test_demangle.pass.cpp Index: test/test_demangle.pass.cpp

  1   2   >