Author: gkistanova
Date: Sat Jun 3 01:40:10 2017
New Revision: 304653
URL: http://llvm.org/viewvc/llvm-project?rev=304653&view=rev
Log:
Added missing break.
Modified:
cfe/trunk/lib/Basic/IdentifierTable.cpp
Modified: cfe/trunk/lib/Basic/IdentifierTable.cpp
URL:
http://llvm.org/viewvc/llvm-
Author: gkistanova
Date: Sat Jun 3 01:38:22 2017
New Revision: 304652
URL: http://llvm.org/viewvc/llvm-project?rev=304652&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Basic/TargetInfo.cpp
Modified: cfe/trunk/lib/Basic
Author: gkistanova
Date: Sat Jun 3 01:35:06 2017
New Revision: 304651
URL: http://llvm.org/viewvc/llvm-project?rev=304651&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Sema/SemaCodeComplete.cpp
cfe/trunk/lib/Sema/Se
Author: gkistanova
Date: Sat Jun 3 01:31:42 2017
New Revision: 304650
URL: http://llvm.org/viewvc/llvm-project?rev=304650&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
cfe/trunk/lib/AST/ASTDiagnos
Author: gkistanova
Date: Sat Jun 3 01:30:46 2017
New Revision: 304649
URL: http://llvm.org/viewvc/llvm-project?rev=304649&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/CodeGen/CGC
Author: gkistanova
Date: Sat Jun 3 01:30:08 2017
New Revision: 304648
URL: http://llvm.org/viewvc/llvm-project?rev=304648&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Edit/RewriteObjCFoundationAPI.cpp
Modified: cfe/tr
Author: gkistanova
Date: Sat Jun 3 01:29:40 2017
New Revision: 304647
URL: http://llvm.org/viewvc/llvm-project?rev=304647&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Rewrite/HTMLRewrite.cpp
Modified: cfe/trunk/lib/Re
Author: gkistanova
Date: Sat Jun 3 01:29:16 2017
New Revision: 304646
URL: http://llvm.org/viewvc/llvm-project?rev=304646&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Parse/Parser.cpp
Modified: cfe/trunk/lib/Parse/Par
Author: gkistanova
Date: Sat Jun 3 01:27:16 2017
New Revision: 304645
URL: http://llvm.org/viewvc/llvm-project?rev=304645&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Frontend/CompilerInstance.cpp
cfe/trunk/lib/Fro
Author: gkistanova
Date: Sat Jun 3 01:26:27 2017
New Revision: 304644
URL: http://llvm.org/viewvc/llvm-project?rev=304644&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp
c
Author: gkistanova
Date: Sat Jun 3 01:25:47 2017
New Revision: 304643
URL: http://llvm.org/viewvc/llvm-project?rev=304643&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Lex/Lexer.cpp
Modified: cfe/trunk/lib/Lex/Lexer.cp
Author: gkistanova
Date: Sat Jun 3 01:25:29 2017
New Revision: 304642
URL: http://llvm.org/viewvc/llvm-project?rev=304642&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through +
formatted. NFC.
Modified:
cfe/trunk/lib/Lex/LiteralSupport.cpp
Modified: cfe/
Author: gkistanova
Date: Sat Jun 3 01:23:51 2017
New Revision: 304641
URL: http://llvm.org/viewvc/llvm-project?rev=304641&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/Analysis/PrintfFormatString.cpp
cfe/trunk/lib/A
Author: gkistanova
Date: Sat Jun 3 01:23:19 2017
New Revision: 304640
URL: http://llvm.org/viewvc/llvm-project?rev=304640&view=rev
Log:
Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.
Modified:
cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp
cfe/tr
EricWF updated this revision to Diff 101307.
EricWF edited the summary of this revision.
EricWF added reviewers: rtrieu, dexonsmith, dblaikie, aprantl, v.g.vassilev.
EricWF added a comment.
- Only allow the top level header search directories to be search for
`module.modulemap` files when loadin
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaLookup.cpp:3792-3793
static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) {
if (TC.begin() == TC.end())
return;
--
Author: kcc
Date: Fri Jun 2 20:36:23 2017
New Revision: 304631
URL: http://llvm.org/viewvc/llvm-project?rev=304631&view=rev
Log:
[sanitizer-coverage] one more flavor of coverage:
-fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting
yet. (clang part)
Modified:
cfe/
Author: marshall
Date: Fri Jun 2 20:21:29 2017
New Revision: 304629
URL: http://llvm.org/viewvc/llvm-project?rev=304629&view=rev
Log:
Fix the recently introduced test to work on C++03
Modified:
libcxx/trunk/test/libcxx/containers/unord/next_pow2.pass.cpp
Modified: libcxx/trunk/test/libcxx/c
jgorbe added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:3792-3793
static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) {
if (TC.begin() == TC.end())
return;
rsmith wrote:
> Do we need to clear the flag on this path too? (T
jgorbe updated this revision to Diff 101302.
jgorbe added a comment.
Also clear the 'requires import' flag when the TypoCorrection has no decls at
all.
https://reviews.llvm.org/D30963
Files:
lib/Sema/SemaLookup.cpp
test/Modules/Inputs/crash-typo-correction-visibility/module.h
test/Module
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:3792-3793
static void checkCorrectionVisibility(Sema &SemaRef, TypoCorrection &TC) {
if (TC.begin() == TC.end())
return;
Do we need to clear the flag on this path too? (This might happen
Hello everyone,
Below are some buildbot numbers for the last week of 05/21/2017 -
05/27/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Hello everyone,
Below are some buildbot numbers for the week of 05/14/2017 - 05/20/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Author: ericwf
Date: Fri Jun 2 19:22:18 2017
New Revision: 304620
URL: http://llvm.org/viewvc/llvm-project?rev=304620&view=rev
Log:
[coroutines] Fix rebuilding of dependent coroutine parameters
Summary:
We were not handling correctly rebuilding of parameter and were not creating
copies for them
EricWF added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:1285
+ // We needed to check it, but we don't need to generate code for it.
+ if (!paramDecl->getIdentifier())
+continue;
rsmith wrote:
> EricWF wrote:
> > @rsmith Is there a b
Author: rtrieu
Date: Fri Jun 2 19:11:23 2017
New Revision: 304618
URL: http://llvm.org/viewvc/llvm-project?rev=304618&view=rev
Log:
Revert r304592
r304592 - [ODRHash] Add support for TemplateArgument types.
Possibly causing one of the errors in modules build bot.
Modified:
cfe/trunk/lib/AST
mclow.lists accepted this revision.
mclow.lists added inline comments.
This revision is now accepted and ready to land.
Comment at: include/__hash_table:140
+return (__n > 1) ? (size_t(1) << (std::numeric_limits::digits -
__clz(__n-1))) : __n;
}
I turned
Author: marshall
Date: Fri Jun 2 19:08:32 2017
New Revision: 304617
URL: http://llvm.org/viewvc/llvm-project?rev=304617&view=rev
Log:
Fix some undefined behavior in __hash_table. Thanks to vsk for the report and
the patch. Reviewed as https://reviews.llvm.org/D33588.
Added:
libcxx/trunk/tes
jgorbe added a comment.
Ping?
https://reviews.llvm.org/D30963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF updated this revision to Diff 101293.
EricWF added a comment.
- No longer unnamed parameters from the AST.
https://reviews.llvm.org/D33797
Files:
lib/Sema/CoroutineStmtBuilder.h
lib/Sema/SemaCoroutine.cpp
lib/Sema/TreeTransform.h
test/CodeGenCoroutines/coro-params.cpp
test/Sema
rsmith added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:1285
+ // We needed to check it, but we don't need to generate code for it.
+ if (!paramDecl->getIdentifier())
+continue;
EricWF wrote:
> @rsmith Is there a better way to check
Prazek added a comment.
OK, I will try to make it work on linux and windows only
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
extern on function definition is also redundant, right?
Also, what about:
inline extern void foo();
(you check if it startswith extern)
Repository:
rL LLVM
https://reviews.llvm.org/D33841
___
cfe-commits mailing list
cfe-
EricWF added inline comments.
Comment at: lib/Sema/SemaCoroutine.cpp:1285
+ // We needed to check it, but we don't need to generate code for it.
+ if (!paramDecl->getIdentifier())
+continue;
@rsmith Is there a better way to check if the move wou
EricWF updated this revision to Diff 101291.
EricWF added a comment.
- Diagnose non-moveable but otherwise unnamed parameters.
- Have TreeTransform.h check if building the move params is successful.
https://reviews.llvm.org/D33797
Files:
lib/Sema/CoroutineStmtBuilder.h
lib/Sema/SemaCoroutin
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D33841#771944, @Prazek wrote:
> Feature request: removing "void" from int main(void)
This will duplicate modernize-redundant-void-arg.
Repository:
rL LLVM
https://reviews.llvm.org/D33841
Prazek added a comment.
Feature request: removing "void" from int main(void)
Repository:
rL LLVM
https://reviews.llvm.org/D33841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/readability-redundant-keyword.rst:6
+
+This checker removes the redundant `extern` and `inline` keywords from code.
+
hubert.reinterpretcast added inline comments.
Comment at: lib/AST/DeclCXX.cpp:1420
DeclContext::lookup_result R = lookup(Name);
- if (R.empty())
+ if (R.empty() || !isa(R.front()))
return nullptr;
As it is,
```
return R.empty() ? nullptr : dyn_cast(R.fr
Author: rsmith
Date: Fri Jun 2 17:53:06 2017
New Revision: 304604
URL: http://llvm.org/viewvc/llvm-project?rev=304604&view=rev
Log:
Fix assertion failure if we can't deduce a template argument for a variable
template partial specialization.
In passing, fix the deduction-crash.cpp test to actuall
davide added a comment.
If you take my example, and you pass `-target x86_64-pc-win32-macho`:
On clang-3.8, `TinkyWinky` is lowered to a GV with `weak_odr` linkage:
$ clang++ 1.cpp -o - -emit-llvm -S -fms-extensions -target
x86_64-pc-win32-macho
; ModuleID = '1.cpp'
target datalayout = "e
davide added a comment.
I think lowering `__declspec(selectany)` to a `comdat` for GVs on ELF platform
is actually reasonable.
I don't know what happens on Mach-O (as far as I can tell they don't have a
real notion of COMDAT, they use coalesced symbols, but I'm not an expert of the
format so yo
I think it comes down to a question of whether we want to guarantee that
these traits are treated as not being identifiers. In some sense, it's an
implementation detail that we model them as keywords -- and as it happens,
there are some circumstances in which we *don't* model them as keywords.
For
GorNishanov updated this revision to Diff 101282.
GorNishanov added a comment.
test updated to use %[[copy_x]] instead of %x1
https://reviews.llvm.org/D33797
Files:
lib/Sema/CoroutineStmtBuilder.h
lib/Sema/SemaCoroutine.cpp
lib/Sema/TreeTransform.h
test/CodeGenCoroutines/coro-params.cpp
Prazek created this revision.
This feature was disabled probably by mistake in
https://reviews.llvm.org/rL300562
This fixes bug https://bugs.llvm.org/show_bug.cgi?id=33285
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-sele
EricWF added a comment.
@GorNishanov I think we should be transforming the move parameters, instead of
re-building them entirely. I'll put together a different set of changes.
https://reviews.llvm.org/D33797
___
cfe-commits mailing list
cfe-commits
yawanng updated this revision to Diff 101279.
yawanng added a comment.
Format changes.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/FileOpenFlagCheck.cpp
clang-tidy/androi
GorNishanov added inline comments.
Comment at: test/CodeGenCoroutines/coro-params.cpp:103
+ // CHECK: call i8* @llvm.coro.begin
+ // CHECK-NEXT: call void @_ZN1AC1EOS_(%struct.A* %x1, %struct.A*
dereferenceable(512) %x)
+ // CHECK-NEXT: call void
@_ZNSt12experimental16corout
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1868-1871
bool isThisDeclarationADefinition() const {
-return IsDeleted || Body || IsLateTemplateParsed;
+return IsDeleted || IsDefaulted || Body || IsLateTemplateParsed ||
+ hasDefiningAttr();
Cool. Thanks for checking.
On Fri, Jun 2, 2017 at 1:12 PM, Vedant Kumar wrote:
> Hm, sorry, the compiler on the bot could not have picked up r304518, so I
> jumped the gun here. I'll try again later and report back in PR33271.
>
> vedant
>
> > On Jun 2, 2017, at 1:09 PM, Vedant Kumar via cfe-com
I've been using !__is_identifier to test for things like that. It seems to
be the most consistent way.
Is there some problem with this?
/Eric
On Thu, Jun 1, 2017 at 6:46 PM, Richard Smith wrote:
> On 31 May 2017 at 17:41, Eric Fiselier wrote:
>
>> I'm assuming libc++ should move to this trait
yawanng updated this revision to Diff 101267.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/FileOpenFlagCheck.cpp
clang-tidy/android/FileOpenFlagCheck.h
clang-tidy/plugin/C
Author: rtrieu
Date: Fri Jun 2 15:35:29 2017
New Revision: 304592
URL: http://llvm.org/viewvc/llvm-project?rev=304592&view=rev
Log:
[ODRHash] Add support for TemplateArgument types.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/lib/AST/O
bruno added a comment.
Hi,
Comment at: test/Sema/types.c:92
+
+typedef float __attribute__((ext_vector_type(4))) float4;
+float4 test3(float4 x) {
Can you also add a test for the `vector_type` variant? It might be more
appropriate to put this at test/Sema/ext
On 2 June 2017 at 12:26, Aaron Ballman wrote:
> On Fri, Jun 2, 2017 at 3:22 PM, Richard Smith
> wrote:
> > On 2 June 2017 at 12:04, Richard Smith wrote:
> >>
> >> On 2 June 2017 at 11:39, Aaron Ballman via Phabricator via cfe-commits
> >> wrote:
> >>>
> >>> aaron.ballman added a comment.
> >>>
Add --cached option to git-clang-format which behaves analogously to
--cached for other git subcommands, by causing the operation to work
against the index state rather than the working directory state.
This can be particularly useful for hook scripts which need to check or
change the formatting o
Hm, sorry, the compiler on the bot could not have picked up r304518, so I
jumped the gun here. I'll try again later and report back in PR33271.
vedant
> On Jun 2, 2017, at 1:09 PM, Vedant Kumar via cfe-commits
> wrote:
>
> Hi Gor,
>
> This is just a heads-up that I tried re-enabling ubsan fo
Hi Gor,
This is just a heads-up that I tried re-enabling ubsan for the two tests
affected by PR33271, but saw some similar failures. The commit message below
has more details about what was tested and what went wrong.
best,
vedant
> On Jun 2, 2017, at 1:06 PM, Vedant Kumar via cfe-commits
>
Author: vedantk
Date: Fri Jun 2 15:06:49 2017
New Revision: 304591
URL: http://llvm.org/viewvc/llvm-project?rev=304591&view=rev
Log:
Mark two coroutine tests as unsupported under ubsan, again
This reverts commit r304580, making bool_await_suspend.pass.cpp and
generator.pass.cpp unsupported on ub
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D33827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ABataev updated this revision to Diff 101262.
ABataev added a comment.
Herald added a subscriber: jholewinski.
Added different kinds of ImplicitParamDecl.
https://reviews.llvm.org/D33735
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/AST/Decl.cpp
lib/AST/DeclObjC.cpp
lib/
On Fri, Jun 2, 2017 at 3:22 PM, Richard Smith wrote:
> On 2 June 2017 at 12:04, Richard Smith wrote:
>>
>> On 2 June 2017 at 11:39, Aaron Ballman via Phabricator via cfe-commits
>> wrote:
>>>
>>> aaron.ballman added a comment.
>>>
>>> In https://reviews.llvm.org/D33788#771671, @bruno wrote:
>>>
On Fri, Jun 2, 2017 at 3:04 PM, Richard Smith wrote:
> On 2 June 2017 at 11:39, Aaron Ballman via Phabricator via cfe-commits
> wrote:
>>
>> aaron.ballman added a comment.
>>
>> In https://reviews.llvm.org/D33788#771671, @bruno wrote:
>>
>> > > I'm unaware of any other API that canonicalizes the
sepavloff updated this revision to Diff 101260.
sepavloff added a comment.
Do not call getCanonicalDecl for deleted functions
https://reviews.llvm.org/D30170
Files:
include/clang/AST/Decl.h
lib/AST/Decl.cpp
lib/Sema/SemaDecl.cpp
test/SemaCXX/cxx0x-cursory-default-delete.cpp
test/SemaC
On 2 June 2017 at 12:04, Richard Smith wrote:
> On 2 June 2017 at 11:39, Aaron Ballman via Phabricator via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> aaron.ballman added a comment.
>>
>> In https://reviews.llvm.org/D33788#771671, @bruno wrote:
>>
>> > > I'm unaware of any other API t
On 2 June 2017 at 11:39, Aaron Ballman via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> aaron.ballman added a comment.
>
> In https://reviews.llvm.org/D33788#771671, @bruno wrote:
>
> > > I'm unaware of any other API that canonicalizes the path, which is
> what users of this
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
> Yes, but that does not canonicalize the path. For instance, it won't handle
> doubled-up slashes or symlinks.
Right.
> Ultimately, the value returned from this API gets passed to POSIX func
Author: alexfh
Date: Fri Jun 2 13:47:50 2017
New Revision: 304583
URL: http://llvm.org/viewvc/llvm-project?rev=304583&view=rev
Log:
[clang-tidy] Add `const` to operator() to fix a warning.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/LambdaFunctionNameCheck.h
Modified: clang-tools-extr
Author: alexfh
Date: Fri Jun 2 13:44:32 2017
New Revision: 304581
URL: http://llvm.org/viewvc/llvm-project?rev=304581&view=rev
Log:
Fix formatting in docs.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/v
aaron.ballman added a comment.
In https://reviews.llvm.org/D33788#771671, @bruno wrote:
> > I'm unaware of any other API that canonicalizes the path, which is what
> > users of this API are going to expect.
>
> You can also call `sys::path::remove_dots(Path, /*remove_dot_dot=*/true);`
Yes, but
Author: vedantk
Date: Fri Jun 2 13:30:16 2017
New Revision: 304580
URL: http://llvm.org/viewvc/llvm-project?rev=304580&view=rev
Log:
Revert "Mark two coroutine tests as unsupported under ubsan"
This reverts commit r304462, thereby re-enabling two tests under ubsan.
We expect these tests to pass
bruno added a comment.
> I'm unaware of any other API that canonicalizes the path, which is what users
> of this API are going to expect.
You can also call `sys::path::remove_dots(Path, /*remove_dot_dot=*/true);`
> There's already a test case that covers this: Index/pch-from-libclang.c -- it
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:360
+ CGF.getContext().getTargetAddressSpace(LangAS::opencl_constant);
+}
auto *GV = new llvm::GlobalVariable(
This is not an appropriate place to stick target-specif
lebedev.ri added a comment.
While not directly related to this Differential, i wonder if it would make
sense to also not warn on calls to (especially non-member) functions marked
with `__attribute__((const))`, maybe `__attribute__((pure))` too.
At least i'm not sure what side-effects such calls
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304575: [OpenCL] Harden function pointer diagnostics.
(authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D33821?vs=101181&id=101242#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: bader
Date: Fri Jun 2 13:08:58 2017
New Revision: 304575
URL: http://llvm.org/viewvc/llvm-project?rev=304575&view=rev
Log:
[OpenCL] Harden function pointer diagnostics.
Summary: Improve OpenCL type checking by rejecting function pointer types.
Reviewers: Anastasia, yaxunl
Reviewed By:
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D33597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D33821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304570: [clang-tidy] check for __func__/__FUNCTION__ in
lambdas (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D33497?vs=101224&id=101237#toc
Repository:
rL LLVM
https://rev
Author: alexfh
Date: Fri Jun 2 12:36:32 2017
New Revision: 304570
URL: http://llvm.org/viewvc/llvm-project?rev=304570&view=rev
Log:
[clang-tidy] check for __func__/__FUNCTION__ in lambdas
Add a clang-tidy check for using func__/FUNCTION__ inside lambdas. This
evaluates to the string operator(),
yaxunl created this revision.
Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl.
amdgcn target requires global variable to stay in global or constant address
space.
In C or C++ global variables are emitted in the default (generic) address space
which the amdgcn backend cannot handle
Anastasia updated this revision to Diff 101236.
Anastasia added a comment.
Added RUN line for AMD
https://reviews.llvm.org/D33597
Files:
lib/AST/ASTContext.cpp
test/Index/pipe-size.cl
Index: test/Index/pipe-size.cl
===
--- /d
I committed a workaround in r304568.
On Fri, Jun 2, 2017 at 6:59 PM, Alexander Kornienko via cfe-commits
wrote:
> I've not yet figured out exactly, but I have a suspicion that this commit
> causes crashes when run under asan. Specifically, when running
> test/Modules/preprocess-module.cpp
>
> The
Author: d0k
Date: Fri Jun 2 12:30:24 2017
New Revision: 304568
URL: http://llvm.org/viewvc/llvm-project?rev=304568&view=rev
Log:
[Modules] Fix use after scope.
Found by asan.
Modified:
cfe/trunk/lib/Serialization/ASTWriter.cpp
Modified: cfe/trunk/lib/Serialization/ASTWriter.cpp
URL:
http:
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/cert/CERTTidyModule.cpp:64
+"cert-msc54-cpp");
// C checkers
// DCL
checker -> check.
Comment at: docs/ReleaseNotes.rst:73
+
+ Checks if a signal handler is not a p
akyrtzi added a comment.
I retract my comment, I see that `getMainExecutable` on OSX calls realpath as
well, so it's good to use realpath in this code to make sure they are in-sync
with how the compiler will determine the path.
https://reviews.llvm.org/D33788
___
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D33497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
lebedev.ri added a comment.
In https://reviews.llvm.org/D33102#767291, @dblaikie wrote:
> Still seems like an awful lot more testing than I'd expect for this warning.
> (eg: testing all the many variations of C++ const_cast - when they all
> provide basically the same coverage I think, that al
lebedev.ri updated this revision to Diff 101232.
lebedev.ri marked an inline comment as done.
lebedev.ri added a subscriber: cfe-commits.
lebedev.ri added a comment.
Address review notes.
Repository:
rL LLVM
https://reviews.llvm.org/D33102
Files:
docs/ReleaseNotes.rst
lib/Sema/SemaCast.c
aaron.ballman added a comment.
In https://reviews.llvm.org/D33788#771504, @akyrtzi wrote:
> Getting the real path is notoriously slow (at least it's horrible in OSX, not
> sure about linux). Since this is about dropping the '/../' part, could we do
> some simple canonicalization of removing the
rdwampler added inline comments.
Comment at: tools/libclang/CIndex.cpp:7322
+
+ for (int I = 0, E = AvailabilityAttrs.size(); I < E && I < availability_size;
+ ++I) {
arphaman wrote:
> You can use a ranged for loop here if you use `take_front`, e.g.
>
> `
akyrtzi added a comment.
Getting the real path is notoriously slow (at least it's horrible in OSX, not
sure about linux). Since this is about dropping the '/../' part, could we do
some simple canonicalization of removing the dots ? Not sure if there is an
existing function that does that.
htt
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D33706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:1388
SourceLocation IdLoc, IdentifierInfo *Id,
- QualType T);
+ QualType T, bool IsThisOrSelf = false);
-
alexfh added a comment.
In https://reviews.llvm.org/D33304#771215, @hokein wrote:
> Thanks for the contributions.
>
> All your three checks are not android specific -- because they are checking
> POSIX APIs (`open`, `creat`, `fopen`), which are more likely related to
> POSIX. So personally, I'm
yaxunl updated this revision to Diff 101227.
yaxunl added a comment.
Fix a comment.
https://reviews.llvm.org/D33706
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGen/address-space.c
test/CodeGen/default-address-spa
rjmccall added a comment.
Thanks. One tweak and then LGTM.
Comment at: lib/CodeGen/CodeGenFunction.h:1937
+ /// to the stack.
+
+ /// Because the address of a temporary is often exposed to the program in
This line should have ///.
https://reviews.llvm.org/
brycel updated this revision to Diff 101224.
brycel added a comment.
Move namespace-level types to class-level to avoid potential future name
conflicts.
https://reviews.llvm.org/D33497
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/LambdaFunctionNameCheck.cpp
clang-tidy/misc/Lambd
jyu2 marked 2 inline comments as done.
jyu2 added inline comments.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:334
+ continue;
+else
+ HasThrowOutFunc = true;
jyu2 wrote:
> aaron.ballman wrote:
> > You can drop the `else` here and just set `HasTh
Author: jvesely
Date: Fri Jun 2 10:58:35 2017
New Revision: 304556
URL: http://llvm.org/viewvc/llvm-project?rev=304556&view=rev
Log:
generic: add missing get_work_dim include
Fixes few piglits since clang r304193
Signed-off-by: Jan Vesely
Reviewed-by: Aaron Watry
Modified:
libclc/trunk/g
1 - 100 of 129 matches
Mail list logo
