[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

2017-06-07 Thread Matan via Phabricator via cfe-commits
mharoush marked an inline comment as done. mharoush added inline comments. Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:722 + bool ParseIntelExpression(IntelExprStateMachine , SMLoc , +bool ); std::unique_ptr rnk wrote:

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

2017-06-07 Thread Matan via Phabricator via cfe-commits
mharoush updated this revision to Diff 101688. mharoush marked an inline comment as done. mharoush added a comment. Simplified the AsmRewrite condition in x86AsmParser. Some fixes to simplify the Intel State Machine immediate value rewrite treatment divergence. Repository: rL LLVM

[PATCH] D33448: [CodeGen] Add thumb-mode to target-features for arm/thumb triples.

2017-06-07 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 101687. fhahn added a comment. rebased https://reviews.llvm.org/D33448 Files: lib/Basic/Targets.cpp test/CodeGen/arm-long-calls.c test/CodeGen/arm-no-movt.c test/CodeGen/arm-target-features.c test/CodeGen/arm-thumb-mode-target-feature.c Index:

[libcxx] r304893 - Mark LWG 2904 as complete.

2017-06-07 Thread Michael Park via cfe-commits
Author: mpark Date: Wed Jun 7 05:27:17 2017 New Revision: 304893 URL: http://llvm.org/viewvc/llvm-project?rev=304893=rev Log: Mark LWG 2904 as complete. Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL:

r304892 - [Sema] Silence unused variable warning.

2017-06-07 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Jun 7 05:23:17 2017 New Revision: 304892 URL: http://llvm.org/viewvc/llvm-project?rev=304892=rev Log: [Sema] Silence unused variable warning. Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL:

[libcxx] r304891 - Implement LWG 2904.

2017-06-07 Thread Michael Park via cfe-commits
Author: mpark Date: Wed Jun 7 05:22:43 2017 New Revision: 304891 URL: http://llvm.org/viewvc/llvm-project?rev=304891=rev Log: Implement LWG 2904. Summary: - Removed the move-constructibe requirement from copy-assignable. - Updated `__assign_alt` such that we direct initialize if `_Tp` can be

r304889 - [ARM] Fix Neon vector type alignment to 64-bit

2017-06-07 Thread Javed Absar via cfe-commits
Author: javed.absar Date: Wed Jun 7 05:02:02 2017 New Revision: 304889 URL: http://llvm.org/viewvc/llvm-project?rev=304889=rev Log: [ARM] Fix Neon vector type alignment to 64-bit This is restricted version of patch - https://reviews.llvm.org/D33205 that I reverted as it was leading to ABI

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

2017-06-07 Thread Christian Bruel via Phabricator via cfe-commits
chrib updated this revision to Diff 101675. chrib added a comment. - do not omit the frame pointer for netbsd-eabi and darwin-eabi https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/frame-pointer.c Index: test/Driver/frame-pointer.c

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

2017-06-07 Thread Christian Bruel via Phabricator via cfe-commits
chrib added a comment. OK, I have created a RFE tracker (BZ #32501). I will forward to cfe-dev. Regarding the need to avoid table-based unwinding, the way to handle those request for an explicit frame pointer when not required by the ABI is to use -fno-omit-frame-pointer flag, catching up with

[libcxx] r304883 - Fix test with exceptions disabled

2017-06-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Jun 7 04:06:05 2017 New Revision: 304883 URL: http://llvm.org/viewvc/llvm-project?rev=304883=rev Log: Fix test with exceptions disabled Modified: libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp Modified:

[PATCH] D33941: [Driver] Add test to cover case when LSan is not supported

2017-06-07 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304880: [Driver] Add test to cover case when LSan is not supported (authored by chefmax). Changed prior to commit: https://reviews.llvm.org/D33941?vs=101557=101672#toc Repository: rL LLVM

r304880 - [Driver] Add test to cover case when LSan is not supported

2017-06-07 Thread Maxim Ostapenko via cfe-commits
Author: chefmax Date: Wed Jun 7 03:51:15 2017 New Revision: 304880 URL: http://llvm.org/viewvc/llvm-project?rev=304880=rev Log: [Driver] Add test to cover case when LSan is not supported This commit adds a testcase for uncovered code paths in LSan options parsing logic in driver. Differential

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

2017-06-07 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In any case, I'm strongly against these hacks, please revert them. https://reviews.llvm.org/D20693 ___ cfe-commits mailing list

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

2017-06-07 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D20693#774693, @hintonda wrote: > In order to fix diagnostic corruption in some of the buildbot tests > (unable to reproduce locally): > > - make NoexceptMacro a static variable so it's lifetime doesn't end when > UseNoexceptCheck is

[PATCH] D32745: Correct debug info bit offset calculation for big-endian targets

2017-06-07 Thread Frej Drejhammar via Phabricator via cfe-commits
frej added a comment. Ping, I don't have have commit permissions, so I am at the mercy of others for getting this fix committed... https://reviews.llvm.org/D32745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r304879 - [clang-tidy] Make misc-inaccurate-erase work with real C++11 containers.

2017-06-07 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Jun 7 03:25:51 2017 New Revision: 304879 URL: http://llvm.org/viewvc/llvm-project?rev=304879=rev Log: [clang-tidy] Make misc-inaccurate-erase work with real C++11 containers. The check failed to match iterator->const_iterator conversion that is happening at least when

Re: [PATCH] D33660: [coroutines] Fix assertion during -Wuninitialized analysis

2017-06-07 Thread Eric Fiselier via cfe-commits
Yes, the thing that it's supposed to be testing is -Wuninitialized and other analysis warnings. I'll re-name the test and add more test cases to this effect shortly. Thanks for the input. On Mon, Jun 5, 2017 at 10:33 AM, David Blaikie wrote: > > > On Mon, May 29, 2017 at

r304872 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-07 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Wed Jun 7 01:31:55 2017 New Revision: 304872 URL: http://llvm.org/viewvc/llvm-project?rev=304872=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp Modified:

r304870 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-07 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Wed Jun 7 01:25:05 2017 New Revision: 304870 URL: http://llvm.org/viewvc/llvm-project?rev=304870=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified:

Re: r304852 - Improve error recovery for missing 'template' keyword in contexts where the

2017-06-07 Thread Mikael Holmén via cfe-commits
Hi Richard, See below. On 06/07/2017 02:29 AM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Jun 6 19:29:44 2017 New Revision: 304852 URL: http://llvm.org/viewvc/llvm-project?rev=304852=rev Log: Improve error recovery for missing 'template' keyword in contexts where the

<    1   2