Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

> On Jun 15, 2017, at 22:22, Eric Fiselier wrote: > > > >> On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith >> wrote: >> Your suggestion is essentially to replace experimental/string_view with >> something like: >> >> namespace std { inline namespace __1 { namespace experiment

[PATCH] D33676: Place implictly declared functions at block scope

rogfer01 added a comment. Thanks Momchil, this looks sensible to me. What do you think @aaron.ballman @rsmith ? https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D33823: [clang-format] Support sorting using declarations

Typz added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:66 + } + return HasIdentifier && Tok && Tok->isOneOf(tok::semi, tok::comma); +} could also be followed by an assignment, in case of type alias: using foo = bar::foo; https://rev

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); aaron.ballman wrote: > szdominik wrote

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 102809. Typz added a comment. fix indent https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

aaron.ballman added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); szdominik wrote: > aaron.ballman w

[PATCH] D34238: clang-format: Do not binpack initialization lists

Typz updated this revision to Diff 102808. Typz marked an inline comment as done. Typz added a comment. remove special case after assignment https://reviews.llvm.org/D34238 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added inline comments. Comment at: clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp:92 + // Loop until the beginning of the initialization list. + while (!Tok.is(tok::r_paren)) +Lex.LexFromRawLexer(Tok); aaron.ballman wrote: > This doesn't ba

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 102807. szdominik marked 9 inline comments as done. szdominik added a comment. Rename check. Hoisted matcher, changed warning message & nits. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/CopyConstructorInitChec

r305551 - Expand vector oparation to as IR constants, PR28129.

Author: dinar Date: Fri Jun 16 07:09:52 2017 New Revision: 305551 URL: http://llvm.org/viewvc/llvm-project?rev=305551&view=rev Log: Expand vector oparation to as IR constants, PR28129. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen/avx-builtins.c Modified: cfe/trunk

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

bader added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1041 +default: + return LangAS::Default; +} yaxunl wrote: > bader wrote: > > yaxunl wrote: > > > I think the default (including even_t, clk_event_t, queue_t, > > > reserved_id

[PATCH] D33676: Place implictly declared functions at block scope

chill added inline comments. Comment at: test/Sema/implicit-decl.c:12 int32_t compCount = 0; - if (_CFCalendarDecomposeAbsoluteTimeV(compDesc, vector, compCount)) { // expected-note {{previous implicit declaration is here}} \ - expected-error {{implicit declaration

[PATCH] D33491: clang-format: Fix C99 designated initializers corner cases

Typz updated this revision to Diff 102803. Typz added a comment. Fix incorrect labelling as ObjCMethodExpr https://reviews.llvm.org/D33491 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/

[PATCH] D34269: [clangd] Add "Go to Declaration" functionality

ilya-biryukov added a comment. Hi @malaperle-ericsson. Thanks for the patch. IndexingAction has a very simple interface, exactly what clangd needs and nothing more. BTW, we had a bug open for that: https://bugs.llvm.org/show_bug.cgi?id=33261, feel free to reassign to yourself. =

[PATCH] D33676: Place implictly declared functions at block scope

chill updated this revision to Diff 102802. chill added a comment. Update 2: added a testcase involving expression statements https://reviews.llvm.org/D33676 Files: include/clang/Sema/Scope.h lib/Parse/ParseStmt.cpp lib/Sema/SemaDecl.cpp test/Sema/implicit-decl-c90.c test/Sema/implici

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added a comment. Dear Raphael, Sorry I am not available, I am looking after my little kid, see you next week, rebase perhaps. Thanks, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31320 ___ cfe-commits mailing list cfe-co

[PATCH] D33644: Add default values for function parameter chunks

yvvan updated this revision to Diff 102800. yvvan added a comment. Use Lexer::getSourceText https://reviews.llvm.org/D33644 Files: lib/Sema/SemaCodeComplete.cpp Index: lib/Sema/SemaCodeComplete.cpp === --- lib/Sema/SemaCodeComp

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Please check the last inline comment and then feel free to commit it with the suggested fix. And I wanted to wait for review on the other performance patches, so you can push this now.

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 102796. xiangzhai added a comment. Dear Raphael, I updated my patch as you suggested, please review it, thanks a lot! And I noticed that you are doing Performance optimizations for the CloneChecker https://reviews.llvm.org/D34182 I will rebase my patch if

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

voskresensky.vladimir added a comment. Hello Argyrios, This is a good addition to simplify reuse of preprocessor in IDEs. Thanks for doing this. From our experience of integrating clang PP into NetBeans, the following change gives more flexibility: - introduce method in PPCallbacks and consult

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor added a comment. See my inline comments about technical changes, but otherwise this looks ready to land. Please update and I'll give green light ASAP. Thanks! Comment at: lib/Analysis/CloneDetection.cpp:375 +const Decl *D = S.getContainingDecl(); +const Sourc

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

ioeric added a comment. Hi Dan, thanks for the patch! https://reviews.llvm.org/D33560, which adds the same feature, is already under review :) https://reviews.llvm.org/D34252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D34235: [OpenCL] Fix OpenCL and SPIR version metadata generation.

bader updated this revision to Diff 102789. bader added a comment. Applied Akira's comment: re-used cached Int32Ty type. https://reviews.llvm.org/D34235 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/spir_version.cl Index:

[PATCH] D34235: [OpenCL] Fix OpenCL and SPIR version metadata generation.

ahatanak added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:516 + llvm::LLVMContext &Ctx = TheModule.getContext(); + llvm::Type *Int32Ty = llvm::Type::getInt32Ty(Ctx); + // SPIR v2.0 s2.12 - The SPIR version used by the module is stored in the ---

<    1   2